Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.0, 3.0.0-alpha2
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Issue Links

        Activity

        Hide
        kihwal Kihwal Lee added a comment -

        Pushed to 2.8.

        Show
        kihwal Kihwal Lee added a comment - Pushed to 2.8.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #10246 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10246/)
        HADOOP-13473. Tracing in IPC Server is broken. Contributed by Daryn (kihwal: rev caf800d5290d8618003b764afb0b3ef8d9a5a0a8)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10246 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10246/ ) HADOOP-13473 . Tracing in IPC Server is broken. Contributed by Daryn (kihwal: rev caf800d5290d8618003b764afb0b3ef8d9a5a0a8) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
        Hide
        kihwal Kihwal Lee added a comment -

        Committed to trunk and branch-2. Thanks for reporting this Wei-Chiu Chuang.

        Show
        kihwal Kihwal Lee added a comment - Committed to trunk and branch-2. Thanks for reporting this Wei-Chiu Chuang .
        Hide
        kihwal Kihwal Lee added a comment -

        +1. lgtm. Verified that TestTracing in hdfs works.

        Show
        kihwal Kihwal Lee added a comment - +1. lgtm. Verified that TestTracing in hdfs works.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 7s trunk passed
        +1 compile 7m 27s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 0m 59s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 27s trunk passed
        +1 javadoc 0m 49s trunk passed
        +1 mvninstall 0m 40s the patch passed
        +1 compile 7m 13s the patch passed
        +1 javac 7m 13s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 55s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 31s the patch passed
        +1 javadoc 0m 47s the patch passed
        +1 unit 8m 15s hadoop-common in the patch passed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        40m 23s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822854/HADOOP-13473.patch
        JIRA Issue HADOOP-13473
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 85c420f8638e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c4b77ae
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10212/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10212/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 7s trunk passed +1 compile 7m 27s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 27s trunk passed +1 javadoc 0m 49s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 7m 13s the patch passed +1 javac 7m 13s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 31s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 8m 15s hadoop-common in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 40m 23s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822854/HADOOP-13473.patch JIRA Issue HADOOP-13473 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 85c420f8638e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c4b77ae Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10212/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10212/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        daryn Daryn Sharp added a comment -

        The htrace span is technically violating abstractions by accessing rpc headers in the ipc layer. I tried to push the htrace scope down into the rpc engine/handler but that would alter the start time semantics from when it went in the queue, to when it was extracted. Tried to create a span with the queue time, but htrace apis just aren't amiable to creating a scope from the manual span.

        Anyway, just added a wrapper to lazy decode the rpc header.

        Show
        daryn Daryn Sharp added a comment - The htrace span is technically violating abstractions by accessing rpc headers in the ipc layer. I tried to push the htrace scope down into the rpc engine/handler but that would alter the start time semantics from when it went in the queue, to when it was extracted. Tried to create a span with the queue time, but htrace apis just aren't amiable to creating a scope from the manual span. Anyway, just added a wrapper to lazy decode the rpc header.
        Hide
        kihwal Kihwal Lee added a comment -

        Moved this to Common.

        Show
        kihwal Kihwal Lee added a comment - Moved this to Common.
        Hide
        daryn Daryn Sharp added a comment -

        Htrace expects the instantiated ipc value object's toString to be the protocol + method name. That's apparently not always the case now.

        Show
        daryn Daryn Sharp added a comment - Htrace expects the instantiated ipc value object's toString to be the protocol + method name. That's apparently not always the case now.

          People

          • Assignee:
            daryn Daryn Sharp
            Reporter:
            jojochuang Wei-Chiu Chuang
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development