Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13458

LoadBalancingKMSClientProvider#doOp should log IOException stacktrace

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: kms
    • Labels:

      Description

      Sometimes it's relatively hard to comprehend the meaning of the exception message without stacktrace. I think we should log the stacktrace too.

      LOG.warn("KMS provider at [{}] threw an IOException [{}]!!",
                  provider.getKMSUrl(), ioe.getMessage());
      
      1. HADOOP-13458.002.patch
        1 kB
        Chen Liang
      2. HADOOP-13458.001.patch
        1 kB
        Chen Liang

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #10209 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10209/)
        HADOOP-13458. LoadBalancingKMSClientProvider#doOp should log IOException (weichiu: rev a1f6564d31c16582ea949e4448091f1cc56c7dfe)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/LoadBalancingKMSClientProvider.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10209 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10209/ ) HADOOP-13458 . LoadBalancingKMSClientProvider#doOp should log IOException (weichiu: rev a1f6564d31c16582ea949e4448091f1cc56c7dfe) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/LoadBalancingKMSClientProvider.java
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Thanks Chen Liang for the contribution. Committed to this to trunk/branch-2

        Show
        jojochuang Wei-Chiu Chuang added a comment - Thanks Chen Liang for the contribution. Committed to this to trunk/branch-2
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        +1

        Show
        jojochuang Wei-Chiu Chuang added a comment - +1
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 41s trunk passed
        +1 compile 6m 48s trunk passed
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 19s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 37s the patch passed
        +1 compile 6m 46s the patch passed
        +1 javac 6m 46s the patch passed
        +1 checkstyle 0m 22s the patch passed
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 27s the patch passed
        +1 javadoc 0m 45s the patch passed
        +1 unit 7m 6s hadoop-common in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        37m 3s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821867/HADOOP-13458.002.patch
        JIRA Issue HADOOP-13458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 58186240ad64 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 58db263
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10168/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10168/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 41s trunk passed +1 compile 6m 48s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 19s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 46s the patch passed +1 javac 6m 46s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 27s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 7m 6s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 37m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821867/HADOOP-13458.002.patch JIRA Issue HADOOP-13458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 58186240ad64 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 58db263 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10168/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10168/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        vagarychen Chen Liang added a comment -

        Hi Wei-Chiu Chuang,

        I missed that, thanks! Uploaded another patch.

        Show
        vagarychen Chen Liang added a comment - Hi Wei-Chiu Chuang , I missed that, thanks! Uploaded another patch.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hi Chen Liang thanks for the quick patch contribution!
        In the spirit of code reuse, can you use StringUtils.stringifyException(ioe)) instead?

        Show
        jojochuang Wei-Chiu Chuang added a comment - Hi Chen Liang thanks for the quick patch contribution! In the spirit of code reuse, can you use StringUtils.stringifyException(ioe)) instead?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 30s trunk passed
        +1 compile 7m 57s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 1m 0s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 35s trunk passed
        +1 javadoc 0m 48s trunk passed
        +1 mvninstall 0m 50s the patch passed
        +1 compile 6m 44s the patch passed
        +1 javac 6m 44s the patch passed
        +1 checkstyle 0m 22s the patch passed
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 27s the patch passed
        +1 javadoc 0m 46s the patch passed
        +1 unit 7m 43s hadoop-common in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        41m 20s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821699/HADOOP-13458.001.patch
        JIRA Issue HADOOP-13458
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f258f9b9011e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 954465e
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10156/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10156/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 30s trunk passed +1 compile 7m 57s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 35s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 6m 44s the patch passed +1 javac 6m 44s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 27s the patch passed +1 javadoc 0m 46s the patch passed +1 unit 7m 43s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 41m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821699/HADOOP-13458.001.patch JIRA Issue HADOOP-13458 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f258f9b9011e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 954465e Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10156/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10156/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            vagarychen Chen Liang
            Reporter:
            jojochuang Wei-Chiu Chuang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development