Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      Hadoop-common failed to generate JDiff. We need to fix that.

      1. HADOOP-13428-branch-2.8.005.patch
        1.97 MB
        Wangda Tan
      2. HADOOP-13428.5.patch
        1.97 MB
        Wangda Tan
      3. HADOOP-13428.4.patch
        1.97 MB
        Wangda Tan
      4. HADOOP-13428.3.patch
        2.00 MB
        Wangda Tan
      5. HADOOP-13428.2.patch
        1.99 MB
        Wangda Tan
      6. metric-system-temp-fix.patch
        4 kB
        Wangda Tan
      7. HADOOP-13428.1.patch
        2.02 MB
        Wangda Tan

        Issue Links

          Activity

          Hide
          leftnoteasy Wangda Tan added a comment -

          Update: I found xml file can be generated, but changes.html is missing, still looking at it.

          Show
          leftnoteasy Wangda Tan added a comment - Update: I found xml file can be generated, but changes.html is missing, still looking at it.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Attached ver.1 patch for review.

          Show
          leftnoteasy Wangda Tan added a comment - Attached ver.1 patch for review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 8m 35s trunk passed
          +1 compile 7m 14s trunk passed
          +1 mvnsite 1m 4s trunk passed
          +1 mvneclipse 0m 22s trunk passed
          +1 javadoc 0m 54s trunk passed
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 0m 45s the patch passed
          +1 compile 7m 12s the patch passed
          +1 javac 7m 12s the patch passed
          +1 mvnsite 1m 4s the patch passed
          +1 mvneclipse 0m 21s the patch passed
          -1 whitespace 0m 0s The patch has 1250 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 1m 14s The patch 1 line(s) with tabs.
          +1 xml 0m 3s The patch has no ill-formed XML file.
          +1 javadoc 0m 54s the patch passed
          +1 unit 0m 9s hadoop-project-dist in the patch passed.
          +1 unit 7m 4s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          38m 49s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820282/HADOOP-13428.1.patch
          JIRA Issue HADOOP-13428
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit
          uname Linux de26410fe9b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d2cf8b5
          Default Java 1.8.0_101
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10091/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10091/artifact/patchprocess/whitespace-tabs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10091/testReport/
          modules C: hadoop-project-dist hadoop-common-project/hadoop-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10091/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 8m 35s trunk passed +1 compile 7m 14s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 22s trunk passed +1 javadoc 0m 54s trunk passed 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 0m 45s the patch passed +1 compile 7m 12s the patch passed +1 javac 7m 12s the patch passed +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 21s the patch passed -1 whitespace 0m 0s The patch has 1250 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 1m 14s The patch 1 line(s) with tabs. +1 xml 0m 3s The patch has no ill-formed XML file. +1 javadoc 0m 54s the patch passed +1 unit 0m 9s hadoop-project-dist in the patch passed. +1 unit 7m 4s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 38m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820282/HADOOP-13428.1.patch JIRA Issue HADOOP-13428 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit uname Linux de26410fe9b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d2cf8b5 Default Java 1.8.0_101 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10091/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10091/artifact/patchprocess/whitespace-tabs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10091/testReport/ modules C: hadoop-project-dist hadoop-common-project/hadoop-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10091/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Hi Wangda, could you provide the mvn invocation you're using to test? I didn't see anything in BUILDING.txt or README.txt. Tried mvn -Pdocs package -DskipTests but got this error:

          ression}s.
            [javadoc] Warning: incorrectly formatted @link in text: Retrieve the Bloom filter used by this instance of the Reader.
            [javadoc]  @return a Bloom filter (see {@link Filter})
            [javadoc] Warning: incorrectly formatted @link in text: Helper class to shutdown {@link Thread}s and {@link ExecutorService}s.
            [javadoc] Warning: incorrectly formatted @link in text: Constructor
            [javadoc]  @param vectorSize The vector size of <i>this</i> filter.
            [javadoc]  @param nbHash The number of hash function to consider.
            [javadoc]  @param hashType type of the hashing function (see
            [javadoc]  {@link org.apache.hadoop.util.hash.Hash}).
            [javadoc] Warning: incorrectly formatted @link in text: Constructor
            [javadoc]  @param vectorSize The vector size of <i>this</i> filter.
            [javadoc]  @param nbHash The number of hash function to consider.
            [javadoc]  @param hashType type of the hashing function (see
            [javadoc]  {@link org.apache.hadoop.util.hash.Hash}).
            [javadoc] Warning: incorrectly formatted @link in text: Constructor.
            [javadoc]  <p>
            [javadoc]  Builds a hash function that must obey to a given maximum number of returned values and a highest value.
            [javadoc]  @param maxValue The maximum highest returned value.
            [javadoc]  @param nbHash The number of resulting hashed values.
            [javadoc]  @param hashType type of the hashing function (see {@link Hash}).
            [javadoc] Warning: incorrectly formatted @link in text: Constructor
            [javadoc]  @param vectorSize The vector size of <i>this</i> filter.
            [javadoc]  @param nbHash The number of hash function to consider.
            [javadoc]  @param hashType type of the hashing function (see
            [javadoc]  {@link org.apache.hadoop.util.hash.Hash}).
            [javadoc]  finished
            [javadoc] JDiff: reading the new API in from file '/home/andrew/dev/hadoop/trunk/hadoop-common-project/hadoop-common/target/site/jdiff/xml/Apache_Hadoop_Common_3.0.0-alpha2-SNAPSHOT.xml'...Warning: incorrectly formatted @link in text: Options to be used by the {@link Find} command and its {@link Expression}s.
            [javadoc] Warning: incorrectly formatted @link in text: Retrieve the Bloom filter used by this instance of the Reader.
            [javadoc]  @return a Bloom filter (see {@link Filter})
            [javadoc] Error: duplicate comment id: org.apache.hadoop.metrics2.MetricsSystem.register_changed(java.lang.String, java.lang.String, T)
          
          Show
          andrew.wang Andrew Wang added a comment - Hi Wangda, could you provide the mvn invocation you're using to test? I didn't see anything in BUILDING.txt or README.txt. Tried mvn -Pdocs package -DskipTests but got this error: ression}s. [javadoc] Warning: incorrectly formatted @link in text: Retrieve the Bloom filter used by this instance of the Reader. [javadoc] @return a Bloom filter (see {@link Filter}) [javadoc] Warning: incorrectly formatted @link in text: Helper class to shutdown {@link Thread}s and {@link ExecutorService}s. [javadoc] Warning: incorrectly formatted @link in text: Constructor [javadoc] @param vectorSize The vector size of <i>this</i> filter. [javadoc] @param nbHash The number of hash function to consider. [javadoc] @param hashType type of the hashing function (see [javadoc] {@link org.apache.hadoop.util.hash.Hash}). [javadoc] Warning: incorrectly formatted @link in text: Constructor [javadoc] @param vectorSize The vector size of <i>this</i> filter. [javadoc] @param nbHash The number of hash function to consider. [javadoc] @param hashType type of the hashing function (see [javadoc] {@link org.apache.hadoop.util.hash.Hash}). [javadoc] Warning: incorrectly formatted @link in text: Constructor. [javadoc] <p> [javadoc] Builds a hash function that must obey to a given maximum number of returned values and a highest value. [javadoc] @param maxValue The maximum highest returned value. [javadoc] @param nbHash The number of resulting hashed values. [javadoc] @param hashType type of the hashing function (see {@link Hash}). [javadoc] Warning: incorrectly formatted @link in text: Constructor [javadoc] @param vectorSize The vector size of <i>this</i> filter. [javadoc] @param nbHash The number of hash function to consider. [javadoc] @param hashType type of the hashing function (see [javadoc] {@link org.apache.hadoop.util.hash.Hash}). [javadoc] finished [javadoc] JDiff: reading the new API in from file '/home/andrew/dev/hadoop/trunk/hadoop-common-project/hadoop-common/target/site/jdiff/xml/Apache_Hadoop_Common_3.0.0-alpha2-SNAPSHOT.xml'...Warning: incorrectly formatted @link in text: Options to be used by the {@link Find} command and its {@link Expression}s. [javadoc] Warning: incorrectly formatted @link in text: Retrieve the Bloom filter used by this instance of the Reader. [javadoc] @return a Bloom filter (see {@link Filter}) [javadoc] Error: duplicate comment id: org.apache.hadoop.metrics2.MetricsSystem.register_changed(java.lang.String, java.lang.String, T)
          Hide
          leftnoteasy Wangda Tan added a comment -

          Andrew Wang,

          The error is caused by a known jdiff bug: https://sourceforge.net/p/javadiff/bugs/19/

          In MetricSystem, there're two register overloads have same parameter types and return types, but one is <T extends MetricsSink> and another one is <T>.

          However, jdiff cannot recognize it. So I just attached a workaround patch https://issues.apache.org/jira/secure/attachment/12820786/metric-system-temp-fix.patch, to temporarily remove one of the register method. I think we should not commit it to our code base, but we can temporally apply it when generating jdiff.

          The steps of generate jdiff is:

          1) Apply https://issues.apache.org/jira/secure/attachment/12820787/HADOOP-13428.2.patch, which include jdiff file of hadoop-common from 2.7.3 and update pom to compare to 2.7.3.
          2) Apply metric-system temp fix
          3) Run mvn clean package -Pdocs -DskipTests
          4) Result:

          • Generated jdiff file: hadoop-common-project/hadoop-common/target/site/jdiff/xml/Apache_Hadoop_Common_3.0.0-alpha2-SNAPSHOT.xml
          • Generated jdiff report: hadoop-common-project/hadoop-common/target/site/jdiff/xml/changes.html
          Show
          leftnoteasy Wangda Tan added a comment - Andrew Wang , The error is caused by a known jdiff bug: https://sourceforge.net/p/javadiff/bugs/19/ In MetricSystem, there're two register overloads have same parameter types and return types, but one is <T extends MetricsSink> and another one is <T>. However, jdiff cannot recognize it. So I just attached a workaround patch https://issues.apache.org/jira/secure/attachment/12820786/metric-system-temp-fix.patch , to temporarily remove one of the register method. I think we should not commit it to our code base, but we can temporally apply it when generating jdiff. The steps of generate jdiff is: 1) Apply https://issues.apache.org/jira/secure/attachment/12820787/HADOOP-13428.2.patch , which include jdiff file of hadoop-common from 2.7.3 and update pom to compare to 2.7.3. 2) Apply metric-system temp fix 3) Run mvn clean package -Pdocs -DskipTests 4) Result: Generated jdiff file: hadoop-common-project/hadoop-common/target/site/jdiff/xml/Apache_Hadoop_Common_3.0.0-alpha2-SNAPSHOT.xml Generated jdiff report: hadoop-common-project/hadoop-common/target/site/jdiff/xml/changes.html
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 13s Maven dependency ordering for branch
          +1 mvninstall 6m 54s trunk passed
          +1 compile 7m 5s trunk passed
          +1 mvnsite 1m 11s trunk passed
          +1 mvneclipse 0m 21s trunk passed
          +1 javadoc 0m 56s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 0m 45s the patch passed
          +1 compile 6m 56s the patch passed
          +1 javac 6m 56s the patch passed
          +1 mvnsite 1m 3s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          -1 whitespace 0m 0s The patch has 1234 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 1m 12s The patch 1 line(s) with tabs.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 javadoc 0m 54s the patch passed
          +1 unit 0m 9s hadoop-project-dist in the patch passed.
          +1 unit 7m 59s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          37m 37s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820787/HADOOP-13428.2.patch , which include jdiff file of hadoop-common from 2.7.3 and update pom to compare to 2.7.3.
          JIRA Issue HADOOP-13428
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit
          uname Linux 4eeb97a2dcff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a3d0cba
          Default Java 1.8.0_101
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10112/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10112/artifact/patchprocess/whitespace-tabs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10112/testReport/
          modules C: hadoop-project-dist hadoop-common-project/hadoop-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10112/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 6m 54s trunk passed +1 compile 7m 5s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 21s trunk passed +1 javadoc 0m 56s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 0m 45s the patch passed +1 compile 6m 56s the patch passed +1 javac 6m 56s the patch passed +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 22s the patch passed -1 whitespace 0m 0s The patch has 1234 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 1m 12s The patch 1 line(s) with tabs. +1 xml 0m 2s The patch has no ill-formed XML file. +1 javadoc 0m 54s the patch passed +1 unit 0m 9s hadoop-project-dist in the patch passed. +1 unit 7m 59s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 37m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820787/HADOOP-13428.2.patch , which include jdiff file of hadoop-common from 2.7.3 and update pom to compare to 2.7.3. JIRA Issue HADOOP-13428 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit uname Linux 4eeb97a2dcff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a3d0cba Default Java 1.8.0_101 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10112/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10112/artifact/patchprocess/whitespace-tabs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10112/testReport/ modules C: hadoop-project-dist hadoop-common-project/hadoop-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10112/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Attached ver.3 patch, this contains a modification to maven build script that automatically add the temporary fix before building jdiff contents, and revert it once jdiff build is done. So after this patch, we don't need to manually apply the patch to properly generate jdiff contents.

          Show
          leftnoteasy Wangda Tan added a comment - Attached ver.3 patch, this contains a modification to maven build script that automatically add the temporary fix before building jdiff contents, and revert it once jdiff build is done. So after this patch, we don't need to manually apply the patch to properly generate jdiff contents.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 58s trunk passed
          +1 compile 8m 11s trunk passed
          +1 mvnsite 2m 47s trunk passed
          +1 mvneclipse 0m 36s trunk passed
          +1 javadoc 1m 51s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 43s the patch passed
          +1 compile 6m 43s the patch passed
          +1 javac 6m 43s the patch passed
          +1 mvnsite 2m 15s the patch passed
          +1 mvneclipse 0m 37s the patch passed
          -1 whitespace 0m 1s The patch has 1242 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 1m 14s The patch 1 line(s) with tabs.
          +1 xml 0m 4s The patch has no ill-formed XML file.
          +1 javadoc 1m 49s the patch passed
          +1 unit 0m 9s hadoop-project-dist in the patch passed.
          +1 unit 8m 5s hadoop-common in the patch passed.
          +1 unit 13m 28s hadoop-common-project in the patch passed.
          -1 asflicense 0m 21s The patch generated 1 ASF License warnings.
          59m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824435/HADOOP-13428.3.patch
          JIRA Issue HADOOP-13428
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit
          uname Linux 1b3b8b323402 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ae4db25
          Default Java 1.8.0_101
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10303/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10303/artifact/patchprocess/whitespace-tabs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10303/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10303/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-project-dist hadoop-common-project/hadoop-common hadoop-common-project U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10303/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 58s trunk passed +1 compile 8m 11s trunk passed +1 mvnsite 2m 47s trunk passed +1 mvneclipse 0m 36s trunk passed +1 javadoc 1m 51s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 43s the patch passed +1 compile 6m 43s the patch passed +1 javac 6m 43s the patch passed +1 mvnsite 2m 15s the patch passed +1 mvneclipse 0m 37s the patch passed -1 whitespace 0m 1s The patch has 1242 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 1m 14s The patch 1 line(s) with tabs. +1 xml 0m 4s The patch has no ill-formed XML file. +1 javadoc 1m 49s the patch passed +1 unit 0m 9s hadoop-project-dist in the patch passed. +1 unit 8m 5s hadoop-common in the patch passed. +1 unit 13m 28s hadoop-common-project in the patch passed. -1 asflicense 0m 21s The patch generated 1 ASF License warnings. 59m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824435/HADOOP-13428.3.patch JIRA Issue HADOOP-13428 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit uname Linux 1b3b8b323402 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ae4db25 Default Java 1.8.0_101 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10303/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10303/artifact/patchprocess/whitespace-tabs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10303/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/10303/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-project-dist hadoop-common-project/hadoop-common hadoop-common-project U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10303/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Glad to see progress on this. This approach looks good to me to work around the jdiff bug.

          Can we use 2.7.2 as the base stable version instead of 2.7.3 as 2.7.3 is still under release?

          Also fix the whitespace issues before uploading the next patch?

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Glad to see progress on this. This approach looks good to me to work around the jdiff bug. Can we use 2.7.2 as the base stable version instead of 2.7.3 as 2.7.3 is still under release? Also fix the whitespace issues before uploading the next patch?
          Hide
          leftnoteasy Wangda Tan added a comment -

          Attached ver.4 patch.

          Show
          leftnoteasy Wangda Tan added a comment - Attached ver.4 patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 38s Maven dependency ordering for branch
          +1 mvninstall 6m 36s trunk passed
          +1 compile 6m 49s trunk passed
          +1 mvnsite 1m 4s trunk passed
          +1 mvneclipse 0m 22s trunk passed
          +1 javadoc 0m 54s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 0m 44s the patch passed
          +1 compile 6m 43s the patch passed
          +1 javac 6m 43s the patch passed
          +1 mvnsite 1m 2s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          -1 whitespace 0m 0s The patch has 1228 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 1m 12s The patch 1 line(s) with tabs.
          +1 xml 0m 3s The patch has no ill-formed XML file.
          +1 javadoc 0m 53s the patch passed
          +1 unit 0m 9s hadoop-project-dist in the patch passed.
          +1 unit 8m 4s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          37m 21s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824491/HADOOP-13428.4.patch
          JIRA Issue HADOOP-13428
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit
          uname Linux b4073cf4c95d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c5c3e81
          Default Java 1.8.0_101
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10305/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10305/artifact/patchprocess/whitespace-tabs.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10305/testReport/
          modules C: hadoop-project-dist hadoop-common-project/hadoop-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10305/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 38s Maven dependency ordering for branch +1 mvninstall 6m 36s trunk passed +1 compile 6m 49s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 22s trunk passed +1 javadoc 0m 54s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 0m 44s the patch passed +1 compile 6m 43s the patch passed +1 javac 6m 43s the patch passed +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 23s the patch passed -1 whitespace 0m 0s The patch has 1228 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 1m 12s The patch 1 line(s) with tabs. +1 xml 0m 3s The patch has no ill-formed XML file. +1 javadoc 0m 53s the patch passed +1 unit 0m 9s hadoop-project-dist in the patch passed. +1 unit 8m 4s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 37m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824491/HADOOP-13428.4.patch JIRA Issue HADOOP-13428 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit uname Linux b4073cf4c95d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c5c3e81 Default Java 1.8.0_101 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10305/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10305/artifact/patchprocess/whitespace-tabs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10305/testReport/ modules C: hadoop-project-dist hadoop-common-project/hadoop-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10305/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Attached ver.5 patch fixes whitespaces.

          Show
          leftnoteasy Wangda Tan added a comment - Attached ver.5 patch fixes whitespaces.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Also attached patch for branch-2.8

          Show
          leftnoteasy Wangda Tan added a comment - Also attached patch for branch-2.8
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 3m 26s Maven dependency ordering for branch
          +1 mvninstall 7m 22s branch-2.8 passed
          +1 compile 6m 48s branch-2.8 passed with JDK v1.8.0_101
          +1 compile 6m 59s branch-2.8 passed with JDK v1.7.0_111
          +1 mvnsite 1m 11s branch-2.8 passed
          +1 mvneclipse 0m 30s branch-2.8 passed
          +1 javadoc 0m 56s branch-2.8 passed with JDK v1.8.0_101
          +1 javadoc 1m 8s branch-2.8 passed with JDK v1.7.0_111
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 0m 51s the patch passed
          +1 compile 6m 14s the patch passed with JDK v1.8.0_101
          +1 javac 6m 14s the patch passed
          +1 compile 7m 27s the patch passed with JDK v1.7.0_111
          +1 javac 7m 27s the patch passed
          +1 mvnsite 1m 9s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 javadoc 0m 56s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 8s the patch passed with JDK v1.7.0_111
          +1 unit 0m 10s hadoop-project-dist in the patch passed with JDK v1.7.0_111.
          +1 unit 7m 56s hadoop-common in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          64m 27s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.security.TestGroupsCaching



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5af2af1
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824634/HADOOP-13428-branch-2.8.005.patch
          JIRA Issue HADOOP-13428
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit
          uname Linux 5ba09eeb8758 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / 4f3df8e
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10311/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10311/testReport/
          modules C: hadoop-project-dist hadoop-common-project/hadoop-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10311/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 3m 26s Maven dependency ordering for branch +1 mvninstall 7m 22s branch-2.8 passed +1 compile 6m 48s branch-2.8 passed with JDK v1.8.0_101 +1 compile 6m 59s branch-2.8 passed with JDK v1.7.0_111 +1 mvnsite 1m 11s branch-2.8 passed +1 mvneclipse 0m 30s branch-2.8 passed +1 javadoc 0m 56s branch-2.8 passed with JDK v1.8.0_101 +1 javadoc 1m 8s branch-2.8 passed with JDK v1.7.0_111 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 0m 51s the patch passed +1 compile 6m 14s the patch passed with JDK v1.8.0_101 +1 javac 6m 14s the patch passed +1 compile 7m 27s the patch passed with JDK v1.7.0_111 +1 javac 7m 27s the patch passed +1 mvnsite 1m 9s the patch passed +1 mvneclipse 0m 25s the patch passed -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 xml 0m 2s The patch has no ill-formed XML file. +1 javadoc 0m 56s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 8s the patch passed with JDK v1.7.0_111 +1 unit 0m 10s hadoop-project-dist in the patch passed with JDK v1.7.0_111. +1 unit 7m 56s hadoop-common in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 64m 27s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.security.TestGroupsCaching Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824634/HADOOP-13428-branch-2.8.005.patch JIRA Issue HADOOP-13428 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit uname Linux 5ba09eeb8758 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 4f3df8e Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10311/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10311/testReport/ modules C: hadoop-project-dist hadoop-common-project/hadoop-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10311/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          The whitespace warnings are reported on hadoop-common-project/hadoop-common/src/site/resources/core-default.xml which doesn't exist at all. Not in the patch, not on trunk, branch2. I also tried running mvn site to see if that gets generated - nope. If this happens again, we'll have to investigate more, but I have hit a dead-end here.

          Anyways, it is unrelated to the patch.

          The latest patch looks good to me. +1, checking this in.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - The whitespace warnings are reported on hadoop-common-project/hadoop-common/src/site/resources/core-default.xml which doesn't exist at all. Not in the patch, not on trunk, branch2. I also tried running mvn site to see if that gets generated - nope. If this happens again, we'll have to investigate more, but I have hit a dead-end here. Anyways, it is unrelated to the patch. The latest patch looks good to me. +1, checking this in.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10314 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10314/)
          HADOOP-13428. Fixed hadoop-common build files to generate jdiff by (vinodkv: rev 99603e902244f17b04cfd55122f47355d070b588)

          • (add) hadoop-common-project/hadoop-common/dev-support/jdiff-workaround.patch
          • (edit) hadoop-common-project/hadoop-common/pom.xml
          • (edit) hadoop-project-dist/pom.xml
          • (add) hadoop-common-project/hadoop-common/dev-support/jdiff/Apache_Hadoop_Common_2.7.2.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10314 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10314/ ) HADOOP-13428 . Fixed hadoop-common build files to generate jdiff by (vinodkv: rev 99603e902244f17b04cfd55122f47355d070b588) (add) hadoop-common-project/hadoop-common/dev-support/jdiff-workaround.patch (edit) hadoop-common-project/hadoop-common/pom.xml (edit) hadoop-project-dist/pom.xml (add) hadoop-common-project/hadoop-common/dev-support/jdiff/Apache_Hadoop_Common_2.7.2.xml
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Committed this to trunk, branch-2 and branch-2.8. Thanks Wangda Tan.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Committed this to trunk, branch-2 and branch-2.8. Thanks Wangda Tan .
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Pushed this into branch-3.0.0-alpha1 too.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Pushed this into branch-3.0.0-alpha1 too.

            People

            • Assignee:
              leftnoteasy Wangda Tan
              Reporter:
              leftnoteasy Wangda Tan
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development