Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: fs
    • Labels:
      None

      Description

      I see more problems with TestLocalFileSystemPermission:

      • Many checkstyle warnings
      • Relays on JUnit3 so Assume framework cannot be used for Windows checks.
      • In the tests in case of exception we get an error message but the test itself will pass (because of the return).
      1. HADOOP-13388.01.patch
        9 kB
        Andras Bokor
      2. HADOOP-13388.02.patch
        10 kB
        Andras Bokor
      3. HADOOP-13388.03.patch
        10 kB
        Andras Bokor
      4. HADOOP-13388.04.patch
        10 kB
        Andras Bokor

        Issue Links

          Activity

          Hide
          boky01 Andras Bokor added a comment -

          Uploading 1st patch.
          I removed the catch blocks because it does make sense for me to let a test pass if we get an exception. Do I misunderstand something?

          Show
          boky01 Andras Bokor added a comment - Uploading 1st patch. I removed the catch blocks because it does make sense for me to let a test pass if we get an exception. Do I misunderstand something?
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 11s trunk passed
          +1 compile 7m 4s trunk passed
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 55s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 22s trunk passed
          +1 javadoc 0m 47s trunk passed
          +1 mvninstall 0m 41s the patch passed
          +1 compile 7m 13s the patch passed
          +1 javac 7m 13s the patch passed
          +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11)
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 32s the patch passed
          +1 javadoc 0m 46s the patch passed
          +1 unit 8m 5s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          39m 35s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820680/HADOOP-13388.01.patch
          JIRA Issue HADOOP-13388
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3412b37c66f4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 414fbfa
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10103/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10103/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 11s trunk passed +1 compile 7m 4s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 22s trunk passed +1 javadoc 0m 47s trunk passed +1 mvninstall 0m 41s the patch passed +1 compile 7m 13s the patch passed +1 javac 7m 13s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 46s the patch passed +1 unit 8m 5s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 39m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12820680/HADOOP-13388.01.patch JIRA Issue HADOOP-13388 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3412b37c66f4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 414fbfa Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10103/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10103/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          anu Anu Engineer added a comment -

          Andras Bokor Thank you for the patch.

          some minor comments/ nitpicks:

          1. import static org.junit.Assert.*; in most places I see you have removed "*" imports
            but this place you seem to have done the reverse. Just making sure that it is not your editor automatically doing this.
          2. Please feel free to ignore this comment. I am not sure that replacing assertTrue(!fs.exists(name)); with assertFalse(fs.exists(name)); adds to more readability. I agree it is one character less, but not sure if it makes code comprehension easier.
          3. I realize that you did not write this code. However the cleanup logic in testLocalFSsetPermission does not look correct to me. in the finally we are attempting to cleanup all file artifacts. However we have a set of file creates happening outside the try, f,f1 and f2. it is possible that we might fail when creating f1, which case the cleanup of f will not happen.
            I am presuming that you really do want to cleanup all file resources even if the test fails ?
          4. in testLocalFSsetOwner we still have LOGGER.error / return pattern. Just making sure that it is intentional.
          Show
          anu Anu Engineer added a comment - Andras Bokor Thank you for the patch. some minor comments/ nitpicks: import static org.junit.Assert.*; in most places I see you have removed "*" imports but this place you seem to have done the reverse. Just making sure that it is not your editor automatically doing this. Please feel free to ignore this comment. I am not sure that replacing assertTrue(!fs.exists(name)); with assertFalse(fs.exists(name)); adds to more readability. I agree it is one character less, but not sure if it makes code comprehension easier. I realize that you did not write this code. However the cleanup logic in testLocalFSsetPermission does not look correct to me. in the finally we are attempting to cleanup all file artifacts. However we have a set of file creates happening outside the try, f,f1 and f2. it is possible that we might fail when creating f1, which case the cleanup of f will not happen. I am presuming that you really do want to cleanup all file resources even if the test fails ? in testLocalFSsetOwner we still have LOGGER.error / return pattern. Just making sure that it is intentional.
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for the patch, Andras Bokor.

          1. As to the parameter order, can you double check the assertEquals(expected, actual) pattern is used? Or else, the error message is confusing. Even better, provide an error message. e.g.
            112	      assertEquals(copyPermission, initialPermission);
            
          2. Should we assertTrue() here? Or the unit test with null/empty group is considered successful?
            198	      if (groups == null || groups.size() < 1) {
            199	        LOGGER.error("Cannot run test: need at least one group. groups={}",
            200	            groups);
            201	        return;
            202	      }
            
          3. Hm...why while loop is preferred to for?
                for(StringTokenizer t = new StringTokenizer(s); t.hasMoreTokens(); ) {
                  a.add(t.nextToken());
                }
            
          Show
          liuml07 Mingliang Liu added a comment - Thanks for the patch, Andras Bokor . As to the parameter order, can you double check the assertEquals(expected, actual) pattern is used? Or else, the error message is confusing. Even better, provide an error message. e.g. 112 assertEquals(copyPermission, initialPermission); Should we assertTrue() here? Or the unit test with null/empty group is considered successful? 198 if (groups == null || groups.size() < 1) { 199 LOGGER.error( "Cannot run test: need at least one group. groups={}" , 200 groups); 201 return ; 202 } Hm...why while loop is preferred to for ? for (StringTokenizer t = new StringTokenizer(s); t.hasMoreTokens(); ) { a.add(t.nextToken()); }
          Hide
          boky01 Andras Bokor added a comment -

          Thanks for the review Anu Engineer and Mingliang Liu.

          Anu Engineer:

          1. The import changes was done by my IDE. The Assert got wildcard when I imported assertFalse. I think wildcard is reasonable there since assertFalse the 4th method from the class
          2. I thought assertFalse is more readable here because we have an asserTrue followed by a delete so assertFalse seemed more straightforward.
          3. Good point. I put them into the try. I had to add some null check to the cleanup method because if we have an exception while creating the file the cleanup will throw NPE which will hide the real exception.
          4. Yes, I do not really understand the purpose of that check. getGroups cannot return with null and on Unix users have to belong to at least one group. I would remove the whole block.

          Mingliang Liu

          1. Yes, the order was wrong. Fixed.
          2. Please check 4th point from above
          3. Replacing for by while only has readability purposes. While seems more appropriate here for me (Idea also suggests to do).

          What do you guys think about the 2nd patch?

          Show
          boky01 Andras Bokor added a comment - Thanks for the review Anu Engineer and Mingliang Liu . Anu Engineer : The import changes was done by my IDE. The Assert got wildcard when I imported assertFalse. I think wildcard is reasonable there since assertFalse the 4th method from the class I thought assertFalse is more readable here because we have an asserTrue followed by a delete so assertFalse seemed more straightforward. Good point. I put them into the try. I had to add some null check to the cleanup method because if we have an exception while creating the file the cleanup will throw NPE which will hide the real exception. Yes, I do not really understand the purpose of that check. getGroups cannot return with null and on Unix users have to belong to at least one group. I would remove the whole block. Mingliang Liu Yes, the order was wrong. Fixed. Please check 4th point from above Replacing for by while only has readability purposes. While seems more appropriate here for me (Idea also suggests to do). What do you guys think about the 2nd patch?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 51s trunk passed
          +1 compile 6m 51s trunk passed
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 18s trunk passed
          +1 javadoc 0m 46s trunk passed
          +1 mvninstall 0m 37s the patch passed
          +1 compile 6m 42s the patch passed
          +1 javac 6m 42s the patch passed
          +1 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11)
          +1 mvnsite 0m 51s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 findbugs 1m 26s the patch passed
          +1 javadoc 0m 45s the patch passed
          +1 unit 8m 2s hadoop-common in the patch passed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          38m 25s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824398/HADOOP-13388.02.patch
          JIRA Issue HADOOP-13388
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3e8dd6d0b420 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0da69c3
          Default Java 1.8.0_101
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10297/artifact/patchprocess/whitespace-eol.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10297/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10297/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 51s trunk passed +1 compile 6m 51s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 42s the patch passed +1 javac 6m 42s the patch passed +1 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 13s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 1m 26s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 8m 2s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 38m 25s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824398/HADOOP-13388.02.patch JIRA Issue HADOOP-13388 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3e8dd6d0b420 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0da69c3 Default Java 1.8.0_101 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10297/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10297/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10297/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          boky01 Andras Bokor added a comment -

          Fix whitespace issue.

          Show
          boky01 Andras Bokor added a comment - Fix whitespace issue.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 1s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 35s trunk passed
          +1 compile 6m 48s trunk passed
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 19s trunk passed
          +1 javadoc 0m 45s trunk passed
          +1 mvninstall 0m 37s the patch passed
          +1 compile 6m 45s the patch passed
          +1 javac 6m 45s the patch passed
          +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11)
          +1 mvnsite 0m 50s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 27s the patch passed
          +1 javadoc 0m 44s the patch passed
          -1 unit 16m 54s hadoop-common in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          46m 54s



          Reason Tests
          Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824517/HADOOP-13388.03.patch
          JIRA Issue HADOOP-13388
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b5c96fbbb9b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8179f9a
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10306/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10306/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10306/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 35s trunk passed +1 compile 6m 48s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 19s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 45s the patch passed +1 javac 6m 45s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 27s the patch passed +1 javadoc 0m 44s the patch passed -1 unit 16m 54s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 46m 54s Reason Tests Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824517/HADOOP-13388.03.patch JIRA Issue HADOOP-13388 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b5c96fbbb9b4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8179f9a Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/10306/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10306/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10306/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          boky01 Andras Bokor added a comment -

          Unit test failure is unrelated.

          Show
          boky01 Andras Bokor added a comment - Unit test failure is unrelated.
          Hide
          anu Anu Engineer added a comment -

          Andras Bokor Thank you for taking care of all the issues. The new patch looks quite good. However I am wondering if there is a small race condition in the cleanup path.

          There are two functions where we have this same pattern. we do localfs.rename(dir2, copyPath); and after rename execute a bunch of statements. I am presuming that any of these statements can fail, but little later at the end of the try block we do dir2=copyPath; based on this assignment we invoke cleanup without checking if the file exists.

          if we get a failure in the bunch of lines between rename and assignment, I am worried that cleanup will fail, that is dir2 will not be null, yet the file will not exist. In the earlier code we checked if the file exists before calling cleanup which avoided this problem. You can fix it by making sure that there are no statements that can fail between rename and dir2=copyPath assignment or by bringing back the check for file before invoking cleanup.

          As I said at the start, the next function has a very similar code pattern.

          Show
          anu Anu Engineer added a comment - Andras Bokor Thank you for taking care of all the issues. The new patch looks quite good. However I am wondering if there is a small race condition in the cleanup path. There are two functions where we have this same pattern. we do localfs.rename(dir2, copyPath); and after rename execute a bunch of statements. I am presuming that any of these statements can fail, but little later at the end of the try block we do dir2=copyPath; based on this assignment we invoke cleanup without checking if the file exists. if we get a failure in the bunch of lines between rename and assignment, I am worried that cleanup will fail, that is dir2 will not be null, yet the file will not exist. In the earlier code we checked if the file exists before calling cleanup which avoided this problem. You can fix it by making sure that there are no statements that can fail between rename and dir2=copyPath assignment or by bringing back the check for file before invoking cleanup. As I said at the start, the next function has a very similar code pattern.
          Hide
          boky01 Andras Bokor added a comment -

          Thanks a lot Anu Engineer,

          I could not catch the purpose of the check. I put back into final section. Please check now.

          Show
          boky01 Andras Bokor added a comment - Thanks a lot Anu Engineer , I could not catch the purpose of the check. I put back into final section. Please check now.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 38s trunk passed
          +1 compile 6m 52s trunk passed
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 16s trunk passed
          +1 javadoc 0m 45s trunk passed
          +1 mvninstall 0m 36s the patch passed
          +1 compile 6m 48s the patch passed
          +1 javac 6m 48s the patch passed
          +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11)
          +1 mvnsite 0m 51s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 26s the patch passed
          +1 javadoc 0m 45s the patch passed
          +1 unit 8m 11s hadoop-common in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          38m 20s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13388
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827202/HADOOP-13388.04.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 879dc6c4a803 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 62a9667
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10450/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10450/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 38s trunk passed +1 compile 6m 52s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 16s trunk passed +1 javadoc 0m 45s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 6m 48s the patch passed +1 javac 6m 48s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 0 unchanged - 11 fixed = 0 total (was 11) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 26s the patch passed +1 javadoc 0m 45s the patch passed +1 unit 8m 11s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 38m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13388 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827202/HADOOP-13388.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 879dc6c4a803 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 62a9667 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10450/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10450/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          anu Anu Engineer added a comment -

          +1, LGTM. Thanks for the patch Andras Bokor. I will commit this shortly.

          Show
          anu Anu Engineer added a comment - +1, LGTM. Thanks for the patch Andras Bokor . I will commit this shortly.
          Hide
          anu Anu Engineer added a comment -

          Andras Bokor Thanks for the contribution. I have committed this to trunk.

          Show
          anu Anu Engineer added a comment - Andras Bokor Thanks for the contribution. I have committed this to trunk.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10405 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10405/)
          HADOOP-13388. Clean up TestLocalFileSystemPermission. Contributed by (aengineer: rev f414d5e118940cb98015c0b66e11102a9704a505)

          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystemPermission.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10405 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10405/ ) HADOOP-13388 . Clean up TestLocalFileSystemPermission. Contributed by (aengineer: rev f414d5e118940cb98015c0b66e11102a9704a505) (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystemPermission.java
          Hide
          boky01 Andras Bokor added a comment -

          Thanks for all of your help Anu Engineer!

          Show
          boky01 Andras Bokor added a comment - Thanks for all of your help Anu Engineer !

            People

            • Assignee:
              boky01 Andras Bokor
              Reporter:
              boky01 Andras Bokor
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development