Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13354

Update WASB driver to use the latest version (4.2.0) of SDK for Microsoft Azure Storage Clients

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: fs/azure
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      The WASB FileSystem now uses version 4.2.0 of the Azure Storage SDK.
    • Flags:
      Patch

      Description

      Update WASB driver to use the latest version (4.2.0) of SDK for Microsoft Azure Storage Clients.
      We are currently using version 2.2.0 of the SDK.
      Version 4.2.0 brings some breaking changes.
      Need to fix code to resolve all these breaking changes and certify that everything works properly.

      1. HADOOP-13354.001.patch
        17 kB
        Sivaguru Sankaridurg
      2. HADOOP-13354.002.patch
        18 kB
        Sivaguru Sankaridurg
      3. HADOOP-13354.003.patch
        9 kB
        Sivaguru Sankaridurg
      4. HADOOP-13354.004.patch
        9 kB
        Sivaguru Sankaridurg
      5. Test-Results-With-4.2.0-fixes
        10 kB
        Sivaguru Sankaridurg

        Activity

        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Thanks Chris Nauroth.

        -Siva

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Thanks Chris Nauroth . -Siva
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #10165 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10165/)
        HADOOP-13354. Update WASB driver to use the latest version (4.2.0) of (cnauroth: rev b43de80031d1272e8a08ea5bd31027efe45e9d70)

        • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/StorageInterfaceImpl.java
        • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/BlockBlobAppendStream.java
        • hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/SendRequestIntercept.java
        • hadoop-project/pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10165 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10165/ ) HADOOP-13354 . Update WASB driver to use the latest version (4.2.0) of (cnauroth: rev b43de80031d1272e8a08ea5bd31027efe45e9d70) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/StorageInterfaceImpl.java hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/BlockBlobAppendStream.java hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/SendRequestIntercept.java hadoop-project/pom.xml
        Hide
        cnauroth Chris Nauroth added a comment -

        +1 for patch 004. I verified a successful full test run against my Azure Storage account. Sivaguru Sankaridurg, thank you for the patch. I have committed this to trunk and branch-2.

        Regarding commons-lang3, it shows up in one other place as a test dependency of hadoop-hdfs. It's a transitive dependency through org.mock-server:mockserver-netty. Given that this is isolated from product code, I didn't ask for any changes on the dependency management within scope of this patch. (I would not object to it though if someone wanted to do it as a separate patch.)

        Show
        cnauroth Chris Nauroth added a comment - +1 for patch 004. I verified a successful full test run against my Azure Storage account. Sivaguru Sankaridurg , thank you for the patch. I have committed this to trunk and branch-2. Regarding commons-lang3, it shows up in one other place as a test dependency of hadoop-hdfs. It's a transitive dependency through org.mock-server:mockserver-netty. Given that this is isolated from product code, I didn't ask for any changes on the dependency management within scope of this patch. (I would not object to it though if someone wanted to do it as a separate patch.)
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - - edited

        Hi Chris Nauroth,

        Thank you for reviewing the code changes.

        The block ID generation logic in BlockBlobAppendStream needed to change in order to match the logic in 4.2.0.

        The check for blockIdPrefix was just defensive programming.
        The constructor calls setBlocksCountAndBlockIdPrefix today.
        This check would bring to fore, the implicit assumption in the code that setBlocksCountAndBlockIdPrefix needs to be called before generateBlockId; if the code were to be moved around later.

        Another way that I think about it, is that generateBlockId uses this.blockIdPrefix. The check ensures that the input it uses is initialized before actually using it, independent of the code that actually initializes the input.

        Thanks
        Siva

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - - edited Hi Chris Nauroth , Thank you for reviewing the code changes. The block ID generation logic in BlockBlobAppendStream needed to change in order to match the logic in 4.2.0. The check for blockIdPrefix was just defensive programming. The constructor calls setBlocksCountAndBlockIdPrefix today. This check would bring to fore, the implicit assumption in the code that setBlocksCountAndBlockIdPrefix needs to be called before generateBlockId ; if the code were to be moved around later. Another way that I think about it, is that generateBlockId uses this.blockIdPrefix . The check ensures that the input it uses is initialized before actually using it, independent of the code that actually initializes the input. Thanks Siva
        Hide
        cnauroth Chris Nauroth added a comment -

        Sivaguru Sankaridurg, thank you for the patch.

        I'm unclear about why the block ID generation logic in BlockBlobAppendStream needed to change. I remember this code was originally implemented to match block ID logic inside the Azure Storage SDK. Is this updating our code to keep in sync with the logic of 4.2.0, or is there some other reason for this part of the change?

            if (this.blockIdPrefix == null) {
              throw new IOException("Append Stream in invalid state. blockIdPrefix not set correctly");
            }
        

        It appears this check is unnecessary. The constructor always calls setBlocksCountAndBlockIdPrefix, which always guarantees that blockIdPrefix has been initialized to a non-null value.

        Show
        cnauroth Chris Nauroth added a comment - Sivaguru Sankaridurg , thank you for the patch. I'm unclear about why the block ID generation logic in BlockBlobAppendStream needed to change. I remember this code was originally implemented to match block ID logic inside the Azure Storage SDK. Is this updating our code to keep in sync with the logic of 4.2.0, or is there some other reason for this part of the change? if ( this .blockIdPrefix == null ) { throw new IOException( "Append Stream in invalid state. blockIdPrefix not set correctly" ); } It appears this check is unnecessary. The constructor always calls setBlocksCountAndBlockIdPrefix , which always guarantees that blockIdPrefix has been initialized to a non-null value.
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Hi Chris Nauroth,

        Could you please review the changes at your earliest.

        Thanks
        Siva

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Hi Chris Nauroth , Could you please review the changes at your earliest. Thanks Siva
        Hide
        dchickabasapa Dushyanth added a comment -

        +1 to HADOOP-13354.004.patch

        Show
        dchickabasapa Dushyanth added a comment - +1 to HADOOP-13354 .004.patch
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Okay.

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Okay.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Thanks for the test run. Ive been adding some downstream tests in SPARK-7481, incidentally.

        The commons-lang is interesting...i've just looked through the hadoop tree and don't see any explicit naming of commons-lang3 at all. I'm going to take a look at where it gets pulled in transitively; if it comes in from >1 dependency then we should be managing it in Hadoop itself.

        Show
        stevel@apache.org Steve Loughran added a comment - Thanks for the test run. Ive been adding some downstream tests in SPARK-7481 , incidentally. The commons-lang is interesting...i've just looked through the hadoop tree and don't see any explicit naming of commons-lang3 at all. I'm going to take a look at where it gets pulled in transitively; if it comes in from >1 dependency then we should be managing it in Hadoop itself.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Chris is on vacation this week, he's not going to be reviewing anything I'm afraid (though pleased that he's getting some rest)

        Show
        stevel@apache.org Steve Loughran added a comment - Chris is on vacation this week, he's not going to be reviewing anything I'm afraid (though pleased that he's getting some rest)
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Hi Chris Nauroth,

        Could you please take a look at the changes ?

        Thanks
        Siva

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Hi Chris Nauroth , Could you please take a look at the changes ? Thanks Siva
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Hi Steve Loughran,

        Thank you for your comments.

        Please find details of the tests that I ran, below:
        1. I ensured that both the contract tests and the live tests passed. I have attached the output to the JIRA.
        2. I ran Windows Azure Storage Blob (WASB) unit tests against a live Azure Storage account (West US region).

        I am seeing the following changes in the package-dependencies, after incorporating my changes:
        I have included comments at the end of each line below, describing the change.
        This is from comparing the dependencies-output produced by running "mvn dependency:tree -Dverbose", before and after my changes.

        [INFO] | +- org.apache.commons:commons-lang3:jar:3.4:compile /* Upgraded from org.apache.commons:commons-lang3:jar:3.3.2:compile */
        [INFO] | - com.microsoft.azure:azure-keyvault-core:jar:0.8.0:compile /* added, new */

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Hi Steve Loughran , Thank you for your comments. Please find details of the tests that I ran, below: 1. I ensured that both the contract tests and the live tests passed. I have attached the output to the JIRA. 2. I ran Windows Azure Storage Blob (WASB) unit tests against a live Azure Storage account (West US region). I am seeing the following changes in the package-dependencies, after incorporating my changes: I have included comments at the end of each line below, describing the change. This is from comparing the dependencies-output produced by running "mvn dependency:tree -Dverbose", before and after my changes. [INFO] | +- org.apache.commons:commons-lang3:jar:3.4:compile /* Upgraded from org.apache.commons:commons-lang3:jar:3.3.2:compile */ [INFO] | - com.microsoft.azure:azure-keyvault-core:jar:0.8.0:compile /* added, new */
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Test results indicating that both Contract Tests and Live Tests passed after include the code changes.

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Test results indicating that both Contract Tests and Live Tests passed after include the code changes.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        While I'm reasonably confident you've done it, can you declare which azure infrastructure you've tested against

        https://wiki.apache.org/hadoop/HowToContribute#Submitting_patches_against_object_stores_such_as_Amazon_S3.2C_OpenStack_Swift_and_Microsoft_Azure

        I see you are targeting 3.0 with the patch; 2.9 may be a viable target —I await Chris Nauroth's opinion. One question: will any other changes be visible to users. For example: extra transitive pom dependencies?

        Show
        stevel@apache.org Steve Loughran added a comment - While I'm reasonably confident you've done it, can you declare which azure infrastructure you've tested against https://wiki.apache.org/hadoop/HowToContribute#Submitting_patches_against_object_stores_such_as_Amazon_S3.2C_OpenStack_Swift_and_Microsoft_Azure I see you are targeting 3.0 with the patch; 2.9 may be a viable target —I await Chris Nauroth 's opinion. One question: will any other changes be visible to users. For example: extra transitive pom dependencies?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 1m 31s Maven dependency ordering for branch
        +1 mvninstall 6m 36s trunk passed
        +1 compile 6m 53s trunk passed
        +1 checkstyle 1m 21s trunk passed
        +1 mvnsite 0m 32s trunk passed
        +1 mvneclipse 0m 24s trunk passed
        0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
        +1 findbugs 0m 29s trunk passed
        +1 javadoc 0m 26s trunk passed
        0 mvndep 0m 18s Maven dependency ordering for patch
        +1 mvninstall 0m 28s the patch passed
        +1 compile 6m 52s the patch passed
        +1 javac 6m 52s the patch passed
        +1 checkstyle 1m 24s the patch passed
        +1 mvnsite 0m 37s the patch passed
        +1 mvneclipse 0m 32s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
        +1 findbugs 0m 40s the patch passed
        +1 javadoc 0m 32s the patch passed
        +1 unit 0m 13s hadoop-project in the patch passed.
        +1 unit 1m 27s hadoop-azure in the patch passed.
        +1 asflicense 0m 26s The patch does not generate ASF License warnings.
        53m 52s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817037/HADOOP-13354.004.patch
        JIRA Issue HADOOP-13354
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
        uname Linux 8e8d4a4a9a48 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9bdb5be
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9952/testReport/
        modules C: hadoop-project hadoop-tools/hadoop-azure U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9952/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 31s Maven dependency ordering for branch +1 mvninstall 6m 36s trunk passed +1 compile 6m 53s trunk passed +1 checkstyle 1m 21s trunk passed +1 mvnsite 0m 32s trunk passed +1 mvneclipse 0m 24s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 29s trunk passed +1 javadoc 0m 26s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 0m 28s the patch passed +1 compile 6m 52s the patch passed +1 javac 6m 52s the patch passed +1 checkstyle 1m 24s the patch passed +1 mvnsite 0m 37s the patch passed +1 mvneclipse 0m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 40s the patch passed +1 javadoc 0m 32s the patch passed +1 unit 0m 13s hadoop-project in the patch passed. +1 unit 1m 27s hadoop-azure in the patch passed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 53m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817037/HADOOP-13354.004.patch JIRA Issue HADOOP-13354 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 8e8d4a4a9a48 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9bdb5be Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9952/testReport/ modules C: hadoop-project hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9952/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        fixed warnings and error reported by findbugs

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - fixed warnings and error reported by findbugs
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        I have uploaded a patch containing changes to upgrade Microsoft Azure Storage Java SDK to 4.2.0 (from 2.2.0).
        Request Dushyanth, Gaurav Kanade and Chris Nauroth to review the changes.
        The changes do not require addition of new tests.
        The only difference is the version upgrade.. no new functionality has been added.
        The existing tests should continue to pass when the changes are applied.

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - I have uploaded a patch containing changes to upgrade Microsoft Azure Storage Java SDK to 4.2.0 (from 2.2.0). Request Dushyanth , Gaurav Kanade and Chris Nauroth to review the changes. The changes do not require addition of new tests. The only difference is the version upgrade.. no new functionality has been added. The existing tests should continue to pass when the changes are applied.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 1m 35s Maven dependency ordering for branch
        +1 mvninstall 6m 40s trunk passed
        +1 compile 6m 52s trunk passed
        +1 checkstyle 1m 21s trunk passed
        +1 mvnsite 0m 32s trunk passed
        +1 mvneclipse 0m 24s trunk passed
        0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
        +1 findbugs 0m 29s trunk passed
        +1 javadoc 0m 26s trunk passed
        0 mvndep 0m 18s Maven dependency ordering for patch
        +1 mvninstall 0m 28s the patch passed
        +1 compile 6m 50s the patch passed
        +1 javac 6m 50s the patch passed
        +1 checkstyle 1m 24s the patch passed
        +1 mvnsite 0m 38s the patch passed
        +1 mvneclipse 0m 32s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
        -1 findbugs 0m 41s hadoop-tools/hadoop-azure generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
        +1 javadoc 0m 32s the patch passed
        +1 unit 0m 13s hadoop-project in the patch passed.
        +1 unit 1m 26s hadoop-azure in the patch passed.
        +1 asflicense 0m 26s The patch does not generate ASF License warnings.
        54m 1s



        Reason Tests
        FindBugs module:hadoop-tools/hadoop-azure
          Found reliance on default encoding in org.apache.hadoop.fs.azure.BlockBlobAppendStream.generateNewerVersionBlockId(String, long):in org.apache.hadoop.fs.azure.BlockBlobAppendStream.generateNewerVersionBlockId(String, long): String.getBytes() At BlockBlobAppendStream.java:[line 528]
          Comparison of String objects using == or != in org.apache.hadoop.fs.azure.BlockBlobAppendStream.generateBlockId() At BlockBlobAppendStream.java:== or != in org.apache.hadoop.fs.azure.BlockBlobAppendStream.generateBlockId() At BlockBlobAppendStream.java:[line 499]



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817024/HADOOP-13354.003.patch
        JIRA Issue HADOOP-13354
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
        uname Linux a86107b77f1f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9bdb5be
        Default Java 1.8.0_91
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9951/artifact/patchprocess/new-findbugs-hadoop-tools_hadoop-azure.html
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9951/testReport/
        modules C: hadoop-project hadoop-tools/hadoop-azure U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9951/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 1m 35s Maven dependency ordering for branch +1 mvninstall 6m 40s trunk passed +1 compile 6m 52s trunk passed +1 checkstyle 1m 21s trunk passed +1 mvnsite 0m 32s trunk passed +1 mvneclipse 0m 24s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 0m 29s trunk passed +1 javadoc 0m 26s trunk passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 0m 28s the patch passed +1 compile 6m 50s the patch passed +1 javac 6m 50s the patch passed +1 checkstyle 1m 24s the patch passed +1 mvnsite 0m 38s the patch passed +1 mvneclipse 0m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project -1 findbugs 0m 41s hadoop-tools/hadoop-azure generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 0m 32s the patch passed +1 unit 0m 13s hadoop-project in the patch passed. +1 unit 1m 26s hadoop-azure in the patch passed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 54m 1s Reason Tests FindBugs module:hadoop-tools/hadoop-azure   Found reliance on default encoding in org.apache.hadoop.fs.azure.BlockBlobAppendStream.generateNewerVersionBlockId(String, long):in org.apache.hadoop.fs.azure.BlockBlobAppendStream.generateNewerVersionBlockId(String, long): String.getBytes() At BlockBlobAppendStream.java: [line 528]   Comparison of String objects using == or != in org.apache.hadoop.fs.azure.BlockBlobAppendStream.generateBlockId() At BlockBlobAppendStream.java:== or != in org.apache.hadoop.fs.azure.BlockBlobAppendStream.generateBlockId() At BlockBlobAppendStream.java: [line 499] Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817024/HADOOP-13354.003.patch JIRA Issue HADOOP-13354 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux a86107b77f1f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9bdb5be Default Java 1.8.0_91 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9951/artifact/patchprocess/new-findbugs-hadoop-tools_hadoop-azure.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9951/testReport/ modules C: hadoop-project hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9951/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        Changed encoding to UTF8 and Line-endings to Unix line ending

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - Changed encoding to UTF8 and Line-endings to Unix line ending
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 4s HADOOP-13354 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817022/HADOOP-13354.002.patch
        JIRA Issue HADOOP-13354
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9950/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HADOOP-13354 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817022/HADOOP-13354.002.patch JIRA Issue HADOOP-13354 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9950/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        synced, merged and re-uploaded patch

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - synced, merged and re-uploaded patch
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 4s HADOOP-13354 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816823/HADOOP-13354.001.patch
        JIRA Issue HADOOP-13354
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9942/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HADOOP-13354 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816823/HADOOP-13354.001.patch JIRA Issue HADOOP-13354 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9942/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment -

        First version of patch

        Show
        sisankar@microsoft.com Sivaguru Sankaridurg added a comment - First version of patch

          People

          • Assignee:
            sisankar@microsoft.com Sivaguru Sankaridurg
            Reporter:
            sisankar@microsoft.com Sivaguru Sankaridurg
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development