Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None

      Description

      http://http.us.debian.org/debian/pool/main/libi/libisal/libisal2_2.15.0-2_amd64.deb is returning a 404. We need to replace or remove this hack to prevent this from happening in the future.

      1. HADOOP-13342.00.patch
        0.6 kB
        Allen Wittenauer

        Activity

        Hide
        aw Allen Wittenauer added a comment -

        -00:

        • remove ISAL
        Show
        aw Allen Wittenauer added a comment - -00: remove ISAL
        Hide
        hadoopqa Hadoop QA added a comment -

        A patch to the testing environment has been detected.
        Re-executing against the patched versions to perform further tests.
        The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/9923/console in case of problems.

        Show
        hadoopqa Hadoop QA added a comment - A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/9923/console in case of problems.
        Hide
        raviprak Ravi Prakash added a comment -

        +1 LGTM. Will commit

        Show
        raviprak Ravi Prakash added a comment - +1 LGTM. Will commit
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 9m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        0 mvndep 0m 38s Maven dependency ordering for branch
        0 mvndep 0m 12s Maven dependency ordering for patch
        +1 shellcheck 0m 12s There were no new shellcheck issues.
        +1 shelldocs 0m 10s There were no new shelldocs issues.
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        11m 5s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:85209cc
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816237/HADOOP-13342.00.patch
        JIRA Issue HADOOP-13342
        Optional Tests asflicense shellcheck shelldocs
        uname Linux 6a92038e325a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8e672e3
        shellcheck v0.4.4
        modules C: U:
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9923/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 9m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. 0 mvndep 0m 38s Maven dependency ordering for branch 0 mvndep 0m 12s Maven dependency ordering for patch +1 shellcheck 0m 12s There were no new shellcheck issues. +1 shelldocs 0m 10s There were no new shelldocs issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 11m 5s Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816237/HADOOP-13342.00.patch JIRA Issue HADOOP-13342 Optional Tests asflicense shellcheck shelldocs uname Linux 6a92038e325a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8e672e3 shellcheck v0.4.4 modules C: U: Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9923/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        raviprak Ravi Prakash added a comment -

        Committed to trunk

        Show
        raviprak Ravi Prakash added a comment - Committed to trunk
        Hide
        aw Allen Wittenauer added a comment -

        Thank you!

        Show
        aw Allen Wittenauer added a comment - Thank you!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #10051 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10051/)
        HADOOP-13342. ISAL download is breaking the Dockerfile (raviprak: rev 9560f252cf1f6ac0f029f92f85fa710c191c177d)

        • dev-support/docker/Dockerfile
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10051 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10051/ ) HADOOP-13342 . ISAL download is breaking the Dockerfile (raviprak: rev 9560f252cf1f6ac0f029f92f85fa710c191c177d) dev-support/docker/Dockerfile
        Hide
        drankye Kai Zheng added a comment -

        Hi guys,

        Why the support was simply removed without any sync up or notifying? If you don't like ping, probably you could do a simple check and will obviously find in http://http.us.debian.org/debian/pool/main/libi/libisal/ that the library was upgraded. The fix would be rather simple by changing the revision number (2.16), instead of removing block of codes.

        As we discussed somewhere, please notify the relevant guys when you revert someone's work. Thanks!

        Show
        drankye Kai Zheng added a comment - Hi guys, Why the support was simply removed without any sync up or notifying? If you don't like ping, probably you could do a simple check and will obviously find in http://http.us.debian.org/debian/pool/main/libi/libisal/ that the library was upgraded. The fix would be rather simple by changing the revision number ( 2.16 ), instead of removing block of codes. As we discussed somewhere, please notify the relevant guys when you revert someone's work. Thanks!
        Hide
        raviprak Ravi Prakash added a comment - - edited

        Oh! Sorry about that Kai. Please create a new JIRA and I'm happy to +1 it. Also, I thought the Dockerfile was Allen's work. Didn't realize you'd added to it. My apologies.

        Show
        raviprak Ravi Prakash added a comment - - edited Oh! Sorry about that Kai. Please create a new JIRA and I'm happy to +1 it. Also, I thought the Dockerfile was Allen's work. Didn't realize you'd added to it. My apologies.
        Hide
        aw Allen Wittenauer added a comment -

        The basic problem is that the package needs to be reliable for an extremely long length of time since eventually this Dockerfile will end up in a release. Requiring a change every 6 months (was it even that?) is simply not good enough. With the build effectively being broken, it was much more expedient to just remove it rather than spend the effort to come up with a long term solution. It's also worth pointing out that the PowerPC version of the Dockerfile (HADOOP-13329) will also not be including ISAL.

        Show
        aw Allen Wittenauer added a comment - The basic problem is that the package needs to be reliable for an extremely long length of time since eventually this Dockerfile will end up in a release. Requiring a change every 6 months (was it even that?) is simply not good enough. With the build effectively being broken, it was much more expedient to just remove it rather than spend the effort to come up with a long term solution. It's also worth pointing out that the PowerPC version of the Dockerfile ( HADOOP-13329 ) will also not be including ISAL.
        Hide
        drankye Kai Zheng added a comment -

        Thanks Ravi Prakash for the clarifying, and your suggestion to bring it back. I will think about this and figure out a better way to do this, how to download and update new ISA-L library revision.

        Show
        drankye Kai Zheng added a comment - Thanks Ravi Prakash for the clarifying, and your suggestion to bring it back. I will think about this and figure out a better way to do this, how to download and update new ISA-L library revision.
        Hide
        drankye Kai Zheng added a comment -

        Hi Allen Wittenauer,

        Thanks for your thoughts!

        It's also worth pointing out that the PowerPC version of the Dockerfile will also not be including ISAL.

        Do you see any error on the platform? Did you mean the ISA-L library package couldn't be installed or it won't run? In your view, why is it being different when come to the ISA-L library, from the existing ones such as OpenSSL, Snappy and etc.?

        You mentioned a long term solution, do you have any idea besides the way to install it in the dockerfile?

        Thanks again.

        Show
        drankye Kai Zheng added a comment - Hi Allen Wittenauer , Thanks for your thoughts! It's also worth pointing out that the PowerPC version of the Dockerfile will also not be including ISAL. Do you see any error on the platform? Did you mean the ISA-L library package couldn't be installed or it won't run? In your view, why is it being different when come to the ISA-L library, from the existing ones such as OpenSSL, Snappy and etc.? You mentioned a long term solution, do you have any idea besides the way to install it in the dockerfile? Thanks again.

          People

          • Assignee:
            aw Allen Wittenauer
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development