Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13317

Add logs to KMS server-side to improve supportability

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      KMS.java is the main class that serves KMS http requests. There're currently no logs at all, making trouble shooting difficult.

      1. HADOOP-13317.patch
        11 kB
        Suraj Acharya
      2. HADOOP-13317-1.patch
        11 kB
        Suraj Acharya
      3. HADOOP-13317-2.patch
        11 kB
        Suraj Acharya
      4. HADOOP-13317-3.patch
        14 kB
        Suraj Acharya
      5. HADOOP-13317-3.patch
        11 kB
        Suraj Acharya
      6. HADOOP-13317-4.patch
        14 kB
        Suraj Acharya
      7. HADOOP-13317-5.patch
        14 kB
        Suraj Acharya
      8. HADOOP-13317-6.patch
        14 kB
        Suraj Acharya
      9. HADOOP-13317-7.patch
        15 kB
        Suraj Acharya

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10523 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10523/)
        HADOOP-13317. Add logs to KMS server-side to improve supportability. (xiao: rev 89bd6d29a62afd7ed8ff87bcc29d17b1cb53dcb6)

        • (edit) hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10523 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10523/ ) HADOOP-13317 . Add logs to KMS server-side to improve supportability. (xiao: rev 89bd6d29a62afd7ed8ff87bcc29d17b1cb53dcb6) (edit) hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java
        Hide
        xiaochen Xiao Chen added a comment -

        I have committed this to trunk, branch-2 and branch-2.8.
        Thanks Suraj Acharya for the contribution, and Wei-Chiu Chuang for the comment!

        Show
        xiaochen Xiao Chen added a comment - I have committed this to trunk, branch-2 and branch-2.8. Thanks Suraj Acharya for the contribution, and Wei-Chiu Chuang for the comment!
        Hide
        xiaochen Xiao Chen added a comment -

        +1 on patch 7, committing this.

        Show
        xiaochen Xiao Chen added a comment - +1 on patch 7, committing this.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 50s trunk passed
        +1 compile 8m 42s trunk passed
        +1 checkstyle 0m 12s trunk passed
        +1 mvnsite 0m 19s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 22s trunk passed
        +1 javadoc 0m 12s trunk passed
        +1 mvninstall 0m 16s the patch passed
        +1 compile 6m 55s the patch passed
        +1 javac 6m 55s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 20s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 34s the patch passed
        +1 javadoc 0m 13s the patch passed
        +1 unit 2m 10s hadoop-kms in the patch passed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        31m 47s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13317
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831196/HADOOP-13317-7.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c9a4e333db55 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2549ee9
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10636/testReport/
        modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10636/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 50s trunk passed +1 compile 8m 42s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 22s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 16s the patch passed +1 compile 6m 55s the patch passed +1 javac 6m 55s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 34s the patch passed +1 javadoc 0m 13s the patch passed +1 unit 2m 10s hadoop-kms in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 31m 47s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13317 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831196/HADOOP-13317-7.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c9a4e333db55 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2549ee9 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10636/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10636/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sacharya Suraj Acharya added a comment -

        Fix checkstyle

        Show
        sacharya Suraj Acharya added a comment - Fix checkstyle
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 5s trunk passed
        +1 compile 7m 2s trunk passed
        +1 checkstyle 0m 12s trunk passed
        +1 mvnsite 0m 19s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 21s trunk passed
        +1 javadoc 0m 11s trunk passed
        +1 mvninstall 0m 16s the patch passed
        +1 compile 7m 25s the patch passed
        +1 javac 7m 25s the patch passed
        -0 checkstyle 0m 13s hadoop-common-project/hadoop-kms: The patch generated 2 new + 6 unchanged - 0 fixed = 8 total (was 6)
        +1 mvnsite 0m 19s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 30s the patch passed
        +1 javadoc 0m 12s the patch passed
        +1 unit 2m 7s hadoop-kms in the patch passed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        28m 36s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13317
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831145/HADOOP-13317-6.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7acefa7b4b8d 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d6afcf3
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10635/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-kms.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10635/testReport/
        modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10635/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 5s trunk passed +1 compile 7m 2s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 21s trunk passed +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 16s the patch passed +1 compile 7m 25s the patch passed +1 javac 7m 25s the patch passed -0 checkstyle 0m 13s hadoop-common-project/hadoop-kms: The patch generated 2 new + 6 unchanged - 0 fixed = 8 total (was 6) +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 2m 7s hadoop-kms in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 28m 36s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13317 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831145/HADOOP-13317-6.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7acefa7b4b8d 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d6afcf3 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10635/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-kms.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10635/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10635/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 49s trunk passed
        +1 compile 7m 21s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 22s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 0m 26s trunk passed
        +1 javadoc 0m 12s trunk passed
        +1 mvninstall 0m 18s the patch passed
        +1 compile 7m 58s the patch passed
        +1 javac 7m 58s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 19s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 30s the patch passed
        +1 javadoc 0m 14s the patch passed
        +1 unit 2m 13s hadoop-kms in the patch passed.
        +1 asflicense 0m 25s The patch does not generate ASF License warnings.
        30m 41s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13317
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831033/HADOOP-13317-5.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bba5a928ff95 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 10be459
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10632/testReport/
        modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10632/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 49s trunk passed +1 compile 7m 21s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 26s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 18s the patch passed +1 compile 7m 58s the patch passed +1 javac 7m 58s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 14s the patch passed +1 unit 2m 13s hadoop-kms in the patch passed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 30m 41s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13317 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831033/HADOOP-13317-5.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bba5a928ff95 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 10be459 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10632/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10632/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Suraj Acharya for revving. I should have mentioned that the 'string construction' is better to be done using a StringBuilder. +1 pending though.

        Will wait for some time in case Wei-Chiu Chuang or other watchers has any comments.

        Show
        xiaochen Xiao Chen added a comment - Thanks Suraj Acharya for revving. I should have mentioned that the 'string construction' is better to be done using a StringBuilder . +1 pending though. Will wait for some time in case Wei-Chiu Chuang or other watchers has any comments.
        Hide
        sacharya Suraj Acharya added a comment -

        Fixed a typo.

        Show
        sacharya Suraj Acharya added a comment - Fixed a typo.
        Hide
        sacharya Suraj Acharya added a comment -

        Added stacktrace.
        Converted error into a string.

        Show
        sacharya Suraj Acharya added a comment - Added stacktrace. Converted error into a string.
        Hide
        xiaochen Xiao Chen added a comment -

        Would it make sense to print user information as a debug message in each response handler?

        We have audit for that purpose, so don't think having debug info on this is useful.

        Show
        xiaochen Xiao Chen added a comment - Would it make sense to print user information as a debug message in each response handler? We have audit for that purpose, so don't think having debug info on this is useful.
        Hide
        sacharya Suraj Acharya added a comment - - edited

        So the reason i have put some info in is because we usually want to run the debug only for some period of time and during that time period we want to be able to figure out what exactly is happening.
        Also, the information is not technically coming from the client since many usecases might be where the hadoop key shell or some other process is making the call and we want to see if there is a bug in the KMS side or in the incoming messages.

        Show
        sacharya Suraj Acharya added a comment - - edited So the reason i have put some info in is because we usually want to run the debug only for some period of time and during that time period we want to be able to figure out what exactly is happening. Also, the information is not technically coming from the client since many usecases might be where the hadoop key shell or some other process is making the call and we want to see if there is a bug in the KMS side or in the incoming messages.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Would it make sense to print user information as a debug message in each response handler?

        Show
        jojochuang Wei-Chiu Chuang added a comment - Would it make sense to print user information as a debug message in each response handler?
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks for the new rev, Suraj! Overall looks great. +1 pending the following:

        In generateEncryptedKeys:

                LOG.error("Exception in generateEncryptedKeys, Exception type {}," +
                        "Exception Message {}", e, e.toString());
        

        Prefer to add a debug log with full stacktrace here.

              LOG.error("IllegalArgumentException Wrong {} value, it must be {} or {}",
                      KMSRESTConstants.EEK_OP, KMSRESTConstants.EEK_GENERATE,
                      KMSRESTConstants.EEK_DECRYPT);
              throw new IllegalArgumentException("Wrong " + KMSRESTConstants.EEK_OP +
                  " value, it must be " + KMSRESTConstants.EEK_GENERATE + " or " +
                  KMSRESTConstants.EEK_DECRYPT);
        

        Please construct a string and log/throw the constructed string. Same applies to decryptEncryptedKey.

        Show
        xiaochen Xiao Chen added a comment - Thanks for the new rev, Suraj! Overall looks great. +1 pending the following: In generateEncryptedKeys : LOG.error( "Exception in generateEncryptedKeys, Exception type {}," + "Exception Message {}" , e, e.toString()); Prefer to add a debug log with full stacktrace here. LOG.error( "IllegalArgumentException Wrong {} value, it must be {} or {}" , KMSRESTConstants.EEK_OP, KMSRESTConstants.EEK_GENERATE, KMSRESTConstants.EEK_DECRYPT); throw new IllegalArgumentException( "Wrong " + KMSRESTConstants.EEK_OP + " value, it must be " + KMSRESTConstants.EEK_GENERATE + " or " + KMSRESTConstants.EEK_DECRYPT); Please construct a string and log/throw the constructed string. Same applies to decryptEncryptedKey .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 26s Docker mode activated.
        +1 @author 0m 1s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 12s trunk passed
        +1 compile 6m 57s trunk passed
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 18s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 23s trunk passed
        +1 javadoc 0m 12s trunk passed
        +1 mvninstall 0m 15s the patch passed
        +1 compile 6m 49s the patch passed
        +1 javac 6m 49s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 18s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 29s the patch passed
        +1 javadoc 0m 12s the patch passed
        +1 unit 2m 7s hadoop-kms in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        28m 16s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13317
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830229/HADOOP-13317-3.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cb299517f13e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5707f88
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10589/testReport/
        modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10589/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 12s trunk passed +1 compile 6m 57s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 18s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 23s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 15s the patch passed +1 compile 6m 49s the patch passed +1 javac 6m 49s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 29s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 2m 7s hadoop-kms in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 28m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13317 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830229/HADOOP-13317-3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cb299517f13e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5707f88 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10589/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10589/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sacharya Suraj Acharya added a comment - - edited
        • Added trace to exiting a method.
        • Added log information of edek operation as per comments.
        Show
        sacharya Suraj Acharya added a comment - - edited Added trace to exiting a method. Added log information of edek operation as per comments.
        Hide
        xiaochen Xiao Chen added a comment -

        The KMS does not support any other cipher other than AES/CTR in the current implementation. One can change the cipher in core-site.xml but that will throw an error since AES/CTR has been hardcoded.

        Cool, thanks for explaining.

        I havent put some information in the logs because of either sensitive matter or access control.

        Agreed. Though I was referring to the input parameters (from HTTP requests), such as eekOp of decryptEncryptedKey.

        I think we should make that as a separate effort for the KMS.

        Sure.

        Show
        xiaochen Xiao Chen added a comment - The KMS does not support any other cipher other than AES/CTR in the current implementation. One can change the cipher in core-site.xml but that will throw an error since AES/CTR has been hardcoded. Cool, thanks for explaining. I havent put some information in the logs because of either sensitive matter or access control. Agreed. Though I was referring to the input parameters (from HTTP requests), such as eekOp of decryptEncryptedKey . I think we should make that as a separate effort for the KMS. Sure.
        Hide
        sacharya Suraj Acharya added a comment - - edited
        • The KMS does not support any other cipher other than AES/CTR in the current implementation. One can change the cipher in core-site.xml but that will throw an error since AES/CTR has been hardcoded.
        • I havent put some information in the logs because of either sensitive matter or access control. Putting material of a key is an information leak. Also, it is an information leak to print out the metadata and other information while being returned. I have logged mostly the incoming request information and the reason is the same.
        • Also, I didnt wish to put information where ACLs protect transaction.
        • I now get what you are saying about the exceptions. I think we should make that as a separate effort for the KMS. The reason being we will need to know the exceptions we wish to handle.
        Show
        sacharya Suraj Acharya added a comment - - edited The KMS does not support any other cipher other than AES/CTR in the current implementation. One can change the cipher in core-site.xml but that will throw an error since AES/CTR has been hardcoded. I havent put some information in the logs because of either sensitive matter or access control. Putting material of a key is an information leak. Also, it is an information leak to print out the metadata and other information while being returned. I have logged mostly the incoming request information and the reason is the same. Also, I didnt wish to put information where ACLs protect transaction. I now get what you are saying about the exceptions. I think we should make that as a separate effort for the KMS. The reason being we will need to know the exceptions we wish to handle.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Suraj for revving. Overall looks good.

        Some more comments:

        • From my previous comment: for createKey, is it safe to put cipher in the logs?
        • Propose to log all params in debug log. If we want to look at debug log, things are pretty much not what we thought to be. So more information won't harm.
        • Sorry I may not be clear in when the underlying provider throws an exception, it just propagates into tomcat and we ends up seeing nothing in the KMS log. Take createKey for example. If provider.createKey or provider.flush throws, would we see anything in KMS log? Last time I ended up adding a try-catch to the entire method, not sure if there's a better way. You can try it out by hard-coding that block to throw and check the log. Another advantage is we can also add a trace level exit log, symmetric to the entering one.
        Show
        xiaochen Xiao Chen added a comment - Thanks Suraj for revving. Overall looks good. Some more comments: From my previous comment: for createKey, is it safe to put cipher in the logs? Propose to log all params in debug log. If we want to look at debug log, things are pretty much not what we thought to be. So more information won't harm. Sorry I may not be clear in when the underlying provider throws an exception, it just propagates into tomcat and we ends up seeing nothing in the KMS log . Take createKey for example. If provider.createKey or provider.flush throws, would we see anything in KMS log? Last time I ended up adding a try-catch to the entire method, not sure if there's a better way. You can try it out by hard-coding that block to throw and check the log. Another advantage is we can also add a trace level exit log, symmetric to the entering one.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 26s trunk passed
        +1 compile 7m 10s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 18s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 22s trunk passed
        +1 javadoc 0m 11s trunk passed
        +1 mvninstall 0m 15s the patch passed
        +1 compile 7m 5s the patch passed
        +1 javac 7m 5s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 19s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 31s the patch passed
        +1 javadoc 0m 12s the patch passed
        +1 unit 2m 7s hadoop-kms in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        28m 49s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13317
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829842/HADOOP-13317-3.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d0aef0f93a49 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 537095d
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10570/testReport/
        modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10570/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 26s trunk passed +1 compile 7m 10s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 18s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 22s trunk passed +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 15s the patch passed +1 compile 7m 5s the patch passed +1 javac 7m 5s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 31s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 2m 7s hadoop-kms in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 28m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13317 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829842/HADOOP-13317-3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d0aef0f93a49 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 537095d Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10570/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10570/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sacharya Suraj Acharya added a comment -

        Checkstyle fix

        Show
        sacharya Suraj Acharya added a comment - Checkstyle fix
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 11s trunk passed
        +1 compile 7m 26s trunk passed
        +1 checkstyle 0m 12s trunk passed
        +1 mvnsite 0m 19s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 22s trunk passed
        +1 javadoc 0m 12s trunk passed
        +1 mvninstall 0m 16s the patch passed
        +1 compile 7m 23s the patch passed
        +1 javac 7m 23s the patch passed
        -0 checkstyle 0m 12s hadoop-common-project/hadoop-kms: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
        +1 mvnsite 0m 19s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 31s the patch passed
        +1 javadoc 0m 12s the patch passed
        +1 unit 2m 7s hadoop-kms in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        29m 6s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13317
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829743/HADOOP-13317-2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux da74f558d298 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 537095d
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10566/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-kms.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10566/testReport/
        modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10566/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 11s trunk passed +1 compile 7m 26s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 22s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 16s the patch passed +1 compile 7m 23s the patch passed +1 javac 7m 23s the patch passed -0 checkstyle 0m 12s hadoop-common-project/hadoop-kms: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6) +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 31s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 2m 7s hadoop-kms in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 29m 6s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13317 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829743/HADOOP-13317-2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux da74f558d298 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 537095d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10566/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-kms.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10566/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10566/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sacharya Suraj Acharya added a comment -
        • Moved all trace to beginning of the method.
        • removed the isTraceEnabled() and isDebugEnabled() call.
        • Created more precise log messages
        • Log all exceptions before throwing Exception.
        Show
        sacharya Suraj Acharya added a comment - Moved all trace to beginning of the method. removed the isTraceEnabled() and isDebugEnabled() call. Created more precise log messages Log all exceptions before throwing Exception.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks for working on this, Suraj Acharya! I'm very happy to see this improved.

        A few comments:

        • Please make sure the trace is logged at the entry of each call - I guess that's their intended use, we have debug logs soon after. (e.g. move it to before the Meter#mark() in createKey
        • I believe slf4j doesn't need to have the wrapper isTraceEnabled or isDebugEnabled if we provide a format string, because there is no extra cost when they're disabled.
        • Same as above, let's use placeholders '{}' for the logs.
        • We can possibly combine some of the debug logs. For example, createKey we can print sth like LOG.debug("length is {}, description is {}", length, description) to reduce message number. Also for createKey, is it safe to put cipher in the logs?
        • I also remember seeing when the underlying provider throws an exception, it just propagates into tomcat and we ends up seeing nothing in the KMS log. Can we also take care of that?
        Show
        xiaochen Xiao Chen added a comment - Thanks for working on this, Suraj Acharya ! I'm very happy to see this improved. A few comments: Please make sure the trace is logged at the entry of each call - I guess that's their intended use, we have debug logs soon after. (e.g. move it to before the Meter#mark() in createKey I believe slf4j doesn't need to have the wrapper isTraceEnabled or isDebugEnabled if we provide a format string, because there is no extra cost when they're disabled . Same as above, let's use placeholders '{}' for the logs. We can possibly combine some of the debug logs. For example, createKey we can print sth like LOG.debug("length is {}, description is {}", length, description) to reduce message number. Also for createKey , is it safe to put cipher in the logs? I also remember seeing when the underlying provider throws an exception, it just propagates into tomcat and we ends up seeing nothing in the KMS log. Can we also take care of that?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 6s trunk passed
        +1 compile 7m 21s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 19s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 22s trunk passed
        +1 javadoc 0m 12s trunk passed
        +1 mvninstall 0m 16s the patch passed
        +1 compile 7m 18s the patch passed
        +1 javac 7m 18s the patch passed
        +1 checkstyle 0m 13s the patch passed
        +1 mvnsite 0m 19s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 32s the patch passed
        +1 javadoc 0m 13s the patch passed
        +1 unit 2m 11s hadoop-kms in the patch passed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        28m 59s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13317
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829703/HADOOP-13317-1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3e97973ae4be 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 964e546
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10560/testReport/
        modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10560/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 6s trunk passed +1 compile 7m 21s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 22s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 16s the patch passed +1 compile 7m 18s the patch passed +1 javac 7m 18s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 32s the patch passed +1 javadoc 0m 13s the patch passed +1 unit 2m 11s hadoop-kms in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 28m 59s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13317 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829703/HADOOP-13317-1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3e97973ae4be 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 964e546 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10560/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10560/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sacharya Suraj Acharya added a comment -
        • Fixed checkstyle issue.
        • Log improvements. hence no tests are needed.
        Show
        sacharya Suraj Acharya added a comment - Fixed checkstyle issue. Log improvements. hence no tests are needed.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 48s trunk passed
        +1 compile 8m 26s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 22s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 25s trunk passed
        +1 javadoc 0m 13s trunk passed
        +1 mvninstall 0m 20s the patch passed
        +1 compile 6m 45s the patch passed
        +1 javac 6m 45s the patch passed
        -0 checkstyle 0m 12s hadoop-common-project/hadoop-kms: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6)
        +1 mvnsite 0m 18s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 28s the patch passed
        +1 javadoc 0m 12s the patch passed
        +1 unit 2m 7s hadoop-kms in the patch passed.
        +1 asflicense 0m 25s The patch does not generate ASF License warnings.
        30m 13s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HADOOP-13317
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829686/HADOOP-13317.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 87ee50ad8708 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 964e546
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10558/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-kms.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10558/testReport/
        modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10558/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 48s trunk passed +1 compile 8m 26s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 13s trunk passed +1 mvninstall 0m 20s the patch passed +1 compile 6m 45s the patch passed +1 javac 6m 45s the patch passed -0 checkstyle 0m 12s hadoop-common-project/hadoop-kms: The patch generated 1 new + 6 unchanged - 0 fixed = 7 total (was 6) +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 28s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 2m 7s hadoop-kms in the patch passed. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 30m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13317 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829686/HADOOP-13317.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 87ee50ad8708 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 964e546 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10558/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-kms.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10558/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10558/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sacharya Suraj Acharya added a comment -

        I have added some logs to KMS.java.
        I have tried to refrain from printing too much information from creation of key.

        Show
        sacharya Suraj Acharya added a comment - I have added some logs to KMS.java. I have tried to refrain from printing too much information from creation of key.

          People

          • Assignee:
            sacharya Suraj Acharya
            Reporter:
            xiaochen Xiao Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development