Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13296

Cleanup javadoc for Path

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: 2.8.0
        • Fix Version/s: 2.8.0, 3.0.0-alpha1
        • Component/s: documentation
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          The javadoc in the Path class needs lots of help.

          1. Text File
            HADOOP-13296.001.patch
            12 kB
            Daniel Templeton

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ajisakaa Akira Ajisaka added a comment -

            Copied from https://builds.apache.org/job/PreCommit-HADOOP-Build/9835/console

            -1 overall

            Vote Subsystem Runtime Comment
            0 reexec 0m 18s Docker mode activated.
            +1 @author 0m 0s The patch does not contain any @author
                  tags.
            -1 test4tests 0m 0s The patch doesn't appear to include any
                  new or modified tests. Please justify why
                  no new tests are needed for this patch.
                  Also please list what manual steps were
                  performed to verify this patch.
            +1 mvninstall 8m 3s trunk passed
            +1 compile 7m 31s trunk passed
            +1 checkstyle 0m 24s trunk passed
            +1 mvnsite 0m 56s trunk passed
            +1 mvneclipse 0m 13s trunk passed
            +1 findbugs 1m 23s trunk passed
            +1 javadoc 0m 46s trunk passed
            +1 mvninstall 0m 40s the patch passed
            +1 compile 6m 30s the patch passed
            +1 javac 6m 30s the patch passed
            +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The
                  patch generated 0 new + 22 unchanged - 3
                  fixed = 22 total (was 25)
            +1 mvnsite 0m 53s the patch passed
            +1 mvneclipse 0m 12s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 findbugs 1m 37s the patch passed
            +1 javadoc 0m 46s the patch passed
            +1 unit 7m 42s hadoop-common in the patch passed.
            +1 asflicense 0m 22s The patch does not generate ASF License
                  warnings.
                39m 27s
            Subsystem Report/Notes
            Docker Image:yetus/hadoop:e2f6409
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811863/HADOOP-13296.001.patch
            JIRA Issue HADOOP-13296
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
            uname Linux 32255c9870ae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
            git revision trunk / 5107a96
            Default Java 1.8.0_91
            findbugs v3.0.0
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9835/testReport/
            modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9835/console
            Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org
            Show
            ajisakaa Akira Ajisaka added a comment - Copied from https://builds.apache.org/job/PreCommit-HADOOP-Build/9835/console -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author       tags. -1 test4tests 0m 0s The patch doesn't appear to include any       new or modified tests. Please justify why       no new tests are needed for this patch.       Also please list what manual steps were       performed to verify this patch. +1 mvninstall 8m 3s trunk passed +1 compile 7m 31s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 23s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 6m 30s the patch passed +1 javac 6m 30s the patch passed +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The       patch generated 0 new + 22 unchanged - 3       fixed = 22 total (was 25) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 37s the patch passed +1 javadoc 0m 46s the patch passed +1 unit 7m 42s hadoop-common in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License       warnings.     39m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811863/HADOOP-13296.001.patch JIRA Issue HADOOP-13296 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 32255c9870ae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5107a96 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9835/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9835/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org
            Hide
            Permalink
            ajisakaa Akira Ajisaka added a comment -

            LGTM, +1.

            Show
            ajisakaa Akira Ajisaka added a comment - LGTM, +1.
            Hide
            Permalink
            ajisakaa Akira Ajisaka added a comment -

            Committed this to branch-2.8 and above. Thanks Daniel Templeton for the contribution!

            Show
            ajisakaa Akira Ajisaka added a comment - Committed this to branch-2.8 and above. Thanks Daniel Templeton for the contribution!
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-trunk-Commit #9994 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9994/)
            HADOOP-13296. Cleanup javadoc for Path. Contributed by Daniel Templeton. (aajisaka: rev e15cd43369eb6d478844f25897e4a86065c62168)

            • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9994 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9994/ ) HADOOP-13296 . Cleanup javadoc for Path. Contributed by Daniel Templeton. (aajisaka: rev e15cd43369eb6d478844f25897e4a86065c62168) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
            Hide
            Permalink
            templedf Daniel Templeton added a comment -

            Thanks for the commit, Akira Ajisaka!

            Show
            templedf Daniel Templeton added a comment - Thanks for the commit, Akira Ajisaka !

              People

              • Assignee:
                templedf Daniel Templeton
                Reporter:
                templedf Daniel Templeton
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development