Yuanbo Liu added a comment - 28/Jun/16 03:19 Seems that this jira could be marked as improvement.

Jonathan Hung added a comment - 09/Jul/16 17:19 Attached a patch. Parameterizes BlockingQueue in FairCallQueue and parameterizes FairCallQueue in MetricsProxy nested class. Please review!

Konstantin Shvachko added a comment - 11/Jul/16 18:24 Jonathan Hung , the patch looks good. Could you please explain your motivation for the new test case. Also you should click on the "Submit Patch" button to trigger Jenkins build.

Jonathan Hung added a comment - 11/Jul/16 19:00 Konstantin Shvachko , thanks. The test case is just a sanity check to make sure the MXBean still works properly, and I noticed there wasn't an existing unit test for it.

Hadoop QA added a comment - 11/Jul/16 20:15 +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 56s trunk passed +1 compile 6m 55s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 20s trunk passed +1 javadoc 0m 46s trunk passed +1 mvninstall 0m 37s the patch passed +1 compile 6m 51s the patch passed +1 javac 6m 51s the patch passed -0 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 1 new + 34 unchanged - 0 fixed = 35 total (was 34) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 49s the patch passed +1 unit 7m 53s hadoop-common in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 41m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816997/HADOOP-13290.001.patch JIRA Issue HADOOP-13290 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fd0de9efec29 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0fd3980 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9958/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9958/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9958/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

Konstantin Shvachko added a comment - 12/Jul/16 01:35 Looks like you made a line longer than 80 symbols, therefore the checkstyle warning.

Jonathan Hung added a comment - 12/Jul/16 02:35 Ah. Thanks. Just uploaded a new patch and triggered jenkins build.

Hadoop QA added a comment - 12/Jul/16 03:24 +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 25s trunk passed +1 compile 9m 0s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 54s trunk passed +1 mvninstall 0m 55s the patch passed +1 compile 7m 45s the patch passed +1 javac 7m 45s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 34s the patch passed +1 javadoc 0m 49s the patch passed +1 unit 8m 23s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 44m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817321/HADOOP-13290.002.patch JIRA Issue HADOOP-13290 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fdbbe8aa5bd9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f292624 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9964/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9964/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

Konstantin Shvachko added a comment - 13/Jul/16 00:01 +1 from me too.

Zhe Zhang added a comment - 13/Jul/16 23:58 Thanks Jonathan for the fix and Konstantin for the review. I just committed the patch to trunk~branch2.6.

Hudson added a comment - 14/Jul/16 00:18 SUCCESS: Integrated in Hadoop-trunk-Commit #10094 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10094/ ) HADOOP-13290 . Appropriate use of generics in FairCallQueue. Contributed (zhz: rev 728bf7f6988e13f17f03d2e3a4037b7238c4fd45) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/FairCallQueue.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestFairCallQueue.java

Jonathan Hung added a comment - 14/Jul/16 00:28 Thanks Zhe Zhang and Konstantin Shvachko !

Vinod Kumar Vavilapalli added a comment - 20/Jul/16 17:53 2.7.3 was already under release process, changing the fix-version to 2.7.4.