Seems that this jira could be marked as improvement.
Attached a patch. Parameterizes BlockingQueue in FairCallQueue and parameterizes FairCallQueue in MetricsProxy nested class. Please review!
Jonathan Hung, the patch looks good. Could you please explain your motivation for the new test case. Also you should click on the "Submit Patch" button to trigger Jenkins build.
Konstantin Shvachko, thanks. The test case is just a sanity check to make sure the MXBean still works properly, and I noticed there wasn't an existing unit test for it.
This message was automatically generated.
Looks like you made a line longer than 80 symbols, therefore the checkstyle warning.
Ah. Thanks. Just uploaded a new patch and triggered jenkins build.
+1 from me too.
Thanks Jonathan for the fix and Konstantin for the review. I just committed the patch to trunk~branch2.6.
SUCCESS: Integrated in Hadoop-trunk-Commit #10094 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10094/)
HADOOP-13290. Appropriate use of generics in FairCallQueue. Contributed (zhz: rev 728bf7f6988e13f17f03d2e3a4037b7238c4fd45)
Thanks Zhe Zhang and Konstantin Shvachko!
2.7.3 was already under release process, changing the fix-version to 2.7.4.