Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13243

TestRollingFileSystemSink.testSetInitialFlushTime() fails intermittently

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Because of poor checking of boundary conditions, the test fails 1% of the time:

      The initial flush time was calculated incorrectly: 0
      
      Stacktrace
      
      java.lang.AssertionError: The initial flush time was calculated incorrectly: 0
      	at org.junit.Assert.fail(Assert.java:88)
      	at org.junit.Assert.assertTrue(Assert.java:41)
      	at org.apache.hadoop.metrics2.sink.TestRollingFileSystemSink.testSetInitialFlushTime(TestRollingFileSystemSink.java:120)
      

        Activity

        Hide
        templedf Daniel Templeton added a comment -

        I'm working on it, even though I can't assign it to myself anymore.

        Show
        templedf Daniel Templeton added a comment - I'm working on it, even though I can't assign it to myself anymore.
        Hide
        templedf Daniel Templeton added a comment -

        The test has not failed in 180 test runs. I'll let it go overnight to be extra sure.

        Show
        templedf Daniel Templeton added a comment - The test has not failed in 180 test runs. I'll let it go overnight to be extra sure.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 25s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 10m 11s trunk passed
        +1 compile 7m 2s trunk passed
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 1m 4s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 20s trunk passed
        +1 javadoc 0m 54s trunk passed
        +1 mvninstall 0m 39s the patch passed
        +1 compile 6m 59s the patch passed
        +1 javac 6m 59s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 29s the patch passed
        +1 javadoc 0m 57s the patch passed
        -1 unit 8m 17s hadoop-common in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        42m 21s



        Reason Tests
        Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808498/HADOOP-13243.001.patch
        JIRA Issue HADOOP-13243
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cc584a68b859 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6de9213
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9671/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9671/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9671/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 10m 11s trunk passed +1 compile 7m 2s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 20s trunk passed +1 javadoc 0m 54s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 6m 59s the patch passed +1 javac 6m 59s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 29s the patch passed +1 javadoc 0m 57s the patch passed -1 unit 8m 17s hadoop-common in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 42m 21s Reason Tests Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808498/HADOOP-13243.001.patch JIRA Issue HADOOP-13243 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cc584a68b859 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6de9213 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9671/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9671/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9671/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        I just ran it 4122 times without a failure. I think it's fixed.

        The unit test failure from Jenkins is unrelated.

        Show
        templedf Daniel Templeton added a comment - I just ran it 4122 times without a failure. I think it's fixed. The unit test failure from Jenkins is unrelated.
        Hide
        kasha Karthik Kambatla added a comment -

        +1

        Show
        kasha Karthik Kambatla added a comment - +1
        Hide
        kasha Karthik Kambatla added a comment -

        Just committed this to trunk and branch-2.

        Thanks Daniel Templeton for the fix.

        Show
        kasha Karthik Kambatla added a comment - Just committed this to trunk and branch-2. Thanks Daniel Templeton for the fix.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9952 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9952/)
        HADOOP-13243. TestRollingFileSystemSink.testSetInitialFlushTime() fails (kasha: rev 49b4064644b242921af4ddf1de9932bc7bcf5f0e)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/sink/TestRollingFileSystemSink.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9952 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9952/ ) HADOOP-13243 . TestRollingFileSystemSink.testSetInitialFlushTime() fails (kasha: rev 49b4064644b242921af4ddf1de9932bc7bcf5f0e) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/sink/TestRollingFileSystemSink.java

          People

          • Assignee:
            templedf Daniel Templeton
            Reporter:
            templedf Daniel Templeton
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development