Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:

      Description

      We can use Date and Time API (JSR-310) in trunk code.

        Activity

        Hide
        ajisakaa Akira Ajisaka added a comment -

        01 patch:

        • Use Date and Time API in KafkaSink
        • Re-use DateTimeFormatter
        • Fixes format "hh"(1-12) -> "HH" (0-23)
        Show
        ajisakaa Akira Ajisaka added a comment - 01 patch: Use Date and Time API in KafkaSink Re-use DateTimeFormatter Fixes format "hh"(1-12) -> "HH" (0-23)
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 28s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 29s trunk passed
        +1 compile 0m 10s trunk passed
        +1 checkstyle 0m 10s trunk passed
        +1 mvnsite 0m 13s trunk passed
        +1 mvneclipse 0m 10s trunk passed
        +1 findbugs 0m 16s trunk passed
        +1 javadoc 0m 11s trunk passed
        +1 mvninstall 0m 9s the patch passed
        +1 compile 0m 9s the patch passed
        +1 javac 0m 9s the patch passed
        +1 checkstyle 0m 8s the patch passed
        +1 mvnsite 0m 10s the patch passed
        +1 mvneclipse 0m 8s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 29s the patch passed
        +1 javadoc 0m 8s the patch passed
        +1 unit 0m 8s hadoop-kafka in the patch passed.
        +1 asflicense 0m 14s The patch does not generate ASF License warnings.
        10m 29s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807913/HADOOP-13235.01.patch
        JIRA Issue HADOOP-13235
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1620ed4a8226 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 97e2449
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9657/testReport/
        modules C: hadoop-tools/hadoop-kafka U: hadoop-tools/hadoop-kafka
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9657/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 28s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 29s trunk passed +1 compile 0m 10s trunk passed +1 checkstyle 0m 10s trunk passed +1 mvnsite 0m 13s trunk passed +1 mvneclipse 0m 10s trunk passed +1 findbugs 0m 16s trunk passed +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 9s the patch passed +1 compile 0m 9s the patch passed +1 javac 0m 9s the patch passed +1 checkstyle 0m 8s the patch passed +1 mvnsite 0m 10s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 29s the patch passed +1 javadoc 0m 8s the patch passed +1 unit 0m 8s hadoop-kafka in the patch passed. +1 asflicense 0m 14s The patch does not generate ASF License warnings. 10m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807913/HADOOP-13235.01.patch JIRA Issue HADOOP-13235 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1620ed4a8226 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 97e2449 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9657/testReport/ modules C: hadoop-tools/hadoop-kafka U: hadoop-tools/hadoop-kafka Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9657/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        +1

        Show
        aw Allen Wittenauer added a comment - +1
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk. Thanks Allen for review!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Allen for review!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #10034 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10034/)
        HADOOP-13235. Use Date and Time API in KafkaSink. (aajisaka: rev 8d202f12589356344e26b7ca15097eec46886055)

        • hadoop-tools/hadoop-kafka/src/main/java/org/apache/hadoop/metrics2/sink/KafkaSink.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10034 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10034/ ) HADOOP-13235 . Use Date and Time API in KafkaSink. (aajisaka: rev 8d202f12589356344e26b7ca15097eec46886055) hadoop-tools/hadoop-kafka/src/main/java/org/apache/hadoop/metrics2/sink/KafkaSink.java

          People

          • Assignee:
            ajisakaa Akira Ajisaka
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development