[HADOOP-13201] Print the directory paths when ViewFs denies the rename operation on internal dirs

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.2
• Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha2
• Component/s: viewfs
• Hadoop Flags: Reviewed
• Assignee: Rakesh Radhakrishnan
• Reporter: Tianyin Xu
• Created: 24/May/16 22:57
• Updated: 27/Oct/16 14:49
• Resolved: 27/Oct/16 14:40

Description

With ViewFs, the delete and rename operations on internal dirs are denied by throwing AccessControlException.

Unlike the delete() which notify the internal dir path, rename does not.

The attached patch appends the directory path on the logged exception.

ViewFs.java

     InodeTree.ResolveResult<AbstractFileSystem> resSrc = 
       fsState.resolve(getUriPath(src), false); 
     if (resSrc.isInternalDir()) {
       throw new AccessControlException(
-          "Cannot Rename within internal dirs of mount table: it is readOnly");
+          "Cannot Rename within internal dirs of mount table: it is readOnly"
+          + src);
     }
       
     InodeTree.ResolveResult<AbstractFileSystem> resDst = 
                                 fsState.resolve(getUriPath(dst), false);
     if (resDst.isInternalDir()) {
       throw new AccessControlException(
-          "Cannot Rename within internal dirs of mount table: it is readOnly");
+          "Cannot Rename within internal dirs of mount table: it is readOnly"
+          + dst);
     }