Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13197

Add non-decayed call metrics for DecayRpcScheduler

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.9.0, 3.0.0-alpha1
    • Component/s: ipc, metrics
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      DecayRpcScheduler currently exposes decayed call count over the time. It will be useful to expose the non-decayed raw count for monitoring applications.

      1. HADOOP-13197.00.patch
        15 kB
        Xiaoyu Yao
      2. HADOOP-13197.01.patch
        15 kB
        Xiaoyu Yao
      3. HADOOP-13197.02.patch
        16 kB
        Xiaoyu Yao

        Activity

        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Update fix versions based on git log.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Update fix versions based on git log.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9882 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9882/)
        HADOOP-13197. Add non-decayed call metrics for DecayRpcScheduler. (xyao: rev 4ca8859583839761663fc1fc1de1b3ce2e3fc5b5)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9882 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9882/ ) HADOOP-13197 . Add non-decayed call metrics for DecayRpcScheduler. (xyao: rev 4ca8859583839761663fc1fc1de1b3ce2e3fc5b5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Jitendra Nath Pandey for the review. I committed the patch to trunk, branch-2 and branch-2.8 based on the +1. The only delta from v02 is comment fix.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Jitendra Nath Pandey for the review. I committed the patch to trunk, branch-2 and branch-2.8 based on the +1. The only delta from v02 is comment fix.
        Hide
        jnp Jitendra Nath Pandey added a comment -

        Minor nit: The comment still has Top.0 prefix.

        // Key: Top.0.Caller(xyz).Volume and Top.0.Caller(xyz).Priority
        private void addTopNCallerSummary(MetricsRecordBuilder rb) 
        

        +1 for the latest patch. The patch is ok to commit with the above minor fix.

        Show
        jnp Jitendra Nath Pandey added a comment - Minor nit: The comment still has Top.0 prefix. // Key: Top.0.Caller(xyz).Volume and Top.0.Caller(xyz).Priority private void addTopNCallerSummary(MetricsRecordBuilder rb) +1 for the latest patch. The patch is ok to commit with the above minor fix.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 42s trunk passed
        +1 compile 7m 1s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 21s trunk passed
        +1 javadoc 0m 56s trunk passed
        +1 mvninstall 0m 48s the patch passed
        +1 compile 6m 42s the patch passed
        +1 javac 6m 42s the patch passed
        +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 38 unchanged - 3 fixed = 38 total (was 41)
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 34s the patch passed
        +1 javadoc 0m 55s the patch passed
        -1 unit 7m 59s hadoop-common in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        38m 5s



        Reason Tests
        Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806723/HADOOP-13197.02.patch
        JIRA Issue HADOOP-13197
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d8d807af2ac2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5ea6fd8
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9608/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9608/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9608/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9608/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 42s trunk passed +1 compile 7m 1s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 21s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 6m 42s the patch passed +1 javac 6m 42s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 38 unchanged - 3 fixed = 38 total (was 41) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 34s the patch passed +1 javadoc 0m 55s the patch passed -1 unit 7m 59s hadoop-common in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 38m 5s Reason Tests Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806723/HADOOP-13197.02.patch JIRA Issue HADOOP-13197 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d8d807af2ac2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5ea6fd8 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9608/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9608/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9608/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9608/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Jitendra Nath Pandey for the review. Attach a patch that removes the prefix as suggested. The public API getTotalCallVolume() is kept as-is to maintain backward compatibility.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Jitendra Nath Pandey for the review. Attach a patch that removes the prefix as suggested. The public API getTotalCallVolume() is kept as-is to maintain backward compatibility.
        Hide
        jnp Jitendra Nath Pandey added a comment -

        One more minor comment. I think we can get rid of the TopN prefix from the metric name, because decayedCallerVolume lets us figure anyway which are the top users. The metrics would be easier to consume without that prefix.

        Show
        jnp Jitendra Nath Pandey added a comment - One more minor comment. I think we can get rid of the TopN prefix from the metric name, because decayedCallerVolume lets us figure anyway which are the top users. The metrics would be easier to consume without that prefix.
        Hide
        jnp Jitendra Nath Pandey added a comment - - edited
         public long getTotalCallVolume() 

        I think we should rename the method as well to getTotalDecayedCallVolume.

        Otherwise, looks good to me. +1

        Show
        jnp Jitendra Nath Pandey added a comment - - edited public long getTotalCallVolume() I think we should rename the method as well to getTotalDecayedCallVolume. Otherwise, looks good to me. +1
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 17s trunk passed
        +1 compile 6m 27s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 20s trunk passed
        +1 javadoc 0m 54s trunk passed
        +1 mvninstall 0m 39s the patch passed
        +1 compile 6m 26s the patch passed
        +1 javac 6m 26s the patch passed
        +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 38 unchanged - 3 fixed = 38 total (was 41)
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 30s the patch passed
        +1 javadoc 0m 56s the patch passed
        +1 unit 7m 52s hadoop-common in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        36m 33s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806063/HADOOP-13197.01.patch
        JIRA Issue HADOOP-13197
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 39f8885effd6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 28bd63e
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9578/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9578/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 17s trunk passed +1 compile 6m 27s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 20s trunk passed +1 javadoc 0m 54s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 6m 26s the patch passed +1 javac 6m 26s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 38 unchanged - 3 fixed = 38 total (was 41) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 30s the patch passed +1 javadoc 0m 56s the patch passed +1 unit 7m 52s hadoop-common in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 36m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806063/HADOOP-13197.01.patch JIRA Issue HADOOP-13197 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 39f8885effd6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 28bd63e Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9578/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9578/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xyao Xiaoyu Yao added a comment -

        Attach patch v01 to address the check style issues.

        Show
        xyao Xiaoyu Yao added a comment - Attach patch v01 to address the check style issues.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 35s trunk passed
        +1 compile 7m 47s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 31s trunk passed
        +1 javadoc 0m 59s trunk passed
        +1 mvninstall 0m 47s the patch passed
        +1 compile 7m 17s the patch passed
        +1 javac 7m 17s the patch passed
        -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 2 new + 38 unchanged - 3 fixed = 40 total (was 41)
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 23s the patch passed
        +1 javadoc 0m 54s the patch passed
        +1 unit 6m 57s hadoop-common in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        39m 32s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806025/HADOOP-13197.00.patch
        JIRA Issue HADOOP-13197
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a5f886c2198d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / edd716e
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9573/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9573/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9573/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 35s trunk passed +1 compile 7m 47s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 31s trunk passed +1 javadoc 0m 59s trunk passed +1 mvninstall 0m 47s the patch passed +1 compile 7m 17s the patch passed +1 javac 7m 17s the patch passed -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 2 new + 38 unchanged - 3 fixed = 40 total (was 41) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 23s the patch passed +1 javadoc 0m 54s the patch passed +1 unit 6m 57s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 39m 32s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806025/HADOOP-13197.00.patch JIRA Issue HADOOP-13197 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a5f886c2198d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / edd716e Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9573/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9573/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9573/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xyao Xiaoyu Yao added a comment -

        Attach a patch that collects non-decayed call metrics for DecayRpcScheduler.

        Show
        xyao Xiaoyu Yao added a comment - Attach a patch that collects non-decayed call metrics for DecayRpcScheduler.

          People

          • Assignee:
            xyao Xiaoyu Yao
            Reporter:
            xyao Xiaoyu Yao
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development