Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13189

FairCallQueue makes callQueue larger than the configured capacity.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.6.5
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      FairCallQueue divides callQueue into multiple (4 by default) sub-queues, with each sub-queue corresponding to a different level of priority. The constructor for FairCallQueue takes the same parameter capacity as the default CallQueue implementation, and allocates all its sub-queues of size capacity. With 4 levels of priority (sub-queues) by default it results in the total callQueue size 4 times larger than it should be based on the configuration.
      capacity should be divided by the number of sub-queues at some place.

      1. HADOOP-13189.001.patch
        3 kB
        Vinitha Reddy Gankidi
      2. HADOOP-13189.002.patch
        6 kB
        Vinitha Reddy Gankidi
      3. HADOOP-13189.003.patch
        6 kB
        Vinitha Reddy Gankidi
      4. HADOOP-13189.003-branch-2.7.patch
        5 kB
        Konstantin Shvachko

        Issue Links

          Activity

          Hide
          shv Konstantin Shvachko added a comment -

          FairCallQueue was introduced by HADOOP-10282.

          Show
          shv Konstantin Shvachko added a comment - FairCallQueue was introduced by HADOOP-10282 .
          Hide
          shv Konstantin Shvachko added a comment -

          This is actually in IPC code base, so moved under Hadoop Common.

          Show
          shv Konstantin Shvachko added a comment - This is actually in IPC code base, so moved under Hadoop Common.
          Hide
          redvine Vinitha Reddy Gankidi added a comment -

          Attached a patch. Please review.

          Show
          redvine Vinitha Reddy Gankidi added a comment - Attached a patch. Please review.
          Hide
          shv Konstantin Shvachko added a comment -

          Submitting to Jenkins.
          Patch looks good. Two minor improvements:

          1. Could you add logging of queue size in CallQueueManager, so that we could see the size in the logs for any implementation of call queue.
          2. In TestFairCallQueue we can remove all junit.Assert imports, as they are unused.
          Show
          shv Konstantin Shvachko added a comment - Submitting to Jenkins. Patch looks good. Two minor improvements: Could you add logging of queue size in CallQueueManager , so that we could see the size in the logs for any implementation of call queue. In TestFairCallQueue we can remove all junit.Assert imports, as they are unused.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 docker 0m 5s Docker failed to build yetus/hadoop:2c91fd8.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808426/HADOOP-13189.001.patch
          JIRA Issue HADOOP-13189
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9672/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 0m 5s Docker failed to build yetus/hadoop:2c91fd8. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808426/HADOOP-13189.001.patch JIRA Issue HADOOP-13189 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9672/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          cc some folks who may be interested in FairCallQueue as FYI Chris Li, Ming Ma, Xiaoyu Yao.

          Show
          arpitagarwal Arpit Agarwal added a comment - cc some folks who may be interested in FairCallQueue as FYI Chris Li , Ming Ma , Xiaoyu Yao .
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks for the heads up Arpit Agarwal. The code change looks good. I'm not sure whether the unit test change is needed as the 2nd parameter of the FairCallQueue constructor is already based on per queue capacity. I would suggest we test with mock (e.g., mockito) to validate internal subqueue capacity allocation given different ipc.server.handler.queue.size.

          -    fcq = new FairCallQueue<Schedulable>(2, 5, "ns", conf);
          +    fcq = new FairCallQueue<Schedulable>(2, 10, "ns", conf);
          
          Show
          xyao Xiaoyu Yao added a comment - Thanks for the heads up Arpit Agarwal . The code change looks good. I'm not sure whether the unit test change is needed as the 2nd parameter of the FairCallQueue constructor is already based on per queue capacity. I would suggest we test with mock (e.g., mockito) to validate internal subqueue capacity allocation given different ipc.server.handler.queue.size . - fcq = new FairCallQueue<Schedulable>(2, 5, "ns" , conf); + fcq = new FairCallQueue<Schedulable>(2, 10, "ns" , conf);
          Hide
          redvine Vinitha Reddy Gankidi added a comment -

          Xiaoyu Yao Thanks for the review. The 2nd parameter of the FairCallQueue constructor is the per queue capacity in the current implementation. However, this patch makes it the total capacity of all subqueues. So, this change is needed.
          It would be better to keep the capacity allocation to the subqueues flexible. Instead of validating the internal subqueue capacity allocation, I will add a test that validates that the total capacity of all subqueues equals the maxQueueSize.

          Show
          redvine Vinitha Reddy Gankidi added a comment - Xiaoyu Yao Thanks for the review. The 2nd parameter of the FairCallQueue constructor is the per queue capacity in the current implementation. However, this patch makes it the total capacity of all subqueues. So, this change is needed. It would be better to keep the capacity allocation to the subqueues flexible. Instead of validating the internal subqueue capacity allocation, I will add a test that validates that the total capacity of all subqueues equals the maxQueueSize.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 35s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 1s trunk passed
          +1 compile 8m 38s trunk passed
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 45s trunk passed
          +1 javadoc 1m 2s trunk passed
          +1 mvninstall 0m 44s the patch passed
          +1 compile 8m 33s the patch passed
          +1 javac 8m 33s the patch passed
          -1 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 1 new + 65 unchanged - 1 fixed = 66 total (was 66)
          +1 mvnsite 1m 2s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 1m 9s the patch passed
          -1 unit 9m 5s hadoop-common in the patch failed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          46m 1s



          Reason Tests
          Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.net.TestDNS



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808854/HADOOP-13189.002.patch
          JIRA Issue HADOOP-13189
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 23759cb9f6f5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 76f0800
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9687/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9687/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9687/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9687/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 35s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 1s trunk passed +1 compile 8m 38s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 1m 2s trunk passed +1 mvninstall 0m 44s the patch passed +1 compile 8m 33s the patch passed +1 javac 8m 33s the patch passed -1 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 1 new + 65 unchanged - 1 fixed = 66 total (was 66) +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 1m 9s the patch passed -1 unit 9m 5s hadoop-common in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 46m 1s Reason Tests Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808854/HADOOP-13189.002.patch JIRA Issue HADOOP-13189 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 23759cb9f6f5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 76f0800 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9687/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9687/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9687/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9687/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          shv Konstantin Shvachko added a comment -

          Looks like you need to split the comment line in TestFairCallQueue.java into two as per checkstyle warning.
          Test failures do not seem to be related to the patch.

          Show
          shv Konstantin Shvachko added a comment - Looks like you need to split the comment line in TestFairCallQueue.java into two as per checkstyle warning. Test failures do not seem to be related to the patch.
          Hide
          redvine Vinitha Reddy Gankidi added a comment -

          Added another patch (003) that resolves the checkstyle warning.

          Show
          redvine Vinitha Reddy Gankidi added a comment - Added another patch (003) that resolves the checkstyle warning.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 docker 0m 5s Docker failed to build yetus/hadoop:2c91fd8.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809031/HADOOP-13189.003.patch
          JIRA Issue HADOOP-13189
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9694/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 0m 5s Docker failed to build yetus/hadoop:2c91fd8. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809031/HADOOP-13189.003.patch JIRA Issue HADOOP-13189 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9694/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          shv Konstantin Shvachko added a comment -

          +1 on the patch.
          I restarted jenkins build for this patch. Will commit once it is finished.

          Show
          shv Konstantin Shvachko added a comment - +1 on the patch. I restarted jenkins build for this patch. Will commit once it is finished.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 28s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 31s trunk passed
          +1 compile 9m 21s trunk passed
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 11s trunk passed
          +1 mvneclipse 0m 21s trunk passed
          +1 findbugs 1m 51s trunk passed
          +1 javadoc 1m 5s trunk passed
          +1 mvninstall 0m 54s the patch passed
          +1 compile 9m 9s the patch passed
          +1 javac 9m 9s the patch passed
          +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 65 unchanged - 1 fixed = 65 total (was 66)
          +1 mvnsite 1m 12s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 findbugs 1m 46s the patch passed
          +1 javadoc 1m 1s the patch passed
          -1 unit 8m 55s hadoop-common in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          48m 2s



          Reason Tests
          Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809031/HADOOP-13189.003.patch
          JIRA Issue HADOOP-13189
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 95aa22aee728 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1500a0a
          Default Java 1.8.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9700/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9700/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9700/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 28s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 31s trunk passed +1 compile 9m 21s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 21s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 1m 5s trunk passed +1 mvninstall 0m 54s the patch passed +1 compile 9m 9s the patch passed +1 javac 9m 9s the patch passed +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 65 unchanged - 1 fixed = 65 total (was 66) +1 mvnsite 1m 12s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 1m 1s the patch passed -1 unit 8m 55s hadoop-common in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 48m 2s Reason Tests Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809031/HADOOP-13189.003.patch JIRA Issue HADOOP-13189 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 95aa22aee728 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1500a0a Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9700/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9700/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9700/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          mingma Ming Ma added a comment -

          Thanks Konstantin Shvachko, Vinitha Reddy Gankidi. That seems reasonable. Although in actual setup, we haven't run into any issue or we have accounted for the factor. Another thing, if RPC backoff is enabled and all users fall under highest priority queue, equal divide means smaller capacity for the highest priority queue and thus got backoff sooner than the configured queue size.

          Show
          mingma Ming Ma added a comment - Thanks Konstantin Shvachko , Vinitha Reddy Gankidi . That seems reasonable. Although in actual setup, we haven't run into any issue or we have accounted for the factor. Another thing, if RPC backoff is enabled and all users fall under highest priority queue, equal divide means smaller capacity for the highest priority queue and thus got backoff sooner than the configured queue size.
          Hide
          shv Konstantin Shvachko added a comment -

          Hey Ming Ma good to hear from you. I should have given a bit more context in the description. Doing it now.
          So we are trying to solve two inter-related issues here:

          1. Inconsistency between the config value of ipc.server.handler.queue.size, which is defined as "How many calls per handler are allowed in the queue.", and the actual queue size when FairCallQueue is used, which lets 4 times more.
          2. A need to reconfigure the cluster when switching from one CallQueue implementation to another.

          The latter is important to prevent NN meltdown. Before we learned about this issue we saw too many clients connecting to the NameNode and making it unresponsive. This is related to read requests like listStatus and getFileInfo. And it worked fine with the default queue, but not with FairCallQueue. Looking deeper it was noticed that NN allowed more requests with FairCallQueue than with the default. We had to reconfigure NN and adjust the queue size, but now we have problem 1. Hope this makes sense.

          With your example when all requests go only into the high priority queue one should probably switch to the default queue as FairCallQueue functionality is not utilized.

          Show
          shv Konstantin Shvachko added a comment - Hey Ming Ma good to hear from you. I should have given a bit more context in the description. Doing it now. So we are trying to solve two inter-related issues here: Inconsistency between the config value of ipc.server.handler.queue.size , which is defined as "How many calls per handler are allowed in the queue." , and the actual queue size when FairCallQueue is used, which lets 4 times more. A need to reconfigure the cluster when switching from one CallQueue implementation to another. The latter is important to prevent NN meltdown. Before we learned about this issue we saw too many clients connecting to the NameNode and making it unresponsive. This is related to read requests like listStatus and getFileInfo . And it worked fine with the default queue, but not with FairCallQueue. Looking deeper it was noticed that NN allowed more requests with FairCallQueue than with the default. We had to reconfigure NN and adjust the queue size, but now we have problem 1. Hope this makes sense. With your example when all requests go only into the high priority queue one should probably switch to the default queue as FairCallQueue functionality is not utilized.
          Hide
          mingma Ming Ma added a comment -

          Thanks Konstantin. Did you use https://issues.apache.org/jira/browse/HADOOP-10285 to change call CallQueue?

          when all requests go only into the high priority queue one should probably switch to the default queue as FairCallQueue functionality is not utilized.

          This only happens at a given point of time, with FairCallQueue is useful in other times on the same NN.

          Show
          mingma Ming Ma added a comment - Thanks Konstantin. Did you use https://issues.apache.org/jira/browse/HADOOP-10285 to change call CallQueue? when all requests go only into the high priority queue one should probably switch to the default queue as FairCallQueue functionality is not utilized. This only happens at a given point of time, with FairCallQueue is useful in other times on the same NN.
          Hide
          shv Konstantin Shvachko added a comment -

          We did not use refreshCallQueue. Just configured FairCallQueue via callqueue.impl

          Show
          shv Konstantin Shvachko added a comment - We did not use refreshCallQueue. Just configured FairCallQueue via callqueue.impl
          Hide
          shv Konstantin Shvachko added a comment -

          Ming Ma do you suggest anything or should I commit it?

          Show
          shv Konstantin Shvachko added a comment - Ming Ma do you suggest anything or should I commit it?
          Hide
          mingma Ming Ma added a comment -

          Konstantin Shvachko, the reason I asked is refreshCallQueue should switch to the new call queue right away while draining existing calls. Just to confirm, this patch does change the meaning of call queue size for FairCallQueue(it was meant for sub queue, but now it is for the aggregated size). It really depends on how you interpret it, it could be a backward compatibility issue, or just bug fix. What is your take?

          Show
          mingma Ming Ma added a comment - Konstantin Shvachko , the reason I asked is refreshCallQueue should switch to the new call queue right away while draining existing calls. Just to confirm, this patch does change the meaning of call queue size for FairCallQueue(it was meant for sub queue, but now it is for the aggregated size). It really depends on how you interpret it, it could be a backward compatibility issue, or just bug fix. What is your take?
          Hide
          shv Konstantin Shvachko added a comment -

          I think it is a bug fix. Current meaning of call queue size for FairCallQueue contradicts documentation.
          The refreshCallQueue is a good example. You had a standard queue of size 1000. Then you switch to FairCallQueue using refreshCallQueue command, and suddenly increase the queue size to 4000. I don't think this is expected. It is definitely not documented.

          Show
          shv Konstantin Shvachko added a comment - I think it is a bug fix. Current meaning of call queue size for FairCallQueue contradicts documentation. The refreshCallQueue is a good example. You had a standard queue of size 1000. Then you switch to FairCallQueue using refreshCallQueue command, and suddenly increase the queue size to 4000. I don't think this is expected. It is definitely not documented.
          Hide
          shv Konstantin Shvachko added a comment -

          What do you think?

          Show
          shv Konstantin Shvachko added a comment - What do you think?
          Hide
          mingma Ming Ma added a comment -

          Sounds good. Konstantin Shvachko please go ahead and thank you.

          Show
          mingma Ming Ma added a comment - Sounds good. Konstantin Shvachko please go ahead and thank you.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9974 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9974/)
          HADOOP-13189. FairCallQueue makes callQueue larger than the configured (shv: rev a2a5cb60b09491cb672978ba9442f02373392c67)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallQueueManager.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestFairCallQueue.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestCallQueueManager.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/FairCallQueue.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9974 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9974/ ) HADOOP-13189 . FairCallQueue makes callQueue larger than the configured (shv: rev a2a5cb60b09491cb672978ba9442f02373392c67) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallQueueManager.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestFairCallQueue.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestCallQueueManager.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/FairCallQueue.java
          Hide
          shv Konstantin Shvachko added a comment -

          This is a version of the patch for branch-2.7 and 2.6.
          A removed testTotalCapacityOfSubQueues() because the priorityLevels parameter for FairCallQueue() is not available.

          Show
          shv Konstantin Shvachko added a comment - This is a version of the patch for branch-2.7 and 2.6. A removed testTotalCapacityOfSubQueues() because the priorityLevels parameter for FairCallQueue() is not available.
          Hide
          shv Konstantin Shvachko added a comment -

          I just committed this to trunk and branches 2 through 2.6. Thank you Vinitha Reddy Gankidi.

          Show
          shv Konstantin Shvachko added a comment - I just committed this to trunk and branches 2 through 2.6. Thank you Vinitha Reddy Gankidi .

            People

            • Assignee:
              redvine Vinitha Reddy Gankidi
              Reporter:
              shv Konstantin Shvachko
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development