Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13160

Suppress checkstyle JavadocPackage check for test source

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Suppress "Missing package-info.java" checkstyle error for test source files.

      1. HADOOP-13160.001.patch
        2 kB
        John Zhuge
      2. HADOOP-13160.002.patch
        2 kB
        John Zhuge
      3. HADOOP-13160.003.patch
        2 kB
        John Zhuge

        Activity

        Hide
        jzhuge John Zhuge added a comment -

        Patch 001:

        • Add checkstyle suppression filter XML
        • Suppress JavadocPackage check for test source files
        Show
        jzhuge John Zhuge added a comment - Patch 001: Add checkstyle suppression filter XML Suppress JavadocPackage check for test source files
        Hide
        jzhuge John Zhuge added a comment -

        Run the following script to find out the number of all test files in all Hadoop components with "Missing package-info" checkstyle error:

        find * -name 'checkstyle-errors.xml' | xargs cat | grep '^<file\|Missing pack' | grep -B1 'Missing pack' | grep -c 'src/test'
        

        Before the patch, the count was 394; after the patch, it should be 0.

        Show
        jzhuge John Zhuge added a comment - Run the following script to find out the number of all test files in all Hadoop components with "Missing package-info" checkstyle error: find * -name 'checkstyle-errors.xml' | xargs cat | grep '^<file\|Missing pack' | grep -B1 'Missing pack' | grep -c 'src/test' Before the patch, the count was 394; after the patch, it should be 0.
        Hide
        jzhuge John Zhuge added a comment -

        Tested the patch on Mac and Ubuntu. Not tested on Windows, could someone with Windows Hadoop env do a quick test? Thanks.

        Show
        jzhuge John Zhuge added a comment - Tested the patch on Mac and Ubuntu. Not tested on Windows, could someone with Windows Hadoop env do a quick test? Thanks.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 31s trunk passed
        +1 compile 7m 36s trunk passed with JDK v1.8.0_91
        +1 compile 7m 41s trunk passed with JDK v1.7.0_95
        +1 mvnsite 10m 38s trunk passed
        +1 mvneclipse 0m 58s trunk passed
        +1 javadoc 6m 50s trunk passed with JDK v1.8.0_91
        +1 javadoc 10m 36s trunk passed with JDK v1.7.0_95
        +1 mvninstall 7m 37s the patch passed
        +1 compile 7m 45s the patch passed with JDK v1.8.0_91
        +1 javac 7m 45s the patch passed
        +1 compile 8m 9s the patch passed with JDK v1.7.0_95
        +1 javac 8m 9s the patch passed
        +1 mvnsite 10m 2s the patch passed
        +1 mvneclipse 0m 40s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 javadoc 5m 32s the patch passed with JDK v1.8.0_91
        +1 javadoc 9m 34s the patch passed with JDK v1.7.0_95
        -1 unit 24m 36s root in the patch failed with JDK v1.8.0_91.
        -1 unit 125m 12s root in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 30s The patch generated 1 ASF License warnings.
        252m 57s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestEditLog
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.TestAsyncDFSRename
          hadoop.yarn.server.applicationhistoryservice.TestFileSystemApplicationHistoryStore



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804260/HADOOP-13160.001.patch
        JIRA Issue HADOOP-13160
        Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit
        uname Linux f2e8b2dc3d8f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1217c8f
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/artifact/patchprocess/patch-unit-root-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/artifact/patchprocess/patch-unit-root-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/artifact/patchprocess/patch-unit-root-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/artifact/patchprocess/patch-unit-root-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: . U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 31s trunk passed +1 compile 7m 36s trunk passed with JDK v1.8.0_91 +1 compile 7m 41s trunk passed with JDK v1.7.0_95 +1 mvnsite 10m 38s trunk passed +1 mvneclipse 0m 58s trunk passed +1 javadoc 6m 50s trunk passed with JDK v1.8.0_91 +1 javadoc 10m 36s trunk passed with JDK v1.7.0_95 +1 mvninstall 7m 37s the patch passed +1 compile 7m 45s the patch passed with JDK v1.8.0_91 +1 javac 7m 45s the patch passed +1 compile 8m 9s the patch passed with JDK v1.7.0_95 +1 javac 8m 9s the patch passed +1 mvnsite 10m 2s the patch passed +1 mvneclipse 0m 40s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 2s The patch has no ill-formed XML file. +1 javadoc 5m 32s the patch passed with JDK v1.8.0_91 +1 javadoc 9m 34s the patch passed with JDK v1.7.0_95 -1 unit 24m 36s root in the patch failed with JDK v1.8.0_91. -1 unit 125m 12s root in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 30s The patch generated 1 ASF License warnings. 252m 57s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestEditLog   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestAsyncDFSRename   hadoop.yarn.server.applicationhistoryservice.TestFileSystemApplicationHistoryStore Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804260/HADOOP-13160.001.patch JIRA Issue HADOOP-13160 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit uname Linux f2e8b2dc3d8f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1217c8f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/artifact/patchprocess/patch-unit-root-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/artifact/patchprocess/patch-unit-root-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/artifact/patchprocess/patch-unit-root-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/artifact/patchprocess/patch-unit-root-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/artifact/patchprocess/patch-asflicense-problems.txt modules C: . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9446/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        can you put the checkstyle file into dev-support?

        Show
        stevel@apache.org Steve Loughran added a comment - can you put the checkstyle file into dev-support?
        Hide
        boky01 Andras Bokor added a comment - - edited

        John Zhuge,

        It does not work on Windows. Since it is a regex I suggest using the following:

         <suppress checks="JavadocPackage" files="[\\/]src[\\/]test[\\/].*"/>

        Another thing. I would use DTD version 1.1 instead of 1.0.
        There is no affect for this particular issue but id property can help if we need to write more complicated suppressions.

        Show
        boky01 Andras Bokor added a comment - - edited John Zhuge , It does not work on Windows. Since it is a regex I suggest using the following: <suppress checks= "JavadocPackage" files= "[\\/]src[\\/]test[\\/].*" /> Another thing. I would use DTD version 1.1 instead of 1.0. There is no affect for this particular issue but id property can help if we need to write more complicated suppressions.
        Hide
        jzhuge John Zhuge added a comment -

        Patch 002:

        • Move checkstyle suppressions xml to dev-support/checkstyle directory
        • Bump checkstyle suppressions xml to DTD 1.1
        • Fix whitespace issues

        Tested it on Mac and Ubuntu.

        Thanks Steve Loughran and Andras Bokor for comments.

        Show
        jzhuge John Zhuge added a comment - Patch 002: Move checkstyle suppressions xml to dev-support/checkstyle directory Bump checkstyle suppressions xml to DTD 1.1 Fix whitespace issues Tested it on Mac and Ubuntu. Thanks Steve Loughran and Andras Bokor for comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 docker 2m 51s Docker failed to build yetus/hadoop:2c91fd8.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804457/HADOOP-13160.002.patch
        JIRA Issue HADOOP-13160
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9467/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 2m 51s Docker failed to build yetus/hadoop:2c91fd8. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804457/HADOOP-13160.002.patch JIRA Issue HADOOP-13160 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9467/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 18s trunk passed
        +1 compile 6m 12s trunk passed
        +1 mvnsite 8m 14s trunk passed
        +1 mvneclipse 1m 20s trunk passed
        +1 javadoc 5m 22s trunk passed
        +1 mvninstall 5m 58s the patch passed
        +1 compile 6m 11s the patch passed
        +1 javac 6m 11s the patch passed
        +1 mvnsite 7m 58s the patch passed
        +1 mvneclipse 0m 34s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 javadoc 5m 25s the patch passed
        -1 unit 36m 29s root in the patch failed.
        -1 asflicense 0m 20s The patch generated 1 ASF License warnings.
        91m 16s



        Reason Tests
        Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804457/HADOOP-13160.002.patch
        JIRA Issue HADOOP-13160
        Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit
        uname Linux e33fa7e2d248 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 34fddd1
        Default Java 1.8.0_91
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9468/artifact/patchprocess/patch-unit-root.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9468/artifact/patchprocess/patch-unit-root.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9468/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/9468/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: . U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9468/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 18s trunk passed +1 compile 6m 12s trunk passed +1 mvnsite 8m 14s trunk passed +1 mvneclipse 1m 20s trunk passed +1 javadoc 5m 22s trunk passed +1 mvninstall 5m 58s the patch passed +1 compile 6m 11s the patch passed +1 javac 6m 11s the patch passed +1 mvnsite 7m 58s the patch passed +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 javadoc 5m 25s the patch passed -1 unit 36m 29s root in the patch failed. -1 asflicense 0m 20s The patch generated 1 ASF License warnings. 91m 16s Reason Tests Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804457/HADOOP-13160.002.patch JIRA Issue HADOOP-13160 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit uname Linux e33fa7e2d248 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 34fddd1 Default Java 1.8.0_91 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9468/artifact/patchprocess/patch-unit-root.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9468/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9468/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/9468/artifact/patchprocess/patch-asflicense-problems.txt modules C: . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9468/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        Patch 003:

        • Fix asflicense error
        Show
        jzhuge John Zhuge added a comment - Patch 003: Fix asflicense error
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 5s trunk passed
        +1 compile 7m 4s trunk passed
        +1 mvnsite 9m 10s trunk passed
        +1 mvneclipse 0m 34s trunk passed
        +1 javadoc 5m 30s trunk passed
        +1 mvninstall 6m 19s the patch passed
        +1 compile 6m 39s the patch passed
        +1 javac 6m 39s the patch passed
        +1 mvnsite 8m 29s the patch passed
        +1 mvneclipse 0m 34s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 3s The patch has no ill-formed XML file.
        +1 javadoc 5m 37s the patch passed
        -1 unit 106m 30s root in the patch failed.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        164m 52s



        Reason Tests
        Failed junit tests hadoop.yarn.server.applicationhistoryservice.TestFileSystemApplicationHistoryStore
          hadoop.yarn.server.nodemanager.containermanager.monitor.TestContainerMetrics



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804502/HADOOP-13160.003.patch
        JIRA Issue HADOOP-13160
        Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit
        uname Linux 16372e5b5784 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / fa3bc34
        Default Java 1.8.0_91
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9470/artifact/patchprocess/patch-unit-root.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9470/artifact/patchprocess/patch-unit-root.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9470/testReport/
        modules C: . U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9470/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 5s trunk passed +1 compile 7m 4s trunk passed +1 mvnsite 9m 10s trunk passed +1 mvneclipse 0m 34s trunk passed +1 javadoc 5m 30s trunk passed +1 mvninstall 6m 19s the patch passed +1 compile 6m 39s the patch passed +1 javac 6m 39s the patch passed +1 mvnsite 8m 29s the patch passed +1 mvneclipse 0m 34s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 javadoc 5m 37s the patch passed -1 unit 106m 30s root in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 164m 52s Reason Tests Failed junit tests hadoop.yarn.server.applicationhistoryservice.TestFileSystemApplicationHistoryStore   hadoop.yarn.server.nodemanager.containermanager.monitor.TestContainerMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804502/HADOOP-13160.003.patch JIRA Issue HADOOP-13160 Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit uname Linux 16372e5b5784 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fa3bc34 Default Java 1.8.0_91 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9470/artifact/patchprocess/patch-unit-root.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9470/artifact/patchprocess/patch-unit-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9470/testReport/ modules C: . U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9470/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        LGTM. Has anyone tested this on windows?

        Show
        stevel@apache.org Steve Loughran added a comment - LGTM. Has anyone tested this on windows?
        Hide
        boky01 Andras Bokor added a comment -

        When I suggested

        <suppress checks="JavadocPackage" files="[\\/]src[\\/]test[\\/].*"/>

        I tested it on Windows. But let me do a try with the full HADOOP-13160.003.patch. I will get back to here.

        Show
        boky01 Andras Bokor added a comment - When I suggested <suppress checks= "JavadocPackage" files= "[\\/]src[\\/]test[\\/].*" /> I tested it on Windows. But let me do a try with the full HADOOP-13160.003.patch . I will get back to here.
        Hide
        boky01 Andras Bokor added a comment - - edited

        +1
        HADOOP-13160.003.patch works on Windows.

        src\\test.*missing package-

        pattern was found 394 times before the patch and 0 matches after the patch.

        Show
        boky01 Andras Bokor added a comment - - edited +1 HADOOP-13160.003.patch works on Windows. src\\test.*missing package - pattern was found 394 times before the patch and 0 matches after the patch.
        Hide
        boky01 Andras Bokor added a comment -

        +1
        HADOOP-13160.003.patch works on Windows.

        "src\\test.*missing package-"

        pattern was found 394 times before the patch and 0 matches after the patch.

        Show
        boky01 Andras Bokor added a comment - +1 HADOOP-13160.003.patch works on Windows. "src\\test.*missing package -" pattern was found 394 times before the patch and 0 matches after the patch.
        Hide
        jzhuge John Zhuge added a comment -

        Thanks Andras Bokor for the suggestion and testing on Windows.

        Show
        jzhuge John Zhuge added a comment - Thanks Andras Bokor for the suggestion and testing on Windows.
        Hide
        jzhuge John Zhuge added a comment -

        Steve Loughran Could you please commit?

        Show
        jzhuge John Zhuge added a comment - Steve Loughran Could you please commit?
        Hide
        stevel@apache.org Steve Loughran added a comment -

        +1, committed to branch-2 and trunk

        Show
        stevel@apache.org Steve Loughran added a comment - +1, committed to branch-2 and trunk
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9856 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9856/)
        HADOOP-13160. Suppress checkstyle JavadocPackage check for test source. (stevel: rev dcbb7009b6f94e655724f6a0320723e1279ebc79)

        • dev-support/checkstyle/suppressions.xml
        • pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9856 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9856/ ) HADOOP-13160 . Suppress checkstyle JavadocPackage check for test source. (stevel: rev dcbb7009b6f94e655724f6a0320723e1279ebc79) dev-support/checkstyle/suppressions.xml pom.xml
        Hide
        jzhuge John Zhuge added a comment -
        Show
        jzhuge John Zhuge added a comment - Thanks Steve Loughran !
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        I found this was missing from branch-2. So I just cherry picked the change to the branch.

        Show
        jojochuang Wei-Chiu Chuang added a comment - I found this was missing from branch-2. So I just cherry picked the change to the branch.

          People

          • Assignee:
            jzhuge John Zhuge
            Reporter:
            jzhuge John Zhuge
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development