Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13148

TestDistCpViewFs to include IOExceptions in test error reports

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: tools/distcp
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Minor test code style: all IOEs are caught and logged @ error, then test failed with a simple assert. This will lose all failure data from the XML test reports, hiding it in the logs.

      Better to not catch the IOEs, just rethrow, and let JUnit handle them.

        Activity

        Hide
        stevel@apache.org Steve Loughran added a comment -

        patch 001; trivial cleanup. Jenkins will appreciate this

        Show
        stevel@apache.org Steve Loughran added a comment - patch 001; trivial cleanup. Jenkins will appreciate this
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 59s trunk passed
        +1 compile 0m 16s trunk passed with JDK v1.8.0_91
        +1 compile 0m 16s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 20s trunk passed
        +1 mvneclipse 12m 32s trunk passed
        +1 findbugs 0m 30s trunk passed
        +1 javadoc 0m 12s trunk passed with JDK v1.8.0_91
        +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 18s the patch passed
        +1 compile 0m 12s the patch passed with JDK v1.8.0_91
        +1 javac 0m 12s the patch passed
        +1 compile 0m 15s the patch passed with JDK v1.7.0_95
        +1 javac 0m 15s the patch passed
        -1 checkstyle 0m 12s hadoop-tools/hadoop-distcp: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)
        +1 mvnsite 0m 19s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 38s the patch passed
        +1 javadoc 0m 10s the patch passed with JDK v1.8.0_91
        +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95
        +1 unit 8m 22s hadoop-distcp in the patch passed with JDK v1.8.0_91.
        +1 unit 7m 22s hadoop-distcp in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        41m 16s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804040/HADOOP-13148-001.patch
        JIRA Issue HADOOP-13148
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 30bb0edd1d31 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7be53b6
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9429/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-distcp.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9429/testReport/
        modules C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9429/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 59s trunk passed +1 compile 0m 16s trunk passed with JDK v1.8.0_91 +1 compile 0m 16s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 20s trunk passed +1 mvneclipse 12m 32s trunk passed +1 findbugs 0m 30s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 18s the patch passed +1 compile 0m 12s the patch passed with JDK v1.8.0_91 +1 javac 0m 12s the patch passed +1 compile 0m 15s the patch passed with JDK v1.7.0_95 +1 javac 0m 15s the patch passed -1 checkstyle 0m 12s hadoop-tools/hadoop-distcp: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19) +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 10s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95 +1 unit 8m 22s hadoop-distcp in the patch passed with JDK v1.8.0_91. +1 unit 7m 22s hadoop-distcp in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 41m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804040/HADOOP-13148-001.patch JIRA Issue HADOOP-13148 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 30bb0edd1d31 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7be53b6 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9429/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-distcp.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9429/testReport/ modules C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9429/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -

        +1 for the patch. I committed this to trunk, branch-2 and branch-2.8. The Checkstyle warning was an unused import, and I removed it before committing.

        Show
        cnauroth Chris Nauroth added a comment - +1 for the patch. I committed this to trunk, branch-2 and branch-2.8. The Checkstyle warning was an unused import, and I removed it before committing.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9767 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9767/)
        HADOOP-13148. TestDistCpViewFs to include IOExceptions in test error (cnauroth: rev b9685e85d59e69e5dd64802fa9025dad1b315be5)

        • hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpViewFs.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9767 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9767/ ) HADOOP-13148 . TestDistCpViewFs to include IOExceptions in test error (cnauroth: rev b9685e85d59e69e5dd64802fa9025dad1b315be5) hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpViewFs.java

          People

          • Assignee:
            stevel@apache.org Steve Loughran
            Reporter:
            stevel@apache.org Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.25h
              0.25h
              Remaining:
              Remaining Estimate - 0.25h
              0.25h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development