Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13137

TraceAdmin should support Kerberized cluster

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0, 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: tracing
    • Labels:
    • Environment:

      CDH5.5.1 cluster with Kerberos

    • Target Version/s:

      Description

      When I run hadoop trace command for a Kerberized NameNode, it failed with the following error:

      [hdfs@weichiu-encryption-1 root]$ hadoop trace -list -host weichiu-encryption-1.vpc.cloudera.com:802216/05/12 00:02:13 WARN ipc.Client: Exception encountered while connecting to the server : java.lang.IllegalArgumentException: Failed to specify server's Kerberos principal name
      16/05/12 00:02:13 WARN security.UserGroupInformation: PriviledgedActionException as:hdfs@VPC.CLOUDERA.COM (auth:KERBEROS) cause:java.io.IOException: java.lang.IllegalArgumentException: Failed to specify server's Kerberos principal name
      Exception in thread "main" java.io.IOException: Failed on local exception: java.io.IOException: java.lang.IllegalArgumentException: Failed to specify server's Kerberos principal name; Host Details : local host is: "weichiu-encryption-1.vpc.cloudera.com/172.26.8.185"; destination host is: "weichiu-encryption-1.vpc.cloudera.com":8022;
      at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:772)
      at org.apache.hadoop.ipc.Client.call(Client.java:1470)
      at org.apache.hadoop.ipc.Client.call(Client.java:1403)
      at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:230)
      at com.sun.proxy.$Proxy11.listSpanReceivers(Unknown Source)
      at org.apache.hadoop.tracing.TraceAdminProtocolTranslatorPB.listSpanReceivers(TraceAdminProtocolTranslatorPB.java:58)
      at org.apache.hadoop.tracing.TraceAdmin.listSpanReceivers(TraceAdmin.java:68)
      at org.apache.hadoop.tracing.TraceAdmin.run(TraceAdmin.java:177)
      at org.apache.hadoop.tracing.TraceAdmin.main(TraceAdmin.java:195)
      Caused by: java.io.IOException: java.lang.IllegalArgumentException: Failed to specify server's Kerberos principal name
      at org.apache.hadoop.ipc.Client$Connection$1.run(Client.java:682)
      at java.security.AccessController.doPrivileged(Native Method)
      at javax.security.auth.Subject.doAs(Subject.java:415)
      at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1671)
      at org.apache.hadoop.ipc.Client$Connection.handleSaslConnectionFailure(Client.java:645)
      at org.apache.hadoop.ipc.Client$Connection.setupIOstreams(Client.java:733)
      at org.apache.hadoop.ipc.Client$Connection.access$2800(Client.java:370)
      at org.apache.hadoop.ipc.Client.getConnection(Client.java:1519)
      at org.apache.hadoop.ipc.Client.call(Client.java:1442)
      ... 7 more
      Caused by: java.lang.IllegalArgumentException: Failed to specify server's Kerberos principal name
      at org.apache.hadoop.security.SaslRpcClient.getServerPrincipal(SaslRpcClient.java:322)
      at org.apache.hadoop.security.SaslRpcClient.createSaslClient(SaslRpcClient.java:231)
      at org.apache.hadoop.security.SaslRpcClient.selectSaslClient(SaslRpcClient.java:159)
      at org.apache.hadoop.security.SaslRpcClient.saslConnect(SaslRpcClient.java:396)
      at org.apache.hadoop.ipc.Client$Connection.setupSaslConnection(Client.java:555)
      at org.apache.hadoop.ipc.Client$Connection.access$1800(Client.java:370)
      at org.apache.hadoop.ipc.Client$Connection$2.run(Client.java:725)
      at org.apache.hadoop.ipc.Client$Connection$2.run(Client.java:721)
      at java.security.AccessController.doPrivileged(Native Method)
      at javax.security.auth.Subject.doAs(Subject.java:415)
      at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1671)
      at org.apache.hadoop.ipc.Client$Connection.setupIOstreams(Client.java:720)
      ... 10 more

      It is failing because TraceAdmin does not set up the property CommonConfigurationKeys.HADOOP_SECURITY_SERVICE_USER_NAME_KEY

      Fixing it may require some restructuring, as the NameNode principal dfs.namenode.kerberos.principal is a HDFS property, but TraceAdmin is in hadoop-common. Or, specify it with a new command -principal. Any suggestions? Thanks

      1. HADOOP-13137.001.patch
        2 kB
        Wei-Chiu Chuang
      2. HADOOP-13137.002.patch
        7 kB
        Wei-Chiu Chuang
      3. HADOOP-13137.003.patch
        7 kB
        Wei-Chiu Chuang
      4. HADOOP-13137.004.patch
        7 kB
        Wei-Chiu Chuang
      5. HADOOP-13137.005.patch
        7 kB
        Wei-Chiu Chuang

        Activity

        Hide
        stevel@apache.org Steve Loughran added a comment -

        if the command takes {{-D name=value }} assignments, you could to try to set the property that way and see if the problem goes away

        Show
        stevel@apache.org Steve Loughran added a comment - if the command takes {{-D name=value }} assignments, you could to try to set the property that way and see if the problem goes away
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hi Steve, Thanks for the suggestion, I've tried that but however that doesn't work. It's also interesting that {{-D }} is said to be a general option, but apparently quite a few Hadoop (as well as HDFS) commands do not take it.

        I am thinking to either add a -principle command option, or make TraceAdmin to support -D command option, and update the doc.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Hi Steve, Thanks for the suggestion, I've tried that but however that doesn't work. It's also interesting that {{-D }} is said to be a general option, but apparently quite a few Hadoop (as well as HDFS) commands do not take it. I am thinking to either add a -principle command option, or make TraceAdmin to support -D command option, and update the doc.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        A quick fix (no test, no doc). I ran this patch on a CDH5.5.1 Kerberized cluster, and it works if I supply the option -principal as follows:

        hadoop trace -list -host weichiu-encryption-1.vpc.cloudera.com:8022 -principal hdfs/weichiu-encryption-1.vpc.cloudera.com@VPC.CLOUDERA.COM

        Show
        jojochuang Wei-Chiu Chuang added a comment - A quick fix (no test, no doc). I ran this patch on a CDH5.5.1 Kerberized cluster, and it works if I supply the option -principal as follows: hadoop trace -list -host weichiu-encryption-1.vpc.cloudera.com:8022 -principal hdfs/weichiu-encryption-1.vpc.cloudera.com@VPC.CLOUDERA.COM
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        v02: added a test case to test hadoop trace command against a Kerberized cluster. In addition, updated Enabling Dapper-like Tracing in Hadoop doc for the usage.

        Show
        jojochuang Wei-Chiu Chuang added a comment - v02: added a test case to test hadoop trace command against a Kerberized cluster. In addition, updated Enabling Dapper-like Tracing in Hadoop doc for the usage.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Submit the patch for precommit test.
        Colin P. McCabe, Steve Loughran, would you mind to review the patch? Thank you very much!

        Show
        jojochuang Wei-Chiu Chuang added a comment - Submit the patch for precommit test. Colin P. McCabe , Steve Loughran , would you mind to review the patch? Thank you very much!
        Hide
        stevel@apache.org Steve Loughran added a comment -

        LGTM. Colin P. McCabe —thoughts?

        1. No need to wrap the LOG.debug() with a condition; SLF4J is low cost if is not invoked

        2. Could you replace the

        ``${dfs.namenode.kerberos.principal}`
        

        with a simple example like namenode/NN1@EXAMPLE. Why? avoid confusion to the reader about when $ expansion takes place: in shell versus in config.

        Show
        stevel@apache.org Steve Loughran added a comment - LGTM. Colin P. McCabe —thoughts? 1. No need to wrap the LOG.debug() with a condition; SLF4J is low cost if is not invoked 2. Could you replace the ``${dfs.namenode.kerberos.principal}` with a simple example like namenode/NN1@EXAMPLE . Why? avoid confusion to the reader about when $ expansion takes place: in shell versus in config.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 15s Maven dependency ordering for branch
        +1 mvninstall 6m 37s trunk passed
        +1 compile 7m 38s trunk passed
        +1 checkstyle 1m 24s trunk passed
        +1 mvnsite 2m 2s trunk passed
        +1 mvneclipse 0m 26s trunk passed
        +1 findbugs 3m 14s trunk passed
        +1 javadoc 2m 4s trunk passed
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 37s the patch passed
        +1 compile 7m 20s the patch passed
        -1 javac 7m 20s root generated 1 new + 697 unchanged - 0 fixed = 698 total (was 697)
        +1 checkstyle 1m 24s the patch passed
        +1 mvnsite 2m 1s the patch passed
        +1 mvneclipse 0m 27s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 37s the patch passed
        +1 javadoc 2m 8s the patch passed
        +1 unit 7m 53s hadoop-common in the patch passed.
        -1 unit 59m 29s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        111m 15s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestEditLog
          hadoop.hdfs.TestAsyncDFSRename



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804769/HADOOP-13137.002.patch
        JIRA Issue HADOOP-13137
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c6cb031975ad 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 141873c
        Default Java 1.8.0_91
        findbugs v3.0.0
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9514/artifact/patchprocess/diff-compile-javac-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9514/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9514/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9514/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9514/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 37s trunk passed +1 compile 7m 38s trunk passed +1 checkstyle 1m 24s trunk passed +1 mvnsite 2m 2s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 14s trunk passed +1 javadoc 2m 4s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 37s the patch passed +1 compile 7m 20s the patch passed -1 javac 7m 20s root generated 1 new + 697 unchanged - 0 fixed = 698 total (was 697) +1 checkstyle 1m 24s the patch passed +1 mvnsite 2m 1s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 37s the patch passed +1 javadoc 2m 8s the patch passed +1 unit 7m 53s hadoop-common in the patch passed. -1 unit 59m 29s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 111m 15s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.TestAsyncDFSRename Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804769/HADOOP-13137.002.patch JIRA Issue HADOOP-13137 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c6cb031975ad 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 141873c Default Java 1.8.0_91 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9514/artifact/patchprocess/diff-compile-javac-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9514/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9514/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9514/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9514/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        The patch looks good to me. I think there are a few other commands that might need to get an argument like this, if it's necessary when communicating directly with a kerberized Hadoop server. I do wonder why we need a new file, TestKerberizedTraceAdmin.java, when it could have been a test in TestTraceAdmin.java, but I don't feel that strongly about it. Thanks, Wei-Chiu Chuang and Steve Loughran.

        Show
        cmccabe Colin P. McCabe added a comment - The patch looks good to me. I think there are a few other commands that might need to get an argument like this, if it's necessary when communicating directly with a kerberized Hadoop server. I do wonder why we need a new file, TestKerberizedTraceAdmin.java, when it could have been a test in TestTraceAdmin.java, but I don't feel that strongly about it. Thanks, Wei-Chiu Chuang and Steve Loughran .
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        v03. Thanks Steve Loughran and Colin P. McCabe!

        No need to wrap the LOG.debug() with a condition; SLF4J is low cost if is not invoked

        done

        Could you replace the ``${dfs.namenode.kerberos.principal}`

        done

        I do wonder why we need a new file, TestKerberizedTraceAdmin.java, when it could have been a test in TestTraceAdmin.java

        I needed a subclass of SaslDataTransferTestCase to set up Kerberized mini cluster.
        I removed the new test file, and instead, let TestTraceAdmin to extend from SaslDataTransferTestCase.

        I think there are a few other commands that might need to get an argument like this

        I believe so. I'm working on a patch to support hadoop daemonlog in Kerberized cluster, and I suspect erasure coding commands and other new commands should also be fixed.

        Show
        jojochuang Wei-Chiu Chuang added a comment - v03. Thanks Steve Loughran and Colin P. McCabe ! No need to wrap the LOG.debug() with a condition; SLF4J is low cost if is not invoked done Could you replace the ``${dfs.namenode.kerberos.principal}` done I do wonder why we need a new file, TestKerberizedTraceAdmin.java, when it could have been a test in TestTraceAdmin.java I needed a subclass of SaslDataTransferTestCase to set up Kerberized mini cluster. I removed the new test file, and instead, let TestTraceAdmin to extend from SaslDataTransferTestCase . I think there are a few other commands that might need to get an argument like this I believe so. I'm working on a patch to support hadoop daemonlog in Kerberized cluster, and I suspect erasure coding commands and other new commands should also be fixed.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 31s Maven dependency ordering for branch
        +1 mvninstall 6m 14s trunk passed
        +1 compile 7m 57s trunk passed
        +1 checkstyle 1m 23s trunk passed
        +1 mvnsite 1m 58s trunk passed
        +1 mvneclipse 0m 26s trunk passed
        +1 findbugs 3m 41s trunk passed
        +1 javadoc 2m 17s trunk passed
        0 mvndep 0m 12s Maven dependency ordering for patch
        +1 mvninstall 1m 27s the patch passed
        +1 compile 6m 21s the patch passed
        -1 javac 6m 21s root generated 1 new + 698 unchanged - 0 fixed = 699 total (was 698)
        -1 checkstyle 1m 19s root: The patch generated 1 new + 11 unchanged - 2 fixed = 12 total (was 13)
        +1 mvnsite 1m 42s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 12s the patch passed
        +1 javadoc 2m 8s the patch passed
        +1 unit 8m 32s hadoop-common in the patch passed.
        +1 unit 60m 57s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        112m 9s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805663/HADOOP-13137.003.patch
        JIRA Issue HADOOP-13137
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0e3e77fe3b42 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ac95448
        Default Java 1.8.0_91
        findbugs v3.0.0
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9554/artifact/patchprocess/diff-compile-javac-root.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9554/artifact/patchprocess/diff-checkstyle-root.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9554/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9554/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 31s Maven dependency ordering for branch +1 mvninstall 6m 14s trunk passed +1 compile 7m 57s trunk passed +1 checkstyle 1m 23s trunk passed +1 mvnsite 1m 58s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 41s trunk passed +1 javadoc 2m 17s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 27s the patch passed +1 compile 6m 21s the patch passed -1 javac 6m 21s root generated 1 new + 698 unchanged - 0 fixed = 699 total (was 698) -1 checkstyle 1m 19s root: The patch generated 1 new + 11 unchanged - 2 fixed = 12 total (was 13) +1 mvnsite 1m 42s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 12s the patch passed +1 javadoc 2m 8s the patch passed +1 unit 8m 32s hadoop-common in the patch passed. +1 unit 60m 57s hadoop-hdfs in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 112m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805663/HADOOP-13137.003.patch JIRA Issue HADOOP-13137 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0e3e77fe3b42 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ac95448 Default Java 1.8.0_91 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9554/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9554/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9554/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9554/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        v04: fixed checkstyle and javac warnings.

        Show
        jojochuang Wei-Chiu Chuang added a comment - v04: fixed checkstyle and javac warnings.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 35s Maven dependency ordering for branch
        +1 mvninstall 9m 50s trunk passed
        +1 compile 10m 27s trunk passed
        +1 checkstyle 1m 41s trunk passed
        +1 mvnsite 2m 37s trunk passed
        +1 mvneclipse 0m 37s trunk passed
        +1 findbugs 4m 10s trunk passed
        +1 javadoc 2m 41s trunk passed
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 2m 10s the patch passed
        +1 compile 10m 29s the patch passed
        +1 javac 10m 29s the patch passed
        +1 checkstyle 1m 40s root: The patch generated 0 new + 13 unchanged - 2 fixed = 13 total (was 15)
        +1 mvnsite 2m 35s the patch passed
        +1 mvneclipse 0m 35s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 34s the patch passed
        +1 javadoc 2m 32s the patch passed
        +1 unit 10m 54s hadoop-common in the patch passed.
        -1 unit 69m 47s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        140m 3s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs
          hadoop.hdfs.server.datanode.TestDataNodeUUID
          hadoop.hdfs.TestAsyncDFSRename
          hadoop.hdfs.shortcircuit.TestShortCircuitCache



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806062/HADOOP-13137.004.patch
        JIRA Issue HADOOP-13137
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d327efa2f553 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 28bd63e
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9577/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9577/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9577/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9577/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 35s Maven dependency ordering for branch +1 mvninstall 9m 50s trunk passed +1 compile 10m 27s trunk passed +1 checkstyle 1m 41s trunk passed +1 mvnsite 2m 37s trunk passed +1 mvneclipse 0m 37s trunk passed +1 findbugs 4m 10s trunk passed +1 javadoc 2m 41s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 2m 10s the patch passed +1 compile 10m 29s the patch passed +1 javac 10m 29s the patch passed +1 checkstyle 1m 40s root: The patch generated 0 new + 13 unchanged - 2 fixed = 13 total (was 15) +1 mvnsite 2m 35s the patch passed +1 mvneclipse 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 34s the patch passed +1 javadoc 2m 32s the patch passed +1 unit 10m 54s hadoop-common in the patch passed. -1 unit 69m 47s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 140m 3s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs   hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.TestAsyncDFSRename   hadoop.hdfs.shortcircuit.TestShortCircuitCache Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806062/HADOOP-13137.004.patch JIRA Issue HADOOP-13137 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d327efa2f553 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 28bd63e Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9577/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9577/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9577/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9577/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        getting close. in assertEquals() the expected should come first, e.g. assertEquals(0, ret)

        Show
        stevel@apache.org Steve Loughran added a comment - getting close. in assertEquals() the expected should come first, e.g. assertEquals(0, ret)
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Thanks Steve Loughran, I've made a new patch based on your comment:
        v05.

        1. changed the argument order in assertEquals.
        2. removed final MiniDFSCluster clusterRef
        Show
        jojochuang Wei-Chiu Chuang added a comment - Thanks Steve Loughran , I've made a new patch based on your comment: v05. changed the argument order in assertEquals. removed final MiniDFSCluster clusterRef
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 1m 29s Maven dependency ordering for branch
        +1 mvninstall 6m 15s trunk passed
        +1 compile 6m 36s trunk passed
        +1 checkstyle 1m 24s trunk passed
        +1 mvnsite 1m 58s trunk passed
        +1 mvneclipse 0m 25s trunk passed
        +1 findbugs 3m 3s trunk passed
        +1 javadoc 2m 5s trunk passed
        0 mvndep 0m 13s Maven dependency ordering for patch
        +1 mvninstall 1m 55s the patch passed
        +1 compile 7m 53s the patch passed
        +1 javac 7m 53s the patch passed
        +1 checkstyle 1m 27s root: The patch generated 0 new + 11 unchanged - 2 fixed = 11 total (was 13)
        +1 mvnsite 2m 11s the patch passed
        +1 mvneclipse 0m 27s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 37s the patch passed
        +1 javadoc 2m 2s the patch passed
        -1 unit 7m 30s hadoop-common in the patch failed.
        -1 unit 73m 17s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        125m 23s



        Reason Tests
        Failed junit tests hadoop.net.TestDNS
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806225/HADOOP-13137.005.patch
        JIRA Issue HADOOP-13137
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3d560cad5db3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1ba31fe
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9584/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9584/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9584/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9584/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9584/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9584/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 29s Maven dependency ordering for branch +1 mvninstall 6m 15s trunk passed +1 compile 6m 36s trunk passed +1 checkstyle 1m 24s trunk passed +1 mvnsite 1m 58s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 3s trunk passed +1 javadoc 2m 5s trunk passed 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 55s the patch passed +1 compile 7m 53s the patch passed +1 javac 7m 53s the patch passed +1 checkstyle 1m 27s root: The patch generated 0 new + 11 unchanged - 2 fixed = 11 total (was 13) +1 mvnsite 2m 11s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 37s the patch passed +1 javadoc 2m 2s the patch passed -1 unit 7m 30s hadoop-common in the patch failed. -1 unit 73m 17s hadoop-hdfs in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 125m 23s Reason Tests Failed junit tests hadoop.net.TestDNS   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806225/HADOOP-13137.005.patch JIRA Issue HADOOP-13137 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3d560cad5db3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1ba31fe Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9584/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9584/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9584/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9584/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9584/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9584/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        The test failures look unrelated.

        Show
        jojochuang Wei-Chiu Chuang added a comment - The test failures look unrelated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        The test failures look unrelated.

        I agree-- I ran them locally, and they passed.

        Thanks, Wei-Chiu Chuang and Steve Loughran. +1.

        Show
        cmccabe Colin P. McCabe added a comment - The test failures look unrelated. I agree-- I ran them locally, and they passed. Thanks, Wei-Chiu Chuang and Steve Loughran . +1.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9891 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9891/)
        HADOOP-13137. TraceAdmin should support Kerberized cluster (Wei-Chiu (cmccabe: rev 8ceb06e2392763726210f96bb1c176e6a9fe7b53)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceAdmin.java
        • hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9891 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9891/ ) HADOOP-13137 . TraceAdmin should support Kerberized cluster (Wei-Chiu (cmccabe: rev 8ceb06e2392763726210f96bb1c176e6a9fe7b53) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTraceAdmin.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceAdmin.java hadoop-common-project/hadoop-common/src/site/markdown/Tracing.md

          People

          • Assignee:
            jojochuang Wei-Chiu Chuang
            Reporter:
            jojochuang Wei-Chiu Chuang
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development