Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13118

Fix IOUtils#cleanup and IOUtils#closeStream javadoc

    Details

      Description

      HADOOP-7256 ignored all {{Throwable}}s in IOUtils#cleanup but did not update its javadoc.

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 26s trunk passed
          +1 compile 6m 31s trunk passed with JDK v1.8.0_91
          +1 compile 6m 55s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 1m 0s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 1m 38s trunk passed
          +1 javadoc 1m 2s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 10s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 46s the patch passed
          +1 compile 6m 22s the patch passed with JDK v1.8.0_91
          +1 javac 6m 22s the patch passed
          +1 compile 6m 47s the patch passed with JDK v1.7.0_95
          +1 javac 6m 47s the patch passed
          +1 checkstyle 0m 23s the patch passed
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 55s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95
          +1 unit 7m 36s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 7m 42s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          62m 42s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802887/HADOOP-13118.001.patch
          JIRA Issue HADOOP-13118
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3aaeb22a6b24 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 411fb4b
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9337/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9337/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 26s trunk passed +1 compile 6m 31s trunk passed with JDK v1.8.0_91 +1 compile 6m 55s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 38s trunk passed +1 javadoc 1m 2s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 10s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 6m 22s the patch passed with JDK v1.8.0_91 +1 javac 6m 22s the patch passed +1 compile 6m 47s the patch passed with JDK v1.7.0_95 +1 javac 6m 47s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 55s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95 +1 unit 7m 36s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 7m 42s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 62m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802887/HADOOP-13118.001.patch JIRA Issue HADOOP-13118 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3aaeb22a6b24 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 411fb4b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9337/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9337/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1. Hi Wei-Chiu Chuang, before committing this patch, can we backport HADOOP-7256 to branch-2? I'll comment it in HADOOP-7256.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1. Hi Wei-Chiu Chuang , before committing this patch, can we backport HADOOP-7256 to branch-2? I'll comment it in HADOOP-7256 .
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks for the review, Akira Ajisaka.
          Harsh probably has a reason to only commit HADOOP-7256 into trunk. Given that HADOOP-7256 does not break the API, I feel it's okay to backport though.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks for the review, Akira Ajisaka . Harsh probably has a reason to only commit HADOOP-7256 into trunk. Given that HADOOP-7256 does not break the API, I feel it's okay to backport though.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Wei-Chiu Chuang. I backported HADOOP-7256 to branch-2, so I'll commit this to trunk/branch-2 shortly.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Wei-Chiu Chuang . I backported HADOOP-7256 to branch-2, so I'll commit this to trunk/branch-2 shortly.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed to trunk and branch-2. Thanks Wei-Chiu Chuang for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed to trunk and branch-2. Thanks Wei-Chiu Chuang for the contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9740 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9740/)
          HADOOP-13118. Fix IOUtils#cleanup and IOUtils#closeStream javadoc. (aajisaka: rev 0f0c6415af409d213e7a132390a850c1251b92ef)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9740 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9740/ ) HADOOP-13118 . Fix IOUtils#cleanup and IOUtils#closeStream javadoc. (aajisaka: rev 0f0c6415af409d213e7a132390a850c1251b92ef) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Akira Ajisaka for the quick review and commit!

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Akira Ajisaka for the quick review and commit!

            People

            • Assignee:
              jojochuang Wei-Chiu Chuang
              Reporter:
              jojochuang Wei-Chiu Chuang
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development