Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13116

Jets3tNativeS3FileSystemContractTest does not run.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Target Version/s:

      Description

      S3N includes a test suite named Jets3tNativeS3FileSystemContractTest. This test suite does not run during an mvn test run, because our Surefire configuration includes only test suite classes that start with "Test" in the name.

        Activity

        Hide
        cnauroth Chris Nauroth added a comment -

        I'm attaching patch v001, which renames Jets3tNativeS3FileSystemContractTest to TestJets3tNativeS3FileSystemContract. I have confirmed that this gets included now in a full mvn test run.

        It appears there is some trouble with running this test suite repeatedly. I sometimes see a failure in testListStatusForRoot. The test assumes the bucket is empty, but it doesn't explicitly delete the contents, and it looks like sometimes a prior test can leave data behind. Clearing the bucket manually resolves it. This patch might need more work to clear the bucket automatically before we call it final.

        Show
        cnauroth Chris Nauroth added a comment - I'm attaching patch v001, which renames Jets3tNativeS3FileSystemContractTest to TestJets3tNativeS3FileSystemContract . I have confirmed that this gets included now in a full mvn test run. It appears there is some trouble with running this test suite repeatedly. I sometimes see a failure in testListStatusForRoot . The test assumes the bucket is empty, but it doesn't explicitly delete the contents, and it looks like sometimes a prior test can leave data behind. Clearing the bucket manually resolves it. This patch might need more work to clear the bucket automatically before we call it final.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 49s trunk passed
        +1 compile 0m 11s trunk passed with JDK v1.8.0_91
        +1 compile 0m 14s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 19s trunk passed
        +1 mvneclipse 1m 1s trunk passed
        +1 findbugs 0m 31s trunk passed
        +1 javadoc 0m 12s trunk passed with JDK v1.8.0_91
        +1 javadoc 0m 15s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 14s the patch passed
        +1 compile 0m 11s the patch passed with JDK v1.8.0_91
        +1 javac 0m 11s the patch passed
        +1 compile 0m 11s the patch passed with JDK v1.7.0_95
        +1 javac 0m 11s the patch passed
        -1 checkstyle 0m 11s hadoop-tools/hadoop-aws: The patch generated 2 new + 1 unchanged - 1 fixed = 3 total (was 2)
        +1 mvnsite 0m 16s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 38s the patch passed
        +1 javadoc 0m 10s the patch passed with JDK v1.8.0_91
        +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95
        +1 unit 0m 11s hadoop-aws in the patch passed with JDK v1.8.0_91.
        +1 unit 0m 11s hadoop-aws in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        13m 49s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802847/HADOOP-13116.001.patch
        JIRA Issue HADOOP-13116
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c077f174cf17 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 47c41e7
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9327/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-aws.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9327/testReport/
        modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9327/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 49s trunk passed +1 compile 0m 11s trunk passed with JDK v1.8.0_91 +1 compile 0m 14s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 1m 1s trunk passed +1 findbugs 0m 31s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 14s the patch passed +1 compile 0m 11s the patch passed with JDK v1.8.0_91 +1 javac 0m 11s the patch passed +1 compile 0m 11s the patch passed with JDK v1.7.0_95 +1 javac 0m 11s the patch passed -1 checkstyle 0m 11s hadoop-tools/hadoop-aws: The patch generated 2 new + 1 unchanged - 1 fixed = 3 total (was 2) +1 mvnsite 0m 16s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 10s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95 +1 unit 0m 11s hadoop-aws in the patch passed with JDK v1.8.0_91. +1 unit 0m 11s hadoop-aws in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 13m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802847/HADOOP-13116.001.patch JIRA Issue HADOOP-13116 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c077f174cf17 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 47c41e7 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9327/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-aws.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9327/testReport/ modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9327/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        +1

        This must a relic of the time when the s3 tests were all in hadoop-common —the s3 tests couldn't be set up to run automatically, as the standard runs would lack the credentials. As the aws module tests only run when the credentials are present, so this situation does not arise.

        Show
        stevel@apache.org Steve Loughran added a comment - +1 This must a relic of the time when the s3 tests were all in hadoop-common —the s3 tests couldn't be set up to run automatically, as the standard runs would lack the credentials. As the aws module tests only run when the credentials are present, so this situation does not arise.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        committed, thanks

        Show
        stevel@apache.org Steve Loughran added a comment - committed, thanks
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9752 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9752/)
        HADOOP-13116 Jets3tNativeS3FileSystemContractTest does not run. (stevel: rev 3f2816ab5a3db5bfee1ee457c32e1d98c4b3d367)

        • hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3native/TestJets3tNativeS3FileSystemContract.java
        • hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3native/Jets3tNativeS3FileSystemContractTest.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9752 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9752/ ) HADOOP-13116 Jets3tNativeS3FileSystemContractTest does not run. (stevel: rev 3f2816ab5a3db5bfee1ee457c32e1d98c4b3d367) hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3native/TestJets3tNativeS3FileSystemContract.java hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3native/Jets3tNativeS3FileSystemContractTest.java

          People

          • Assignee:
            cnauroth Chris Nauroth
            Reporter:
            cnauroth Chris Nauroth
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development