Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13112

Change CredentialShell to use CommandShell base class

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      org.apache.hadoop.tools.CommandShell is a base class created for use by DtUtilShell. It was inspired by CredentialShell and much of it was taken verbatim. It should be a simple change to get CredentialShell to use the base class and simplify its code without changing its functionality.

      1. HADOOP-13112.06.patch
        30 kB
        Matthew Paduano
      2. HADOOP-13112.05.patch
        30 kB
        Matthew Paduano
      3. HADOOP-13112.04.patch
        30 kB
        Matthew Paduano
      4. HADOOP-13112.03.patch
        33 kB
        Matthew Paduano
      5. HADOOP-13112.02.patch
        14 kB
        Matthew Paduano
      6. HADOOP-13112.01.patch
        14 kB
        Matthew Paduano

        Issue Links

          Activity

          Hide
          mattpaduano Matthew Paduano added a comment -

          .../hadoop/security/alias/CredentialShell.java | 159 ++++++++-------------
          .../java/org/apache/hadoop/tools/CommandShell.java | 2 +-
          2 files changed, 63 insertions, 98 deletions

          -------------------------------------------------------
          T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.security.alias.TestCredShell
          Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.22 sec - in org.apache.hadoop.security.alias.TestCredShell

          Running org.apache.hadoop.security.token.TestDtUtilShell
          Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.014 sec - in org.apache.hadoop.security.token.TestDtUtilShell

          Running org.apache.hadoop.tools.TestCommandShell
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.122 sec - in org.apache.hadoop.tools.TestCommandShell

          Show
          mattpaduano Matthew Paduano added a comment - .../hadoop/security/alias/CredentialShell.java | 159 ++++++++------------- .../java/org/apache/hadoop/tools/CommandShell.java | 2 +- 2 files changed, 63 insertions , 98 deletions ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.security.alias.TestCredShell Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.22 sec - in org.apache.hadoop.security.alias.TestCredShell Running org.apache.hadoop.security.token.TestDtUtilShell Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.014 sec - in org.apache.hadoop.security.token.TestDtUtilShell Running org.apache.hadoop.tools.TestCommandShell Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.122 sec - in org.apache.hadoop.tools.TestCommandShell
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 57s trunk passed
          +1 compile 5m 52s trunk passed with JDK v1.8.0_91
          +1 compile 6m 44s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 35s trunk passed
          +1 javadoc 0m 55s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 4s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 41s the patch passed
          +1 compile 5m 56s the patch passed with JDK v1.8.0_91
          +1 javac 5m 56s the patch passed
          +1 compile 6m 46s the patch passed with JDK v1.7.0_95
          +1 javac 6m 46s the patch passed
          -1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 2 new + 16 unchanged - 11 fixed = 18 total (was 27)
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 47s the patch passed
          +1 javadoc 0m 56s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95
          +1 unit 8m 3s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 7m 52s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 25s The patch does not generate ASF License warnings.
          61m 10s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802769/HADOOP-13112.01.patch
          JIRA Issue HADOOP-13112
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ec5516f34d1c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6957e45
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9318/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9318/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9318/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 57s trunk passed +1 compile 5m 52s trunk passed with JDK v1.8.0_91 +1 compile 6m 44s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 35s trunk passed +1 javadoc 0m 55s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 4s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 5m 56s the patch passed with JDK v1.8.0_91 +1 javac 5m 56s the patch passed +1 compile 6m 46s the patch passed with JDK v1.7.0_95 +1 javac 6m 46s the patch passed -1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 2 new + 16 unchanged - 11 fixed = 18 total (was 27) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95 +1 unit 8m 3s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 7m 52s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 61m 10s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802769/HADOOP-13112.01.patch JIRA Issue HADOOP-13112 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ec5516f34d1c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6957e45 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9318/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9318/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9318/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          lmccay Larry McCay added a comment -

          Nice, Matthew Paduano.
          FYI - KeyShell is based on exactly the same pattern and should also be refactored as a subclass of CommandShell.
          Also, HADOOP-12942 is something that you should be aware of. It should be ready to commit early next week and these two patches may clash a little. I do think that the changes will be isolated to the provider frameworks and the individual commands but it is something to be aware of.

          Show
          lmccay Larry McCay added a comment - Nice, Matthew Paduano . FYI - KeyShell is based on exactly the same pattern and should also be refactored as a subclass of CommandShell. Also, HADOOP-12942 is something that you should be aware of. It should be ready to commit early next week and these two patches may clash a little. I do think that the changes will be isolated to the provider frameworks and the individual commands but it is something to be aware of.
          Hide
          mattpaduano Matthew Paduano added a comment -

          thanks for the heads up.

          HADOOP-12942 patch will conflict with this one in the
          run() method and the logic handling usage messaging...
          not sure how important that is. supposing the base
          class was already in place, would HADOOP-12942 still
          try to modify those methods?

          KeyShell does indeed look like a candidate to save some
          code and consolidate the base class. I will add it to this patch.

          Show
          mattpaduano Matthew Paduano added a comment - thanks for the heads up. HADOOP-12942 patch will conflict with this one in the run() method and the logic handling usage messaging... not sure how important that is. supposing the base class was already in place, would HADOOP-12942 still try to modify those methods? KeyShell does indeed look like a candidate to save some code and consolidate the base class. I will add it to this patch.
          Hide
          mattpaduano Matthew Paduano added a comment -

          this patch addresses check style warnings.

          there are no unit tests b/c there is no new functionality
          and existing tests pass and validate the functionality.

          Show
          mattpaduano Matthew Paduano added a comment - this patch addresses check style warnings. there are no unit tests b/c there is no new functionality and existing tests pass and validate the functionality.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 47s trunk passed
          +1 compile 5m 42s trunk passed with JDK v1.8.0_91
          +1 compile 6m 36s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 1m 0s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 34s trunk passed
          +1 javadoc 0m 54s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 43s the patch passed
          +1 compile 6m 37s the patch passed with JDK v1.8.0_91
          +1 javac 6m 37s the patch passed
          +1 compile 7m 1s the patch passed with JDK v1.7.0_95
          +1 javac 7m 1s the patch passed
          +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 16 unchanged - 11 fixed = 16 total (was 27)
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 46s the patch passed
          +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95
          +1 unit 7m 44s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 8m 1s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          61m 25s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802906/HADOOP-13112.02.patch
          JIRA Issue HADOOP-13112
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ad3824950c96 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 411fb4b
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9333/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9333/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 47s trunk passed +1 compile 5m 42s trunk passed with JDK v1.8.0_91 +1 compile 6m 36s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 25s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 54s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 43s the patch passed +1 compile 6m 37s the patch passed with JDK v1.8.0_91 +1 javac 6m 37s the patch passed +1 compile 7m 1s the patch passed with JDK v1.7.0_95 +1 javac 7m 1s the patch passed +1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 0 new + 16 unchanged - 11 fixed = 16 total (was 27) +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95 +1 unit 7m 44s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 8m 1s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 61m 25s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802906/HADOOP-13112.02.patch JIRA Issue HADOOP-13112 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ad3824950c96 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 411fb4b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9333/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9333/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          lmccay Larry McCay added a comment -

          There are some conflicts between these two inflight patches. Mike Yoder - please take a look at this refactoring as well.

          Show
          lmccay Larry McCay added a comment - There are some conflicts between these two inflight patches. Mike Yoder - please take a look at this refactoring as well.
          Hide
          yoderme Mike Yoder added a comment -

          Thanks for the heads up. So which one of us gets to go first?

          Show
          yoderme Mike Yoder added a comment - Thanks for the heads up. So which one of us gets to go first?
          Hide
          mattpaduano Matthew Paduano added a comment -

          do you agree that the only conflicts with the current merge
          are in run() and printCredShellUsage/printShellUsage?

          I might suggest you do what dtutil did. it has a command, "help".
          there is not an object for it. help is dispatched straight from init().
          it does the same thing as a parse error. it dumps the usage strings
          from all the subcommand objects (implemented via an abstract method).
          don't change run(). don't use the printUsage method to signal run().

          what do you think? will that work? I can implement the code if you
          want to commit first and let me handle the merge. that's the approach
          I would take, unless you suggest something different.

          Show
          mattpaduano Matthew Paduano added a comment - do you agree that the only conflicts with the current merge are in run() and printCredShellUsage/printShellUsage? I might suggest you do what dtutil did. it has a command, "help". there is not an object for it. help is dispatched straight from init(). it does the same thing as a parse error. it dumps the usage strings from all the subcommand objects (implemented via an abstract method). don't change run(). don't use the printUsage method to signal run(). what do you think? will that work? I can implement the code if you want to commit first and let me handle the merge. that's the approach I would take, unless you suggest something different.
          Hide
          yoderme Mike Yoder added a comment -

          Your analysis and suggestion seem completely reasonable. Either one of us can do it, it just depends on who makes it in first.

          Show
          yoderme Mike Yoder added a comment - Your analysis and suggestion seem completely reasonable. Either one of us can do it, it just depends on who makes it in first.
          Hide
          mattpaduano Matthew Paduano added a comment -

          great. then we are in a race while I add support for KeyShell.

          Show
          mattpaduano Matthew Paduano added a comment - great. then we are in a race while I add support for KeyShell.
          Hide
          mattpaduano Matthew Paduano added a comment -

          for patch #03
          .../org/apache/hadoop/crypto/key/KeyShell.java | 230 ++++++++-------------
          .../hadoop/security/alias/CredentialShell.java | 155 +++++---------
          .../java/org/apache/hadoop/tools/CommandShell.java | 4 +-
          3 files changed, 144 insertions, 245 deletions
          -------------------------------------------------------
          T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.crypto.key.TestKeyShell
          Tests run: 9, Failures: 0, Errors: 0, Skipped: 0
          Time elapsed: 1.308 sec
          Running org.apache.hadoop.security.alias.TestCredShell
          Tests run: 9, Failures: 0, Errors: 0, Skipped: 0
          Time elapsed: 0.841 sec
          Running org.apache.hadoop.security.token.TestDtUtilShell
          Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
          Time elapsed: 1.012 sec
          Running org.apache.hadoop.tools.TestCommandShell
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
          Time elapsed: 0.128 sec
          Results: Tests run: 27, Failures: 0, Errors: 0, Skipped: 0

          Show
          mattpaduano Matthew Paduano added a comment - for patch #03 .../org/apache/hadoop/crypto/key/KeyShell.java | 230 ++++++++------------- .../hadoop/security/alias/CredentialShell.java | 155 +++++--------- .../java/org/apache/hadoop/tools/CommandShell.java | 4 +- 3 files changed, 144 insertions , 245 deletions ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.crypto.key.TestKeyShell Tests run: 9, Failures: 0, Errors: 0, Skipped: 0 Time elapsed: 1.308 sec Running org.apache.hadoop.security.alias.TestCredShell Tests run: 9, Failures: 0, Errors: 0, Skipped: 0 Time elapsed: 0.841 sec Running org.apache.hadoop.security.token.TestDtUtilShell Tests run: 8, Failures: 0, Errors: 0, Skipped: 0 Time elapsed: 1.012 sec Running org.apache.hadoop.tools.TestCommandShell Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 Time elapsed: 0.128 sec Results: Tests run: 27, Failures: 0, Errors: 0, Skipped: 0
          Hide
          mattpaduano Matthew Paduano added a comment -

          Patch 04 addresses the merge issue from HADOOP-12942

          for patch #04:
           .../org/apache/hadoop/crypto/key/KeyShell.java     |  180 +++++++-------------
           .../hadoop/security/alias/CredentialShell.java     |  176 ++++++++------------
           .../java/org/apache/hadoop/tools/CommandShell.java |    4 
           3 files changed, 136 insertions(+), 224 deletions(-)
          -------------------------------------------------------
          T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.crypto.key.TestKeyShell
           Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
          Running org.apache.hadoop.security.alias.TestCredShell
           Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
          Running org.apache.hadoop.security.token.TestDtUtilShell
           Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
          Running org.apache.hadoop.tools.TestCommandShell
           Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
          Results: Tests run: 31, Failures: 0, Errors: 0, Skipped: 0
          
          Show
          mattpaduano Matthew Paduano added a comment - Patch 04 addresses the merge issue from HADOOP-12942 for patch #04: .../org/apache/hadoop/crypto/key/KeyShell.java | 180 +++++++------------- .../hadoop/security/alias/CredentialShell.java | 176 ++++++++------------ .../java/org/apache/hadoop/tools/CommandShell.java | 4 3 files changed, 136 insertions(+), 224 deletions(-) ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.crypto.key.TestKeyShell Tests run: 10, Failures: 0, Errors: 0, Skipped: 0 Running org.apache.hadoop.security.alias.TestCredShell Tests run: 12, Failures: 0, Errors: 0, Skipped: 0 Running org.apache.hadoop.security.token.TestDtUtilShell Tests run: 8, Failures: 0, Errors: 0, Skipped: 0 Running org.apache.hadoop.tools.TestCommandShell Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 Results: Tests run: 31, Failures: 0, Errors: 0, Skipped: 0
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          -1 mvninstall 0m 8s root in trunk failed.
          +1 compile 7m 19s trunk passed with JDK v1.8.0_91
          -1 compile 0m 10s root in trunk failed with JDK v1.7.0_101.
          +1 checkstyle 0m 26s trunk passed
          -1 mvnsite 0m 17s hadoop-common in trunk failed.
          +1 mvneclipse 0m 14s trunk passed
          -1 findbugs 0m 11s hadoop-common in trunk failed.
          +1 javadoc 0m 55s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 10s trunk passed with JDK v1.7.0_101
          -1 mvninstall 0m 13s hadoop-common in the patch failed.
          +1 compile 7m 40s the patch passed with JDK v1.8.0_91
          +1 javac 7m 40s the patch passed
          -1 compile 0m 10s root in the patch failed with JDK v1.7.0_101.
          -1 javac 0m 11s root in the patch failed with JDK v1.7.0_101.
          +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
          -1 mvnsite 0m 14s hadoop-common in the patch failed.
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 12s hadoop-common in the patch failed.
          +1 javadoc 1m 0s the patch passed with JDK v1.8.0_91
          -1 javadoc 0m 14s hadoop-common in the patch failed with JDK v1.7.0_101.
          -1 unit 7m 32s hadoop-common in the patch failed with JDK v1.8.0_91.
          -1 unit 0m 12s hadoop-common in the patch failed with JDK v1.7.0_101.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          30m 27s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.security.ssl.TestReloadingX509TrustManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804285/HADOOP-13112.04.patch
          JIRA Issue HADOOP-13112
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e9d3be1a0d76 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4b55642
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/branch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/branch-compile-root-jdk1.7.0_101.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-compile-root-jdk1.7.0_101.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-compile-root-jdk1.7.0_101.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 mvninstall 0m 8s root in trunk failed. +1 compile 7m 19s trunk passed with JDK v1.8.0_91 -1 compile 0m 10s root in trunk failed with JDK v1.7.0_101. +1 checkstyle 0m 26s trunk passed -1 mvnsite 0m 17s hadoop-common in trunk failed. +1 mvneclipse 0m 14s trunk passed -1 findbugs 0m 11s hadoop-common in trunk failed. +1 javadoc 0m 55s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 10s trunk passed with JDK v1.7.0_101 -1 mvninstall 0m 13s hadoop-common in the patch failed. +1 compile 7m 40s the patch passed with JDK v1.8.0_91 +1 javac 7m 40s the patch passed -1 compile 0m 10s root in the patch failed with JDK v1.7.0_101. -1 javac 0m 11s root in the patch failed with JDK v1.7.0_101. +1 checkstyle 0m 25s hadoop-common-project/hadoop-common: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) -1 mvnsite 0m 14s hadoop-common in the patch failed. +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 12s hadoop-common in the patch failed. +1 javadoc 1m 0s the patch passed with JDK v1.8.0_91 -1 javadoc 0m 14s hadoop-common in the patch failed with JDK v1.7.0_101. -1 unit 7m 32s hadoop-common in the patch failed with JDK v1.8.0_91. -1 unit 0m 12s hadoop-common in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 30m 27s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804285/HADOOP-13112.04.patch JIRA Issue HADOOP-13112 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e9d3be1a0d76 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4b55642 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/branch-compile-root-jdk1.7.0_101.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-compile-root-jdk1.7.0_101.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-compile-root-jdk1.7.0_101.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9448/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          I'm not seeing anything obviously wrong here, but the patch does need to be rebased.

          Show
          aw Allen Wittenauer added a comment - I'm not seeing anything obviously wrong here, but the patch does need to be rebased.
          Hide
          mattpaduano Matthew Paduano added a comment -

          for patch #05

          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.crypto.key.TestKeyShell
          Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.604 sec - in org.apache.hadoop.crypto.key.TestKeyShell
          Running org.apache.hadoop.security.alias.TestCredShell
          Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.793 sec - in org.apache.hadoop.security.alias.TestCredShell
          Running org.apache.hadoop.security.token.TestDtUtilShell
          Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.992 sec - in org.apache.hadoop.security.token.TestDtUtilShell
          Running org.apache.hadoop.tools.TestCommandShell
          Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.112 sec - in org.apache.hadoop.tools.TestCommandShell
          
          Show
          mattpaduano Matthew Paduano added a comment - for patch #05 ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.crypto.key.TestKeyShell Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.604 sec - in org.apache.hadoop.crypto.key.TestKeyShell Running org.apache.hadoop.security.alias.TestCredShell Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.793 sec - in org.apache.hadoop.security.alias.TestCredShell Running org.apache.hadoop.security.token.TestDtUtilShell Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.992 sec - in org.apache.hadoop.security.token.TestDtUtilShell Running org.apache.hadoop.tools.TestCommandShell Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.112 sec - in org.apache.hadoop.tools.TestCommandShell
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 35s trunk passed
          +1 compile 6m 38s trunk passed
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 0m 58s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 23s trunk passed
          +1 javadoc 0m 54s trunk passed
          +1 mvninstall 0m 40s the patch passed
          +1 compile 6m 28s the patch passed
          +1 javac 6m 28s the patch passed
          +1 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 32s hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          +1 javadoc 0m 53s the patch passed
          +1 unit 7m 54s hadoop-common in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          37m 11s



          Reason Tests
          FindBugs module:hadoop-common-project/hadoop-common
            Nullcheck of CredentialShell$CreateCommand.alias at line 335 of value previously dereferenced in org.apache.hadoop.security.alias.CredentialShell$CreateCommand.validate() At CredentialShell.java:335 of value previously dereferenced in org.apache.hadoop.security.alias.CredentialShell$CreateCommand.validate() At CredentialShell.java:[line 317]
            Nullcheck of CredentialShell$DeleteCommand.alias at line 247 of value previously dereferenced in org.apache.hadoop.security.alias.CredentialShell$DeleteCommand.validate() At CredentialShell.java:247 of value previously dereferenced in org.apache.hadoop.security.alias.CredentialShell$DeleteCommand.validate() At CredentialShell.java:[line 240]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805015/HADOOP-13112.05.patch
          JIRA Issue HADOOP-13112
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 61bbddf07161 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 141873c
          Default Java 1.8.0_91
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9526/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9526/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9526/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 35s trunk passed +1 compile 6m 38s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 23s trunk passed +1 javadoc 0m 54s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 6m 28s the patch passed +1 javac 6m 28s the patch passed +1 checkstyle 0m 22s hadoop-common-project/hadoop-common: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 32s hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 0m 53s the patch passed +1 unit 7m 54s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 37m 11s Reason Tests FindBugs module:hadoop-common-project/hadoop-common   Nullcheck of CredentialShell$CreateCommand.alias at line 335 of value previously dereferenced in org.apache.hadoop.security.alias.CredentialShell$CreateCommand.validate() At CredentialShell.java:335 of value previously dereferenced in org.apache.hadoop.security.alias.CredentialShell$CreateCommand.validate() At CredentialShell.java: [line 317]   Nullcheck of CredentialShell$DeleteCommand.alias at line 247 of value previously dereferenced in org.apache.hadoop.security.alias.CredentialShell$DeleteCommand.validate() At CredentialShell.java:247 of value previously dereferenced in org.apache.hadoop.security.alias.CredentialShell$DeleteCommand.validate() At CredentialShell.java: [line 240] Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805015/HADOOP-13112.05.patch JIRA Issue HADOOP-13112 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 61bbddf07161 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 141873c Default Java 1.8.0_91 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9526/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9526/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9526/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          mattpaduano Matthew Paduano added a comment -

          patch #06 addresses findbugs.

          for patch #06

          -------------------------------------------------------
          T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.crypto.key.TestKeyShell
           Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
          Running org.apache.hadoop.security.alias.TestCredShell
           Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
          Running org.apache.hadoop.security.token.TestDtUtilShell
           Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
          Running org.apache.hadoop.tools.TestCommandShell
           Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
          
          Show
          mattpaduano Matthew Paduano added a comment - patch #06 addresses findbugs. for patch #06 ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.crypto.key.TestKeyShell Tests run: 10, Failures: 0, Errors: 0, Skipped: 0 Running org.apache.hadoop.security.alias.TestCredShell Tests run: 12, Failures: 0, Errors: 0, Skipped: 0 Running org.apache.hadoop.security.token.TestDtUtilShell Tests run: 8, Failures: 0, Errors: 0, Skipped: 0 Running org.apache.hadoop.tools.TestCommandShell Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 22s trunk passed
          +1 compile 7m 43s trunk passed
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 32s trunk passed
          +1 javadoc 0m 56s trunk passed
          +1 mvninstall 0m 40s the patch passed
          +1 compile 7m 27s the patch passed
          +1 javac 7m 27s the patch passed
          +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4)
          +1 mvnsite 0m 51s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 32s the patch passed
          +1 javadoc 0m 58s the patch passed
          +1 unit 7m 47s hadoop-common in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          40m 13s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805685/HADOOP-13112.06.patch
          JIRA Issue HADOOP-13112
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3b15d93d1662 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ac95448
          Default Java 1.8.0_91
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9558/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9558/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 22s trunk passed +1 compile 7m 43s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 32s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 7m 27s the patch passed +1 javac 7m 27s the patch passed +1 checkstyle 0m 23s hadoop-common-project/hadoop-common: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 32s the patch passed +1 javadoc 0m 58s the patch passed +1 unit 7m 47s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 40m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805685/HADOOP-13112.06.patch JIRA Issue HADOOP-13112 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3b15d93d1662 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ac95448 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9558/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9558/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          +1 committed to trunk

          Thanks!

          Show
          aw Allen Wittenauer added a comment - +1 committed to trunk Thanks!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9843 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9843/)
          HADOOP-13112. Change CredentialShell to use CommandShell base class (aw: rev eebb39a56fe504672b79ea04c6040e360496b6d7)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyShell.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/CommandShell.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialShell.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9843 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9843/ ) HADOOP-13112 . Change CredentialShell to use CommandShell base class (aw: rev eebb39a56fe504672b79ea04c6040e360496b6d7) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyShell.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/CommandShell.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialShell.java

            People

            • Assignee:
              mattpaduano Matthew Paduano
              Reporter:
              mattpaduano Matthew Paduano
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development