Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13109

Add ability to edit existing token file via dtutil -alias flag

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None

      Description

      The first iteration of the dtutil command (org.apache.hadoop.security.token.DtUtilShell) did not provide an operation to edit the service field on a token that has already been fetched to a file. This is a necessary feature for users who have copied a token file out of a cluster that does not support the dtutil command (hence, the token could not be aliased during get).

      1. HADOOP-13109.01.patch
        7 kB
        Matthew Paduano
      2. HADOOP-13109.02.patch
        7 kB
        Matthew Paduano

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9909 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9909/)
        HADOOP-13109. Add ability to edit existing token file via dtutil -alias (aw: rev 78b3a038319cb351632250279f171b756c7f24b0)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/DtUtilShell.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/TestDtUtilShell.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/DtFileOperations.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9909 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9909/ ) HADOOP-13109 . Add ability to edit existing token file via dtutil -alias (aw: rev 78b3a038319cb351632250279f171b756c7f24b0) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/DtUtilShell.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/TestDtUtilShell.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/DtFileOperations.java
        Hide
        aw Allen Wittenauer added a comment -

        Hindsight 20/20, but I'm sort of regretting how the term 'alias' was used in dtutil. Oh well.

        +1. Thanks!

        I'll commit this trunk here in a bit.

        Show
        aw Allen Wittenauer added a comment - Hindsight 20/20, but I'm sort of regretting how the term 'alias' was used in dtutil. Oh well. +1. Thanks! I'll commit this trunk here in a bit.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 37s trunk passed
        +1 compile 6m 19s trunk passed with JDK v1.8.0_91
        +1 compile 6m 46s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 36s trunk passed
        +1 javadoc 0m 53s trunk passed with JDK v1.8.0_91
        +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 42s the patch passed
        +1 compile 5m 58s the patch passed with JDK v1.8.0_91
        +1 javac 5m 58s the patch passed
        +1 compile 6m 53s the patch passed with JDK v1.7.0_95
        +1 javac 6m 53s the patch passed
        +1 checkstyle 0m 20s the patch passed
        +1 mvnsite 0m 57s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 59s the patch passed
        +1 javadoc 0m 57s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 9s the patch passed with JDK v1.7.0_95
        +1 unit 8m 23s hadoop-common in the patch passed with JDK v1.8.0_91.
        +1 unit 13m 29s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 25s The patch does not generate ASF License warnings.
        68m 38s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802727/HADOOP-13109.02.patch
        JIRA Issue HADOOP-13109
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ea215d3658a6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2835f14
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9312/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9312/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 37s trunk passed +1 compile 6m 19s trunk passed with JDK v1.8.0_91 +1 compile 6m 46s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 36s trunk passed +1 javadoc 0m 53s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 42s the patch passed +1 compile 5m 58s the patch passed with JDK v1.8.0_91 +1 javac 5m 58s the patch passed +1 compile 6m 53s the patch passed with JDK v1.7.0_95 +1 javac 6m 53s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 59s the patch passed +1 javadoc 0m 57s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 9s the patch passed with JDK v1.7.0_95 +1 unit 8m 23s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 13m 29s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 68m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802727/HADOOP-13109.02.patch JIRA Issue HADOOP-13109 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ea215d3658a6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2835f14 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9312/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9312/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        mattpaduano Matthew Paduano added a comment -

        patch requires whitespace diff to apply...

        Show
        mattpaduano Matthew Paduano added a comment - patch requires whitespace diff to apply...
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 5s HADOOP-13109 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802714/HADOOP-13109.01.patch
        JIRA Issue HADOOP-13109
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9310/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HADOOP-13109 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802714/HADOOP-13109.01.patch JIRA Issue HADOOP-13109 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9310/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        mattpaduano Matthew Paduano added a comment -

        this patch adds new feature and unit test

        Show
        mattpaduano Matthew Paduano added a comment - this patch adds new feature and unit test

          People

          • Assignee:
            mattpaduano Matthew Paduano
            Reporter:
            mattpaduano Matthew Paduano
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development