Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13105

Support timeouts in LDAP queries in LdapGroupsMapping.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      This patch adds two new config keys for supporting timeouts in LDAP query operations. The property "hadoop.security.group.mapping.ldap.connection.timeout.ms" is the connection timeout (in milliseconds), within which period if the LDAP provider doesn't establish a connection, it will abort the connect attempt. The property "hadoop.security.group.mapping.ldap.read.timeout.ms" is the read timeout (in milliseconds), within which period if the LDAP provider doesn't get a LDAP response, it will abort the read attempt.
      Show
      This patch adds two new config keys for supporting timeouts in LDAP query operations. The property "hadoop.security.group.mapping.ldap.connection.timeout.ms" is the connection timeout (in milliseconds), within which period if the LDAP provider doesn't establish a connection, it will abort the connect attempt. The property "hadoop.security.group.mapping.ldap.read.timeout.ms" is the read timeout (in milliseconds), within which period if the LDAP provider doesn't get a LDAP response, it will abort the read attempt.

      Description

      LdapGroupsMapping currently does not set timeouts on the LDAP queries. This can create a risk of a very long/infinite wait on a connection.

      1. HADOOP-13105.000.patch
        4 kB
        Mingliang Liu
      2. HADOOP-13105.001.patch
        10 kB
        Mingliang Liu
      3. HADOOP-13105.002.patch
        9 kB
        Mingliang Liu
      4. HADOOP-13105.003.patch
        10 kB
        Mingliang Liu
      5. HADOOP-13105.004.patch
        10 kB
        Mingliang Liu

        Activity

        Hide
        cnauroth Chris Nauroth added a comment -

        This document discusses the JNDI API calls that can be used to set timeouts. I think we'd want the actual timeout values to be configurable.

        https://docs.oracle.com/javase/tutorial/jndi/newstuff/readtimeout.html

        Show
        cnauroth Chris Nauroth added a comment - This document discusses the JNDI API calls that can be used to set timeouts. I think we'd want the actual timeout values to be configurable. https://docs.oracle.com/javase/tutorial/jndi/newstuff/readtimeout.html
        Hide
        liuml07 Mingliang Liu added a comment -

        Hi Chris Nauroth, thanks for reporting this.

        1. In the LdapGroupsMapping, we are also missing the com.sun.jndi.ldap.connect.timeout property for the env. I suppose this is orthogonal to the read timeouts. Should we address this as well?
        2. I had a look at the JNDI API documentation you kindly posted. I'm not sure I understand it correctly or the documentation is stale, but I was not able to reproduce the timed out exception using the ReadTimeoutTest.java. If we only set the com.sun.jndi.ldap.read.timeout env, the new InitialDirContext(env) will be stuck at connection phase and the read (query) operation will never be really issued. The test is running forever. However, if I set the com.sun.jndi.ldap.connect.timeout, the LDAP response read timed out naming exception will be thrown as expected.
        3. That's said, to test the com.sun.jndi.ldap.read.timeout feature is not as easy as to test the connect timeout. I'm wondering if the mock/spy will really help us here.

        See the v0 patch attached. I can make the property values configurable.

        Show
        liuml07 Mingliang Liu added a comment - Hi Chris Nauroth , thanks for reporting this. In the LdapGroupsMapping , we are also missing the com.sun.jndi.ldap.connect.timeout property for the env. I suppose this is orthogonal to the read timeouts. Should we address this as well? I had a look at the JNDI API documentation you kindly posted. I'm not sure I understand it correctly or the documentation is stale, but I was not able to reproduce the timed out exception using the ReadTimeoutTest.java . If we only set the com.sun.jndi.ldap.read.timeout env, the new InitialDirContext(env) will be stuck at connection phase and the read (query) operation will never be really issued. The test is running forever. However, if I set the com.sun.jndi.ldap.connect.timeout , the LDAP response read timed out naming exception will be thrown as expected. That's said, to test the com.sun.jndi.ldap.read.timeout feature is not as easy as to test the connect timeout. I'm wondering if the mock/spy will really help us here. See the v0 patch attached. I can make the property values configurable.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 39s trunk passed
        +1 compile 5m 50s trunk passed with JDK v1.8.0_91
        +1 compile 6m 48s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 1m 0s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 37s trunk passed
        +1 javadoc 0m 53s trunk passed with JDK v1.8.0_91
        +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 42s the patch passed
        +1 compile 5m 53s the patch passed with JDK v1.8.0_91
        +1 javac 5m 53s the patch passed
        +1 compile 6m 47s the patch passed with JDK v1.7.0_95
        +1 javac 6m 47s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 57s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 52s the patch passed
        +1 javadoc 0m 56s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95
        +1 unit 7m 31s hadoop-common in the patch passed with JDK v1.8.0_91.
        +1 unit 7m 44s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        60m 20s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802809/HADOOP-13105.000.patch
        JIRA Issue HADOOP-13105
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux fc6c61cb00ec 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 47c41e7
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9323/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9323/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 39s trunk passed +1 compile 5m 50s trunk passed with JDK v1.8.0_91 +1 compile 6m 48s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 37s trunk passed +1 javadoc 0m 53s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 42s the patch passed +1 compile 5m 53s the patch passed with JDK v1.8.0_91 +1 javac 5m 53s the patch passed +1 compile 6m 47s the patch passed with JDK v1.7.0_95 +1 javac 6m 47s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 52s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95 +1 unit 7m 31s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 7m 44s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 60m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802809/HADOOP-13105.000.patch JIRA Issue HADOOP-13105 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fc6c61cb00ec 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 47c41e7 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9323/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9323/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Thanks for the patch, Mingliang Liu.
        I think it'll be a good idea to make these two timeout values configurable. Could you also add these two configurable properties into core-default.xml?

        Your point #2 looks reasonable to me. If connection timeout is not set, the connection will block until the underlying network times out.

        Out of curiosty, doesn't the property hadoop.security.group.mapping.ldap.directory.search.timeout work for this purpose?

        Show
        jojochuang Wei-Chiu Chuang added a comment - Thanks for the patch, Mingliang Liu . I think it'll be a good idea to make these two timeout values configurable. Could you also add these two configurable properties into core-default.xml? Your point #2 looks reasonable to me. If connection timeout is not set, the connection will block until the underlying network times out. Out of curiosty, doesn't the property hadoop.security.group.mapping.ldap.directory.search.timeout work for this purpose?
        Hide
        cnauroth Chris Nauroth added a comment -

        Mingliang Liu, thank you for the patch.

        1. I agree with handling both connection timeout and read timeout within the scope of this patch.
        2. I agree with the suggestion to make the timeout settings configurable, and use something pretty long, like 60 seconds, as the default. A value of "0" could mean "don't set the timeout". That way, there is minimal impact to existing LDAP deployments that experience long latency, and in case anyone really wants the old unbounded wait behavior, they can set it to 0.
        3. For testing, I suggest looking at TestWebHdfsTimeouts, which uses techniques similar to what your test here does. To cover read timeout, it starts a TCP server that accepts connections but never responds, like what your patch already does. To simulate connect timeout, it spams a bunch of connections at that server to consume the TCP connection backlog before running the test.

        Out of curiosity, doesn't the property hadoop.security.group.mapping.ldap.directory.search.timeout work for this purpose?

        Wei-Chiu Chuang, I'm pretty sure this is something different. This is an application layer control, passed in the LDAP query, to give the LDAP server a hint that it should expect the query to complete in this amount of time. An LDAP server may choose to abort its query if it cannot complete within this timeout. This does not control timeouts at the TCP layer. It would not catch connection timeouts due to an overloaded LDAP server that has exhausted its listen backlog. It also would not catch timeouts if the LDAP server implementation chooses not to respect the search timeout. It also wouldn't cover cases like firewall misconfigurations that accept the client's SYN packet for connection establishment, but then drop subsequent packets.

        At least that's my recollection of what the search timeout does. Unfortunately, I can't find a definitive reference for that on the web right now to backup my claim. I definitely have seen LDAP connection timeouts and read timeouts despite having the search timeout configured correctly.

        If you were thinking of overloading hadoop.security.group.mapping.ldap.directory.search.timeout to also pass that same value for these new connect and read timeout settings, I'd instead prefer new properties for greater flexibility.

        Show
        cnauroth Chris Nauroth added a comment - Mingliang Liu , thank you for the patch. I agree with handling both connection timeout and read timeout within the scope of this patch. I agree with the suggestion to make the timeout settings configurable, and use something pretty long, like 60 seconds, as the default. A value of "0" could mean "don't set the timeout". That way, there is minimal impact to existing LDAP deployments that experience long latency, and in case anyone really wants the old unbounded wait behavior, they can set it to 0. For testing, I suggest looking at TestWebHdfsTimeouts , which uses techniques similar to what your test here does. To cover read timeout, it starts a TCP server that accepts connections but never responds, like what your patch already does. To simulate connect timeout, it spams a bunch of connections at that server to consume the TCP connection backlog before running the test. Out of curiosity, doesn't the property hadoop.security.group.mapping.ldap.directory.search.timeout work for this purpose? Wei-Chiu Chuang , I'm pretty sure this is something different. This is an application layer control, passed in the LDAP query, to give the LDAP server a hint that it should expect the query to complete in this amount of time. An LDAP server may choose to abort its query if it cannot complete within this timeout. This does not control timeouts at the TCP layer. It would not catch connection timeouts due to an overloaded LDAP server that has exhausted its listen backlog. It also would not catch timeouts if the LDAP server implementation chooses not to respect the search timeout. It also wouldn't cover cases like firewall misconfigurations that accept the client's SYN packet for connection establishment, but then drop subsequent packets. At least that's my recollection of what the search timeout does. Unfortunately, I can't find a definitive reference for that on the web right now to backup my claim. I definitely have seen LDAP connection timeouts and read timeouts despite having the search timeout configured correctly. If you were thinking of overloading hadoop.security.group.mapping.ldap.directory.search.timeout to also pass that same value for these new connect and read timeout settings, I'd instead prefer new properties for greater flexibility.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Thanks Chris Nauroth! Your explanation makes sense to me.
        Mingliang Liu, please also rebase the patch due to HADOOP-12782.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Thanks Chris Nauroth ! Your explanation makes sense to me. Mingliang Liu , please also rebase the patch due to HADOOP-12782 .
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks Wei-Chiu Chuang and Chris Nauroth for the review and comment. The next patch (on its way) will make both connect and read timeout configurable. As to the name, do you have any suggestion? I mean, we're setting com.sun.jndi.ldap.connect.timeout in the LDAP environment, and we may need a wrapped hadoop name.

        As to the test, I find when creating InitialDirContext() it will authenticate when connects and binds. This seems different from the stateless HTTP request as TestWebHdfsTimeouts. See the doc here. I'm not aware of any easy way in the fake LDAP server to make the client LdapCtx connected. In v0 patch, we're testing the connection timeout, instead of read timeout as the client has never connected to the server. As the following exception stack.

        2016-05-19 16:49:23,225 INFO  security.TestLdapGroupsMapping (TestLdapGroupsMapping.java:testLdapReadTimeout(245)) - Got the exception while LDAP querying: 
        javax.naming.NamingException: LDAP response read timed out, timeout used:5000ms.
        	at com.sun.jndi.ldap.Connection.readReply(Connection.java:490)
        	at com.sun.jndi.ldap.LdapClient.ldapBind(LdapClient.java:365)
        	at com.sun.jndi.ldap.LdapClient.authenticate(LdapClient.java:214)
        	at com.sun.jndi.ldap.LdapCtx.connect(LdapCtx.java:2788)
        	at com.sun.jndi.ldap.LdapCtx.<init>(LdapCtx.java:319)
        	at com.sun.jndi.ldap.LdapCtxFactory.getUsingURL(LdapCtxFactory.java:192)
        	at com.sun.jndi.ldap.LdapCtxFactory.getUsingURLs(LdapCtxFactory.java:210)
        	at com.sun.jndi.ldap.LdapCtxFactory.getLdapCtxInstance(LdapCtxFactory.java:153)
        	at com.sun.jndi.ldap.LdapCtxFactory.getInitialContext(LdapCtxFactory.java:83)
        	at javax.naming.spi.NamingManager.getInitialContext(NamingManager.java:684)
        	at javax.naming.InitialContext.getDefaultInitCtx(InitialContext.java:313)
        	at javax.naming.InitialContext.init(InitialContext.java:244)
        	at javax.naming.InitialContext.<init>(InitialContext.java:216)
        	at javax.naming.directory.InitialDirContext.<init>(InitialDirContext.java:101)
        	at org.apache.hadoop.security.LdapGroupsMapping.getDirContext(LdapGroupsMapping.java:437)
        	at org.apache.hadoop.security.LdapGroupsMapping.doGetGroups(LdapGroupsMapping.java:366)
        	at org.apache.hadoop.security.TestLdapGroupsMapping.testLdapReadTimeout(TestLdapGroupsMapping.java:242)
        

        Choices are:

        1. test connection timeout only, not ideal
        2. implement a mini LDAP server which can handle real LADP requests
        3. mock (assuming Java Naming performs well with given env variables)

        I'm working on the 2nd option. Any comment?

        Show
        liuml07 Mingliang Liu added a comment - Thanks Wei-Chiu Chuang and Chris Nauroth for the review and comment. The next patch (on its way) will make both connect and read timeout configurable. As to the name, do you have any suggestion? I mean, we're setting com.sun.jndi.ldap.connect.timeout in the LDAP environment, and we may need a wrapped hadoop name. As to the test, I find when creating InitialDirContext() it will authenticate when connects and binds. This seems different from the stateless HTTP request as TestWebHdfsTimeouts . See the doc here . I'm not aware of any easy way in the fake LDAP server to make the client LdapCtx connected. In v0 patch, we're testing the connection timeout, instead of read timeout as the client has never connected to the server. As the following exception stack. 2016-05-19 16:49:23,225 INFO security.TestLdapGroupsMapping (TestLdapGroupsMapping.java:testLdapReadTimeout(245)) - Got the exception while LDAP querying: javax.naming.NamingException: LDAP response read timed out, timeout used:5000ms. at com.sun.jndi.ldap.Connection.readReply(Connection.java:490) at com.sun.jndi.ldap.LdapClient.ldapBind(LdapClient.java:365) at com.sun.jndi.ldap.LdapClient.authenticate(LdapClient.java:214) at com.sun.jndi.ldap.LdapCtx.connect(LdapCtx.java:2788) at com.sun.jndi.ldap.LdapCtx.<init>(LdapCtx.java:319) at com.sun.jndi.ldap.LdapCtxFactory.getUsingURL(LdapCtxFactory.java:192) at com.sun.jndi.ldap.LdapCtxFactory.getUsingURLs(LdapCtxFactory.java:210) at com.sun.jndi.ldap.LdapCtxFactory.getLdapCtxInstance(LdapCtxFactory.java:153) at com.sun.jndi.ldap.LdapCtxFactory.getInitialContext(LdapCtxFactory.java:83) at javax.naming.spi.NamingManager.getInitialContext(NamingManager.java:684) at javax.naming.InitialContext.getDefaultInitCtx(InitialContext.java:313) at javax.naming.InitialContext.init(InitialContext.java:244) at javax.naming.InitialContext.<init>(InitialContext.java:216) at javax.naming.directory.InitialDirContext.<init>(InitialDirContext.java:101) at org.apache.hadoop.security.LdapGroupsMapping.getDirContext(LdapGroupsMapping.java:437) at org.apache.hadoop.security.LdapGroupsMapping.doGetGroups(LdapGroupsMapping.java:366) at org.apache.hadoop.security.TestLdapGroupsMapping.testLdapReadTimeout(TestLdapGroupsMapping.java:242) Choices are: test connection timeout only, not ideal implement a mini LDAP server which can handle real LADP requests mock (assuming Java Naming performs well with given env variables) I'm working on the 2nd option. Any comment?
        Hide
        cnauroth Chris Nauroth added a comment -

        Mingliang Liu, do you think hadoop-minikdc is helpful at all for testing a read timeout? Maybe there is a way to subclass something in there to stick a wait time inside the query handling?

        If the test gets too cumbersome or brittle, then I'd be comfortable proceeding with a patch that tests only connection timeout. The JNDI documentation clearly spells out how to set both connection and read timeout. Maybe it's more pragmatic to verify read timeout through code review and cross-check against that documentation.

        Show
        cnauroth Chris Nauroth added a comment - Mingliang Liu , do you think hadoop-minikdc is helpful at all for testing a read timeout? Maybe there is a way to subclass something in there to stick a wait time inside the query handling? If the test gets too cumbersome or brittle, then I'd be comfortable proceeding with a patch that tests only connection timeout. The JNDI documentation clearly spells out how to set both connection and read timeout. Maybe it's more pragmatic to verify read timeout through code review and cross-check against that documentation.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Mingliang Liu you may not need to re-implement an LDAP server –
        you can check out my patch at HADOOP-8145 to see how I use Apache Directory Service test framework to unit test LDAP queries.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Mingliang Liu you may not need to re-implement an LDAP server – you can check out my patch at HADOOP-8145 to see how I use Apache Directory Service test framework to unit test LDAP queries.
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks Chris Nauroth for the suggestion. I had a look at minikdc and find it's not straightforward to simply extend it. Actually I figured out a way similar to your last comment TestWebHdfsTimeouts. The only magic is AUTHENTICATE_SUCCESS_MSG. I don't like this hacking message but this is the best I can tell. The bright side is that, we're testing both connect and read timeout using a dummy server. As you stated, the JNDI documentation clearly spells out how to set both connection and read timeout. But still, in case the JNDI env variables are not working in upstream package, we'll find it out sooner than later.

        As to exploring ApacheDS for testing the LDAP mapping code, I like the idea. Thanks for letting me know the in-progress HADOOP-8145 work, Wei-Chiu Chuang. Actually I was expecting something alike before I checked out the TestLdapGroupsMapping. I was disappointed that we were just mocking the stuff.

        However, as 1) the change will bring new dependencies (ApacheDS test module), 2) heavy to use (I personally don't like the aspect-like annotations) 3) I don't know easy way to make the server delay for a specific period, I suggest we consolidate the effort of testing these features against a real LDAP server along with other test cases in HADOOP-8145, clearly in a new class as what's you're doing.

        Show
        liuml07 Mingliang Liu added a comment - Thanks Chris Nauroth for the suggestion. I had a look at minikdc and find it's not straightforward to simply extend it. Actually I figured out a way similar to your last comment TestWebHdfsTimeouts . The only magic is AUTHENTICATE_SUCCESS_MSG . I don't like this hacking message but this is the best I can tell. The bright side is that, we're testing both connect and read timeout using a dummy server. As you stated, the JNDI documentation clearly spells out how to set both connection and read timeout. But still, in case the JNDI env variables are not working in upstream package, we'll find it out sooner than later. As to exploring ApacheDS for testing the LDAP mapping code, I like the idea. Thanks for letting me know the in-progress HADOOP-8145 work, Wei-Chiu Chuang . Actually I was expecting something alike before I checked out the TestLdapGroupsMapping . I was disappointed that we were just mocking the stuff. However, as 1) the change will bring new dependencies (ApacheDS test module), 2) heavy to use (I personally don't like the aspect-like annotations) 3) I don't know easy way to make the server delay for a specific period, I suggest we consolidate the effort of testing these features against a real LDAP server along with other test cases in HADOOP-8145 , clearly in a new class as what's you're doing.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 47s trunk passed
        +1 compile 6m 27s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 22s trunk passed
        +1 javadoc 0m 55s trunk passed
        +1 mvninstall 0m 40s the patch passed
        +1 compile 6m 26s the patch passed
        +1 javac 6m 26s the patch passed
        -1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 24 new + 36 unchanged - 0 fixed = 60 total (was 36)
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 1m 29s the patch passed
        +1 javadoc 0m 52s the patch passed
        -1 unit 7m 29s hadoop-common in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        36m 48s



        Reason Tests
        Failed junit tests hadoop.net.TestDNS



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805768/HADOOP-13105.001.patch
        JIRA Issue HADOOP-13105
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 137fd747300d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4b0f55b
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9563/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9563/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9563/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9563/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9563/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 47s trunk passed +1 compile 6m 27s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 22s trunk passed +1 javadoc 0m 55s trunk passed +1 mvninstall 0m 40s the patch passed +1 compile 6m 26s the patch passed +1 javac 6m 26s the patch passed -1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 24 new + 36 unchanged - 0 fixed = 60 total (was 36) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 29s the patch passed +1 javadoc 0m 52s the patch passed -1 unit 7m 29s hadoop-common in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 36m 48s Reason Tests Failed junit tests hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805768/HADOOP-13105.001.patch JIRA Issue HADOOP-13105 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 137fd747300d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4b0f55b Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9563/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9563/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9563/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9563/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9563/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        The v2 patch fixes the checkstyle warnings.

        Show
        liuml07 Mingliang Liu added a comment - The v2 patch fixes the checkstyle warnings.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 34s trunk passed
        +1 compile 6m 50s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 21s trunk passed
        +1 javadoc 0m 57s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 6m 55s the patch passed
        +1 javac 6m 55s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 1m 36s the patch passed
        +1 javadoc 0m 54s the patch passed
        -1 unit 7m 47s hadoop-common in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        37m 54s



        Reason Tests
        Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806755/HADOOP-13105.002.patch
        JIRA Issue HADOOP-13105
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 8fa6b861650a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 21890c4
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9610/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9610/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9610/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9610/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 34s trunk passed +1 compile 6m 50s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 21s trunk passed +1 javadoc 0m 57s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 6m 55s the patch passed +1 javac 6m 55s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 36s the patch passed +1 javadoc 0m 54s the patch passed -1 unit 7m 47s hadoop-common in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 37m 54s Reason Tests Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806755/HADOOP-13105.002.patch JIRA Issue HADOOP-13105 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 8fa6b861650a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 21890c4 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9610/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9610/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9610/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9610/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        The failing test is not related, and I can't reproduce it locally.

        Show
        liuml07 Mingliang Liu added a comment - The failing test is not related, and I can't reproduce it locally.
        Hide
        cnauroth Chris Nauroth added a comment -

        The testing approach looks good to me. Here are a few comments on patch 002.

        1. I recommend adding a comment on AUTHENTICATE_SUCCESS_MSG to clarify what is in that binary data.
        2. It's fun to see the lambdas. This does mean it can't apply to branch-2 though. You'd either need to take away the lambdas for a patch that can apply to both trunk and branch-2, or post separate patches.
        Show
        cnauroth Chris Nauroth added a comment - The testing approach looks good to me. Here are a few comments on patch 002. I recommend adding a comment on AUTHENTICATE_SUCCESS_MSG to clarify what is in that binary data. It's fun to see the lambdas. This does mean it can't apply to branch-2 though. You'd either need to take away the lambdas for a patch that can apply to both trunk and branch-2, or post separate patches.
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks for your review, Chris Nauroth. The v3 patch is to address your latest comments. Specially, I took away the lambdas in the v3 patch (the IntelliJ refactored it for me in the first place).

        Show
        liuml07 Mingliang Liu added a comment - Thanks for your review, Chris Nauroth . The v3 patch is to address your latest comments. Specially, I took away the lambdas in the v3 patch (the IntelliJ refactored it for me in the first place).
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 10s trunk passed
        +1 compile 6m 30s trunk passed
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 18s trunk passed
        +1 javadoc 0m 54s trunk passed
        +1 mvninstall 0m 39s the patch passed
        +1 compile 6m 23s the patch passed
        +1 javac 6m 23s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 1m 26s the patch passed
        +1 javadoc 0m 53s the patch passed
        +1 unit 7m 36s hadoop-common in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        36m 8s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807858/HADOOP-13105.003.patch
        JIRA Issue HADOOP-13105
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux e321341bc21e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 97e2449
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9656/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9656/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 10s trunk passed +1 compile 6m 30s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 18s trunk passed +1 javadoc 0m 54s trunk passed +1 mvninstall 0m 39s the patch passed +1 compile 6m 23s the patch passed +1 javac 6m 23s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 26s the patch passed +1 javadoc 0m 53s the patch passed +1 unit 7m 36s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 36m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807858/HADOOP-13105.003.patch JIRA Issue HADOOP-13105 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux e321341bc21e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 97e2449 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9656/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9656/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -

        Mingliang Liu, patch 003 looks good. I just have one more request. In the tests, please declare finLatch as final. Without that, the patch will cause compilation to fail on branch-2 with the errors shown below.

        This didn't show up in pre-commit, because pre-commit ran against trunk, which is building with Java 8. In Java 8, they have introduced the concept of "effectively final" variables, which means that Java 8 auto-detected that those variables are final, because they were assigned only once.

        [ERROR] /Users/chris/git/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java:[232,15] local variable finLatch is accessed from within inner class; needs to be declared final
        [ERROR] /Users/chris/git/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java:[288,15] local variable finLatch is accessed from within inner class; needs to be declared final
        
        Show
        cnauroth Chris Nauroth added a comment - Mingliang Liu , patch 003 looks good. I just have one more request. In the tests, please declare finLatch as final . Without that, the patch will cause compilation to fail on branch-2 with the errors shown below. This didn't show up in pre-commit, because pre-commit ran against trunk, which is building with Java 8. In Java 8, they have introduced the concept of "effectively final" variables, which means that Java 8 auto-detected that those variables are final, because they were assigned only once. [ERROR] /Users/chris/git/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java:[232,15] local variable finLatch is accessed from within inner class; needs to be declared final [ERROR] /Users/chris/git/hadoop/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java:[288,15] local variable finLatch is accessed from within inner class; needs to be declared final
        Hide
        liuml07 Mingliang Liu added a comment -

        Thank you Chris Nauroth for your comment. Sorry I was not aware of the final variable problem when sharing with a nested thread in Java 7. I should have fixed the problem if I had the chance to build against branch-2. I was spoiled by the Java 8 and especially IntelliJ IDE.

        The v4 patch simply added two "final" keyword to the finLatch varaible in the test. I tested the patch on both trunk (Java 8) and trunk (Java 7), and it looked good.

        Show
        liuml07 Mingliang Liu added a comment - Thank you Chris Nauroth for your comment. Sorry I was not aware of the final variable problem when sharing with a nested thread in Java 7. I should have fixed the problem if I had the chance to build against branch-2 . I was spoiled by the Java 8 and especially IntelliJ IDE. The v4 patch simply added two "final" keyword to the finLatch varaible in the test. I tested the patch on both trunk (Java 8) and trunk (Java 7), and it looked good.
        Hide
        cnauroth Chris Nauroth added a comment -

        +1 for patch 004, pending pre-commit run.

        Show
        cnauroth Chris Nauroth added a comment - +1 for patch 004, pending pre-commit run.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 6m 52s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 24s trunk passed
        +1 compile 7m 22s trunk passed
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 28s trunk passed
        +1 javadoc 0m 57s trunk passed
        +1 mvninstall 0m 42s the patch passed
        +1 compile 7m 9s the patch passed
        +1 javac 7m 9s the patch passed
        +1 checkstyle 0m 26s the patch passed
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 1m 38s the patch passed
        +1 javadoc 0m 59s the patch passed
        +1 unit 7m 51s hadoop-common in the patch passed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        46m 49s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808081/HADOOP-13105.004.patch
        JIRA Issue HADOOP-13105
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 8dc662e623c0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 78b3a03
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9660/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9660/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 6m 52s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 24s trunk passed +1 compile 7m 22s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 28s trunk passed +1 javadoc 0m 57s trunk passed +1 mvninstall 0m 42s the patch passed +1 compile 7m 9s the patch passed +1 javac 7m 9s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 1m 38s the patch passed +1 javadoc 0m 59s the patch passed +1 unit 7m 51s hadoop-common in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 46m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808081/HADOOP-13105.004.patch JIRA Issue HADOOP-13105 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 8dc662e623c0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 78b3a03 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9660/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9660/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -

        I have committed this to trunk, branch-2 and branch-2.8. Mingliang Liu, thank you for the patch. Wei-Chiu Chuang, thank you for helping with code review.

        Show
        cnauroth Chris Nauroth added a comment - I have committed this to trunk, branch-2 and branch-2.8. Mingliang Liu , thank you for the patch. Wei-Chiu Chuang , thank you for helping with code review.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9910 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9910/)
        HADOOP-13105. Support timeouts in LDAP queries in LdapGroupsMapping. (cnauroth: rev d82bc8501869be78780fc09752dbf7af918c14af)

        • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9910 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9910/ ) HADOOP-13105 . Support timeouts in LDAP queries in LdapGroupsMapping. (cnauroth: rev d82bc8501869be78780fc09752dbf7af918c14af) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
        Hide
        liuml07 Mingliang Liu added a comment -

        Thank you for your review and commit, Chris Nauroth, and thank you Wei-Chiu Chuang for the review and discussion.

        Show
        liuml07 Mingliang Liu added a comment - Thank you for your review and commit, Chris Nauroth , and thank you Wei-Chiu Chuang for the review and discussion.
        Hide
        liuml07 Mingliang Liu added a comment -

        Added release notes. Feel free to refine it. Thanks.

        Show
        liuml07 Mingliang Liu added a comment - Added release notes. Feel free to refine it. Thanks.

          People

          • Assignee:
            liuml07 Mingliang Liu
            Reporter:
            cnauroth Chris Nauroth
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development