[HADOOP-12991] Conflicting default ports in DelegateToFileSystem

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.2
• Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
• Component/s: fs
• Hadoop Flags: Reviewed
• Assignee: Kai
• Reporter: Kevin Hogeland
• Created: 01/Apr/16 23:57
• Updated: 30/Aug/16 01:16
• Resolved: 19/Jul/16 23:08

Description

HADOOP-12304 introduced logic to ensure that the DelegateToFileSystem constructor sets the default port to -1:

DelegateToFileSystem.java

  protected DelegateToFileSystem(URI theUri, FileSystem theFsImpl,
      Configuration conf, String supportedScheme, boolean authorityRequired)
      throws IOException, URISyntaxException {
    super(theUri, supportedScheme, authorityRequired, 
        getDefaultPortIfDefined(theFsImpl));
    fsImpl = theFsImpl;
    fsImpl.initialize(theUri, conf);
    fsImpl.statistics = getStatistics();
  }

  private static int getDefaultPortIfDefined(FileSystem theFsImpl) {
    int defaultPort = theFsImpl.getDefaultPort();
    return defaultPort != 0 ? defaultPort : -1;
  }

However, DelegateToFileSystem#getUriDefaultPort returns 0:

DelegateToFileSystem.java

  public int getUriDefaultPort() {
    return 0;
  }

This breaks AbstractFileSystem#checkPath:

AbstractFileSystem.java

    int thisPort = this.getUri().getPort(); // If using DelegateToFileSystem, this is -1
    int thatPort = uri.getPort(); // This is -1 by default in java.net.URI
    if (thatPort == -1) {
      thatPort = this.getUriDefaultPort();  // Sets thatPort to 0
    }
    if (thisPort != thatPort) {
      throw new InvalidPathException("Wrong FS: " + path + ", expected: "
          + this.getUri());
    }

Which breaks any subclasses of DelegateToFileSystem that don't specify a port.

Issue Links

• is broken by: HADOOP-12304 Applications using FileContext fail with the default file system configured to be wasb/s3/etc.