Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12985

Support MetricsSource interface for DecayRpcScheduler Metrics

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This allows metrics collector such as AMS to collect it with MetricsSink. The per user RPC call counts, schedule decisions and per priority response time will be useful to detect and trouble shoot Hadoop RPC server such as Namenode overload issues.

      1. HADOOP-12985.06.patch
        21 kB
        Xiaoyu Yao
      2. HADOOP-12985.05.patch
        21 kB
        Xiaoyu Yao
      3. HADOOP-12985.04.patch
        20 kB
        Xiaoyu Yao
      4. HADOOP-12985.03.patch
        16 kB
        Xiaoyu Yao
      5. HADOOP-12985.02.patch
        16 kB
        Xiaoyu Yao
      6. HADOOP-12985.00.patch
        10 kB
        Xiaoyu Yao

        Activity

        Hide
        xyao Xiaoyu Yao added a comment -

        Attach a draft patch without unit test. Will add unit test later.

        Show
        xyao Xiaoyu Yao added a comment - Attach a draft patch without unit test. Will add unit test later.
        Hide
        xyao Xiaoyu Yao added a comment -

        Attach a new patch with unit test.

        Show
        xyao Xiaoyu Yao added a comment - Attach a new patch with unit test.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 14s trunk passed
        +1 compile 6m 39s trunk passed with JDK v1.8.0_77
        +1 compile 7m 20s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 1m 4s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 39s trunk passed
        +1 javadoc 0m 59s trunk passed with JDK v1.8.0_77
        +1 javadoc 1m 8s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 45s the patch passed
        +1 compile 6m 55s the patch passed with JDK v1.8.0_77
        +1 javac 6m 55s the patch passed
        +1 compile 7m 29s the patch passed with JDK v1.7.0_95
        +1 javac 7m 29s the patch passed
        -1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 5 new + 12 unchanged - 1 fixed = 17 total (was 13)
        +1 mvnsite 0m 57s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 57s the patch passed
        +1 javadoc 0m 56s the patch passed with JDK v1.8.0_77
        +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95
        -1 unit 17m 3s hadoop-common in the patch failed with JDK v1.8.0_77.
        +1 unit 8m 36s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        74m 37s



        Reason Tests
        JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799638/HADOOP-12985.02.patch
        JIRA Issue HADOOP-12985
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2c0f7171e0c0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / af9bdbe
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9120/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9120/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9120/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9120/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9120/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 14s trunk passed +1 compile 6m 39s trunk passed with JDK v1.8.0_77 +1 compile 7m 20s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 22s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 39s trunk passed +1 javadoc 0m 59s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 8s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 6m 55s the patch passed with JDK v1.8.0_77 +1 javac 6m 55s the patch passed +1 compile 7m 29s the patch passed with JDK v1.7.0_95 +1 javac 7m 29s the patch passed -1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 5 new + 12 unchanged - 1 fixed = 17 total (was 13) +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 57s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95 -1 unit 17m 3s hadoop-common in the patch failed with JDK v1.8.0_77. +1 unit 8m 36s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 74m 37s Reason Tests JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799638/HADOOP-12985.02.patch JIRA Issue HADOOP-12985 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2c0f7171e0c0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / af9bdbe Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9120/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9120/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9120/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9120/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9120/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        xyao Xiaoyu Yao added a comment -

        Fix the checkstyle issue.

        Show
        xyao Xiaoyu Yao added a comment - Fix the checkstyle issue.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 25s trunk passed
        +1 compile 5m 36s trunk passed with JDK v1.8.0_77
        +1 compile 6m 31s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 32s trunk passed
        +1 javadoc 0m 50s trunk passed with JDK v1.8.0_77
        +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 40s the patch passed
        +1 compile 5m 34s the patch passed with JDK v1.8.0_77
        +1 javac 5m 34s the patch passed
        +1 compile 6m 32s the patch passed with JDK v1.7.0_95
        +1 javac 6m 32s the patch passed
        +1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 0 new + 12 unchanged - 1 fixed = 12 total (was 13)
        +1 mvnsite 0m 56s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 45s the patch passed
        +1 javadoc 0m 52s the patch passed with JDK v1.8.0_77
        +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95
        -1 unit 7m 46s hadoop-common in the patch failed with JDK v1.8.0_77.
        +1 unit 8m 15s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        59m 2s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799652/HADOOP-12985.03.patch
        JIRA Issue HADOOP-12985
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 87f1043849a5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / af9bdbe
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9124/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9124/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9124/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9124/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 25s trunk passed +1 compile 5m 36s trunk passed with JDK v1.8.0_77 +1 compile 6m 31s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 32s trunk passed +1 javadoc 0m 50s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 40s the patch passed +1 compile 5m 34s the patch passed with JDK v1.8.0_77 +1 javac 5m 34s the patch passed +1 compile 6m 32s the patch passed with JDK v1.7.0_95 +1 javac 6m 32s the patch passed +1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 0 new + 12 unchanged - 1 fixed = 12 total (was 13) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95 -1 unit 7m 46s hadoop-common in the patch failed with JDK v1.8.0_77. +1 unit 8m 15s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 59m 2s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799652/HADOOP-12985.03.patch JIRA Issue HADOOP-12985 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 87f1043849a5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / af9bdbe Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9124/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9124/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9124/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9124/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jnp Jitendra Nath Pandey added a comment -

        The patch looks good to me. A minor comment that NameValuePair and TopN seem generally useful, might make sense to move them to MetricsUtil or a separate class.

        Show
        jnp Jitendra Nath Pandey added a comment - The patch looks good to me. A minor comment that NameValuePair and TopN seem generally useful, might make sense to move them to MetricsUtil or a separate class.
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Jitendra Nath Pandey for the review. Patch v04 addressed your comments.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Jitendra Nath Pandey for the review. Patch v04 addressed your comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 16s Maven dependency ordering for branch
        +1 mvninstall 7m 18s trunk passed
        +1 compile 6m 26s trunk passed with JDK v1.8.0_77
        +1 compile 6m 53s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 2s trunk passed
        +1 mvnsite 1m 48s trunk passed
        +1 mvneclipse 0m 29s trunk passed
        +1 findbugs 3m 30s trunk passed
        +1 javadoc 1m 56s trunk passed with JDK v1.8.0_77
        +1 javadoc 2m 49s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 1m 28s the patch passed
        +1 compile 6m 1s the patch passed with JDK v1.8.0_77
        -1 javac 7m 43s root-jdk1.8.0_77 with JDK v1.8.0_77 generated 8 new + 739 unchanged - 0 fixed = 747 total (was 739)
        +1 javac 6m 1s the patch passed
        +1 compile 6m 50s the patch passed with JDK v1.7.0_95
        -1 javac 14m 33s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 8 new + 736 unchanged - 0 fixed = 744 total (was 736)
        +1 javac 6m 50s the patch passed
        +1 checkstyle 1m 4s root: patch generated 0 new + 18 unchanged - 5 fixed = 18 total (was 23)
        +1 mvnsite 1m 49s the patch passed
        +1 mvneclipse 0m 30s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 3m 58s the patch passed
        +1 javadoc 2m 0s the patch passed with JDK v1.8.0_77
        +1 javadoc 2m 53s the patch passed with JDK v1.7.0_95
        +1 unit 7m 8s hadoop-common in the patch passed with JDK v1.8.0_77.
        -1 unit 58m 58s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
        -1 unit 6m 49s hadoop-common in the patch failed with JDK v1.7.0_95.
        -1 unit 57m 28s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 37s Patch does not generate ASF License warnings.
        191m 49s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache
          hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
          hadoop.hdfs.server.namenode.TestNamenodeRetryCache
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
        JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS
          hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
          hadoop.hdfs.server.namenode.TestNamenodeRetryCache
          hadoop.hdfs.TestHFlush



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799678/HADOOP-12985.04.patch
        JIRA Issue HADOOP-12985
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 94c9b8ffa3ab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / af9bdbe
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        javac root-jdk1.8.0_77: https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_77.txt
        javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 7m 18s trunk passed +1 compile 6m 26s trunk passed with JDK v1.8.0_77 +1 compile 6m 53s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 2s trunk passed +1 mvnsite 1m 48s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 3m 30s trunk passed +1 javadoc 1m 56s trunk passed with JDK v1.8.0_77 +1 javadoc 2m 49s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 28s the patch passed +1 compile 6m 1s the patch passed with JDK v1.8.0_77 -1 javac 7m 43s root-jdk1.8.0_77 with JDK v1.8.0_77 generated 8 new + 739 unchanged - 0 fixed = 747 total (was 739) +1 javac 6m 1s the patch passed +1 compile 6m 50s the patch passed with JDK v1.7.0_95 -1 javac 14m 33s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 8 new + 736 unchanged - 0 fixed = 744 total (was 736) +1 javac 6m 50s the patch passed +1 checkstyle 1m 4s root: patch generated 0 new + 18 unchanged - 5 fixed = 18 total (was 23) +1 mvnsite 1m 49s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 58s the patch passed +1 javadoc 2m 0s the patch passed with JDK v1.8.0_77 +1 javadoc 2m 53s the patch passed with JDK v1.7.0_95 +1 unit 7m 8s hadoop-common in the patch passed with JDK v1.8.0_77. -1 unit 58m 58s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 6m 49s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 57m 28s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 37s Patch does not generate ASF License warnings. 191m 49s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799678/HADOOP-12985.04.patch JIRA Issue HADOOP-12985 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 94c9b8ffa3ab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / af9bdbe Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.8.0_77: https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_77.txt javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9125/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        xyao Xiaoyu Yao added a comment -

        Fix the javac issue as the MetricsUtil is in metrics 1 package. It has been deprecated by metrics2. Move the utility class into metrics2 util.

        Show
        xyao Xiaoyu Yao added a comment - Fix the javac issue as the MetricsUtil is in metrics 1 package. It has been deprecated by metrics2. Move the utility class into metrics2 util.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 15s Maven dependency ordering for branch
        +1 mvninstall 6m 38s trunk passed
        +1 compile 5m 55s trunk passed with JDK v1.8.0_77
        +1 compile 6m 46s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 3s trunk passed
        +1 mvnsite 1m 46s trunk passed
        +1 mvneclipse 0m 29s trunk passed
        +1 findbugs 3m 32s trunk passed
        +1 javadoc 1m 58s trunk passed with JDK v1.8.0_77
        +1 javadoc 2m 49s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 1m 26s the patch passed
        +1 compile 5m 56s the patch passed with JDK v1.8.0_77
        +1 javac 5m 56s the patch passed
        +1 compile 6m 43s the patch passed with JDK v1.7.0_95
        +1 javac 6m 43s the patch passed
        -1 checkstyle 1m 4s root: patch generated 1 new + 19 unchanged - 5 fixed = 20 total (was 24)
        +1 mvnsite 1m 49s the patch passed
        +1 mvneclipse 0m 28s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 4m 3s the patch passed
        +1 javadoc 2m 0s the patch passed with JDK v1.8.0_77
        +1 javadoc 2m 54s the patch passed with JDK v1.7.0_95
        +1 unit 8m 17s hadoop-common in the patch passed with JDK v1.8.0_77.
        -1 unit 58m 23s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
        +1 unit 8m 18s hadoop-common in the patch passed with JDK v1.7.0_95.
        -1 unit 54m 8s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        188m 51s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.namenode.TestEditLog
          hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
          hadoop.hdfs.TestHFlush
          hadoop.hdfs.server.namenode.TestNamenodeRetryCache
          hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestPersistBlocks
          hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
          hadoop.hdfs.TestHFlush
          hadoop.hdfs.server.namenode.TestNamenodeRetryCache
          hadoop.hdfs.server.namenode.TestStartup



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799756/HADOOP-12985.05.patch
        JIRA Issue HADOOP-12985
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1e56d65d8189 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / af9bdbe
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 5m 55s trunk passed with JDK v1.8.0_77 +1 compile 6m 46s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 3s trunk passed +1 mvnsite 1m 46s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 3m 32s trunk passed +1 javadoc 1m 58s trunk passed with JDK v1.8.0_77 +1 javadoc 2m 49s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 26s the patch passed +1 compile 5m 56s the patch passed with JDK v1.8.0_77 +1 javac 5m 56s the patch passed +1 compile 6m 43s the patch passed with JDK v1.7.0_95 +1 javac 6m 43s the patch passed -1 checkstyle 1m 4s root: patch generated 1 new + 19 unchanged - 5 fixed = 20 total (was 24) +1 mvnsite 1m 49s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 3s the patch passed +1 javadoc 2m 0s the patch passed with JDK v1.8.0_77 +1 javadoc 2m 54s the patch passed with JDK v1.7.0_95 +1 unit 8m 17s hadoop-common in the patch passed with JDK v1.8.0_77. -1 unit 58m 23s hadoop-hdfs in the patch failed with JDK v1.8.0_77. +1 unit 8m 18s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 54m 8s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 188m 51s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.server.namenode.TestStartup Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799756/HADOOP-12985.05.patch JIRA Issue HADOOP-12985 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1e56d65d8189 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / af9bdbe Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9126/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        xyao Xiaoyu Yao added a comment -

        Fix the checkstyle issue.

        Show
        xyao Xiaoyu Yao added a comment - Fix the checkstyle issue.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 15s Maven dependency ordering for branch
        +1 mvninstall 6m 42s trunk passed
        +1 compile 5m 53s trunk passed with JDK v1.8.0_77
        +1 compile 6m 57s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 6s trunk passed
        +1 mvnsite 1m 51s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 3m 31s trunk passed
        +1 javadoc 1m 58s trunk passed with JDK v1.8.0_77
        +1 javadoc 2m 52s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 1m 28s the patch passed
        +1 compile 5m 54s the patch passed with JDK v1.8.0_77
        +1 javac 5m 54s the patch passed
        +1 compile 6m 57s the patch passed with JDK v1.7.0_95
        +1 javac 6m 57s the patch passed
        +1 checkstyle 1m 5s root: patch generated 0 new + 19 unchanged - 5 fixed = 19 total (was 24)
        +1 mvnsite 1m 50s the patch passed
        +1 mvneclipse 0m 29s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 4m 0s the patch passed
        +1 javadoc 2m 0s the patch passed with JDK v1.8.0_77
        +1 javadoc 2m 59s the patch passed with JDK v1.7.0_95
        -1 unit 21m 40s hadoop-common in the patch failed with JDK v1.8.0_77.
        -1 unit 71m 40s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
        +1 unit 7m 34s hadoop-common in the patch passed with JDK v1.7.0_95.
        -1 unit 67m 23s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        228m 50s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestHFlush
          hadoop.hdfs.server.datanode.TestLargeBlockReport
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs
        JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.TestRollingUpgrade



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799838/HADOOP-12985.06.patch
        JIRA Issue HADOOP-12985
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux dfd193025604 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 63ac2db
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 42s trunk passed +1 compile 5m 53s trunk passed with JDK v1.8.0_77 +1 compile 6m 57s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 6s trunk passed +1 mvnsite 1m 51s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 31s trunk passed +1 javadoc 1m 58s trunk passed with JDK v1.8.0_77 +1 javadoc 2m 52s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 28s the patch passed +1 compile 5m 54s the patch passed with JDK v1.8.0_77 +1 javac 5m 54s the patch passed +1 compile 6m 57s the patch passed with JDK v1.7.0_95 +1 javac 6m 57s the patch passed +1 checkstyle 1m 5s root: patch generated 0 new + 19 unchanged - 5 fixed = 19 total (was 24) +1 mvnsite 1m 50s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 0s the patch passed +1 javadoc 2m 0s the patch passed with JDK v1.8.0_77 +1 javadoc 2m 59s the patch passed with JDK v1.7.0_95 -1 unit 21m 40s hadoop-common in the patch failed with JDK v1.8.0_77. -1 unit 71m 40s hadoop-hdfs in the patch failed with JDK v1.8.0_77. +1 unit 7m 34s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 67m 23s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 228m 50s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.TestLargeBlockReport   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799838/HADOOP-12985.06.patch JIRA Issue HADOOP-12985 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dfd193025604 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 63ac2db Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9132/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jnp Jitendra Nath Pandey added a comment -

        Minor : TopN import is not needed in RollingWindowManager
        +1 with the above fix.

        Show
        jnp Jitendra Nath Pandey added a comment - Minor : TopN import is not needed in RollingWindowManager +1 with the above fix.
        Hide
        xyao Xiaoyu Yao added a comment -

        Jitendra Nath Pandey, the TopN was shared by RollingWindowManager and the MetricsSource for DecayRpcScheduler.

        Show
        xyao Xiaoyu Yao added a comment - Jitendra Nath Pandey , the TopN was shared by RollingWindowManager and the MetricsSource for DecayRpcScheduler.
        Hide
        jnp Jitendra Nath Pandey added a comment -

        I see, ok. +1

        Show
        jnp Jitendra Nath Pandey added a comment - I see, ok. +1
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Jitendra Nath Pandey for the review. I've commit the patch to trunk, branch-2 and branch-2.8.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Jitendra Nath Pandey for the review. I've commit the patch to trunk, branch-2 and branch-2.8.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9641 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9641/)
        HADOOP-12985. Support MetricsSource interface for DecayRpcScheduler (xyao: rev 5bd7b592e5fbe4d448fd127c15d29f3121b8a833)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/util/Metrics2Util.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9641 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9641/ ) HADOOP-12985 . Support MetricsSource interface for DecayRpcScheduler (xyao: rev 5bd7b592e5fbe4d448fd127c15d29f3121b8a833) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/util/Metrics2Util.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java

          People

          • Assignee:
            xyao Xiaoyu Yao
            Reporter:
            xyao Xiaoyu Yao
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development