Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12957

Limit the number of outstanding async calls

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In async RPC, if the callers don't read replies fast enough, the buffer storing replies could be used up. This is to propose limiting the number of outstanding async calls to eliminate the issue.

      1. HADOOP-12957-HADOOP-12909.000.patch
        3 kB
        Xiaobing Zhou
      2. HADOOP-12957-combo.000.patch
        33 kB
        Xiaobing Zhou
      3. HADOOP-12957.001.patch
        16 kB
        Xiaobing Zhou
      4. HADOOP-12957.002.patch
        16 kB
        Xiaobing Zhou
      5. HADOOP-12957.003.patch
        16 kB
        Xiaobing Zhou
      6. HADOOP-12957.004.patch
        35 kB
        Xiaobing Zhou
      7. HADOOP-12957.005.patch
        35 kB
        Xiaobing Zhou
      8. HADOOP-12957.006.patch
        33 kB
        Xiaobing Zhou
      9. HADOOP-12957.007.patch
        33 kB
        Xiaobing Zhou
      10. HADOOP-12957.008.patch
        33 kB
        Xiaobing Zhou
      11. HADOOP-12957.009.patch
        33 kB
        Xiaobing Zhou
      12. HADOOP-12957.010.patch
        33 kB
        Xiaobing Zhou
      13. HADOOP-12957.011.patch
        33 kB
        Xiaobing Zhou

        Issue Links

          Activity

          Hide
          xiaobingo Xiaobing Zhou added a comment -

          I posted patch v000 for review. There could be two changes:
          1. make asyncCallCounter as a thread local so it makes each thread being subject to the threshold. But there might be a couple of caller threads doing async calls, which exacerbates buffer usage.
          2. make asyncCallCounter configurable.

          I'd like to know reviewers' comments on these. Thanks.

          Show
          xiaobingo Xiaobing Zhou added a comment - I posted patch v000 for review. There could be two changes: 1. make asyncCallCounter as a thread local so it makes each thread being subject to the threshold. But there might be a couple of caller threads doing async calls, which exacerbates buffer usage. 2. make asyncCallCounter configurable. I'd like to know reviewers' comments on these. Thanks.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          I also post the combo patch v000 that contains HADOOP-12957 and HADOOP-12909 for reference and easy review.

          Show
          xiaobingo Xiaobing Zhou added a comment - I also post the combo patch v000 that contains HADOOP-12957 and HADOOP-12909 for reference and easy review.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          The unit tests will be added in upcoming patches.

          Show
          xiaobingo Xiaobing Zhou added a comment - The unit tests will be added in upcoming patches.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 24s trunk passed
          +1 compile 7m 24s trunk passed with JDK v1.8.0_74
          +1 compile 7m 5s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 55s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 34s trunk passed
          +1 javadoc 0m 52s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 2s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 41s the patch passed
          +1 compile 5m 53s the patch passed with JDK v1.8.0_74
          -1 javac 10m 14s root-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 737 unchanged - 1 fixed = 738 total (was 738)
          +1 javac 5m 53s the patch passed
          +1 compile 7m 7s the patch passed with JDK v1.7.0_95
          -1 javac 17m 21s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 733 unchanged - 1 fixed = 734 total (was 734)
          +1 javac 7m 7s the patch passed
          -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 3 new + 85 unchanged - 1 fixed = 88 total (was 86)
          +1 mvnsite 0m 59s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 55s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95
          -1 unit 6m 57s hadoop-common in the patch failed with JDK v1.8.0_74.
          -1 unit 7m 8s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 23s Patch generated 2 ASF License warnings.
          61m 43s



          Reason Tests
          JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795310/HADOOP-12957-combo.000.patch
          JIRA Issue HADOOP-12957
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 603bed744ac9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2e1d0ff
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac root-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_74.txt
          javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 24s trunk passed +1 compile 7m 24s trunk passed with JDK v1.8.0_74 +1 compile 7m 5s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 5m 53s the patch passed with JDK v1.8.0_74 -1 javac 10m 14s root-jdk1.8.0_74 with JDK v1.8.0_74 generated 1 new + 737 unchanged - 1 fixed = 738 total (was 738) +1 javac 5m 53s the patch passed +1 compile 7m 7s the patch passed with JDK v1.7.0_95 -1 javac 17m 21s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 733 unchanged - 1 fixed = 734 total (was 734) +1 javac 7m 7s the patch passed -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 3 new + 85 unchanged - 1 fixed = 88 total (was 86) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 55s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95 -1 unit 6m 57s hadoop-common in the patch failed with JDK v1.8.0_74. -1 unit 7m 8s hadoop-common in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 23s Patch generated 2 ASF License warnings. 61m 43s Reason Tests JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795310/HADOOP-12957-combo.000.patch JIRA Issue HADOOP-12957 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 603bed744ac9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2e1d0ff Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_74.txt javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8918/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Thanks for the patch. We could simply use Semaphore instead of adding a new class RateLimiter.

          Please also add some tests.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Thanks for the patch. We could simply use Semaphore instead of adding a new class RateLimiter. Please also add some tests.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          I posted patch v001 for review. The idea is:
          When the limit is reached, AsyncCallLimitExceededException will be thrown, applications need to handle the exception by calling Future#get to retrieve results of established async calls in order not to block follow-on async calls.

          Show
          xiaobingo Xiaobing Zhou added a comment - I posted patch v001 for review. The idea is: When the limit is reached, AsyncCallLimitExceededException will be thrown, applications need to handle the exception by calling Future#get to retrieve results of established async calls in order not to block follow-on async calls.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 26s trunk passed
          +1 compile 6m 17s trunk passed with JDK v1.8.0_92
          +1 compile 6m 44s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 1m 1s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 36s trunk passed
          +1 javadoc 0m 56s trunk passed with JDK v1.8.0_92
          +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 40s the patch passed
          +1 compile 5m 56s the patch passed with JDK v1.8.0_92
          +1 javac 5m 56s the patch passed
          +1 compile 6m 46s the patch passed with JDK v1.7.0_95
          +1 javac 6m 46s the patch passed
          -1 checkstyle 0m 21s hadoop-common-project/hadoop-common: The patch generated 2 new + 163 unchanged - 0 fixed = 165 total (was 163)
          +1 mvnsite 0m 58s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 51s the patch passed with JDK v1.8.0_92
          +1 javadoc 1m 3s the patch passed with JDK v1.7.0_95
          +1 unit 7m 49s hadoop-common in the patch passed with JDK v1.8.0_92.
          +1 unit 8m 3s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          60m 49s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800704/HADOOP-12957.001.patch
          JIRA Issue HADOOP-12957
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d984e4af1cce 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5865fe2
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9181/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9181/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9181/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 26s trunk passed +1 compile 6m 17s trunk passed with JDK v1.8.0_92 +1 compile 6m 44s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 36s trunk passed +1 javadoc 0m 56s trunk passed with JDK v1.8.0_92 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 40s the patch passed +1 compile 5m 56s the patch passed with JDK v1.8.0_92 +1 javac 5m 56s the patch passed +1 compile 6m 46s the patch passed with JDK v1.7.0_95 +1 javac 6m 46s the patch passed -1 checkstyle 0m 21s hadoop-common-project/hadoop-common: The patch generated 2 new + 163 unchanged - 0 fixed = 165 total (was 163) +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 51s the patch passed with JDK v1.8.0_92 +1 javadoc 1m 3s the patch passed with JDK v1.7.0_95 +1 unit 7m 49s hadoop-common in the patch passed with JDK v1.8.0_92. +1 unit 8m 3s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 60m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800704/HADOOP-12957.001.patch JIRA Issue HADOOP-12957 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d984e4af1cce 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5865fe2 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9181/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9181/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9181/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Patch v002 used a different way to probe limit of async calls, e.g.

          for (;;) {
                  try {
                    doCall(idx, param);
                    return;
                  } catch (AsyncCallLimitExceededException e) {
                    /**
                     * reached limit of async calls, fetch results of finished async calls
                     * to let follow-on calls go
                     */
                    start = end;
                    end = idx;
                    waitForReturnValues(start, end);
                  }
                }
          

          Thank you Tsz Wo Nicholas Sze for the comment.

          Show
          xiaobingo Xiaobing Zhou added a comment - Patch v002 used a different way to probe limit of async calls, e.g. for (;;) { try { doCall(idx, param); return ; } catch (AsyncCallLimitExceededException e) { /** * reached limit of async calls, fetch results of finished async calls * to let follow-on calls go */ start = end; end = idx; waitForReturnValues(start, end); } } Thank you Tsz Wo Nicholas Sze for the comment.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 10m 38s trunk passed
          +1 compile 5m 53s trunk passed with JDK v1.8.0_92
          +1 compile 6m 44s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 1m 7s trunk passed
          +1 mvneclipse 0m 19s trunk passed
          +1 findbugs 1m 44s trunk passed
          +1 javadoc 0m 54s trunk passed with JDK v1.8.0_92
          +1 javadoc 1m 2s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 40s the patch passed
          +1 compile 5m 41s the patch passed with JDK v1.8.0_92
          +1 javac 5m 41s the patch passed
          +1 compile 6m 45s the patch passed with JDK v1.7.0_95
          +1 javac 6m 45s the patch passed
          +1 checkstyle 0m 23s the patch passed
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 52s the patch passed with JDK v1.8.0_92
          +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95
          -1 unit 6m 48s hadoop-common in the patch failed with JDK v1.8.0_92.
          -1 unit 7m 1s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          62m 44s



          Reason Tests
          JDK v1.8.0_92 Failed junit tests hadoop.ipc.TestIPC
          JDK v1.7.0_95 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800888/HADOOP-12957.002.patch
          JIRA Issue HADOOP-12957
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4dfa6a5f3377 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6be22dd
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9188/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9188/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9188/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9188/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9188/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9188/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 10m 38s trunk passed +1 compile 5m 53s trunk passed with JDK v1.8.0_92 +1 compile 6m 44s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 0m 54s trunk passed with JDK v1.8.0_92 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 40s the patch passed +1 compile 5m 41s the patch passed with JDK v1.8.0_92 +1 javac 5m 41s the patch passed +1 compile 6m 45s the patch passed with JDK v1.7.0_95 +1 javac 6m 45s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_92 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95 -1 unit 6m 48s hadoop-common in the patch failed with JDK v1.8.0_92. -1 unit 7m 1s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 62m 44s Reason Tests JDK v1.8.0_92 Failed junit tests hadoop.ipc.TestIPC JDK v1.7.0_95 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800888/HADOOP-12957.002.patch JIRA Issue HADOOP-12957 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4dfa6a5f3377 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6be22dd Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9188/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9188/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9188/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9188/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9188/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9188/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Thanks for the update. I think the patch may not work for some exception case since connection.sendRpcRequest(call) may throw exception. Then the count won't be decremented.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Thanks for the update. I think the patch may not work for some exception case since connection.sendRpcRequest(call) may throw exception. Then the count won't be decremented.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Patch v003 caught the exception and decreased the counter accordingly. It also added some other fixes. Thanks.

          Show
          xiaobingo Xiaobing Zhou added a comment - Patch v003 caught the exception and decreased the counter accordingly. It also added some other fixes. Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 docker 0m 2s Docker failed to build yetus/hadoop:7b1c37a.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801126/HADOOP-12957.003.patch
          JIRA Issue HADOOP-12957
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9195/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 0m 2s Docker failed to build yetus/hadoop:7b1c37a. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801126/HADOOP-12957.003.patch JIRA Issue HADOOP-12957 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9195/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Thanks for the update.

          • It seems releaseAsyncCall may not work if the asyncMode is changing between calls. We need to call releaseAsyncCall inside Future.get.
          • Please add the new tests to TestAsyncIPC. We don't need to create new file for TestAsycCallLimit.
          • Please add some new tests to TestAsyncDFSRename (i.e. testing async rename).
          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Thanks for the update. It seems releaseAsyncCall may not work if the asyncMode is changing between calls. We need to call releaseAsyncCall inside Future.get. Please add the new tests to TestAsyncIPC. We don't need to create new file for TestAsycCallLimit. Please add some new tests to TestAsyncDFSRename (i.e. testing async rename).
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Thanks for review. Patch v004 is posted.

          1. fixed some issues in ipc.Client
          2. fixed async call counter
          3. fixed callback across multiple layers (e.g. ipc.Client, ProtobufRpcEngine, ClientNamenodeProtocolTranslatorPB and AsyncDistributedFileSystem)
          4. added many tests for async RPC and async rename (e.g. TestAsyncIPC and TestAsyncDFSRename)
          5. fix broken tests for async rename as a result of limiting number of async calls (see also TestAsyncDFSRename)

          Show
          xiaobingo Xiaobing Zhou added a comment - Thanks for review. Patch v004 is posted. 1. fixed some issues in ipc.Client 2. fixed async call counter 3. fixed callback across multiple layers (e.g. ipc.Client, ProtobufRpcEngine, ClientNamenodeProtocolTranslatorPB and AsyncDistributedFileSystem) 4. added many tests for async RPC and async rename (e.g. TestAsyncIPC and TestAsyncDFSRename) 5. fix broken tests for async rename as a result of limiting number of async calls (see also TestAsyncDFSRename)
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 4m 31s Maven dependency ordering for branch
          +1 mvninstall 7m 54s trunk passed
          +1 compile 6m 42s trunk passed with JDK v1.8.0_91
          +1 compile 6m 55s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 13s trunk passed
          +1 mvnsite 2m 28s trunk passed
          +1 mvneclipse 0m 46s trunk passed
          +1 findbugs 5m 25s trunk passed
          +1 javadoc 2m 21s trunk passed with JDK v1.8.0_91
          +1 javadoc 3m 18s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 2m 6s the patch passed
          +1 compile 6m 39s the patch passed with JDK v1.8.0_91
          +1 javac 6m 39s the patch passed
          +1 compile 6m 55s the patch passed with JDK v1.7.0_95
          +1 javac 6m 55s the patch passed
          -1 checkstyle 1m 8s root: The patch generated 1 new + 201 unchanged - 0 fixed = 202 total (was 201)
          +1 mvnsite 2m 20s the patch passed
          +1 mvneclipse 0m 42s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 5m 58s the patch passed
          +1 javadoc 2m 24s the patch passed with JDK v1.8.0_91
          +1 javadoc 3m 25s the patch passed with JDK v1.7.0_95
          -1 unit 7m 41s hadoop-common in the patch failed with JDK v1.8.0_91.
          +1 unit 0m 55s hadoop-hdfs-client in the patch passed with JDK v1.8.0_91.
          -1 unit 64m 50s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
          +1 unit 8m 4s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 3s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 57m 36s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          215m 48s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.TestAsyncDFSRename
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestAsyncDFSRename
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801401/HADOOP-12957.004.patch
          JIRA Issue HADOOP-12957
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a3cb4e87d4e8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4a85085
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 4m 31s Maven dependency ordering for branch +1 mvninstall 7m 54s trunk passed +1 compile 6m 42s trunk passed with JDK v1.8.0_91 +1 compile 6m 55s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 13s trunk passed +1 mvnsite 2m 28s trunk passed +1 mvneclipse 0m 46s trunk passed +1 findbugs 5m 25s trunk passed +1 javadoc 2m 21s trunk passed with JDK v1.8.0_91 +1 javadoc 3m 18s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 2m 6s the patch passed +1 compile 6m 39s the patch passed with JDK v1.8.0_91 +1 javac 6m 39s the patch passed +1 compile 6m 55s the patch passed with JDK v1.7.0_95 +1 javac 6m 55s the patch passed -1 checkstyle 1m 8s root: The patch generated 1 new + 201 unchanged - 0 fixed = 202 total (was 201) +1 mvnsite 2m 20s the patch passed +1 mvneclipse 0m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 58s the patch passed +1 javadoc 2m 24s the patch passed with JDK v1.8.0_91 +1 javadoc 3m 25s the patch passed with JDK v1.7.0_95 -1 unit 7m 41s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 0m 55s hadoop-hdfs-client in the patch passed with JDK v1.8.0_91. -1 unit 64m 50s hadoop-hdfs in the patch failed with JDK v1.8.0_91. +1 unit 8m 4s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 1m 3s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 57m 36s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 215m 48s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.TestAsyncDFSRename   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestAsyncDFSRename   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801401/HADOOP-12957.004.patch JIRA Issue HADOOP-12957 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a3cb4e87d4e8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4a85085 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9223/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Patch v005 is posted. it
          1. fixed check style issues
          2. changed the timeout setting for test (e.g. TestAsyncDFSRename#testAggressiveConcurrentAsyncRenameWithOverwrite)
          3. changed the position of the one-time call guarantee of callback/future, e.g.

          private final AtomicBoolean callled = new AtomicBoolean(false);
          
          Show
          xiaobingo Xiaobing Zhou added a comment - Patch v005 is posted. it 1. fixed check style issues 2. changed the timeout setting for test (e.g. TestAsyncDFSRename#testAggressiveConcurrentAsyncRenameWithOverwrite) 3. changed the position of the one-time call guarantee of callback/future, e.g. private final AtomicBoolean callled = new AtomicBoolean( false );
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 54s Maven dependency ordering for branch
          +1 mvninstall 6m 50s trunk passed
          +1 compile 6m 8s trunk passed with JDK v1.8.0_92
          +1 compile 6m 52s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 7s trunk passed
          +1 mvnsite 2m 24s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 5m 12s trunk passed
          +1 javadoc 2m 23s trunk passed with JDK v1.8.0_92
          +1 javadoc 3m 24s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 2m 2s the patch passed
          +1 compile 6m 11s the patch passed with JDK v1.8.0_92
          +1 javac 6m 11s the patch passed
          +1 compile 7m 0s the patch passed with JDK v1.7.0_95
          +1 javac 7m 0s the patch passed
          +1 checkstyle 1m 9s the patch passed
          +1 mvnsite 2m 22s the patch passed
          +1 mvneclipse 0m 42s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 6m 3s the patch passed
          +1 javadoc 2m 23s the patch passed with JDK v1.8.0_92
          +1 javadoc 3m 18s the patch passed with JDK v1.7.0_95
          -1 unit 7m 37s hadoop-common in the patch failed with JDK v1.8.0_92.
          +1 unit 0m 52s hadoop-hdfs-client in the patch passed with JDK v1.8.0_92.
          -1 unit 59m 42s hadoop-hdfs in the patch failed with JDK v1.8.0_92.
          -1 unit 7m 48s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 59s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 55m 57s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          202m 31s



          Reason Tests
          JDK v1.8.0_92 Failed junit tests hadoop.net.TestDNS
            hadoop.hdfs.TestEncryptionZones
          JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801487/HADOOP-12957.005.patch
          JIRA Issue HADOOP-12957
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux baa8a7b6358b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9d4d302
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 54s Maven dependency ordering for branch +1 mvninstall 6m 50s trunk passed +1 compile 6m 8s trunk passed with JDK v1.8.0_92 +1 compile 6m 52s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 7s trunk passed +1 mvnsite 2m 24s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 5m 12s trunk passed +1 javadoc 2m 23s trunk passed with JDK v1.8.0_92 +1 javadoc 3m 24s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 2m 2s the patch passed +1 compile 6m 11s the patch passed with JDK v1.8.0_92 +1 javac 6m 11s the patch passed +1 compile 7m 0s the patch passed with JDK v1.7.0_95 +1 javac 7m 0s the patch passed +1 checkstyle 1m 9s the patch passed +1 mvnsite 2m 22s the patch passed +1 mvneclipse 0m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 6m 3s the patch passed +1 javadoc 2m 23s the patch passed with JDK v1.8.0_92 +1 javadoc 3m 18s the patch passed with JDK v1.7.0_95 -1 unit 7m 37s hadoop-common in the patch failed with JDK v1.8.0_92. +1 unit 0m 52s hadoop-hdfs-client in the patch passed with JDK v1.8.0_92. -1 unit 59m 42s hadoop-hdfs in the patch failed with JDK v1.8.0_92. -1 unit 7m 48s hadoop-common in the patch failed with JDK v1.7.0_95. +1 unit 0m 59s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 55m 57s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 202m 31s Reason Tests JDK v1.8.0_92 Failed junit tests hadoop.net.TestDNS   hadoop.hdfs.TestEncryptionZones JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801487/HADOOP-12957.005.patch JIRA Issue HADOOP-12957 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux baa8a7b6358b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9d4d302 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9229/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -
          • asyncCallCounter should be final
          • The AsyncCallLimitExceededException message should include the value of the limit and describle how to config it. Also, we don't need LOG.warn(..). Throwing an exception is good enough.
          • Callbacks (i.e. Callable) do not need the AtomicBoolean called field.
          • The RETURN_VALUE_CALLBACK actually can be removed since it does nothing. AsyncDistributedFileSystem can directly call ProtobufRpcEngine.getReturnMessageCallback().
          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - asyncCallCounter should be final The AsyncCallLimitExceededException message should include the value of the limit and describle how to config it. Also, we don't need LOG.warn(..). Throwing an exception is good enough. Callbacks (i.e. Callable) do not need the AtomicBoolean called field. The RETURN_VALUE_CALLBACK actually can be removed since it does nothing. AsyncDistributedFileSystem can directly call ProtobufRpcEngine.getReturnMessageCallback().
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Thank you for review. Patch v006 is posted to
          1. make asyncCallCounter final
          2. add extra message for AsyncCallLimitExceededException
          3. removed one-time call guarantee for Callable.

          I think we might need to keep ClientNamenodeProtocolTranslatorPB#RETURN_VALUE_CALLBACK. Without this, the logic on how to extract result from message has to be moved to AsyncDistributedFileSystem, which makes AsyncDistributedFileSystem quite heavy-weight.

          Show
          xiaobingo Xiaobing Zhou added a comment - Thank you for review. Patch v006 is posted to 1. make asyncCallCounter final 2. add extra message for AsyncCallLimitExceededException 3. removed one-time call guarantee for Callable. I think we might need to keep ClientNamenodeProtocolTranslatorPB#RETURN_VALUE_CALLBACK. Without this, the logic on how to extract result from message has to be moved to AsyncDistributedFileSystem, which makes AsyncDistributedFileSystem quite heavy-weight.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          The error message "... Please configure IPC_CLIENT_ASYNC_CALLS_MAX_KEY ..." should change to "... Please configure " + CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_KEY + "...".

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - The error message "... Please configure IPC_CLIENT_ASYNC_CALLS_MAX_KEY ..." should change to "... Please configure " + CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_KEY + "...".
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          v007 fixed that, thanks.

          Show
          xiaobingo Xiaobing Zhou added a comment - v007 fixed that, thanks.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          +1 the 007 patch looks good.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - +1 the 007 patch looks good.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          v008 fixed a bug in error message of AsyncCallLimitExceededException.

          Show
          xiaobingo Xiaobing Zhou added a comment - v008 fixed a bug in error message of AsyncCallLimitExceededException.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          v009 adjust position of releaseAsyncCall in ipc.Client#call, e.g.

          if (isAsynchronousMode()) {
                Future<Writable> returnFuture = new AbstractFuture<Writable>() {
                  private final AtomicBoolean callled = new AtomicBoolean(false);
                  @Override
                  public Writable get() throws InterruptedException, ExecutionException {
                    if (callled.compareAndSet(false, true)) {
                      try {
                        set(getRpcResponse(call, connection));
                      } catch (IOException ie) {
                        setException(ie);
                      } finally {
                        releaseAsyncCall();
                      }
                    }
                    return super.get();
                  }
                };
          
          Show
          xiaobingo Xiaobing Zhou added a comment - v009 adjust position of releaseAsyncCall in ipc.Client#call, e.g. if (isAsynchronousMode()) { Future<Writable> returnFuture = new AbstractFuture<Writable>() { private final AtomicBoolean callled = new AtomicBoolean( false ); @Override public Writable get() throws InterruptedException, ExecutionException { if (callled.compareAndSet( false , true )) { try { set(getRpcResponse(call, connection)); } catch (IOException ie) { setException(ie); } finally { releaseAsyncCall(); } } return super .get(); } };
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 45s trunk passed
          +1 compile 6m 8s trunk passed with JDK v1.8.0_91
          +1 compile 6m 39s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 6s trunk passed
          +1 mvnsite 2m 25s trunk passed
          +1 mvneclipse 0m 40s trunk passed
          +1 findbugs 5m 5s trunk passed
          +1 javadoc 2m 21s trunk passed with JDK v1.8.0_91
          +1 javadoc 3m 11s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 59s the patch passed
          +1 compile 5m 58s the patch passed with JDK v1.8.0_91
          +1 javac 5m 58s the patch passed
          +1 compile 6m 49s the patch passed with JDK v1.7.0_95
          +1 javac 6m 49s the patch passed
          +1 checkstyle 1m 6s the patch passed
          +1 mvnsite 2m 20s the patch passed
          +1 mvneclipse 0m 40s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 55s hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          +1 javadoc 2m 19s the patch passed with JDK v1.8.0_91
          +1 javadoc 3m 17s the patch passed with JDK v1.7.0_95
          -1 unit 19m 17s hadoop-common in the patch failed with JDK v1.8.0_91.
          +1 unit 0m 54s hadoop-hdfs-client in the patch passed with JDK v1.8.0_91.
          -1 unit 59m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
          -1 unit 7m 19s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 54m 4s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 25s The patch does not generate ASF License warnings.
          209m 42s



          Reason Tests
          FindBugs module:hadoop-common-project/hadoop-common
            Argument of type String can't be handled by format specifier %d in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:be handled by format specifier %d in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:[line 1366]
            Format string should use %n rather than n in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:rather than n in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:[line 1366]
          JDK v1.8.0_91 Failed junit tests hadoop.ipc.TestAsyncIPC
            hadoop.hdfs.TestAsyncDFSRename
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.TestDFSUpgradeFromImage
          JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
          JDK v1.7.0_95 Failed junit tests hadoop.ipc.TestAsyncIPC
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.TestAsyncDFSRename



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801552/HADOOP-12957.008.patch
          JIRA Issue HADOOP-12957
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux fb2b94c5be78 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7da540d
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 45s trunk passed +1 compile 6m 8s trunk passed with JDK v1.8.0_91 +1 compile 6m 39s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 6s trunk passed +1 mvnsite 2m 25s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 5m 5s trunk passed +1 javadoc 2m 21s trunk passed with JDK v1.8.0_91 +1 javadoc 3m 11s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 59s the patch passed +1 compile 5m 58s the patch passed with JDK v1.8.0_91 +1 javac 5m 58s the patch passed +1 compile 6m 49s the patch passed with JDK v1.7.0_95 +1 javac 6m 49s the patch passed +1 checkstyle 1m 6s the patch passed +1 mvnsite 2m 20s the patch passed +1 mvneclipse 0m 40s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 55s hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 2m 19s the patch passed with JDK v1.8.0_91 +1 javadoc 3m 17s the patch passed with JDK v1.7.0_95 -1 unit 19m 17s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 0m 54s hadoop-hdfs-client in the patch passed with JDK v1.8.0_91. -1 unit 59m 43s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 7m 19s hadoop-common in the patch failed with JDK v1.7.0_95. +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 54m 4s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 209m 42s Reason Tests FindBugs module:hadoop-common-project/hadoop-common   Argument of type String can't be handled by format specifier %d in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:be handled by format specifier %d in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java: [line 1366]   Format string should use %n rather than n in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:rather than n in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java: [line 1366] JDK v1.8.0_91 Failed junit tests hadoop.ipc.TestAsyncIPC   hadoop.hdfs.TestAsyncDFSRename   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestDFSUpgradeFromImage JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_95 Failed junit tests hadoop.ipc.TestAsyncIPC   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestAsyncDFSRename Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801552/HADOOP-12957.008.patch JIRA Issue HADOOP-12957 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fb2b94c5be78 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7da540d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9235/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 3m 13s Maven dependency ordering for branch
          +1 mvninstall 7m 38s trunk passed
          +1 compile 7m 55s trunk passed with JDK v1.8.0_91
          +1 compile 6m 44s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 12s trunk passed
          +1 mvnsite 2m 28s trunk passed
          +1 mvneclipse 0m 49s trunk passed
          +1 findbugs 5m 25s trunk passed
          +1 javadoc 2m 24s trunk passed with JDK v1.8.0_91
          +1 javadoc 3m 17s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 20s Maven dependency ordering for patch
          +1 mvninstall 2m 5s the patch passed
          +1 compile 6m 22s the patch passed with JDK v1.8.0_91
          +1 javac 6m 22s the patch passed
          +1 compile 6m 37s the patch passed with JDK v1.7.0_95
          +1 javac 6m 37s the patch passed
          +1 checkstyle 1m 5s the patch passed
          +1 mvnsite 2m 21s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 50s hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          +1 javadoc 2m 16s the patch passed with JDK v1.8.0_91
          +1 javadoc 3m 16s the patch passed with JDK v1.7.0_95
          -1 unit 6m 27s hadoop-common in the patch failed with JDK v1.8.0_91.
          +1 unit 0m 51s hadoop-hdfs-client in the patch passed with JDK v1.8.0_91.
          -1 unit 56m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
          -1 unit 7m 1s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 unit 1m 1s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 54m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          200m 40s



          Reason Tests
          FindBugs module:hadoop-common-project/hadoop-common
            Argument of type String can't be handled by format specifier %d in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:be handled by format specifier %d in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:[line 1366]
            Format string should use %n rather than n in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:rather than n in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:[line 1366]
          JDK v1.8.0_91 Failed junit tests hadoop.ipc.TestAsyncIPC
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.namenode.TestCheckpoint
            hadoop.hdfs.TestAsyncDFSRename
          JDK v1.7.0_95 Failed junit tests hadoop.ipc.TestAsyncIPC
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.TestAsyncDFSRename



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801552/HADOOP-12957.008.patch
          JIRA Issue HADOOP-12957
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 025dbfa2c96d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7da540d
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 3m 13s Maven dependency ordering for branch +1 mvninstall 7m 38s trunk passed +1 compile 7m 55s trunk passed with JDK v1.8.0_91 +1 compile 6m 44s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 12s trunk passed +1 mvnsite 2m 28s trunk passed +1 mvneclipse 0m 49s trunk passed +1 findbugs 5m 25s trunk passed +1 javadoc 2m 24s trunk passed with JDK v1.8.0_91 +1 javadoc 3m 17s trunk passed with JDK v1.7.0_95 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 2m 5s the patch passed +1 compile 6m 22s the patch passed with JDK v1.8.0_91 +1 javac 6m 22s the patch passed +1 compile 6m 37s the patch passed with JDK v1.7.0_95 +1 javac 6m 37s the patch passed +1 checkstyle 1m 5s the patch passed +1 mvnsite 2m 21s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 50s hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 2m 16s the patch passed with JDK v1.8.0_91 +1 javadoc 3m 16s the patch passed with JDK v1.7.0_95 -1 unit 6m 27s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 0m 51s hadoop-hdfs-client in the patch passed with JDK v1.8.0_91. -1 unit 56m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 7m 1s hadoop-common in the patch failed with JDK v1.7.0_95. +1 unit 1m 1s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 54m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 200m 40s Reason Tests FindBugs module:hadoop-common-project/hadoop-common   Argument of type String can't be handled by format specifier %d in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:be handled by format specifier %d in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java: [line 1366]   Format string should use %n rather than n in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:rather than n in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java: [line 1366] JDK v1.8.0_91 Failed junit tests hadoop.ipc.TestAsyncIPC   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.namenode.TestCheckpoint   hadoop.hdfs.TestAsyncDFSRename JDK v1.7.0_95 Failed junit tests hadoop.ipc.TestAsyncIPC   hadoop.hdfs.TestHFlush   hadoop.hdfs.TestAsyncDFSRename Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801552/HADOOP-12957.008.patch JIRA Issue HADOOP-12957 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 025dbfa2c96d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7da540d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9237/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 38s Maven dependency ordering for branch
          +1 mvninstall 6m 47s trunk passed
          +1 compile 5m 52s trunk passed with JDK v1.8.0_92
          +1 compile 6m 40s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 6s trunk passed
          +1 mvnsite 2m 25s trunk passed
          +1 mvneclipse 0m 43s trunk passed
          +1 findbugs 5m 29s trunk passed
          +1 javadoc 2m 17s trunk passed with JDK v1.8.0_92
          +1 javadoc 3m 15s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 2m 1s the patch passed
          +1 compile 5m 55s the patch passed with JDK v1.8.0_92
          +1 javac 5m 55s the patch passed
          +1 compile 6m 52s the patch passed with JDK v1.7.0_95
          +1 javac 6m 52s the patch passed
          +1 checkstyle 1m 7s the patch passed
          +1 mvnsite 2m 23s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 54s hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 2m 18s the patch passed with JDK v1.8.0_92
          +1 javadoc 3m 15s the patch passed with JDK v1.7.0_95
          +1 unit 7m 40s hadoop-common in the patch passed with JDK v1.8.0_92.
          +1 unit 0m 53s hadoop-hdfs-client in the patch passed with JDK v1.8.0_92.
          -1 unit 56m 50s hadoop-hdfs in the patch failed with JDK v1.8.0_92.
          +1 unit 7m 46s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 55m 35s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 36s The patch does not generate ASF License warnings.
          198m 3s



          Reason Tests
          FindBugs module:hadoop-common-project/hadoop-common
            Format string should use %n rather than n in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:rather than n in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:[line 1366]
          JDK v1.8.0_92 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.TestHFlush



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801567/HADOOP-12957.009.patch
          JIRA Issue HADOOP-12957
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d78f4b5b5f52 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7da540d
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 38s Maven dependency ordering for branch +1 mvninstall 6m 47s trunk passed +1 compile 5m 52s trunk passed with JDK v1.8.0_92 +1 compile 6m 40s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 6s trunk passed +1 mvnsite 2m 25s trunk passed +1 mvneclipse 0m 43s trunk passed +1 findbugs 5m 29s trunk passed +1 javadoc 2m 17s trunk passed with JDK v1.8.0_92 +1 javadoc 3m 15s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 2m 1s the patch passed +1 compile 5m 55s the patch passed with JDK v1.8.0_92 +1 javac 5m 55s the patch passed +1 compile 6m 52s the patch passed with JDK v1.7.0_95 +1 javac 6m 52s the patch passed +1 checkstyle 1m 7s the patch passed +1 mvnsite 2m 23s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 54s hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 2m 18s the patch passed with JDK v1.8.0_92 +1 javadoc 3m 15s the patch passed with JDK v1.7.0_95 +1 unit 7m 40s hadoop-common in the patch passed with JDK v1.8.0_92. +1 unit 0m 53s hadoop-hdfs-client in the patch passed with JDK v1.8.0_92. -1 unit 56m 50s hadoop-hdfs in the patch failed with JDK v1.8.0_92. +1 unit 7m 46s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 55m 35s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 198m 3s Reason Tests FindBugs module:hadoop-common-project/hadoop-common   Format string should use %n rather than n in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java:rather than n in org.apache.hadoop.ipc.Client.checkAsyncCall() At Client.java: [line 1366] JDK v1.8.0_92 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801567/HADOOP-12957.009.patch JIRA Issue HADOOP-12957 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d78f4b5b5f52 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7da540d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9238/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          There is a findbugs warning "Format string should use %n rather than \n in org.apache.hadoop.ipc.Client.checkAsyncCall() ...". Please take a look.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - There is a findbugs warning "Format string should use %n rather than \n in org.apache.hadoop.ipc.Client.checkAsyncCall() ...". Please take a look.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          The previous format string is fine, but FindBugs just mistakingly thinks '%d\n' as '%n'. Patch v010 is posted to have the change:

          String errMsg = String.format(
                      "Exceeded limit of max asynchronous calls: %d, " +
                      "please configure %s to adjust it.",
                      CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_DEFAULT,
                      CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_KEY);
          

          Thank you for review.

          Show
          xiaobingo Xiaobing Zhou added a comment - The previous format string is fine, but FindBugs just mistakingly thinks '%d\n' as '%n'. Patch v010 is posted to have the change: String errMsg = String .format( "Exceeded limit of max asynchronous calls: %d, " + "please configure %s to adjust it." , CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_DEFAULT, CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_KEY); Thank you for review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 1m 11s Maven dependency ordering for branch
          +1 mvninstall 6m 29s trunk passed
          +1 compile 5m 40s trunk passed with JDK v1.8.0_92
          +1 compile 6m 36s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 6s trunk passed
          +1 mvnsite 2m 23s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 5m 8s trunk passed
          +1 javadoc 2m 18s trunk passed with JDK v1.8.0_92
          +1 javadoc 3m 13s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 57s the patch passed
          +1 compile 5m 36s the patch passed with JDK v1.8.0_92
          +1 javac 5m 36s the patch passed
          +1 compile 6m 35s the patch passed with JDK v1.7.0_95
          +1 javac 6m 35s the patch passed
          +1 checkstyle 1m 6s the patch passed
          +1 mvnsite 2m 19s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 5m 48s the patch passed
          +1 javadoc 2m 17s the patch passed with JDK v1.8.0_92
          +1 javadoc 3m 11s the patch passed with JDK v1.7.0_95
          -1 unit 16m 51s hadoop-common in the patch failed with JDK v1.8.0_92.
          +1 unit 0m 49s hadoop-hdfs-client in the patch passed with JDK v1.8.0_92.
          -1 unit 56m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_92.
          +1 unit 8m 3s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 53m 13s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 25s The patch does not generate ASF License warnings.
          203m 17s



          Reason Tests
          JDK v1.8.0_92 Failed junit tests hadoop.hdfs.TestHFlush
            hadoop.hdfs.TestDFSUpgradeFromImage
          JDK v1.8.0_92 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801631/HADOOP-12957.010.patch
          JIRA Issue HADOOP-12957
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 39737bb1f0e8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 971af60
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 1m 11s Maven dependency ordering for branch +1 mvninstall 6m 29s trunk passed +1 compile 5m 40s trunk passed with JDK v1.8.0_92 +1 compile 6m 36s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 6s trunk passed +1 mvnsite 2m 23s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 5m 8s trunk passed +1 javadoc 2m 18s trunk passed with JDK v1.8.0_92 +1 javadoc 3m 13s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 57s the patch passed +1 compile 5m 36s the patch passed with JDK v1.8.0_92 +1 javac 5m 36s the patch passed +1 compile 6m 35s the patch passed with JDK v1.7.0_95 +1 javac 6m 35s the patch passed +1 checkstyle 1m 6s the patch passed +1 mvnsite 2m 19s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 48s the patch passed +1 javadoc 2m 17s the patch passed with JDK v1.8.0_92 +1 javadoc 3m 11s the patch passed with JDK v1.7.0_95 -1 unit 16m 51s hadoop-common in the patch failed with JDK v1.8.0_92. +1 unit 0m 49s hadoop-hdfs-client in the patch passed with JDK v1.8.0_92. -1 unit 56m 45s hadoop-hdfs in the patch failed with JDK v1.8.0_92. +1 unit 8m 3s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 53m 13s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 203m 17s Reason Tests JDK v1.8.0_92 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.TestDFSUpgradeFromImage JDK v1.8.0_92 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801631/HADOOP-12957.010.patch JIRA Issue HADOOP-12957 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 39737bb1f0e8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 971af60 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9240/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          The previous format string is fine, but FindBugs just mistakingly thinks '%d\n' as '%n'. Patch v010 is posted to have the change:

          String errMsg = String.format(
                      "Exceeded limit of max asynchronous calls: %d, " +
                      "please configure %s to adjust it.",
                      CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_DEFAULT,
                      CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_KEY);
          

          The findbugs warning indeed says that we should use "%n" and avoid using "\n" since "%n" is the platform-specific line separator; see http://docs.oracle.com/javase/7/docs/api/java/util/Formatter.html . Anyway, removing it is good.

          BTW, we should print out the configured value but not the default value, i.e. CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_DEFAULT should be replaced by maxAsyncCalls.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - The previous format string is fine, but FindBugs just mistakingly thinks '%d\n' as '%n'. Patch v010 is posted to have the change: String errMsg = String .format( "Exceeded limit of max asynchronous calls: %d, " + "please configure %s to adjust it." , CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_DEFAULT, CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_KEY); The findbugs warning indeed says that we should use "%n" and avoid using "\n" since "%n" is the platform-specific line separator; see http://docs.oracle.com/javase/7/docs/api/java/util/Formatter.html . Anyway, removing it is good. BTW, we should print out the configured value but not the default value, i.e. CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_DEFAULT should be replaced by maxAsyncCalls.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          v001 is posted to fix that, thanks.

          Show
          xiaobingo Xiaobing Zhou added a comment - v001 is posted to fix that, thanks.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Sorry for typo, should be v011.

          Show
          xiaobingo Xiaobing Zhou added a comment - Sorry for typo, should be v011.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 2m 13s Maven dependency ordering for branch
          +1 mvninstall 6m 26s trunk passed
          +1 compile 5m 36s trunk passed with JDK v1.8.0_92
          +1 compile 6m 34s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 7s trunk passed
          +1 mvnsite 2m 23s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 5m 4s trunk passed
          +1 javadoc 2m 17s trunk passed with JDK v1.8.0_92
          +1 javadoc 3m 16s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 57s the patch passed
          +1 compile 5m 36s the patch passed with JDK v1.8.0_92
          +1 javac 5m 36s the patch passed
          +1 compile 6m 34s the patch passed with JDK v1.7.0_95
          +1 javac 6m 34s the patch passed
          +1 checkstyle 1m 6s the patch passed
          +1 mvnsite 2m 20s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 5m 50s the patch passed
          +1 javadoc 2m 18s the patch passed with JDK v1.8.0_92
          +1 javadoc 3m 15s the patch passed with JDK v1.7.0_95
          -1 unit 7m 21s hadoop-common in the patch failed with JDK v1.8.0_92.
          +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_92.
          -1 unit 57m 25s hadoop-hdfs in the patch failed with JDK v1.8.0_92.
          +1 unit 8m 4s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 53m 25s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          195m 46s



          Reason Tests
          JDK v1.8.0_92 Failed junit tests hadoop.net.TestDNS
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.TestHFlush
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.qjournal.TestSecureNNWithQJM



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801684/HADOOP-12957.011.patch
          JIRA Issue HADOOP-12957
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 674f3dafd82e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 971af60
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 2m 13s Maven dependency ordering for branch +1 mvninstall 6m 26s trunk passed +1 compile 5m 36s trunk passed with JDK v1.8.0_92 +1 compile 6m 34s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 7s trunk passed +1 mvnsite 2m 23s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 5m 4s trunk passed +1 javadoc 2m 17s trunk passed with JDK v1.8.0_92 +1 javadoc 3m 16s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 57s the patch passed +1 compile 5m 36s the patch passed with JDK v1.8.0_92 +1 javac 5m 36s the patch passed +1 compile 6m 34s the patch passed with JDK v1.7.0_95 +1 javac 6m 34s the patch passed +1 checkstyle 1m 6s the patch passed +1 mvnsite 2m 20s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 50s the patch passed +1 javadoc 2m 18s the patch passed with JDK v1.8.0_92 +1 javadoc 3m 15s the patch passed with JDK v1.7.0_95 -1 unit 7m 21s hadoop-common in the patch failed with JDK v1.8.0_92. +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_92. -1 unit 57m 25s hadoop-hdfs in the patch failed with JDK v1.8.0_92. +1 unit 8m 4s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 1m 0s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 53m 25s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 195m 46s Reason Tests JDK v1.8.0_92 Failed junit tests hadoop.net.TestDNS   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.TestHFlush JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.qjournal.TestSecureNNWithQJM Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801684/HADOOP-12957.011.patch JIRA Issue HADOOP-12957 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 674f3dafd82e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 971af60 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_92.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9247/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          +1 the 011 patch looks good.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - +1 the 011 patch looks good.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Xiaobing!

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Xiaobing!
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Thank you Tsz Wo Nicholas Sze for the long list of reviews!

          Show
          xiaobingo Xiaobing Zhou added a comment - Thank you Tsz Wo Nicholas Sze for the long list of reviews!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9701 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9701/)
          HADOOP-12957. Limit the number of outstanding async calls. Contributed (szetszwo: rev 1b9f18623ab55507bea94888317c7d63d0f4a6f2)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAsyncDFSRename.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/AsyncCallLimitExceededException.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/AsyncDistributedFileSystem.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestAsyncIPC.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9701 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9701/ ) HADOOP-12957 . Limit the number of outstanding async calls. Contributed (szetszwo: rev 1b9f18623ab55507bea94888317c7d63d0f4a6f2) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAsyncDFSRename.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/AsyncCallLimitExceededException.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/AsyncDistributedFileSystem.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestAsyncIPC.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9913 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9913/)
          Revert "HADOOP-12957. Limit the number of outstanding async calls. (wang: rev 4d36b221a24e3b626bb91093b0bb0fd377061cae)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/AsyncDistributedFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestAsyncIPC.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/AsyncCallLimitExceededException.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAsyncDFSRename.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9913 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9913/ ) Revert " HADOOP-12957 . Limit the number of outstanding async calls. (wang: rev 4d36b221a24e3b626bb91093b0bb0fd377061cae) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/AsyncDistributedFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestAsyncIPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/AsyncCallLimitExceededException.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestAsyncDFSRename.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java

            People

            • Assignee:
              xiaobingo Xiaobing Zhou
              Reporter:
              xiaobingo Xiaobing Zhou
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development