Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12954

Add a way to change hadoop.security.token.service.use_ip

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Currently, hadoop.security.token.service.use_ip is set on JVM startup via:

        static {
          Configuration conf = new Configuration();
          boolean useIp = conf.getBoolean(
              CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP,
              CommonConfigurationKeys.HADOOP_SECURITY_TOKEN_SERVICE_USE_IP_DEFAULT);
          setTokenServiceUseIp(useIp);
        }
      

      This is a problem for clients, such as Oozie, who don't add *-site.xml files to their classpath. Oozie normally creates a JobClient and passes a Configuration to it with the proper configs we need. However, because hadoop.security.token.service.use_ip is specified in a static block like this, and there's no API to change it, Oozie has no way to set it to the non-default value.

      I propose we add a setConfiguration method which takes a Configuration and rereads hadoop.security.token.service.use_ip. There's a few other properties that are also loaded statically on startup that can be reloaded here as well.

      1. HADOOP-12954.001.patch
        5 kB
        Robert Kanter
      2. HADOOP-12954.002.patch
        5 kB
        Robert Kanter
      3. HADOOP-12954.003.patch
        5 kB
        Robert Kanter

        Issue Links

          Activity

          Hide
          cnauroth Chris Nauroth added a comment -

          Hi Robert Kanter. Is this a duplicate of MAPREDUCE-6565?

          Show
          cnauroth Chris Nauroth added a comment - Hi Robert Kanter . Is this a duplicate of MAPREDUCE-6565 ?
          Hide
          rkanter Robert Kanter added a comment -

          The end problems were different, but it's the same root cause: hadoop.security.token.service.use_ip is initialized from the classpath and core-site.xml isn't there.

          I think my proposal should work to solve both problems. The Oozie server can call SecurityUtil.setConfiguration(conf) to pass the Configuration it loaded. The MR AM could do the same. Though for MAPREDUCE-6565, why can't you have a core-site.xml added via mapreduce.application.classpath?

          Show
          rkanter Robert Kanter added a comment - The end problems were different, but it's the same root cause: hadoop.security.token.service.use_ip is initialized from the classpath and core-site.xml isn't there. I think my proposal should work to solve both problems. The Oozie server can call SecurityUtil.setConfiguration(conf) to pass the Configuration it loaded. The MR AM could do the same. Though for MAPREDUCE-6565 , why can't you have a core-site.xml added via mapreduce.application.classpath ?
          Hide
          cnauroth Chris Nauroth added a comment -

          Thanks, Robert. I think this makes sense. I guess the new SecurityUtil#setConfiguration call would have to be wired into the MR AM. If you weren't planning on doing that within the scope of this issue, then maybe it makes more sense to keep both open instead of resolving one as duplicate of another.

          Though for MAPREDUCE-6565, why can't you have a core-site.xml added via mapreduce.application.classpath?

          You can, but when I filed MAPREDUCE-6565, I was asserting that you shouldn't have to do this. The behavior is different from a lot of other things in that the correct value of use_ip doesn't propagate down via the submitted job.xml.

          Show
          cnauroth Chris Nauroth added a comment - Thanks, Robert. I think this makes sense. I guess the new SecurityUtil#setConfiguration call would have to be wired into the MR AM. If you weren't planning on doing that within the scope of this issue, then maybe it makes more sense to keep both open instead of resolving one as duplicate of another. Though for MAPREDUCE-6565 , why can't you have a core-site.xml added via mapreduce.application.classpath? You can, but when I filed MAPREDUCE-6565 , I was asserting that you shouldn't have to do this. The behavior is different from a lot of other things in that the correct value of use_ip doesn't propagate down via the submitted job.xml.
          Hide
          rkanter Robert Kanter added a comment -

          Ya, let's leave them both open. This is a Common change and the MR AM would be in MapReduce, so we'd need to JIRAs anyway. We can add the setConfiguration method in this JIRA and use MAPREDUCE-6565 to call it (similar to what OOZIE-2490 is for).

          Show
          rkanter Robert Kanter added a comment - Ya, let's leave them both open. This is a Common change and the MR AM would be in MapReduce, so we'd need to JIRAs anyway. We can add the setConfiguration method in this JIRA and use MAPREDUCE-6565 to call it (similar to what OOZIE-2490 is for).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 44s trunk passed
          +1 compile 9m 48s trunk passed with JDK v1.8.0_74
          +1 compile 7m 47s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 1s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 36s trunk passed
          +1 javadoc 1m 5s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 45s the patch passed
          +1 compile 8m 36s the patch passed with JDK v1.8.0_74
          +1 javac 8m 36s the patch passed
          +1 compile 7m 47s the patch passed with JDK v1.7.0_95
          +1 javac 7m 47s the patch passed
          +1 checkstyle 0m 21s the patch passed
          +1 mvnsite 0m 59s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 1s the patch passed
          +1 javadoc 1m 13s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 15s the patch passed with JDK v1.7.0_95
          -1 unit 13m 59s hadoop-common in the patch failed with JDK v1.8.0_74.
          -1 unit 9m 27s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 22s Patch generated 2 ASF License warnings.
          79m 3s



          Reason Tests
          JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794885/HADOOP-12954.001.patch
          JIRA Issue HADOOP-12954
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 76aff2f7e08a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0bfe5a0
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 44s trunk passed +1 compile 9m 48s trunk passed with JDK v1.8.0_74 +1 compile 7m 47s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 36s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 8m 36s the patch passed with JDK v1.8.0_74 +1 javac 8m 36s the patch passed +1 compile 7m 47s the patch passed with JDK v1.7.0_95 +1 javac 7m 47s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 1s the patch passed +1 javadoc 1m 13s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 15s the patch passed with JDK v1.7.0_95 -1 unit 13m 59s hadoop-common in the patch failed with JDK v1.8.0_74. -1 unit 9m 27s hadoop-common in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 22s Patch generated 2 ASF License warnings. 79m 3s Reason Tests JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794885/HADOOP-12954.001.patch JIRA Issue HADOOP-12954 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 76aff2f7e08a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0bfe5a0 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8902/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          rkanter Robert Kanter added a comment -

          License warnings and unit test failures are unrelated

          Show
          rkanter Robert Kanter added a comment - License warnings and unit test failures are unrelated
          Hide
          stevel@apache.org Steve Loughran added a comment -

          What's going to happen if this method is called during the execution of a service?

          I'd propose having an inner and and outer method, with the outer one logging (info?) that this update has happened, The inner one would be the one used at startup

          Show
          stevel@apache.org Steve Loughran added a comment - What's going to happen if this method is called during the execution of a service? I'd propose having an inner and and outer method, with the outer one logging (info?) that this update has happened, The inner one would be the one used at startup
          Hide
          rkanter Robert Kanter added a comment -

          The 002 patch adds a log message that only happens when called after the static block

          Show
          rkanter Robert Kanter added a comment - The 002 patch adds a log message that only happens when called after the static block
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 10s trunk passed
          +1 compile 6m 46s trunk passed with JDK v1.8.0_74
          +1 compile 7m 55s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 1m 9s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 42s trunk passed
          +1 javadoc 0m 57s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 8s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 46s the patch passed
          +1 compile 6m 46s the patch passed with JDK v1.8.0_74
          +1 javac 6m 46s the patch passed
          +1 compile 7m 32s the patch passed with JDK v1.7.0_95
          +1 javac 7m 32s the patch passed
          +1 checkstyle 0m 26s the patch passed
          +1 mvnsite 1m 8s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 2s the patch passed
          +1 javadoc 1m 4s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 18s the patch passed with JDK v1.7.0_95
          -1 unit 7m 31s hadoop-common in the patch failed with JDK v1.8.0_74.
          -1 unit 7m 41s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 36s Patch generated 2 ASF License warnings.
          67m 12s



          Reason Tests
          JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795070/HADOOP-12954.002.patch
          JIRA Issue HADOOP-12954
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ae673bea6f5e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 938222b
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 10s trunk passed +1 compile 6m 46s trunk passed with JDK v1.8.0_74 +1 compile 7m 55s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 25s trunk passed +1 mvnsite 1m 9s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 57s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 8s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 6m 46s the patch passed with JDK v1.8.0_74 +1 javac 6m 46s the patch passed +1 compile 7m 32s the patch passed with JDK v1.7.0_95 +1 javac 7m 32s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 2s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 18s the patch passed with JDK v1.7.0_95 -1 unit 7m 31s hadoop-common in the patch failed with JDK v1.8.0_74. -1 unit 7m 41s hadoop-common in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 36s Patch generated 2 ASF License warnings. 67m 12s Reason Tests JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795070/HADOOP-12954.002.patch JIRA Issue HADOOP-12954 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ae673bea6f5e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 938222b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8907/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Can we have some log@ debug mention that the IP flag has been set?

          Show
          stevel@apache.org Steve Loughran added a comment - Can we have some log@ debug mention that the IP flag has been set?
          Hide
          rkanter Robert Kanter added a comment -

          The 003 patch adds a debug log message when the IP flag is set

          Show
          rkanter Robert Kanter added a comment - The 003 patch adds a debug log message when the IP flag is set
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 34s trunk passed
          +1 compile 11m 42s trunk passed with JDK v1.8.0_74
          +1 compile 10m 11s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 1m 21s trunk passed
          +1 mvneclipse 0m 22s trunk passed
          +1 findbugs 2m 7s trunk passed
          +1 javadoc 1m 26s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 32s trunk passed with JDK v1.7.0_95
          +1 mvninstall 1m 1s the patch passed
          +1 compile 11m 40s the patch passed with JDK v1.8.0_74
          +1 javac 11m 40s the patch passed
          +1 compile 10m 16s the patch passed with JDK v1.7.0_95
          +1 javac 10m 16s the patch passed
          +1 checkstyle 0m 31s the patch passed
          +1 mvnsite 1m 19s the patch passed
          +1 mvneclipse 0m 19s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 24s the patch passed
          +1 javadoc 1m 24s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 31s the patch passed with JDK v1.7.0_95
          -1 unit 10m 40s hadoop-common in the patch failed with JDK v1.8.0_74.
          -1 unit 9m 55s hadoop-common in the patch failed with JDK v1.7.0_95.
          -1 asflicense 0m 35s Patch generated 2 ASF License warnings.
          92m 24s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.ipc.TestRPCWaitForProxy
            hadoop.fs.shell.find.TestIname
          JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker
          JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795436/HADOOP-12954.003.patch
          JIRA Issue HADOOP-12954
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d7829f319579 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2c268cc
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 34s trunk passed +1 compile 11m 42s trunk passed with JDK v1.8.0_74 +1 compile 10m 11s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 21s trunk passed +1 mvneclipse 0m 22s trunk passed +1 findbugs 2m 7s trunk passed +1 javadoc 1m 26s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 32s trunk passed with JDK v1.7.0_95 +1 mvninstall 1m 1s the patch passed +1 compile 11m 40s the patch passed with JDK v1.8.0_74 +1 javac 11m 40s the patch passed +1 compile 10m 16s the patch passed with JDK v1.7.0_95 +1 javac 10m 16s the patch passed +1 checkstyle 0m 31s the patch passed +1 mvnsite 1m 19s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 24s the patch passed +1 javadoc 1m 24s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 31s the patch passed with JDK v1.7.0_95 -1 unit 10m 40s hadoop-common in the patch failed with JDK v1.8.0_74. -1 unit 9m 55s hadoop-common in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 35s Patch generated 2 ASF License warnings. 92m 24s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.ipc.TestRPCWaitForProxy   hadoop.fs.shell.find.TestIname JDK v1.8.0_74 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.util.TestNativeLibraryChecker Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795436/HADOOP-12954.003.patch JIRA Issue HADOOP-12954 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d7829f319579 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2c268cc Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8929/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          rkanter Robert Kanter added a comment -

          License warnings and unit test failures are unrelated

          Show
          rkanter Robert Kanter added a comment - License warnings and unit test failures are unrelated
          Hide
          stevel@apache.org Steve Loughran added a comment -

          LGTM: +1

          Show
          stevel@apache.org Steve Loughran added a comment - LGTM: +1
          Hide
          rkanter Robert Kanter added a comment -

          Thanks for the review Steve. Committed to trunk and branch-2!

          Show
          rkanter Robert Kanter added a comment - Thanks for the review Steve. Committed to trunk and branch-2!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9513 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9513/)
          HADOOP-12954. Add a way to change hadoop.security.token.service.use_ip (rkanter: rev 8cac1bb09f55ff2f285914e349507472ff86f4d7)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestSecurityUtil.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9513 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9513/ ) HADOOP-12954 . Add a way to change hadoop.security.token.service.use_ip (rkanter: rev 8cac1bb09f55ff2f285914e349507472ff86f4d7) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestSecurityUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java
          Hide
          djp Junping Du added a comment -

          Hi Robert and Steve, do we want to backport this issue to 2.8 as well?

          Show
          djp Junping Du added a comment - Hi Robert and Steve, do we want to backport this issue to 2.8 as well?
          Hide
          rkanter Robert Kanter added a comment -

          Seems like a good idea to me.

          Show
          rkanter Robert Kanter added a comment - Seems like a good idea to me.

            People

            • Assignee:
              rkanter Robert Kanter
              Reporter:
              rkanter Robert Kanter
            • Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development