Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Some code is used only by tests. Let's relocate them.

      1. c12923_20160314.patch
        26 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        c12923_20160314.patch: 1st patch.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - c12923_20160314.patch: 1st patch.
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Tsz Wo Nicholas Sze for working on this. The change looks good to me. +1 pending Jenkins.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Tsz Wo Nicholas Sze for working on this. The change looks good to me. +1 pending Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 7m 10s trunk passed
        +1 compile 7m 41s trunk passed with JDK v1.8.0_74
        +1 compile 7m 14s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 59s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 39s trunk passed
        +1 javadoc 1m 0s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 8s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 44s the patch passed
        +1 compile 7m 41s the patch passed with JDK v1.8.0_74
        +1 javac 7m 41s the patch passed
        +1 compile 7m 12s the patch passed with JDK v1.7.0_95
        +1 javac 7m 12s the patch passed
        +1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 0 new + 138 unchanged - 7 fixed = 138 total (was 145)
        +1 mvnsite 0m 57s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 54s the patch passed
        +1 javadoc 0m 59s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95
        +1 unit 8m 29s hadoop-common in the patch passed with JDK v1.8.0_74.
        +1 unit 8m 13s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        66m 55s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793369/c12923_20160314.patch
        JIRA Issue HADOOP-12923
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux dae84b4d98b5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5644137
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8847/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8847/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 10s trunk passed +1 compile 7m 41s trunk passed with JDK v1.8.0_74 +1 compile 7m 14s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 39s trunk passed +1 javadoc 1m 0s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 8s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 7m 41s the patch passed with JDK v1.8.0_74 +1 javac 7m 41s the patch passed +1 compile 7m 12s the patch passed with JDK v1.7.0_95 +1 javac 7m 12s the patch passed +1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 0 new + 138 unchanged - 7 fixed = 138 total (was 145) +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 54s the patch passed +1 javadoc 0m 59s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95 +1 unit 8m 29s hadoop-common in the patch passed with JDK v1.8.0_74. +1 unit 8m 13s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 66m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793369/c12923_20160314.patch JIRA Issue HADOOP-12923 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dae84b4d98b5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5644137 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8847/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8847/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        Thanks Xiaoyu Yao for reviewing the patch.

        I have committed this.

        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - Thanks Xiaoyu Yao for reviewing the patch. I have committed this.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9461 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9461/)
        HADOOP-12923. Move the test code in ipc.Client to test. (szetszwo: rev 1898810cda83e6d273a2963b56ed499c0fb91118)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9461 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9461/ ) HADOOP-12923 . Move the test code in ipc.Client to test. (szetszwo: rev 1898810cda83e6d273a2963b56ed499c0fb91118) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java

          People

          • Assignee:
            szetszwo Tsz Wo Nicholas Sze
            Reporter:
            szetszwo Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development