Thanks for the review!
it worked except for needing to change /usr/bin/bash to /bin/bash in the two scripts. Or should we be using /usr/bin/env to find bash instead?
I'll modify to use env.
"yetus_abs" doesn't seem yetus specific, rename to something more generic?
Sure. (At some point, I'm planning on making all of Hadoop's shell code dependent upon the yetus bash library so that I've got all the code in one place... especially since most of the performance enhancements will likely go there first since it's easier for me to get code committed there.)
set_defaults_part1 does some grepping to determine maven variables, can also do that with the help plugin:
I thought about doing it that way, but the bash way is significantly faster due to no JVM overhead. But I can change it if people want.
What does the -Papache-release profile do?
It's part of the maven-release-plugin. I popped it in there as I want to try and use it to generate signed jars, fix version numbers, etc during the build process. That's a work in progress.
If this is generating signatures, then it'd be good to adjust the success message to also indicate the paths.
apache-release (or using --sign option) should be triggering a signing phase. Agreed that the script should probably remind the user where --artifactsdir is located.
typo for imgname in dockermode: "createrelase" -> "createrelease"
do you think there is anything important feature-wise that is still missing?
Yes. I absolutely must fix the maven cache problem. Any sort of parallel maven builds have race conditions. This means that there is a potential of incorrect release artifacts since Hadoop switched to maven and almost with 100% certainty since a) Hadoop release instructions moved to building on Jenkins and b) parallel builds were enabled on Jenkins in late 2014. (This means that releases made since about 2.6.0 are highly suspect. Whee!) One of the key reasons I added the docker support was to make it easier to force RMs into a pseudo-protected customized environment. Now I just need to complete that work.