Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12888

Shell to disable bash and setsid support when running under JVM security manager

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Environment:

      Linux

      Description

      HDFS client requires dangerous permission, in particular execute on all files despite only trying to connect to an HDFS cluster.

      A full list (for both Hadoop 1 and 2) is available here along with the place in code where they occur.
      While it is understandable for some permissions to be used, requiring FilePermission <<ALL FILES>> execute to simply initialize a class field Shell which in the end is not used (since it's just a client) simply compromises the entire security system.

      To make matters worse, the code is executed to initialize a field so in case the permissions is not granted, the VM fails with InitializationError which is unrecoverable.
      Ironically enough, on Windows this problem does not appear since the code simply bypasses it and initializes the field with a fall back value (false).

      A quick fix would be to simply take into account that the JVM SecurityManager might be active and the permission not granted or that the external process fails and use a fall back value.
      A proper and long-term fix would be to minimize the use of permissions for hdfs client since it is simply not required. A client should be as light as possible and not have the server requirements leaked onto.

      1. HADOOP-12888-001.patch
        2 kB
        Costin Leau
      2. HADOOP-12888-002.patch
        2 kB
        Costin Leau
      3. HADOOP-12888-003.patch
        2 kB
        Costin Leau

        Activity

        Hide
        stevel@apache.org Steve Loughran added a comment -

        Hadoop is notoriously bad for security manager support (See HADOOP-5731) ... though being able to go securely client-side would be good. As you note: server-side requirements shouldn't impact client side.

        1. what happens if you try to use webhdfs rather than hdfs:// ?
        2. show us the stack trace?

        Shell is used client-side to detect OS, there is a languishing patch to isolate OS checks...someone needs to refresh that patch and we can get it into trunk. It's also critical on windows.

        Which field is causing the problem?

        Show
        stevel@apache.org Steve Loughran added a comment - Hadoop is notoriously bad for security manager support (See HADOOP-5731 ) ... though being able to go securely client-side would be good. As you note: server-side requirements shouldn't impact client side. what happens if you try to use webhdfs rather than hdfs:// ? show us the stack trace? Shell is used client-side to detect OS, there is a languishing patch to isolate OS checks...someone needs to refresh that patch and we can get it into trunk. It's also critical on windows. Which field is causing the problem?
        Hide
        costin Costin Leau added a comment -

        1. I haven't tried {webhdfs}} simply because it is not an option; for stronger guarantees, the code is based on FileContext and hdfs:// instead of webhdfs://, even more so since it might not be always enabled.
        2. It's posted in the description link:

        at java.lang.ProcessBuilder.start(ProcessBuilder.java:1016)
        at org.apache.hadoop.util.Shell.runCommand(Shell.java:486)
        at org.apache.hadoop.util.Shell.run(Shell.java:456)
        at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:722)
        at org.apache.hadoop.util.Shell.isSetsidSupported(Shell.java:391)
        at org.apache.hadoop.util.Shell.<clinit>(Shell.java:381)
        

        The current problematic field is isSetsidAvailable

        Show
        costin Costin Leau added a comment - 1. I haven't tried {webhdfs}} simply because it is not an option; for stronger guarantees, the code is based on FileContext and hdfs:// instead of webhdfs:// , even more so since it might not be always enabled. 2. It's posted in the description link: at java.lang.ProcessBuilder.start(ProcessBuilder.java:1016) at org.apache.hadoop.util.Shell.runCommand(Shell.java:486) at org.apache.hadoop.util.Shell.run(Shell.java:456) at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:722) at org.apache.hadoop.util.Shell.isSetsidSupported(Shell.java:391) at org.apache.hadoop.util.Shell.<clinit>(Shell.java:381) The current problematic field is isSetsidAvailable
        Hide
        stevel@apache.org Steve Loughran added a comment -

        OK. I expect the same flaw to exist elsewhere.

        Why not add a patch which catches the security exception and downgrades it to a false. After all, setsid isn't available, is it ?

        Show
        stevel@apache.org Steve Loughran added a comment - OK. I expect the same flaw to exist elsewhere. Why not add a patch which catches the security exception and downgrades it to a false . After all, setsid isn't available, is it ?
        Hide
        costin Costin Leau added a comment -

        Sure.
        I've forked the 2.8 branch on github; change is available as a PR, diff and patch.

        Thanks,

        Show
        costin Costin Leau added a comment - Sure. I've forked the 2.8 branch on github; change is available as a PR , diff and patch . Thanks,
        Hide
        costin Costin Leau added a comment -

        Not sure if it helps, but I've opened a PR against the Hadoop clone on Github as well.
        Cheers,

        Show
        costin Costin Leau added a comment - Not sure if it helps, but I've opened a PR against the Hadoop clone on Github as well. Cheers,
        Hide
        stevel@apache.org Steve Loughran added a comment -

        attach the patch to this JIRA, use a name of the form HADOOP-12888-001.patch, hit the the "submit patch" button and it'll be trigger an automatic review. Yetus will complain about the lack of tests, but we'll have to go with that. Did it work for you in any manual tests

        Moving the issue from HDFS to Hadoop as its in the common module

        Show
        stevel@apache.org Steve Loughran added a comment - attach the patch to this JIRA, use a name of the form HADOOP-12888 -001.patch, hit the the "submit patch" button and it'll be trigger an automatic review. Yetus will complain about the lack of tests, but we'll have to go with that. Did it work for you in any manual tests Moving the issue from HDFS to Hadoop as its in the common module
        Hide
        costin Costin Leau added a comment -

        Thanks. Looks like my previous comment was lost; I've improved the patch to take care of isBashSupported field as well (through checkIsBashSupported).

        Cheers

        Show
        costin Costin Leau added a comment - Thanks. Looks like my previous comment was lost; I've improved the patch to take care of isBashSupported field as well (through checkIsBashSupported ). Cheers
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 9s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 33s trunk passed
        +1 compile 5m 59s trunk passed with JDK v1.8.0_74
        +1 compile 6m 42s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 34s trunk passed
        +1 javadoc 0m 51s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 40s the patch passed
        +1 compile 5m 57s the patch passed with JDK v1.8.0_74
        +1 javac 5m 57s the patch passed
        +1 compile 6m 43s the patch passed with JDK v1.7.0_95
        +1 javac 6m 43s the patch passed
        -1 checkstyle 0m 21s hadoop-common-project/hadoop-common: patch generated 3 new + 37 unchanged - 0 fixed = 40 total (was 37)
        +1 mvnsite 0m 55s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 1m 50s the patch passed
        +1 javadoc 0m 51s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 1s the patch passed with JDK v1.7.0_95
        -1 unit 6m 41s hadoop-common in the patch failed with JDK v1.8.0_74.
        +1 unit 7m 3s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        58m 2s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.ha.TestZKFailoverController



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791495/HADOOP-12888-001.patch
        JIRA Issue HADOOP-12888
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 35cc310dc6ac 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / cbd3132
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8789/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8789/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8789/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8789/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8789/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8789/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 33s trunk passed +1 compile 5m 59s trunk passed with JDK v1.8.0_74 +1 compile 6m 42s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 51s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 40s the patch passed +1 compile 5m 57s the patch passed with JDK v1.8.0_74 +1 javac 5m 57s the patch passed +1 compile 6m 43s the patch passed with JDK v1.7.0_95 +1 javac 6m 43s the patch passed -1 checkstyle 0m 21s hadoop-common-project/hadoop-common: patch generated 3 new + 37 unchanged - 0 fixed = 40 total (was 37) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 13s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 51s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 1s the patch passed with JDK v1.7.0_95 -1 unit 6m 41s hadoop-common in the patch failed with JDK v1.8.0_74. +1 unit 7m 3s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 58m 2s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791495/HADOOP-12888-001.patch JIRA Issue HADOOP-12888 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 35cc310dc6ac 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cbd3132 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8789/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8789/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8789/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8789/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8789/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8789/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        ...afraid you'll have to look at the checkstyle issues. Don't worry about the test and whitespace complaints

        Show
        stevel@apache.org Steve Loughran added a comment - ...afraid you'll have to look at the checkstyle issues. Don't worry about the test and whitespace complaints
        Hide
        costin Costin Leau added a comment -

        Fix checkstyle errors.

        Show
        costin Costin Leau added a comment - Fix checkstyle errors.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 30s trunk passed
        +1 compile 5m 52s trunk passed with JDK v1.8.0_74
        +1 compile 6m 47s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 0m 58s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 36s trunk passed
        +1 javadoc 0m 52s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 4s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 42s the patch passed
        +1 compile 5m 53s the patch passed with JDK v1.8.0_74
        +1 javac 5m 53s the patch passed
        +1 compile 6m 41s the patch passed with JDK v1.7.0_95
        +1 javac 6m 41s the patch passed
        -1 checkstyle 0m 21s hadoop-common-project/hadoop-common: patch generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37)
        +1 mvnsite 0m 55s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 1m 49s the patch passed
        +1 javadoc 0m 51s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 2s the patch passed with JDK v1.7.0_95
        -1 unit 6m 57s hadoop-common in the patch failed with JDK v1.8.0_74.
        +1 unit 7m 17s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        58m 32s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.ha.TestZKFailoverController



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791802/HADOOP-12888-002.patch
        JIRA Issue HADOOP-12888
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 69600b5141da 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d718fc1
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8807/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8807/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8807/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8807/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8807/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8807/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 30s trunk passed +1 compile 5m 52s trunk passed with JDK v1.8.0_74 +1 compile 6m 47s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 36s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 4s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 42s the patch passed +1 compile 5m 53s the patch passed with JDK v1.8.0_74 +1 javac 5m 53s the patch passed +1 compile 6m 41s the patch passed with JDK v1.7.0_95 +1 javac 6m 41s the patch passed -1 checkstyle 0m 21s hadoop-common-project/hadoop-common: patch generated 2 new + 37 unchanged - 0 fixed = 39 total (was 37) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 13s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 51s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_95 -1 unit 6m 57s hadoop-common in the patch failed with JDK v1.8.0_74. +1 unit 7m 17s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 58m 32s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791802/HADOOP-12888-002.patch JIRA Issue HADOOP-12888 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 69600b5141da 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d718fc1 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8807/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8807/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8807/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8807/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8807/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8807/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        costin Costin Leau added a comment -

        Yet another update to fix checkstyle errors.

        Show
        costin Costin Leau added a comment - Yet another update to fix checkstyle errors.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 59s trunk passed
        +1 compile 9m 9s trunk passed with JDK v1.8.0_74
        +1 compile 8m 41s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 1m 10s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 1m 58s trunk passed
        +1 javadoc 1m 7s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 11s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 48s the patch passed
        +1 compile 9m 13s the patch passed with JDK v1.8.0_74
        +1 javac 9m 13s the patch passed
        +1 compile 7m 51s the patch passed with JDK v1.7.0_95
        +1 javac 7m 51s the patch passed
        +1 checkstyle 0m 20s the patch passed
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 51s the patch passed
        +1 javadoc 0m 59s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95
        -1 unit 8m 31s hadoop-common in the patch failed with JDK v1.8.0_74.
        +1 unit 8m 5s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        74m 36s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.fs.shell.find.TestName



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791976/HADOOP-12888-003.patch
        JIRA Issue HADOOP-12888
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 72019f998cf3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f86850b
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8819/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8819/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8819/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8819/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 59s trunk passed +1 compile 9m 9s trunk passed with JDK v1.8.0_74 +1 compile 8m 41s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 58s trunk passed +1 javadoc 1m 7s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 11s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 48s the patch passed +1 compile 9m 13s the patch passed with JDK v1.8.0_74 +1 javac 9m 13s the patch passed +1 compile 7m 51s the patch passed with JDK v1.7.0_95 +1 javac 7m 51s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 51s the patch passed +1 javadoc 0m 59s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95 -1 unit 8m 31s hadoop-common in the patch failed with JDK v1.8.0_74. +1 unit 8m 5s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 74m 36s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.fs.shell.find.TestName Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791976/HADOOP-12888-003.patch JIRA Issue HADOOP-12888 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 72019f998cf3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f86850b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8819/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8819/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8819/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8819/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        costin Costin Leau added a comment -

        Steve Loughran Hi. The latest patch passes the test. The unit test is unrelated as far as I can tell:

        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.469 sec <<< FAILURE! - in org.apache.hadoop.fs.shell.find.TestName
        applyGlob(org.apache.hadoop.fs.shell.find.TestName)  Time elapsed: 2.121 sec  <<< ERROR!
        java.lang.Exception: test timed out after 1000 milliseconds
        	at java.util.zip.ZipFile.getEntry(Native Method)
        	at java.util.zip.ZipFile.getEntry(ZipFile.java:310)
        	at java.util.jar.JarFile.getEntry(JarFile.java:240)
        	at java.util.jar.JarFile.getJarEntry(JarFile.java:223)
        
        Show
        costin Costin Leau added a comment - Steve Loughran Hi. The latest patch passes the test. The unit test is unrelated as far as I can tell: Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.469 sec <<< FAILURE! - in org.apache.hadoop.fs.shell.find.TestName applyGlob(org.apache.hadoop.fs.shell.find.TestName) Time elapsed: 2.121 sec <<< ERROR! java.lang.Exception: test timed out after 1000 milliseconds at java.util.zip.ZipFile.getEntry(Native Method) at java.util.zip.ZipFile.getEntry(ZipFile.java:310) at java.util.jar.JarFile.getEntry(JarFile.java:240) at java.util.jar.JarFile.getJarEntry(JarFile.java:223)
        Hide
        stevel@apache.org Steve Loughran added a comment -

        yes, test looks unrelated.

        Should that bash + security manager warning come @ info or debug?

        Show
        stevel@apache.org Steve Loughran added a comment - yes, test looks unrelated. Should that bash + security manager warning come @ info or debug?
        Hide
        costin Costin Leau added a comment -

        I went for debug:
        1. to be consistent (similar to isSetsid
        2. just like on windows on the other code paths, having these features disabled, on the client, has no impact. On info they would simply add noise and confusion in my opinion.

        Show
        costin Costin Leau added a comment - I went for debug: 1. to be consistent (similar to isSetsid 2. just like on windows on the other code paths, having these features disabled, on the client, has no impact. On info they would simply add noise and confusion in my opinion.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        1, patch applied to Hadoop 2.9

        thanks!

        Show
        stevel@apache.org Steve Loughran added a comment - 1, patch applied to Hadoop 2.9 thanks!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9469 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9469/)
        HADOOP-12888 Shell to disable bash and setsid support when running under (stevel: rev 5a725f0ab8ef9e2a8b08f088ba4e87531ae4530d)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9469 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9469/ ) HADOOP-12888 Shell to disable bash and setsid support when running under (stevel: rev 5a725f0ab8ef9e2a8b08f088ba4e87531ae4530d) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java

          People

          • Assignee:
            costin Costin Leau
            Reporter:
            costin Costin Leau
          • Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development