Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Hide
      This change contains the content of HADOOP-10115 which is an incompatible change.
      Show
      This change contains the content of HADOOP-10115 which is an incompatible change.

      Description

      Let's pull the shell code out of the hadoop-dist pom.xml

      1. HADOOP-12850.00.patch
        15 kB
        Allen Wittenauer

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          0 shelldocs 0m 3s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 3s trunk passed
          +1 compile 0m 8s trunk passed with JDK v1.8.0_72
          +1 compile 0m 11s trunk passed with JDK v1.7.0_95
          +1 mvnsite 0m 15s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 javadoc 0m 10s trunk passed with JDK v1.8.0_72
          +1 javadoc 0m 11s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 10s the patch passed
          +1 compile 0m 7s the patch passed with JDK v1.8.0_72
          +1 javac 0m 7s the patch passed
          +1 compile 0m 8s the patch passed with JDK v1.7.0_95
          +1 javac 0m 8s the patch passed
          +1 mvnsite 0m 13s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 shellcheck 0m 8s The applied patch generated 0 new + 97 unchanged - 1 fixed = 97 total (was 98)
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 7s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 8s the patch passed with JDK v1.7.0_95
          +1 unit 0m 6s hadoop-dist in the patch passed with JDK v1.8.0_72.
          +1 unit 0m 8s hadoop-dist in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          10m 55s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790386/HADOOP-12850.00.patch
          JIRA Issue HADOOP-12850
          Optional Tests asflicense shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit xml
          uname Linux aac03556924c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 321a80c
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          shellcheck v0.4.3
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8739/testReport/
          modules C: hadoop-dist U: hadoop-dist
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8739/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. 0 shelldocs 0m 3s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 3s trunk passed +1 compile 0m 8s trunk passed with JDK v1.8.0_72 +1 compile 0m 11s trunk passed with JDK v1.7.0_95 +1 mvnsite 0m 15s trunk passed +1 mvneclipse 0m 12s trunk passed +1 javadoc 0m 10s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 11s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 10s the patch passed +1 compile 0m 7s the patch passed with JDK v1.8.0_72 +1 javac 0m 7s the patch passed +1 compile 0m 8s the patch passed with JDK v1.7.0_95 +1 javac 0m 8s the patch passed +1 mvnsite 0m 13s the patch passed +1 mvneclipse 0m 10s the patch passed +1 shellcheck 0m 8s The applied patch generated 0 new + 97 unchanged - 1 fixed = 97 total (was 98) +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 7s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 8s the patch passed with JDK v1.7.0_95 +1 unit 0m 6s hadoop-dist in the patch passed with JDK v1.8.0_72. +1 unit 0m 8s hadoop-dist in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 10m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790386/HADOOP-12850.00.patch JIRA Issue HADOOP-12850 Optional Tests asflicense shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit xml uname Linux aac03556924c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 321a80c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 shellcheck v0.4.3 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8739/testReport/ modules C: hadoop-dist U: hadoop-dist Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8739/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Makes sense. FWIW we could move most of it to a bit of Ant.xml for better cross platform support, though Ant's <tar> and copy don't preserve permissions and bits, which may be an issue.

          +1

          Show
          stevel@apache.org Steve Loughran added a comment - Makes sense. FWIW we could move most of it to a bit of Ant.xml for better cross platform support, though Ant's <tar> and copy don't preserve permissions and bits, which may be an issue. +1
          Hide
          aw Allen Wittenauer added a comment -

          Thanks! I was playing around with auto-building shell profiles when I saw this. haha.

          This code also contains HADOOP-10115, which I suspect would be hard to do from within maven. Which reminds me, I need to mark this as an incompatible change just head people off at the pass on a direct back port.

          Show
          aw Allen Wittenauer added a comment - Thanks! I was playing around with auto-building shell profiles when I saw this. haha. This code also contains HADOOP-10115 , which I suspect would be hard to do from within maven. Which reminds me, I need to mark this as an incompatible change just head people off at the pass on a direct back port.
          Hide
          aw Allen Wittenauer added a comment -

          Committed to trunk.

          Show
          aw Allen Wittenauer added a comment - Committed to trunk.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9393 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9393/)
          HADOOP-12850. pull shell code out of hadoop-dist (aw: rev 1cb2f93451aa444fadd1b7ffa7825ba4a6ae74e3)

          • dev-support/bin/dist-layout-stitching
          • hadoop-dist/pom.xml
          • dev-support/bin/dist-tar-stitching
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9393 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9393/ ) HADOOP-12850 . pull shell code out of hadoop-dist (aw: rev 1cb2f93451aa444fadd1b7ffa7825ba4a6ae74e3) dev-support/bin/dist-layout-stitching hadoop-dist/pom.xml dev-support/bin/dist-tar-stitching
          Hide
          cnauroth Chris Nauroth added a comment -

          I filed HADOOP-12899 for a follow-up required for Windows.

          Show
          cnauroth Chris Nauroth added a comment - I filed HADOOP-12899 for a follow-up required for Windows.

            People

            • Assignee:
              aw Allen Wittenauer
              Reporter:
              aw Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development