Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.3.0, 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Printing user name during start can help debug access permission related issues, e.g., the namenode storage directory is not accessible by the user who starts the service.

      The message could look like:
      /************************************************************
      STARTUP_MSG: Starting NameNode by hdfs
      ... ...

      1. HDFS-4900.001.patch
        2 kB
        Wei-Chiu Chuang

        Activity

        Hide
        szetszwo Tsz Wo Nicholas Sze added a comment -

        Currently, username is printed in a FSNamesystem constructor as "fsOwner".

        //FSNamesystem constructor
             LOG.info("fsOwner             = " + fsOwner);
        
        Show
        szetszwo Tsz Wo Nicholas Sze added a comment - Currently, username is printed in a FSNamesystem constructor as "fsOwner". //FSNamesystem constructor LOG.info( "fsOwner = " + fsOwner);
        Hide
        brandonli Brandon Li added a comment -

        Looks like Namenode does prints both owner's name and group.

        Datanode (JournalNode) and Secondarynamenode don't start FSNamesystem, and thus don't print the users name/group.

        Show
        brandonli Brandon Li added a comment - Looks like Namenode does prints both owner's name and group. Datanode (JournalNode) and Secondarynamenode don't start FSNamesystem, and thus don't print the users name/group.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hello Brandon,
        Thanks for reporting the issue. I am looking into this issue and am assigning it to myself.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Hello Brandon, Thanks for reporting the issue. I am looking into this issue and am assigning it to myself.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Rev01: Log system user in STARTUP_MSG.
        In addition, KMS server does not use StringUtils.startupShutdownMessage() to print STARTUP_MSG, so add an additional log to print system user.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Rev01: Log system user in STARTUP_MSG. In addition, KMS server does not use StringUtils.startupShutdownMessage() to print STARTUP_MSG, so add an additional log to print system user.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 15s Maven dependency ordering for branch
        +1 mvninstall 7m 35s trunk passed
        +1 compile 11m 18s trunk passed with JDK v1.8.0_72
        +1 compile 9m 37s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 40s trunk passed
        +1 mvnsite 2m 7s trunk passed
        +1 mvneclipse 0m 45s trunk passed
        +1 findbugs 2m 6s trunk passed
        +1 javadoc 1m 18s trunk passed with JDK v1.8.0_72
        +1 javadoc 1m 20s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 6s the patch passed
        +1 compile 9m 12s the patch passed with JDK v1.8.0_72
        +1 javac 9m 12s the patch passed
        +1 compile 7m 50s the patch passed with JDK v1.7.0_95
        +1 javac 7m 50s the patch passed
        +1 checkstyle 0m 28s the patch passed
        +1 mvnsite 1m 31s the patch passed
        +1 mvneclipse 0m 29s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 48s the patch passed
        +1 javadoc 1m 22s the patch passed with JDK v1.8.0_72
        +1 javadoc 1m 19s the patch passed with JDK v1.7.0_95
        +1 unit 9m 59s hadoop-common in the patch passed with JDK v1.8.0_72.
        -1 unit 1m 59s hadoop-kms in the patch failed with JDK v1.8.0_72.
        +1 unit 9m 29s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 unit 2m 0s hadoop-kms in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        88m 43s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.crypto.key.kms.server.TestKMS



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787507/HDFS-4900.001.patch
        JIRA Issue HDFS-4900
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e905a427fd82 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0aa8c82
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14457/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-kms-jdk1.8.0_72.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14457/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-kms-jdk1.8.0_72.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14457/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms U: hadoop-common-project
        Max memory used 77MB
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14457/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 35s trunk passed +1 compile 11m 18s trunk passed with JDK v1.8.0_72 +1 compile 9m 37s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 40s trunk passed +1 mvnsite 2m 7s trunk passed +1 mvneclipse 0m 45s trunk passed +1 findbugs 2m 6s trunk passed +1 javadoc 1m 18s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 20s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 6s the patch passed +1 compile 9m 12s the patch passed with JDK v1.8.0_72 +1 javac 9m 12s the patch passed +1 compile 7m 50s the patch passed with JDK v1.7.0_95 +1 javac 7m 50s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 1m 31s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 48s the patch passed +1 javadoc 1m 22s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 19s the patch passed with JDK v1.7.0_95 +1 unit 9m 59s hadoop-common in the patch passed with JDK v1.8.0_72. -1 unit 1m 59s hadoop-kms in the patch failed with JDK v1.8.0_72. +1 unit 9m 29s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 2m 0s hadoop-kms in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 88m 43s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.crypto.key.kms.server.TestKMS Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787507/HDFS-4900.001.patch JIRA Issue HDFS-4900 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e905a427fd82 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0aa8c82 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14457/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-kms-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14457/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-kms-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14457/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms U: hadoop-common-project Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14457/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        yzhangal Yongjun Zhang added a comment -

        +1 on the patch 001, will commit soon.

        Thanks.

        Show
        yzhangal Yongjun Zhang added a comment - +1 on the patch 001, will commit soon. Thanks.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9329 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9329/)
        HADOOP-12828. Print user when services are started. (Wei-Chiu Chuang via (yzhang: rev a963baba10648859ad88d4ed9a4325b66b1af0d5)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
        • hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9329 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9329/ ) HADOOP-12828 . Print user when services are started. (Wei-Chiu Chuang via (yzhang: rev a963baba10648859ad88d4ed9a4325b66b1af0d5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSWebApp.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        yzhangal Yongjun Zhang added a comment -

        Committed to trunk, branch-2, and branch-2.8.

        Thanks Wei-Chiu for the contribution, Brandon for reporting the issue and Nicholas for the input.

        Show
        yzhangal Yongjun Zhang added a comment - Committed to trunk, branch-2, and branch-2.8. Thanks Wei-Chiu for the contribution, Brandon for reporting the issue and Nicholas for the input.

          People

          • Assignee:
            jojochuang Wei-Chiu Chuang
            Reporter:
            brandonli Brandon Li
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development