Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12794

Support additional compression levels for GzipCodec

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
    • Component/s: io
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Added New compression levels for GzipCodec that can be set in zlib.compress.level

      Description

      gzip supports compression levels 1-9. Compression level 4 seems to give best compression per CPU time in some of our tests. Right now ZlibCompressor that is used by GzipCodec only supports levels 1,9 and six (default).

      Adding all the compression levels that are supported by native ZlibCompressor
      can provide more options to tweak compression levels.

      1. HADOOP-12794.0003.patch
        3 kB
        Ravi Mutyala
      2. HADOOP-12794.0002.patch
        2 kB
        Ravi Mutyala
      3. HADOOP-12794.0001.patch
        1 kB
        Ravi Mutyala

        Activity

        Hide
        rmutyala Ravi Mutyala added a comment -

        New compression levels can be used by setting zlib.compress.level

        eg. -D zlib.compress.level=FOUR -D mapreduce.output.fileoutputformat.compress.codec=org.apache.hadoop.io.compress.GzipCodec

        Show
        rmutyala Ravi Mutyala added a comment - New compression levels can be used by setting zlib.compress.level eg. -D zlib.compress.level=FOUR -D mapreduce.output.fileoutputformat.compress.codec=org.apache.hadoop.io.compress.GzipCodec
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 53s trunk passed
        +1 compile 7m 38s trunk passed with JDK v1.8.0_66
        +1 compile 8m 0s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 1m 11s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 42s trunk passed
        +1 javadoc 1m 1s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 11s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 49s the patch passed
        +1 compile 7m 13s the patch passed with JDK v1.8.0_66
        +1 javac 7m 13s the patch passed
        +1 compile 7m 45s the patch passed with JDK v1.7.0_91
        +1 javac 7m 45s the patch passed
        -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 7 new + 13 unchanged - 0 fixed = 20 total (was 13)
        +1 mvnsite 1m 8s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 57s the patch passed
        +1 javadoc 1m 0s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 8s the patch passed with JDK v1.7.0_91
        +1 unit 8m 35s hadoop-common in the patch passed with JDK v1.8.0_66.
        +1 unit 8m 39s hadoop-common in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        69m 47s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787439/HADOOP-12794.0001.patch
        JIRA Issue HADOOP-12794
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e38242a11dc2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / fa00d3e
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8600/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8600/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 77MB
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8600/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 53s trunk passed +1 compile 7m 38s trunk passed with JDK v1.8.0_66 +1 compile 8m 0s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 25s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 1m 1s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 11s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 49s the patch passed +1 compile 7m 13s the patch passed with JDK v1.8.0_66 +1 javac 7m 13s the patch passed +1 compile 7m 45s the patch passed with JDK v1.7.0_91 +1 javac 7m 45s the patch passed -1 checkstyle 0m 22s hadoop-common-project/hadoop-common: patch generated 7 new + 13 unchanged - 0 fixed = 20 total (was 13) +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 57s the patch passed +1 javadoc 1m 0s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 8s the patch passed with JDK v1.7.0_91 +1 unit 8m 35s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 39s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 69m 47s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787439/HADOOP-12794.0001.patch JIRA Issue HADOOP-12794 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e38242a11dc2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fa00d3e Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8600/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8600/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8600/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        djp Junping Du added a comment -

        Thanks Ravi Mutyala for contributing the patch.
        The patch looks good in overall. However, it could be better to add unit test for some of added compress levels in TestZlibCompressorDecompressor (a good example could be: testCompressorDecompressorWithExeedBufferLimit()).
        Also, for name of some CompressionLevel, like 6, shall we follow existing naming practice to name it as BEST_BALANCE for balance between compression ratio and speed?
        Last but not the least, it seems like some checkstyle issues (missing dot for first line) that should be easily fixed.

        Show
        djp Junping Du added a comment - Thanks Ravi Mutyala for contributing the patch. The patch looks good in overall. However, it could be better to add unit test for some of added compress levels in TestZlibCompressorDecompressor (a good example could be: testCompressorDecompressorWithExeedBufferLimit()). Also, for name of some CompressionLevel, like 6, shall we follow existing naming practice to name it as BEST_BALANCE for balance between compression ratio and speed? Last but not the least, it seems like some checkstyle issues (missing dot for first line) that should be easily fixed.
        Hide
        rmutyala Ravi Mutyala added a comment -

        Thanks Junping. I am working on adding the Tests and checkstyle and will upload a new patch soon.

        Regarding adding BEST_BALANCE for compression level 4 (not 6 which is the default), that is a good option but would like more inputs to confirm that our internal tests about level 4 being best balance is true with other datasets. We could name the levels as
        BEST_SPEED(1),TWO(2), THREE(3),BEST_BALANCE(4),FIVE(5),DEFAULT(6),SEVEN(7), EIGHT(8),BEST_COMPRESSION(9).
        The reason for leaving numbers (TWO,THREE.. etc) would be give flexibility of using all compression levels available in zlib in compressioncodec.

        Show
        rmutyala Ravi Mutyala added a comment - Thanks Junping. I am working on adding the Tests and checkstyle and will upload a new patch soon. Regarding adding BEST_BALANCE for compression level 4 (not 6 which is the default), that is a good option but would like more inputs to confirm that our internal tests about level 4 being best balance is true with other datasets. We could name the levels as BEST_SPEED(1),TWO(2), THREE(3),BEST_BALANCE(4),FIVE(5),DEFAULT(6),SEVEN(7), EIGHT(8),BEST_COMPRESSION(9). The reason for leaving numbers (TWO,THREE.. etc) would be give flexibility of using all compression levels available in zlib in compressioncodec.
        Hide
        djp Junping Du added a comment -

        I am working on adding the Tests and checkstyle and will upload a new patch soon.

        Sure. Thanks Ravi.

        The reason for leaving numbers (TWO,THREE.. etc) would be give flexibility of using all compression levels available in zlib in compressioncodec.

        +1. Sounds reasonable to me.

        Show
        djp Junping Du added a comment - I am working on adding the Tests and checkstyle and will upload a new patch soon. Sure. Thanks Ravi. The reason for leaving numbers (TWO,THREE.. etc) would be give flexibility of using all compression levels available in zlib in compressioncodec. +1. Sounds reasonable to me.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Removed fix version. Fix version is set when the patch is committed.

        I am working on adding the Tests and checkstyle and will upload a new patch soon.

        Thanks!

        Show
        ajisakaa Akira Ajisaka added a comment - Removed fix version. Fix version is set when the patch is committed. I am working on adding the Tests and checkstyle and will upload a new patch soon. Thanks!
        Hide
        djp Junping Du added a comment -

        Removed fix version. Fix version is set when the patch is committed.

        Yes. Thanks for Akira for checking this. We should use "Target version" to set versions that this patch is expected to show up. "Fix version" is used by committer to indicate branches that the commit actually land in the end.

        Show
        djp Junping Du added a comment - Removed fix version. Fix version is set when the patch is committed. Yes. Thanks for Akira for checking this. We should use "Target version" to set versions that this patch is expected to show up. "Fix version" is used by committer to indicate branches that the commit actually land in the end.
        Hide
        rmutyala Ravi Mutyala added a comment -

        Cancelling patch because of -1. Will add a new patch

        Show
        rmutyala Ravi Mutyala added a comment - Cancelling patch because of -1. Will add a new patch
        Hide
        rmutyala Ravi Mutyala added a comment -

        Fixed checkstyle and changed testZlibCompressorDecompressorWithConfiguration to use added configuration

        Show
        rmutyala Ravi Mutyala added a comment - Fixed checkstyle and changed testZlibCompressorDecompressorWithConfiguration to use added configuration
        Hide
        rmutyala Ravi Mutyala added a comment -

        Since the change includes new configuration parameters, I changed an existing test to include the new parameter.

        If anyone thinks adding a new one instead of modifying existing test is the best option here, I can upload another version with a new testcase.

        Show
        rmutyala Ravi Mutyala added a comment - Since the change includes new configuration parameters, I changed an existing test to include the new parameter. If anyone thinks adding a new one instead of modifying existing test is the best option here, I can upload another version with a new testcase.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 43s trunk passed
        +1 compile 7m 2s trunk passed with JDK v1.8.0_72
        +1 compile 7m 31s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 1m 11s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 41s trunk passed
        +1 javadoc 0m 57s trunk passed with JDK v1.8.0_72
        +1 javadoc 1m 8s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 44s the patch passed
        +1 compile 6m 39s the patch passed with JDK v1.8.0_72
        +1 javac 6m 39s the patch passed
        +1 compile 7m 18s the patch passed with JDK v1.7.0_95
        +1 javac 7m 18s the patch passed
        +1 checkstyle 0m 22s the patch passed
        +1 mvnsite 1m 7s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 59s the patch passed
        +1 javadoc 0m 59s the patch passed with JDK v1.8.0_72
        +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95
        +1 unit 8m 17s hadoop-common in the patch passed with JDK v1.8.0_72.
        +1 unit 8m 20s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        66m 38s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788017/HADOOP-12794.0002.patch
        JIRA Issue HADOOP-12794
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ff64ea53be7d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8ed07bd
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8630/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8630/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 43s trunk passed +1 compile 7m 2s trunk passed with JDK v1.8.0_72 +1 compile 7m 31s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 22s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 41s trunk passed +1 javadoc 0m 57s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 8s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 6m 39s the patch passed with JDK v1.8.0_72 +1 javac 6m 39s the patch passed +1 compile 7m 18s the patch passed with JDK v1.7.0_95 +1 javac 7m 18s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 1m 7s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 59s the patch passed +1 javadoc 0m 59s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95 +1 unit 8m 17s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 8m 20s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 66m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788017/HADOOP-12794.0002.patch JIRA Issue HADOOP-12794 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ff64ea53be7d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8ed07bd Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8630/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8630/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        djp Junping Du added a comment -

        Thanks Ravi Mutyala for updating the patch. The patch looks petty good now. Just one NIT:

        If anyone thinks adding a new one instead of modifying existing test is the best option here, I can upload another version with a new test case.

        As a general practice, we normally suggest to add an additional test case rather than modifying existing test cases for new feature/configuration as previous test case could be designed for some other purpose. In this particular case, it would be nice to have an additional test method to verify all compression levels.

        Mark target version to be 2.7.3 and 2.8.0.

        Show
        djp Junping Du added a comment - Thanks Ravi Mutyala for updating the patch. The patch looks petty good now. Just one NIT: If anyone thinks adding a new one instead of modifying existing test is the best option here, I can upload another version with a new test case. As a general practice, we normally suggest to add an additional test case rather than modifying existing test cases for new feature/configuration as previous test case could be designed for some other purpose. In this particular case, it would be nice to have an additional test method to verify all compression levels. Mark target version to be 2.7.3 and 2.8.0.
        Hide
        rmutyala Ravi Mutyala added a comment -

        Added new test case

        Show
        rmutyala Ravi Mutyala added a comment - Added new test case
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 18s trunk passed
        +1 compile 6m 29s trunk passed with JDK v1.8.0_72
        +1 compile 7m 14s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 1m 7s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 40s trunk passed
        +1 javadoc 0m 57s trunk passed with JDK v1.8.0_72
        +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 44s the patch passed
        +1 compile 7m 10s the patch passed with JDK v1.8.0_72
        +1 javac 7m 10s the patch passed
        +1 compile 8m 5s the patch passed with JDK v1.7.0_95
        +1 javac 8m 5s the patch passed
        +1 checkstyle 0m 25s the patch passed
        +1 mvnsite 1m 13s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 4s the patch passed
        +1 javadoc 1m 3s the patch passed with JDK v1.8.0_72
        +1 javadoc 1m 12s the patch passed with JDK v1.7.0_95
        -1 unit 17m 23s hadoop-common in the patch failed with JDK v1.8.0_72.
        +1 unit 9m 11s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        77m 1s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.ha.TestZKFailoverController
        JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788391/HADOOP-12794.0003.patch
        JIRA Issue HADOOP-12794
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8e206d33e000 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7de7068
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8658/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8658/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8658/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8658/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 18s trunk passed +1 compile 6m 29s trunk passed with JDK v1.8.0_72 +1 compile 7m 14s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 40s trunk passed +1 javadoc 0m 57s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 7m 10s the patch passed with JDK v1.8.0_72 +1 javac 7m 10s the patch passed +1 compile 8m 5s the patch passed with JDK v1.7.0_95 +1 javac 8m 5s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 1m 13s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 12s the patch passed with JDK v1.7.0_95 -1 unit 17m 23s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 9m 11s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 77m 1s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.ha.TestZKFailoverController JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788391/HADOOP-12794.0003.patch JIRA Issue HADOOP-12794 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8e206d33e000 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7de7068 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8658/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8658/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8658/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8658/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        djp Junping Du added a comment -

        Latest patch LGTM. +1. Will commit it shortly.

        Show
        djp Junping Du added a comment - Latest patch LGTM. +1. Will commit it shortly.
        Hide
        djp Junping Du added a comment -

        I have commit the patch to trunk, branch-2. branch-2.7 and branch-2.8. Thanks Ravi Mutyala for the contribution!

        Show
        djp Junping Du added a comment - I have commit the patch to trunk, branch-2. branch-2.7 and branch-2.8. Thanks Ravi Mutyala for the contribution!
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Even though this landed in 2.7.3, the commit missed the JIRA number. So, the ticket & commit are disconnected. Here's the SHA, for posterity.

        commit 78a4c348940cd98548650c0a5adb981895cef201
        Author: Junping Du <junping_du@apache.org>
        Date:   Fri Feb 19 14:21:25 2016 -0800
        
            Support additional compression levels for GzipCodec. Contributed by Ravi Mutyala.
            (cherry picked from commit 18f9b77a321b225677ce23c503b41d21478fc4a7)
            (cherry picked from commit e38c2ef6c54521a74cc2b787d78211f629aa07d8)
        
        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Even though this landed in 2.7.3, the commit missed the JIRA number. So, the ticket & commit are disconnected. Here's the SHA, for posterity. commit 78a4c348940cd98548650c0a5adb981895cef201 Author: Junping Du <junping_du@apache.org> Date: Fri Feb 19 14:21:25 2016 -0800 Support additional compression levels for GzipCodec. Contributed by Ravi Mutyala. (cherry picked from commit 18f9b77a321b225677ce23c503b41d21478fc4a7) (cherry picked from commit e38c2ef6c54521a74cc2b787d78211f629aa07d8)
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

          People

          • Assignee:
            rmutyala Ravi Mutyala
            Reporter:
            rmutyala Ravi Mutyala
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development