Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12782

Faster LDAP group name resolution with ActiveDirectory

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      If the user object returned by LDAP server has the user's group object DN (supported by Active Directory), Hadoop can reduce LDAP group mapping latency by setting hadoop.security.group.mapping.ldap.search.attr.memberof to memberOf.

      Description

      The typical LDAP group name resolution works well under typical scenarios. However, we have seen cases where a user is mapped to many groups (in an extreme case, a user is mapped to more than 100 groups). The way it's being implemented now makes this case super slow resolving groups from ActiveDirectory.

      The current LDAP group resolution implementation sends two queries to a ActiveDirectory server. The first query returns a user object, which contains DN (distinguished name). The second query looks for groups where the user DN is a member. If a user is mapped to many groups, the second query returns all group objects associated with the user, and is thus very slow.

      After studying a user object in ActiveDirectory, I found a user object actually contains a "memberOf" field, which is the DN of all group objects where the user belongs to. Assuming that an organization has no recursive group relation (that is, a user A is a member of group G1, and group G1 is a member of group G2), we can use this properties to avoid the second query, which can potentially run very slow.

      I propose that we add a configuration to only enable this feature for users who want to reduce group resolution time and who does not have recursive groups, so that existing behavior will not be broken.

      1. HADOOP-12782.001.patch
        17 kB
        Wei-Chiu Chuang
      2. HADOOP-12782.002.patch
        16 kB
        Wei-Chiu Chuang
      3. HADOOP-12782.003.patch
        21 kB
        Wei-Chiu Chuang
      4. HADOOP-12782.004.patch
        21 kB
        Wei-Chiu Chuang
      5. HADOOP-12782.005.patch
        21 kB
        Wei-Chiu Chuang
      6. HADOOP-12782.006.patch
        21 kB
        Wei-Chiu Chuang
      7. HADOOP-12782.007.patch
        26 kB
        Wei-Chiu Chuang
      8. HADOOP-12782.008.patch
        31 kB
        Wei-Chiu Chuang
      9. HADOOP-12782.009.patch
        31 kB
        Wei-Chiu Chuang
      10. HADOOP-12782.branch-2.010.patch
        31 kB
        Wei-Chiu Chuang

        Issue Links

          Activity

          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev01: implemented fast ldap group name lookup, the associated test case, and associated documentation.

          In this implementation, there are basically three cases:

          1. general scenario, perform two ldap queries per group lookup.
          2. If the server supports posix semantics, perform two ldap queries using posix gid/uid to find groups of the user
          3. (new implementation) perform one ldap query per group lookup, if fast lookup is enabled (The server must be an Active Directory, no recursive group membership and use CN attribute to identify a group's name)

          To enable this feature, set hadoop.security.group.mapping.ldap.search.filter.group=ldapFastLookup.

          I also updated the first two scenarios so that more verbose message will be logged in case of exceptions. (supportability)

          Finally, a new test file TestLdapGroupsMappingWithFastLookup is added that tests the new feature. The test (as well as TestLdapGroupsMapping and TestLdapGroupsMappingWithPosixGroup) all passed locally.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev01: implemented fast ldap group name lookup, the associated test case, and associated documentation. In this implementation, there are basically three cases: general scenario, perform two ldap queries per group lookup. If the server supports posix semantics, perform two ldap queries using posix gid/uid to find groups of the user (new implementation) perform one ldap query per group lookup, if fast lookup is enabled (The server must be an Active Directory, no recursive group membership and use CN attribute to identify a group's name) To enable this feature, set hadoop.security.group.mapping.ldap.search.filter.group=ldapFastLookup. I also updated the first two scenarios so that more verbose message will be logged in case of exceptions. (supportability) Finally, a new test file TestLdapGroupsMappingWithFastLookup is added that tests the new feature. The test (as well as TestLdapGroupsMapping and TestLdapGroupsMappingWithPosixGroup) all passed locally.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 47s trunk passed
          +1 compile 7m 37s trunk passed with JDK v1.8.0_72
          +1 compile 7m 16s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 33s trunk passed
          +1 javadoc 0m 52s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 4s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 39s the patch passed
          +1 compile 6m 3s the patch passed with JDK v1.8.0_72
          -1 javac 10m 24s root-jdk1.8.0_72 with JDK v1.8.0_72 generated 2 new + 738 unchanged - 2 fixed = 740 total (was 740)
          +1 javac 6m 3s the patch passed
          +1 compile 6m 59s the patch passed with JDK v1.7.0_95
          -1 javac 17m 23s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 2 new + 733 unchanged - 2 fixed = 735 total (was 735)
          +1 javac 6m 59s the patch passed
          -1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 4 new + 34 unchanged - 1 fixed = 38 total (was 35)
          +1 mvnsite 1m 2s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          -1 findbugs 1m 54s hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 1m 0s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95
          -1 unit 19m 30s hadoop-common in the patch failed with JDK v1.8.0_72.
          +1 unit 7m 43s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          74m 59s



          Reason Tests
          FindBugs module:hadoop-common-project/hadoop-common
            org.apache.hadoop.security.LdapGroupsMapping.lookupPosixGroup(SearchResult, DirContext) invokes inefficient new String() constructor At LdapGroupsMapping.java:String() constructor At LdapGroupsMapping.java:[line 325]
          JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786901/HADOOP-12782.001.patch
          JIRA Issue HADOOP-12782
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 392b70453a4e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 58acbf9
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac root-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_72.txt
          javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 47s trunk passed +1 compile 7m 37s trunk passed with JDK v1.8.0_72 +1 compile 7m 16s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 33s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 4s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 39s the patch passed +1 compile 6m 3s the patch passed with JDK v1.8.0_72 -1 javac 10m 24s root-jdk1.8.0_72 with JDK v1.8.0_72 generated 2 new + 738 unchanged - 2 fixed = 740 total (was 740) +1 javac 6m 3s the patch passed +1 compile 6m 59s the patch passed with JDK v1.7.0_95 -1 javac 17m 23s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 2 new + 733 unchanged - 2 fixed = 735 total (was 735) +1 javac 6m 59s the patch passed -1 checkstyle 0m 20s hadoop-common-project/hadoop-common: patch generated 4 new + 34 unchanged - 1 fixed = 38 total (was 35) +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. -1 findbugs 1m 54s hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 1m 0s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95 -1 unit 19m 30s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 7m 43s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 74m 59s Reason Tests FindBugs module:hadoop-common-project/hadoop-common   org.apache.hadoop.security.LdapGroupsMapping.lookupPosixGroup(SearchResult, DirContext) invokes inefficient new String() constructor At LdapGroupsMapping.java:String() constructor At LdapGroupsMapping.java: [line 325] JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12786901/HADOOP-12782.001.patch JIRA Issue HADOOP-12782 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 392b70453a4e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 58acbf9 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_72.txt javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8573/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev02: fixed findbugs, checkstyle and javac warnings.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev02: fixed findbugs, checkstyle and javac warnings.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 9m 33s trunk passed
          +1 compile 11m 16s trunk passed with JDK v1.8.0_72
          +1 compile 9m 50s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 1m 29s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 2m 4s trunk passed
          +1 javadoc 1m 19s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 27s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 59s the patch passed
          +1 compile 11m 8s the patch passed with JDK v1.8.0_72
          -1 javac 17m 15s root-jdk1.8.0_72 with JDK v1.8.0_72 generated 2 new + 737 unchanged - 2 fixed = 739 total (was 739)
          +1 javac 11m 8s the patch passed
          +1 compile 9m 55s the patch passed with JDK v1.7.0_95
          -1 javac 27m 10s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 2 new + 733 unchanged - 2 fixed = 735 total (was 735)
          +1 javac 9m 55s the patch passed
          +1 checkstyle 0m 28s hadoop-common-project/hadoop-common: patch generated 0 new + 33 unchanged - 2 fixed = 33 total (was 35)
          +1 mvnsite 1m 22s the patch passed
          +1 mvneclipse 0m 18s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 2m 28s the patch passed
          +1 javadoc 1m 23s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 28s the patch passed with JDK v1.7.0_95
          +1 unit 11m 9s hadoop-common in the patch passed with JDK v1.8.0_72.
          -1 unit 9m 49s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 31s Patch does not generate ASF License warnings.
          90m 35s



          Reason Tests
          JDK v1.7.0_95 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787155/HADOOP-12782.002.patch
          JIRA Issue HADOOP-12782
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux d61080f3f6fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 401ae4e
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac root-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-HADOOP-Build/8581/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_72.txt
          javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8581/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8581/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8581/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8581/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 76MB
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8581/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 9m 33s trunk passed +1 compile 11m 16s trunk passed with JDK v1.8.0_72 +1 compile 9m 50s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 29s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 1m 19s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 27s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 59s the patch passed +1 compile 11m 8s the patch passed with JDK v1.8.0_72 -1 javac 17m 15s root-jdk1.8.0_72 with JDK v1.8.0_72 generated 2 new + 737 unchanged - 2 fixed = 739 total (was 739) +1 javac 11m 8s the patch passed +1 compile 9m 55s the patch passed with JDK v1.7.0_95 -1 javac 27m 10s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 2 new + 733 unchanged - 2 fixed = 735 total (was 735) +1 javac 9m 55s the patch passed +1 checkstyle 0m 28s hadoop-common-project/hadoop-common: patch generated 0 new + 33 unchanged - 2 fixed = 33 total (was 35) +1 mvnsite 1m 22s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 2m 28s the patch passed +1 javadoc 1m 23s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 28s the patch passed with JDK v1.7.0_95 +1 unit 11m 9s hadoop-common in the patch passed with JDK v1.8.0_72. -1 unit 9m 49s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 31s Patch does not generate ASF License warnings. 90m 35s Reason Tests JDK v1.7.0_95 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787155/HADOOP-12782.002.patch JIRA Issue HADOOP-12782 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux d61080f3f6fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 401ae4e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.8.0_72: https://builds.apache.org/job/PreCommit-HADOOP-Build/8581/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_72.txt javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8581/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8581/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8581/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8581/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8581/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          The optimization looks good and makes sense to me. Thanks!

          Some comments:
          1. Does the optimization only work for ActiveDirectory, or is there any similar attribute to memberOf for other LDAP providers?
          2. May be not good to use Faster, ldapFastLookup because some time later some even faster approaches might be found out. Suggest changing hadoop.security.group.mapping.ldap.search.filter.group=ldapFastLookup to hadoop.security.group.mapping.ldap.search.attr.memberof similar to the existing one hadoop.security.group.mapping.ldap.search.attr.member. The logic is, if it's set, then the attribute value will be used as proposed. This way, if other LDAP solutions other than MS AD has similar attribute to employ, then the attribute name can be set to the item and the optimized way still works.

          Show
          drankye Kai Zheng added a comment - The optimization looks good and makes sense to me. Thanks! Some comments: 1. Does the optimization only work for ActiveDirectory, or is there any similar attribute to memberOf for other LDAP providers? 2. May be not good to use Faster , ldapFastLookup because some time later some even faster approaches might be found out. Suggest changing hadoop.security.group.mapping.ldap.search.filter.group=ldapFastLookup to hadoop.security.group.mapping.ldap.search.attr.memberof similar to the existing one hadoop.security.group.mapping.ldap.search.attr.member . The logic is, if it's set, then the attribute value will be used as proposed. This way, if other LDAP solutions other than MS AD has similar attribute to employ, then the attribute name can be set to the item and the optimized way still works.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Hi Kai Zheng thanks for the review and suggestion. Really appreciate!

          I am not sure if other LDAP providers have attributes to do the similar optimization. I read a few Active Directory books and did some experiments to make sure this is supported in AD. What confused me initially was that there does not seem to be one protocol for using LDAP for authentication by all LDAP servers.

          I think your suggestion makes sense to me. I'll update my patch with your suggestion, and I'll also look for similar optimization for other LDAP providers.

          Thanks again.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Hi Kai Zheng thanks for the review and suggestion. Really appreciate! I am not sure if other LDAP providers have attributes to do the similar optimization. I read a few Active Directory books and did some experiments to make sure this is supported in AD. What confused me initially was that there does not seem to be one protocol for using LDAP for authentication by all LDAP servers. I think your suggestion makes sense to me. I'll update my patch with your suggestion, and I'll also look for similar optimization for other LDAP providers. Thanks again.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev03:
          Described this experimental feature in the documentation.
          Fast lookup is enabled by setting hadoop.security.group.mapping.ldap.search.attr.memberof to memberOf, or any other non-empty value. Hadoop will lookup this attribute in the returned user object if this property is set. If the fast lookup fails or disabled (by default), Hadoop send two LDAP queries for group name resolution.

          I have tested this patch against our internal Active Directory server and it worked as expected.

          So far, I have not yet found any LDAP servers other than MS AD that support this feature. Most other LDAP servers support user/group mapping by following RFC-2307 (An Approach for Using LDAP as a Network Information Service). RFC-2307 defines posixAccount and posixGroup objectClass; the former has attributes uidNumber and gidNumber, which are numerical numbers, and therefore it is not possible to get group names from looking up the user object.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev03: Described this experimental feature in the documentation. Fast lookup is enabled by setting hadoop.security.group.mapping.ldap.search.attr.memberof to memberOf , or any other non-empty value. Hadoop will lookup this attribute in the returned user object if this property is set. If the fast lookup fails or disabled (by default), Hadoop send two LDAP queries for group name resolution. I have tested this patch against our internal Active Directory server and it worked as expected. So far, I have not yet found any LDAP servers other than MS AD that support this feature. Most other LDAP servers support user/group mapping by following RFC-2307 (An Approach for Using LDAP as a Network Information Service). RFC-2307 defines posixAccount and posixGroup objectClass; the former has attributes uidNumber and gidNumber , which are numerical numbers, and therefore it is not possible to get group names from looking up the user object.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 4s trunk passed
          +1 compile 6m 5s trunk passed with JDK v1.8.0_74
          +1 compile 6m 49s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 35s trunk passed
          +1 javadoc 0m 55s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 41s the patch passed
          +1 compile 6m 2s the patch passed with JDK v1.8.0_74
          -1 javac 10m 31s root-jdk1.8.0_74 with JDK v1.8.0_74 generated 2 new + 736 unchanged - 2 fixed = 738 total (was 738)
          +1 javac 6m 2s the patch passed
          +1 compile 6m 43s the patch passed with JDK v1.7.0_95
          -1 javac 17m 14s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 2 new + 732 unchanged - 2 fixed = 734 total (was 734)
          +1 javac 6m 43s the patch passed
          -1 checkstyle 0m 21s hadoop-common-project/hadoop-common: patch generated 2 new + 32 unchanged - 2 fixed = 34 total (was 34)
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 53s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95
          +1 unit 7m 14s hadoop-common in the patch passed with JDK v1.8.0_74.
          +1 unit 7m 26s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          60m 20s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794195/HADOOP-12782.003.patch
          JIRA Issue HADOOP-12782
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux b54a9f3b2410 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 92b7e0d
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          javac root-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HADOOP-Build/8872/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_74.txt
          javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8872/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8872/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8872/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8872/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 4s trunk passed +1 compile 6m 5s trunk passed with JDK v1.8.0_74 +1 compile 6m 49s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 35s trunk passed +1 javadoc 0m 55s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 6m 2s the patch passed with JDK v1.8.0_74 -1 javac 10m 31s root-jdk1.8.0_74 with JDK v1.8.0_74 generated 2 new + 736 unchanged - 2 fixed = 738 total (was 738) +1 javac 6m 2s the patch passed +1 compile 6m 43s the patch passed with JDK v1.7.0_95 -1 javac 17m 14s root-jdk1.7.0_95 with JDK v1.7.0_95 generated 2 new + 732 unchanged - 2 fixed = 734 total (was 734) +1 javac 6m 43s the patch passed -1 checkstyle 0m 21s hadoop-common-project/hadoop-common: patch generated 2 new + 32 unchanged - 2 fixed = 34 total (was 34) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95 +1 unit 7m 14s hadoop-common in the patch passed with JDK v1.8.0_74. +1 unit 7m 26s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 60m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12794195/HADOOP-12782.003.patch JIRA Issue HADOOP-12782 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux b54a9f3b2410 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 92b7e0d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac root-jdk1.8.0_74: https://builds.apache.org/job/PreCommit-HADOOP-Build/8872/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_74.txt javac root-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HADOOP-Build/8872/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_95.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8872/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8872/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8872/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          rev04: fixed checkstyle and javac warnings.

          Show
          jojochuang Wei-Chiu Chuang added a comment - rev04: fixed checkstyle and javac warnings.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Resubmit to kick off the precommit build.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Resubmit to kick off the precommit build.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 35s trunk passed
          +1 compile 5m 49s trunk passed with JDK v1.8.0_92
          +1 compile 6m 47s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 0s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 38s trunk passed
          +1 javadoc 0m 54s trunk passed with JDK v1.8.0_92
          +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 41s the patch passed
          +1 compile 5m 47s the patch passed with JDK v1.8.0_92
          +1 javac 5m 47s the patch passed
          +1 compile 6m 46s the patch passed with JDK v1.7.0_95
          +1 javac 6m 46s the patch passed
          +1 checkstyle 0m 21s hadoop-common-project/hadoop-common: The patch generated 0 new + 32 unchanged - 2 fixed = 32 total (was 34)
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 1m 48s the patch passed
          +1 javadoc 0m 53s the patch passed with JDK v1.8.0_92
          +1 javadoc 1m 3s the patch passed with JDK v1.7.0_95
          -1 unit 6m 47s hadoop-common in the patch failed with JDK v1.8.0_92.
          +1 unit 7m 29s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          58m 54s



          Reason Tests
          JDK v1.8.0_92 Failed junit tests hadoop.net.TestClusterTopology



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800779/HADOOP-12782.004.patch
          JIRA Issue HADOOP-12782
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 9165aa11039b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1a3f148
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9184/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9184/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9184/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9184/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 35s trunk passed +1 compile 5m 49s trunk passed with JDK v1.8.0_92 +1 compile 6m 47s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 38s trunk passed +1 javadoc 0m 54s trunk passed with JDK v1.8.0_92 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 5m 47s the patch passed with JDK v1.8.0_92 +1 javac 5m 47s the patch passed +1 compile 6m 46s the patch passed with JDK v1.7.0_95 +1 javac 6m 46s the patch passed +1 checkstyle 0m 21s hadoop-common-project/hadoop-common: The patch generated 0 new + 32 unchanged - 2 fixed = 32 total (was 34) +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_92 +1 javadoc 1m 3s the patch passed with JDK v1.7.0_95 -1 unit 6m 47s hadoop-common in the patch failed with JDK v1.8.0_92. +1 unit 7m 29s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 58m 54s Reason Tests JDK v1.8.0_92 Failed junit tests hadoop.net.TestClusterTopology Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800779/HADOOP-12782.004.patch JIRA Issue HADOOP-12782 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 9165aa11039b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1a3f148 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9184/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9184/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9184/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9184/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          The test failure is unrelated.

          Show
          jojochuang Wei-Chiu Chuang added a comment - The test failure is unrelated.
          Hide
          drankye Kai Zheng added a comment -

          I took a look more closely at the codes. It looks good overall. I'd suggest we refresh this to avoid the word Fast for the reason I mentioned above, when convenient. Also some minor comments:

          • We could remove the variable useFastLookup, instead use memberOfAttr != null directly to indicate the case.
          • Ref. the following block, we could embed the logic in fastLookup directly to simplify some bit?
                if (useFastLookup) {
                  try {
                    return fastLookup(result);
                  } catch (NamingException e) {
                    // If fast lookup failed, fall back to the typical scenario.
                    LOG.debug("Failed in fast lookup. Initiating the second LDAP query " +
                        "using the user's DN.", e);
                  }
                }
            
          • Please have a line break between functions;
          • Please also avoid star imports;
          • Could we remove the word experimental in the user doc?
          Show
          drankye Kai Zheng added a comment - I took a look more closely at the codes. It looks good overall. I'd suggest we refresh this to avoid the word Fast for the reason I mentioned above, when convenient. Also some minor comments: We could remove the variable useFastLookup , instead use memberOfAttr != null directly to indicate the case. Ref. the following block, we could embed the logic in fastLookup directly to simplify some bit? if (useFastLookup) { try { return fastLookup(result); } catch (NamingException e) { // If fast lookup failed, fall back to the typical scenario. LOG.debug( "Failed in fast lookup. Initiating the second LDAP query " + "using the user's DN." , e); } } Please have a line break between functions; Please also avoid star imports; Could we remove the word experimental in the user doc?
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Kai Zheng for the detailed review. Uploaded rev05 to address some of the comments:

          We could remove the variable useFastLookup, instead use memberOfAttr != null directly to indicate the case.

          What about renaming useFastLookup as useOneQuery? If this boolean is not used, it may not appear straightforward why !memberOfAttr.isEmpty() enables this feature.

          Ref. the following block, we could embed the logic in fastLookup directly to simplify some bit?

          Done.

          Please have a line break between functions;

          Done.

          Please also avoid star imports;

          Done.

          Could we remove the word experimental in the user doc?

          Done.

          Thanks again for checking for the code style!

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Kai Zheng for the detailed review. Uploaded rev05 to address some of the comments: We could remove the variable useFastLookup, instead use memberOfAttr != null directly to indicate the case. What about renaming useFastLookup as useOneQuery ? If this boolean is not used, it may not appear straightforward why !memberOfAttr.isEmpty() enables this feature. Ref. the following block, we could embed the logic in fastLookup directly to simplify some bit? Done. Please have a line break between functions; Done. Please also avoid star imports; Done. Could we remove the word experimental in the user doc? Done. Thanks again for checking for the code style!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 46s trunk passed
          +1 compile 5m 40s trunk passed with JDK v1.8.0_91
          +1 compile 6m 36s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 58s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 32s trunk passed
          +1 javadoc 0m 52s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 40s the patch passed
          +1 compile 5m 38s the patch passed with JDK v1.8.0_91
          +1 javac 5m 38s the patch passed
          +1 compile 6m 36s the patch passed with JDK v1.7.0_95
          +1 javac 6m 36s the patch passed
          +1 checkstyle 0m 21s hadoop-common-project/hadoop-common: The patch generated 0 new + 32 unchanged - 2 fixed = 32 total (was 34)
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 48s the patch passed
          +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95
          -1 unit 7m 25s hadoop-common in the patch failed with JDK v1.8.0_91.
          -1 unit 7m 40s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          59m 6s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS
          JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802211/HADOOP-12782.005.patch
          JIRA Issue HADOOP-12782
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux d58dd7e11dd4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 36972d6
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9273/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9273/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9273/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9273/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9273/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9273/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 46s trunk passed +1 compile 5m 40s trunk passed with JDK v1.8.0_91 +1 compile 6m 36s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 32s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 40s the patch passed +1 compile 5m 38s the patch passed with JDK v1.8.0_91 +1 javac 5m 38s the patch passed +1 compile 6m 36s the patch passed with JDK v1.7.0_95 +1 javac 6m 36s the patch passed +1 checkstyle 0m 21s hadoop-common-project/hadoop-common: The patch generated 0 new + 32 unchanged - 2 fixed = 32 total (was 34) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_95 -1 unit 7m 25s hadoop-common in the patch failed with JDK v1.8.0_91. -1 unit 7m 40s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 59m 6s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.net.TestDNS JDK v1.7.0_95 Failed junit tests hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802211/HADOOP-12782.005.patch JIRA Issue HADOOP-12782 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux d58dd7e11dd4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 36972d6 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9273/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9273/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9273/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9273/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9273/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9273/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Sounds good and thanks for the update! It needs a rebase since HADOOP-13103 was in.

          Show
          drankye Kai Zheng added a comment - Sounds good and thanks for the update! It needs a rebase since HADOOP-13103 was in.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev06: thanks for the reminder. Here's the new patch after rebase. Please review again. Thanks!

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev06: thanks for the reminder. Here's the new patch after rebase. Please review again. Thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 58s trunk passed
          +1 compile 5m 45s trunk passed with JDK v1.8.0_91
          +1 compile 6m 36s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 1m 1s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 34s trunk passed
          +1 javadoc 0m 54s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 42s the patch passed
          +1 compile 6m 19s the patch passed with JDK v1.8.0_91
          +1 javac 6m 19s the patch passed
          +1 compile 7m 20s the patch passed with JDK v1.7.0_95
          +1 javac 7m 20s the patch passed
          -1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 9 new + 29 unchanged - 5 fixed = 38 total (was 34)
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 57s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95
          +1 unit 7m 44s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 13m 25s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          67m 15s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802966/HADOOP-12782.006.patch
          JIRA Issue HADOOP-12782
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux dfd4562a083b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 411fb4b
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9336/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9336/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9336/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 58s trunk passed +1 compile 5m 45s trunk passed with JDK v1.8.0_91 +1 compile 6m 36s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 54s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 42s the patch passed +1 compile 6m 19s the patch passed with JDK v1.8.0_91 +1 javac 6m 19s the patch passed +1 compile 7m 20s the patch passed with JDK v1.7.0_95 +1 javac 7m 20s the patch passed -1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 9 new + 29 unchanged - 5 fixed = 38 total (was 34) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 57s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95 +1 unit 7m 44s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 13m 25s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 67m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802966/HADOOP-12782.006.patch JIRA Issue HADOOP-12782 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux dfd4562a083b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 411fb4b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9336/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9336/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9336/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          HADOOP-12701 added checkstyle precommit checking for test files. I uploaded a new patch to fix checkstyle issues.

          Show
          jojochuang Wei-Chiu Chuang added a comment - HADOOP-12701 added checkstyle precommit checking for test files. I uploaded a new patch to fix checkstyle issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          +1 mvninstall 9m 2s trunk passed
          +1 compile 9m 24s trunk passed with JDK v1.8.0_91
          +1 compile 8m 51s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 1m 12s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 1m 59s trunk passed
          +1 javadoc 1m 12s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 21s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 52s the patch passed
          +1 compile 9m 25s the patch passed with JDK v1.8.0_91
          +1 javac 9m 25s the patch passed
          +1 compile 8m 48s the patch passed with JDK v1.7.0_95
          +1 javac 8m 48s the patch passed
          +1 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 0 new + 42 unchanged - 5 fixed = 42 total (was 47)
          +1 mvnsite 1m 10s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 findbugs 2m 14s the patch passed
          +1 javadoc 1m 11s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 18s the patch passed with JDK v1.7.0_95
          +1 unit 10m 23s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 10m 2s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          82m 4s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802998/HADOOP-12782.007.patch
          JIRA Issue HADOOP-12782
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 79f800e205d6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 411fb4b
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9339/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9339/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 9m 2s trunk passed +1 compile 9m 24s trunk passed with JDK v1.8.0_91 +1 compile 8m 51s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 12s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 1m 12s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 21s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 52s the patch passed +1 compile 9m 25s the patch passed with JDK v1.8.0_91 +1 javac 9m 25s the patch passed +1 compile 8m 48s the patch passed with JDK v1.7.0_95 +1 javac 8m 48s the patch passed +1 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 0 new + 42 unchanged - 5 fixed = 42 total (was 47) +1 mvnsite 1m 10s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 2m 14s the patch passed +1 javadoc 1m 11s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 18s the patch passed with JDK v1.7.0_95 +1 unit 10m 23s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 10m 2s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 82m 4s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802998/HADOOP-12782.007.patch JIRA Issue HADOOP-12782 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 79f800e205d6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 411fb4b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9339/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9339/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Sorry for the late. Thanks Wei-Chiu Chuang for the update! It looks almost perfect to me now. Some comments for the test codes:

          • Maybe we can rename: mockUserNamingEnum -> userNames, mockGroupNamingEnum -> groupNames, mappingSpy -> groupsMapping, or something like that. Also note the related methods.
          • For above mentioned mocked variables, is it possible to refactor and move all the related mock codes to the base class? For example:
                SearchResult mockUserResult = mock(SearchResult.class);
                when(getMockUserNamingEnum().nextElement()).thenReturn(mockUserResult);
            
          Show
          drankye Kai Zheng added a comment - Sorry for the late. Thanks Wei-Chiu Chuang for the update! It looks almost perfect to me now. Some comments for the test codes: Maybe we can rename: mockUserNamingEnum -> userNames, mockGroupNamingEnum -> groupNames, mappingSpy -> groupsMapping, or something like that. Also note the related methods. For above mentioned mocked variables, is it possible to refactor and move all the related mock codes to the base class? For example: SearchResult mockUserResult = mock(SearchResult.class); when(getMockUserNamingEnum().nextElement()).thenReturn(mockUserResult);
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Hi Kai, thanks again for your review.

          Good catch! I've refactored the code to include the suggestion you mentioned. However, not all mock code is moved to the base test class, because some code is specific to one test, and might cause confusion if done so.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Hi Kai, thanks again for your review. Good catch! I've refactored the code to include the suggestion you mentioned. However, not all mock code is moved to the base test class, because some code is specific to one test, and might cause confusion if done so.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          +1 mvninstall 6m 58s trunk passed
          +1 compile 7m 23s trunk passed with JDK v1.8.0_91
          +1 compile 6m 45s trunk passed with JDK v1.7.0_101
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 1m 0s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 34s trunk passed
          +1 javadoc 0m 56s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 4s trunk passed with JDK v1.7.0_101
          +1 mvninstall 0m 42s the patch passed
          +1 compile 6m 19s the patch passed with JDK v1.8.0_91
          +1 javac 6m 19s the patch passed
          +1 compile 6m 45s the patch passed with JDK v1.7.0_101
          +1 javac 6m 45s the patch passed
          -1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 1 new + 40 unchanged - 7 fixed = 41 total (was 47)
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 1m 48s the patch passed
          +1 javadoc 0m 53s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 8s the patch passed with JDK v1.7.0_101
          -1 unit 7m 19s hadoop-common in the patch failed with JDK v1.8.0_91.
          +1 unit 8m 14s hadoop-common in the patch passed with JDK v1.7.0_101.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          62m 43s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804272/HADOOP-12782.008.patch
          JIRA Issue HADOOP-12782
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 5856b1515daa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1217c8f
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9447/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9447/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9447/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9447/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9447/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 6m 58s trunk passed +1 compile 7m 23s trunk passed with JDK v1.8.0_91 +1 compile 6m 45s trunk passed with JDK v1.7.0_101 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 56s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 4s trunk passed with JDK v1.7.0_101 +1 mvninstall 0m 42s the patch passed +1 compile 6m 19s the patch passed with JDK v1.8.0_91 +1 javac 6m 19s the patch passed +1 compile 6m 45s the patch passed with JDK v1.7.0_101 +1 javac 6m 45s the patch passed -1 checkstyle 0m 24s hadoop-common-project/hadoop-common: The patch generated 1 new + 40 unchanged - 7 fixed = 41 total (was 47) +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 8s the patch passed with JDK v1.7.0_101 -1 unit 7m 19s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 8m 14s hadoop-common in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 62m 43s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804272/HADOOP-12782.008.patch JIRA Issue HADOOP-12782 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 5856b1515daa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1217c8f Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9447/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9447/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9447/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9447/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9447/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Rev09: fixed checkstyle warning. The test failure is unrelated.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Rev09: fixed checkstyle warning. The test failure is unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          -1 mvninstall 0m 7s root in trunk failed.
          +1 compile 7m 47s trunk passed with JDK v1.8.0_91
          -1 compile 0m 10s root in trunk failed with JDK v1.7.0_101.
          +1 checkstyle 0m 30s trunk passed
          -1 mvnsite 0m 18s hadoop-common in trunk failed.
          +1 mvneclipse 0m 15s trunk passed
          -1 findbugs 0m 13s hadoop-common in trunk failed.
          +1 javadoc 1m 0s trunk passed with JDK v1.8.0_91
          -1 javadoc 0m 12s hadoop-common in trunk failed with JDK v1.7.0_101.
          -1 mvninstall 0m 12s hadoop-common in the patch failed.
          +1 compile 7m 50s the patch passed with JDK v1.8.0_91
          +1 javac 7m 50s the patch passed
          -1 compile 0m 11s root in the patch failed with JDK v1.7.0_101.
          -1 javac 0m 11s root in the patch failed with JDK v1.7.0_101.
          +1 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 0 new + 40 unchanged - 7 fixed = 40 total (was 47)
          -1 mvnsite 0m 14s hadoop-common in the patch failed.
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          -1 findbugs 0m 12s hadoop-common in the patch failed.
          +1 javadoc 1m 2s the patch passed with JDK v1.8.0_91
          -1 javadoc 0m 12s hadoop-common in the patch failed with JDK v1.7.0_101.
          +1 unit 7m 3s hadoop-common in the patch passed with JDK v1.8.0_91.
          -1 unit 0m 11s hadoop-common in the patch failed with JDK v1.7.0_101.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          29m 50s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804294/HADOOP-12782.009.patch
          JIRA Issue HADOOP-12782
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 510862a84aab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4b55642
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/branch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/branch-compile-root-jdk1.7.0_101.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/branch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-compile-root-jdk1.7.0_101.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-compile-root-jdk1.7.0_101.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
          javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. -1 mvninstall 0m 7s root in trunk failed. +1 compile 7m 47s trunk passed with JDK v1.8.0_91 -1 compile 0m 10s root in trunk failed with JDK v1.7.0_101. +1 checkstyle 0m 30s trunk passed -1 mvnsite 0m 18s hadoop-common in trunk failed. +1 mvneclipse 0m 15s trunk passed -1 findbugs 0m 13s hadoop-common in trunk failed. +1 javadoc 1m 0s trunk passed with JDK v1.8.0_91 -1 javadoc 0m 12s hadoop-common in trunk failed with JDK v1.7.0_101. -1 mvninstall 0m 12s hadoop-common in the patch failed. +1 compile 7m 50s the patch passed with JDK v1.8.0_91 +1 javac 7m 50s the patch passed -1 compile 0m 11s root in the patch failed with JDK v1.7.0_101. -1 javac 0m 11s root in the patch failed with JDK v1.7.0_101. +1 checkstyle 0m 27s hadoop-common-project/hadoop-common: The patch generated 0 new + 40 unchanged - 7 fixed = 40 total (was 47) -1 mvnsite 0m 14s hadoop-common in the patch failed. +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. -1 findbugs 0m 12s hadoop-common in the patch failed. +1 javadoc 1m 2s the patch passed with JDK v1.8.0_91 -1 javadoc 0m 12s hadoop-common in the patch failed with JDK v1.7.0_101. +1 unit 7m 3s hadoop-common in the patch passed with JDK v1.8.0_91. -1 unit 0m 11s hadoop-common in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 29m 50s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804294/HADOOP-12782.009.patch JIRA Issue HADOOP-12782 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 510862a84aab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4b55642 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/branch-compile-root-jdk1.7.0_101.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/branch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/branch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-compile-root-jdk1.7.0_101.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-compile-root-jdk1.7.0_101.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9449/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Resubmit the v09 patch. The latest precommit failures were probably not related to this patch. My local yetus precommit test did not fail.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Resubmit the v09 patch. The latest precommit failures were probably not related to this patch. My local yetus precommit test did not fail.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          +1 mvninstall 9m 36s trunk passed
          +1 compile 10m 7s trunk passed
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 1m 11s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 1m 54s trunk passed
          +1 javadoc 1m 10s trunk passed
          +1 mvninstall 0m 58s the patch passed
          +1 compile 10m 34s the patch passed
          +1 javac 10m 34s the patch passed
          +1 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 0 new + 40 unchanged - 7 fixed = 40 total (was 47)
          +1 mvnsite 1m 15s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 2m 5s the patch passed
          +1 javadoc 1m 8s the patch passed
          -1 unit 9m 55s hadoop-common in the patch failed.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          53m 11s



          Reason Tests
          Failed junit tests hadoop.net.TestDNS



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804693/HADOOP-12782.009.patch
          JIRA Issue HADOOP-12782
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 43d0bc81fe77 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / f4d8fde
          Default Java 1.8.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9490/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9490/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9490/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9490/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 9m 36s trunk passed +1 compile 10m 7s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 1m 10s trunk passed +1 mvninstall 0m 58s the patch passed +1 compile 10m 34s the patch passed +1 javac 10m 34s the patch passed +1 checkstyle 0m 32s hadoop-common-project/hadoop-common: The patch generated 0 new + 40 unchanged - 7 fixed = 40 total (was 47) +1 mvnsite 1m 15s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 2m 5s the patch passed +1 javadoc 1m 8s the patch passed -1 unit 9m 55s hadoop-common in the patch failed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 53m 11s Reason Tests Failed junit tests hadoop.net.TestDNS Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804693/HADOOP-12782.009.patch JIRA Issue HADOOP-12782 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 43d0bc81fe77 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f4d8fde Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9490/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9490/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9490/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9490/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          The failed test is a know flaky test, unrelated to this patch.

          Show
          jojochuang Wei-Chiu Chuang added a comment - The failed test is a know flaky test, unrelated to this patch.
          Hide
          drankye Kai Zheng added a comment -

          Thnaks Wei-Chiu Chuang for the nice update! The latest LGTM. +1 will commit it shortly.

          Show
          drankye Kai Zheng added a comment - Thnaks Wei-Chiu Chuang for the nice update! The latest LGTM. +1 will commit it shortly.
          Hide
          drankye Kai Zheng added a comment -

          Committed to trunk. In case it's needed, my opinion is it's also good for other branches as well. Thanks Wei-Chiu Chuang for the contribution!

          Show
          drankye Kai Zheng added a comment - Committed to trunk. In case it's needed, my opinion is it's also good for other branches as well. Thanks Wei-Chiu Chuang for the contribution!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9823 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9823/)
          HADOOP-12782. Faster LDAP group name resolution with ActiveDirectory. (kai.zheng: rev 182fc1986a984ed0be6bed297390a830c2305af1)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/src/site/markdown/GroupsMapping.md
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMappingBase.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMappingWithPosixGroup.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMappingWithOneQuery.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9823 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9823/ ) HADOOP-12782 . Faster LDAP group name resolution with ActiveDirectory. (kai.zheng: rev 182fc1986a984ed0be6bed297390a830c2305af1) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMapping.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/site/markdown/GroupsMapping.md hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMappingBase.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMappingWithPosixGroup.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestLdapGroupsMappingWithOneQuery.java
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Thanks Kai Zheng for reviewing and committing!
          This is not incompatible with Hadoop 2, so it would be great to add this to branch-2. I did a local cherry-pick and found no conflicts. To be cautious, I am attaching the branch-2 patch for precommit validation.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Thanks Kai Zheng for reviewing and committing! This is not incompatible with Hadoop 2, so it would be great to add this to branch-2. I did a local cherry-pick and found no conflicts. To be cautious, I am attaching the branch-2 patch for precommit validation.
          Hide
          drankye Kai Zheng added a comment -

          Agree to include this to branch-2, thanks WeiChiu for the additional patch for it. Will check and commit it today.

          Show
          drankye Kai Zheng added a comment - Agree to include this to branch-2, thanks WeiChiu for the additional patch for it. Will check and commit it today.
          Hide
          drankye Kai Zheng added a comment -

          Committed to branch-2.

          Show
          drankye Kai Zheng added a comment - Committed to branch-2.
          Hide
          djp Junping Du added a comment -

          This patch is not landed in branch-2.8, mark fix version to 2.9.0 instead.

          Show
          djp Junping Du added a comment - This patch is not landed in branch-2.8, mark fix version to 2.9.0 instead.

            People

            • Assignee:
              jojochuang Wei-Chiu Chuang
              Reporter:
              jojochuang Wei-Chiu Chuang
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development