Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12751

While using kerberos Hadoop incorrectly assumes names with '@' to be non-simple

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: security
    • Labels:
    • Environment:

      kerberos

      Description

      In the scenario of a trust between two directories, eg. FreeIPA (ipa.local) and Active Directory (ad.local) users can be made available on the OS level by something like sssd. The trusted users will be of the form 'user@ad.local' while other users are will not contain the domain. Executing 'id -Gn user@ad.local' will successfully return the groups the user belongs to if configured correctly.

      However, it is assumed by Hadoop that users of the format with '@' cannot be correct. This code is in KerberosName.java and seems to be a validator if the 'auth_to_local' rules are applied correctly.

      In my opinion this should be removed or changed to a different kind of check or maybe logged as a warning while still proceeding, as the current behavior limits integration possibilities with other standard tools.

      Workaround are difficult to apply (by having a rewrite by system tools to for example user_ad_local) due to down stream consequences.

      1. 0001-HADOOP-12751-leave-user-validation-to-os.patch
        2 kB
        Bolke de Bruin
      2. 0001-Remove-check-for-user-name-characters-and.patch
        5 kB
        Bolke de Bruin
      3. 0002-HADOOP-12751-leave-user-validation-to-os.patch
        3 kB
        Bolke de Bruin
      4. 0003-HADOOP-12751-leave-user-validation-to-os.patch
        4 kB
        Bolke de Bruin
      5. 0004-HADOOP-12751-leave-user-validation-to-os.patch
        5 kB
        Bolke de Bruin
      6. 0005-HADOOP-12751-leave-user-validation-to-os.patch
        10 kB
        Bolke de Bruin
      7. 0006-HADOOP-12751-leave-user-validation-to-os.patch
        12 kB
        Bolke de Bruin
      8. 0007-HADOOP-12751-leave-user-validation-to-os.patch
        13 kB
        Bolke de Bruin
      9. 0007-HADOOP-12751-leave-user-validation-to-os.patch
        13 kB
        Bolke de Bruin
      10. 0008-HADOOP-12751-leave-user-validation-to-os.patch
        13 kB
        Bolke de Bruin
      11. 0008-HADOOP-12751-leave-user-validation-to-os.patch
        13 kB
        Bolke de Bruin
      12. HADOOP-12751-009.patch
        13 kB
        Steve Loughran

        Issue Links

          Activity

          Hide
          templedf Daniel Templeton added a comment -

          So the suggestion is to remove the validation check and let the login failure be the real test. That seems reasonable to me.

          Show
          templedf Daniel Templeton added a comment - So the suggestion is to remove the validation check and let the login failure be the real test. That seems reasonable to me.
          Hide
          bolke Bolke de Bruin added a comment -

          Yes if my assumption correct. I can prepare a small patch for this.

          Show
          bolke Bolke de Bruin added a comment - Yes if my assumption correct. I can prepare a small patch for this.
          Hide
          bolke Bolke de Bruin added a comment -

          This removes the erroneous validation check and leaves it to the os

          Show
          bolke Bolke de Bruin added a comment - This removes the erroneous validation check and leaves it to the os
          Hide
          bolke Bolke de Bruin added a comment -

          Please note that zookeeper has the same code. I'm note sure what is "upstream" in this case or if I need to report it separately.

          Show
          bolke Bolke de Bruin added a comment - Please note that zookeeper has the same code. I'm note sure what is "upstream" in this case or if I need to report it separately.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 35s trunk passed
          +1 compile 6m 3s trunk passed with JDK v1.8.0_66
          +1 compile 6m 58s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 21s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 15s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 16s the patch passed
          +1 compile 6m 2s the patch passed with JDK v1.8.0_66
          +1 javac 6m 2s the patch passed
          +1 compile 6m 58s the patch passed with JDK v1.7.0_91
          +1 javac 6m 58s the patch passed
          +1 checkstyle 0m 13s hadoop-common-project/hadoop-auth: patch generated 0 new + 12 unchanged - 1 fixed = 12 total (was 13)
          +1 mvnsite 0m 21s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 39s the patch passed
          +1 javadoc 0m 12s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 15s the patch passed with JDK v1.7.0_91
          +1 unit 3m 33s hadoop-auth in the patch passed with JDK v1.8.0_66.
          +1 unit 3m 58s hadoop-auth in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          45m 32s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785270/0001-HADOOP-12751-leave-user-validation-to-os.patch
          JIRA Issue HADOOP-12751
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 73f872f829ca 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 772ea7b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8496/testReport/
          modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8496/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 35s trunk passed +1 compile 6m 3s trunk passed with JDK v1.8.0_66 +1 compile 6m 58s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 21s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 16s the patch passed +1 compile 6m 2s the patch passed with JDK v1.8.0_66 +1 javac 6m 2s the patch passed +1 compile 6m 58s the patch passed with JDK v1.7.0_91 +1 javac 6m 58s the patch passed +1 checkstyle 0m 13s hadoop-common-project/hadoop-auth: patch generated 0 new + 12 unchanged - 1 fixed = 12 total (was 13) +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 39s the patch passed +1 javadoc 0m 12s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 15s the patch passed with JDK v1.7.0_91 +1 unit 3m 33s hadoop-auth in the patch passed with JDK v1.8.0_66. +1 unit 3m 58s hadoop-auth in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 45m 32s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785270/0001-HADOOP-12751-leave-user-validation-to-os.patch JIRA Issue HADOOP-12751 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 73f872f829ca 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 772ea7b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8496/testReport/ modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8496/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 44s trunk passed
          +1 compile 6m 3s trunk passed with JDK v1.8.0_66
          +1 compile 6m 49s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 21s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 13s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 14s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 16s the patch passed
          +1 compile 5m 54s the patch passed with JDK v1.8.0_66
          +1 javac 5m 54s the patch passed
          +1 compile 6m 49s the patch passed with JDK v1.7.0_91
          +1 javac 6m 49s the patch passed
          +1 checkstyle 0m 14s hadoop-common-project/hadoop-auth: patch generated 0 new + 12 unchanged - 1 fixed = 12 total (was 13)
          +1 mvnsite 0m 21s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 0m 38s the patch passed
          +1 javadoc 0m 12s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 15s the patch passed with JDK v1.7.0_91
          +1 unit 13m 19s hadoop-auth in the patch passed with JDK v1.8.0_66.
          +1 unit 13m 23s hadoop-auth in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          64m 31s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785279/0002-HADOOP-12751-leave-user-validation-to-os.patch
          JIRA Issue HADOOP-12751
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7950275fba24 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 772ea7b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8497/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8497/testReport/
          modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8497/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 44s trunk passed +1 compile 6m 3s trunk passed with JDK v1.8.0_66 +1 compile 6m 49s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 21s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 16s the patch passed +1 compile 5m 54s the patch passed with JDK v1.8.0_66 +1 javac 5m 54s the patch passed +1 compile 6m 49s the patch passed with JDK v1.7.0_91 +1 javac 6m 49s the patch passed +1 checkstyle 0m 14s hadoop-common-project/hadoop-auth: patch generated 0 new + 12 unchanged - 1 fixed = 12 total (was 13) +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 12s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 15s the patch passed with JDK v1.7.0_91 +1 unit 13m 19s hadoop-auth in the patch passed with JDK v1.8.0_66. +1 unit 13m 23s hadoop-auth in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 64m 31s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785279/0002-HADOOP-12751-leave-user-validation-to-os.patch JIRA Issue HADOOP-12751 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7950275fba24 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 772ea7b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8497/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8497/testReport/ modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8497/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 16s trunk passed
          +1 compile 7m 8s trunk passed with JDK v1.8.0_66
          +1 compile 7m 35s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 0m 20s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 26s trunk passed
          +1 javadoc 0m 11s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 13s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 16s the patch passed
          +1 compile 6m 50s the patch passed with JDK v1.8.0_66
          +1 javac 6m 50s the patch passed
          +1 compile 7m 20s the patch passed with JDK v1.7.0_91
          +1 javac 7m 20s the patch passed
          +1 checkstyle 0m 13s hadoop-common-project/hadoop-auth: patch generated 0 new + 12 unchanged - 1 fixed = 12 total (was 13)
          +1 mvnsite 0m 21s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 40s the patch passed
          +1 javadoc 0m 12s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 13s the patch passed with JDK v1.7.0_91
          +1 unit 3m 41s hadoop-auth in the patch passed with JDK v1.8.0_66.
          +1 unit 3m 59s hadoop-auth in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          49m 17s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785290/0003-HADOOP-12751-leave-user-validation-to-os.patch
          JIRA Issue HADOOP-12751
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3136381f18aa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 772ea7b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8498/testReport/
          modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8498/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 16s trunk passed +1 compile 7m 8s trunk passed with JDK v1.8.0_66 +1 compile 7m 35s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 20s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 26s trunk passed +1 javadoc 0m 11s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 13s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 16s the patch passed +1 compile 6m 50s the patch passed with JDK v1.8.0_66 +1 javac 6m 50s the patch passed +1 compile 7m 20s the patch passed with JDK v1.7.0_91 +1 javac 7m 20s the patch passed +1 checkstyle 0m 13s hadoop-common-project/hadoop-auth: patch generated 0 new + 12 unchanged - 1 fixed = 12 total (was 13) +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 40s the patch passed +1 javadoc 0m 12s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_91 +1 unit 3m 41s hadoop-auth in the patch passed with JDK v1.8.0_66. +1 unit 3m 59s hadoop-auth in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 49m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785290/0003-HADOOP-12751-leave-user-validation-to-os.patch JIRA Issue HADOOP-12751 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3136381f18aa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 772ea7b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8498/testReport/ modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8498/console This message was automatically generated.
          Hide
          bolke Bolke de Bruin added a comment -
          • whitespace fix
          • Tests have been adjusted to check "fall through" of the rules. Invalid names do not really exist anymore .

          Caveat: does hadoop allow for "/" (slash) in user names? If not patch needs to be adjusted.

          Show
          bolke Bolke de Bruin added a comment - whitespace fix Tests have been adjusted to check "fall through" of the rules. Invalid names do not really exist anymore . Caveat: does hadoop allow for "/" (slash) in user names? If not patch needs to be adjusted.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 18s trunk passed
          +1 compile 7m 9s trunk passed with JDK v1.8.0_66
          +1 compile 7m 40s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 22s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 13s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 14s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 16s the patch passed
          +1 compile 7m 2s the patch passed with JDK v1.8.0_66
          +1 javac 7m 2s the patch passed
          +1 compile 7m 34s the patch passed with JDK v1.7.0_91
          +1 javac 7m 34s the patch passed
          +1 checkstyle 0m 13s hadoop-common-project/hadoop-auth: patch generated 0 new + 12 unchanged - 1 fixed = 12 total (was 13)
          +1 mvnsite 0m 21s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 46s the patch passed
          +1 javadoc 0m 12s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 15s the patch passed with JDK v1.7.0_91
          +1 unit 3m 42s hadoop-auth in the patch passed with JDK v1.8.0_66.
          +1 unit 4m 6s hadoop-auth in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          50m 18s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785344/0004-HADOOP-12751-leave-user-validation-to-os.patch
          JIRA Issue HADOOP-12751
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4a7615fe5349 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 772ea7b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8500/testReport/
          modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8500/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 18s trunk passed +1 compile 7m 9s trunk passed with JDK v1.8.0_66 +1 compile 7m 40s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 16s the patch passed +1 compile 7m 2s the patch passed with JDK v1.8.0_66 +1 javac 7m 2s the patch passed +1 compile 7m 34s the patch passed with JDK v1.7.0_91 +1 javac 7m 34s the patch passed +1 checkstyle 0m 13s hadoop-common-project/hadoop-auth: patch generated 0 new + 12 unchanged - 1 fixed = 12 total (was 13) +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 46s the patch passed +1 javadoc 0m 12s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 15s the patch passed with JDK v1.7.0_91 +1 unit 3m 42s hadoop-auth in the patch passed with JDK v1.8.0_66. +1 unit 4m 6s hadoop-auth in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 50m 18s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785344/0004-HADOOP-12751-leave-user-validation-to-os.patch JIRA Issue HADOOP-12751 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4a7615fe5349 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 772ea7b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8500/testReport/ modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8500/console This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          / is integral to differentiate simple names "user@realm" from names with a host "user/host.ex.org@realm". I don't know if simple users with / are supported, or what that would actually mean

          Show
          stevel@apache.org Steve Loughran added a comment - / is integral to differentiate simple names "user@realm" from names with a host "user/host.ex.org@realm". I don't know if simple users with / are supported, or what that would actually mean
          Hide
          bolke Bolke de Bruin added a comment -

          Steve Loughran I understand that, however the MIT Kerberos implementation does not force rules to apply, ie they can fall through. Executing "id bolke/joe" works as expected (returns no such user), although I cannot add such a user locally it seems. Thus OS does not seem to really care, it gives functional errors, so per Daniel Templeton the check for a valid user can be left to the OS.

          This means the check is there to protect Hadoop's assumptions and I think the question is will it create regression within Hadoop somehow and does not throwing an exception (IOException derived) cause big issues in Hadoop's internals? Remember the RULEs still apply, so normally "user/host.ex.org@realm" would be transformed if configured correctly. So this patch would put more responsibility on the administrator to make sure the rules cover what is needed, but that is the case anyway with a krb5.conf as well.

          Like I mentioned I can re-add the check on '/' to be on the safe side, but I wonder if it is required.

          Show
          bolke Bolke de Bruin added a comment - Steve Loughran I understand that, however the MIT Kerberos implementation does not force rules to apply, ie they can fall through. Executing "id bolke/joe" works as expected (returns no such user), although I cannot add such a user locally it seems. Thus OS does not seem to really care, it gives functional errors, so per Daniel Templeton the check for a valid user can be left to the OS. This means the check is there to protect Hadoop's assumptions and I think the question is will it create regression within Hadoop somehow and does not throwing an exception (IOException derived) cause big issues in Hadoop's internals? Remember the RULEs still apply, so normally "user/host.ex.org@realm" would be transformed if configured correctly. So this patch would put more responsibility on the administrator to make sure the rules cover what is needed, but that is the case anyway with a krb5.conf as well. Like I mentioned I can re-add the check on '/' to be on the safe side, but I wonder if it is required.
          Hide
          bolke Bolke de Bruin added a comment -

          I would suggest (in the future?) to rename this function to "getLocalName" which is in line with corresponding method in MIT/Heimdal "an2ln" (a name to local name).

          Show
          bolke Bolke de Bruin added a comment - I would suggest (in the future?) to rename this function to "getLocalName" which is in line with corresponding method in MIT/Heimdal "an2ln" (a name to local name).
          Hide
          templedf Daniel Templeton added a comment -

          Looking at the patch, it seems sound. My only concern is that the code you're taking out has been in there so long, other code may now assume that an OS username cannot contain a slash. Have you applied this patch and tested it in a live system? Did you try in one that supports a slash and one that doesn't?

          Show
          templedf Daniel Templeton added a comment - Looking at the patch, it seems sound. My only concern is that the code you're taking out has been in there so long, other code may now assume that an OS username cannot contain a slash. Have you applied this patch and tested it in a live system? Did you try in one that supports a slash and one that doesn't?
          Hide
          bolke Bolke de Bruin added a comment -

          Sure I understand the general concern, but I have difficulty grasping the use case. Firstly, this goes for kerberized clusters which are not as widespread although picking up. Secondly, there would need to be code that relies on an exception to do something meaningful afterwards.

          We are running this patch now in our test environment. Although coming by a system that does create users with a '/' is hard to come by, I think I can come up with something (making sssd return this kind of users). Maybe give it a week or so and then I report back?

          Show
          bolke Bolke de Bruin added a comment - Sure I understand the general concern, but I have difficulty grasping the use case. Firstly, this goes for kerberized clusters which are not as widespread although picking up. Secondly, there would need to be code that relies on an exception to do something meaningful afterwards. We are running this patch now in our test environment. Although coming by a system that does create users with a '/' is hard to come by, I think I can come up with something (making sssd return this kind of users). Maybe give it a week or so and then I report back?
          Hide
          templedf Daniel Templeton added a comment -

          Sounds like a plan. Thanks, Bolke de Bruin!

          Show
          templedf Daniel Templeton added a comment - Sounds like a plan. Thanks, Bolke de Bruin !
          Hide
          stevel@apache.org Steve Loughran added a comment -
          1. pretty much all production enterprise customers run Hadoop in Kerberos mode. I know that as Kerberos related problems seem to often reach me. I don't want any more.
          2. Kerberos and Hadoop integration is a pain point, with a combination of a security infrastructure brittle to host, network, DNS and clock config, meaningless error messages coming from the JVM libs, and our own UGI code not doing anything to help.
          3. no, methods don't get renamed, on the basis of (a) "short name" is a concept in Hadoop (specifically, the bit before the /) and (b) things outside hadoop core will be using it.

          For that reason, I'd be tempted to leave the / check in, even if @ is addressed.

          Show
          stevel@apache.org Steve Loughran added a comment - pretty much all production enterprise customers run Hadoop in Kerberos mode. I know that as Kerberos related problems seem to often reach me. I don't want any more. Kerberos and Hadoop integration is a pain point, with a combination of a security infrastructure brittle to host, network, DNS and clock config, meaningless error messages coming from the JVM libs, and our own UGI code not doing anything to help. no, methods don't get renamed, on the basis of (a) "short name" is a concept in Hadoop (specifically, the bit before the /) and (b) things outside hadoop core will be using it. For that reason, I'd be tempted to leave the / check in, even if @ is addressed.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          ps, regarding the patch, don't catch exceptions and convert to fails. just throw it all the way up. And for the codepath that expects a failure, have its failure path (getShortName() returns something), include what gets returned.

          Think "If I were trying to debug this from nothing but a jenkins run, what information would I like —and what information is my test case currently losing?"

          see: https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md

          Show
          stevel@apache.org Steve Loughran added a comment - ps, regarding the patch, don't catch exceptions and convert to fails. just throw it all the way up. And for the codepath that expects a failure, have its failure path (getShortName() returns something), include what gets returned. Think "If I were trying to debug this from nothing but a jenkins run, what information would I like —and what information is my test case currently losing?" see: https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md
          Hide
          bolke Bolke de Bruin added a comment -

          Steve Loughran will keep your comments in mind and update the patch. As for our case (yes enterprise customer) we don't need '/' support in usernames so I can re-add it. I will run without it for a week and report back.

          For now we only found an issue with Hive that has a separate and different code path also sanitizing user names with '@'.

          Show
          bolke Bolke de Bruin added a comment - Steve Loughran will keep your comments in mind and update the patch. As for our case (yes enterprise customer) we don't need '/' support in usernames so I can re-add it. I will run without it for a week and report back. For now we only found an issue with Hive that has a separate and different code path also sanitizing user names with '@'.
          Hide
          bolke Bolke de Bruin added a comment -

          Reporting on local testing:

          /etc/passwd:
          bolke/:x:1017:1017::/home/bolke:/bin/bash

          1. HDFS
            hdfs dfs -mkdir /test
            hdfs dfs -chown bolke/ /test

          hdfs dfs -ls /
          Found 9 items
          drwxrwxrwx - yarn hadoop 0 2016-01-28 19:28 /app-logs
          drwxr-xr-x - hdfs hdfs 0 2016-01-28 19:27 /apps
          drwxr-xr-x - yarn hadoop 0 2016-01-28 19:24 /ats
          drwxr-xr-x - hdfs hdfs 0 2016-01-28 19:24 /hdp
          drwxr-xr-x - mapred hdfs 0 2016-01-28 19:24 /mapred
          drwxrwxrwx - mapred hadoop 0 2016-01-28 19:24 /mr-history
          drwxr-xr-x - bolke/ hdfs 0 2016-02-12 22:22 /test
          drwxrwxrwx - hdfs hdfs 0 2016-02-02 09:58 /tmp
          drwxr-xr-x - hdfs hdfs 0 2016-01-28 19:27 /user

          1. Hive has small issue not allowing @ or / in separate code path, patch has been submitted.
          2. Zookeeper maintains separate KerberosName and will need to be updated (but we havent seen any issues)

          We havent been able to find regressions in our (admittedly) small scale testing. We did test however on kerberized and non-kerberized clusters.

          Please advise how to proceed (will update patch to fix tests).

          Show
          bolke Bolke de Bruin added a comment - Reporting on local testing: /etc/passwd: bolke/:x:1017:1017::/home/bolke:/bin/bash HDFS hdfs dfs -mkdir /test hdfs dfs -chown bolke/ /test hdfs dfs -ls / Found 9 items drwxrwxrwx - yarn hadoop 0 2016-01-28 19:28 /app-logs drwxr-xr-x - hdfs hdfs 0 2016-01-28 19:27 /apps drwxr-xr-x - yarn hadoop 0 2016-01-28 19:24 /ats drwxr-xr-x - hdfs hdfs 0 2016-01-28 19:24 /hdp drwxr-xr-x - mapred hdfs 0 2016-01-28 19:24 /mapred drwxrwxrwx - mapred hadoop 0 2016-01-28 19:24 /mr-history drwxr-xr-x - bolke/ hdfs 0 2016-02-12 22:22 /test drwxrwxrwx - hdfs hdfs 0 2016-02-02 09:58 /tmp drwxr-xr-x - hdfs hdfs 0 2016-01-28 19:27 /user Hive has small issue not allowing @ or / in separate code path, patch has been submitted. Zookeeper maintains separate KerberosName and will need to be updated (but we havent seen any issues) We havent been able to find regressions in our (admittedly) small scale testing. We did test however on kerberized and non-kerberized clusters. Please advise how to proceed (will update patch to fix tests).
          Hide
          bolke Bolke de Bruin added a comment -

          Patch with updated tests

          Show
          bolke Bolke de Bruin added a comment - Patch with updated tests
          Hide
          bolke Bolke de Bruin added a comment -

          Ping Daniel Templeton Steve Loughran

          If you don't mind please provide some feedback. I see 4 options going forward.

          1. Keep as-is. Obviously not preferred in my opinion
          2. Remove check for '@'. Solves my issues, but is imho less elegant. Might run into issues triggered by having a '@' in the name.
          3. Remove check fully. Leaves check to the OS. Might run into issues triggered by having a '@' or '/' or not throwing an exception at all.
          4. Make it configurable, for example based on a regex. On linux it used to be NAME_REGEX to verify usernames for /etc/passwd. However this seems not enforced everywhere (and neither really required) and it might create extra complexity in supporting this (ie. multiple possibilities).

          What are your thoughts?

          Show
          bolke Bolke de Bruin added a comment - Ping Daniel Templeton Steve Loughran If you don't mind please provide some feedback. I see 4 options going forward. 1. Keep as-is. Obviously not preferred in my opinion 2. Remove check for '@'. Solves my issues, but is imho less elegant. Might run into issues triggered by having a '@' in the name. 3. Remove check fully. Leaves check to the OS. Might run into issues triggered by having a '@' or '/' or not throwing an exception at all. 4. Make it configurable, for example based on a regex. On linux it used to be NAME_REGEX to verify usernames for /etc/passwd. However this seems not enforced everywhere (and neither really required) and it might create extra complexity in supporting this (ie. multiple possibilities). What are your thoughts?
          Hide
          bolke Bolke de Bruin added a comment -
          Show
          bolke Bolke de Bruin added a comment - Daniel Templeton Steve Loughran Any response?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          sorry, been to busy to look at this. More pressing Kerberos problems, like "why won't services talk to each other. Linked to the big "fix kerberos" JIRA. I'm also tagging stevel-to-review so I can find it the next time I'm doing a review session.

          Show
          stevel@apache.org Steve Loughran added a comment - sorry, been to busy to look at this. More pressing Kerberos problems, like "why won't services talk to each other. Linked to the big "fix kerberos" JIRA. I'm also tagging stevel-to-review so I can find it the next time I'm doing a review session.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          One issue with OS login is that it is inevitably going to fail with "GSSAPI Unknown Exception". + <something meaningless>. The pattern not only fails fast, it fails meaningfully, which is useful when there are people trying to debug it.

          I think we should retain that check, giving people the option of disabling it if there are problems. Either as a regexp or a simple "use standard check" pattern

          Show
          stevel@apache.org Steve Loughran added a comment - One issue with OS login is that it is inevitably going to fail with "GSSAPI Unknown Exception". + <something meaningless>. The pattern not only fails fast, it fails meaningfully, which is useful when there are people trying to debug it. I think we should retain that check, giving people the option of disabling it if there are problems. Either as a regexp or a simple "use standard check" pattern
          Hide
          bolke Bolke de Bruin added a comment -

          Steve Loughran I assume that you mean "make it configurable"? That's fine to me and I will update the patch to do so.

          Show
          bolke Bolke de Bruin added a comment - Steve Loughran I assume that you mean "make it configurable"? That's fine to me and I will update the patch to do so.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          yes, I mean the existing pattern check will take place unless explicitly disabled

          Show
          stevel@apache.org Steve Loughran added a comment - yes, I mean the existing pattern check will take place unless explicitly disabled
          Hide
          bolke Bolke de Bruin added a comment -

          What do you consider the proper approach to make this configurable? I see that in hadoop-auth there is no reliance on org.apache.hadoop.conf.Configuration, should I introduce it here or is there a smarter approach?

          Show
          bolke Bolke de Bruin added a comment - What do you consider the proper approach to make this configurable? I see that in hadoop-auth there is no reliance on org.apache.hadoop.conf.Configuration, should I introduce it here or is there a smarter approach?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          oh, that's a problem. I'd assumed there was.

          Do others have suggestions here? I don't want to go near JVM properties if we can avoid it, which leaves what? A secret environment variable?

          Maybe Allen Wittenauer will have an opinion?

          Show
          stevel@apache.org Steve Loughran added a comment - oh, that's a problem. I'd assumed there was. Do others have suggestions here? I don't want to go near JVM properties if we can avoid it, which leaves what? A secret environment variable? Maybe Allen Wittenauer will have an opinion?
          Hide
          drankye Kai Zheng added a comment -

          I thought the codes should be good and ok to be moved to hadoop-common module, keeping the same package path. hadoop-auth just can't rely on hadoop-common, because hadoop-common relies on hadoop-auth.

          Bolke,
          I saw you had tested on HDFS with and without Kerberos enabled. It sounds a good base. Did you enforce and check authorization (at least in Hadoop)? Many authorization or acl rules use usernames and they should still parse.

          Show
          drankye Kai Zheng added a comment - I thought the codes should be good and ok to be moved to hadoop-common module, keeping the same package path. hadoop-auth just can't rely on hadoop-common, because hadoop-common relies on hadoop-auth. Bolke, I saw you had tested on HDFS with and without Kerberos enabled. It sounds a good base. Did you enforce and check authorization (at least in Hadoop)? Many authorization or acl rules use usernames and they should still parse.
          Hide
          drankye Kai Zheng added a comment -

          Moving the codes impacts big. Maybe the class can add a parameter and method to enable/disable the check. Then in the places using the class it can support configuration, like the many properties used by authentication filters/handlers.

          Show
          drankye Kai Zheng added a comment - Moving the codes impacts big. Maybe the class can add a parameter and method to enable/disable the check. Then in the places using the class it can support configuration, like the many properties used by authentication filters/handlers.
          Hide
          bolke Bolke de Bruin added a comment -

          Kai Zheng yes we did. We did: we found some issues in some components e.g. hive but they have been fixed by submitting patches (hive was employing its own mechanism). Apache Ranger has some UI issues, but they are non blocking. Zookeeper uses its copy of hadoop-auth, might need to be synced but we haven't seen any issues because of it.

          Show
          bolke Bolke de Bruin added a comment - Kai Zheng yes we did. We did: we found some issues in some components e.g. hive but they have been fixed by submitting patches (hive was employing its own mechanism). Apache Ranger has some UI issues, but they are non blocking. Zookeeper uses its copy of hadoop-auth, might need to be synced but we haven't seen any issues because of it.
          Hide
          stevel@apache.org Steve Loughran added a comment -
          1. we have to leave the auth code in hadoop-auth; things downstream sometimes import that specific JAR and expect kerberos to be there. (I don't know why the auth stuff isn't in hadoop-common; that's an inconvenience and a mystery)
          2. and we can't move Configuration, not when it triggers the loading of core-default and core-site XML, which would have to be in too, etc, etc.

          Here's an alternate proposal.

          1. the logic to pattern check is retained, the check made
          2. .... but it's downgraded to a log@info. People can even edit log4j to make that go away
          3. kdiag is extended to do the pattern check, add an option to fail if the username considered invalid

          This way: no need to do config of the client, some information gets published to explain why things aren't working, and KDiag does the full checking

          Show
          stevel@apache.org Steve Loughran added a comment - we have to leave the auth code in hadoop-auth; things downstream sometimes import that specific JAR and expect kerberos to be there. (I don't know why the auth stuff isn't in hadoop-common; that's an inconvenience and a mystery) and we can't move Configuration, not when it triggers the loading of core-default and core-site XML, which would have to be in too, etc, etc. Here's an alternate proposal. the logic to pattern check is retained, the check made .... but it's downgraded to a log@info. People can even edit log4j to make that go away kdiag is extended to do the pattern check, add an option to fail if the username considered invalid This way: no need to do config of the client, some information gets published to explain why things aren't working, and KDiag does the full checking
          Hide
          bolke Bolke de Bruin added a comment -

          Ah. I like that approach. I will cook something up, hopefully today

          Show
          bolke Bolke de Bruin added a comment - Ah. I like that approach. I will cook something up, hopefully today
          Hide
          bolke Bolke de Bruin added a comment -

          Updated patch with logging to @info and kdiag extension.

          Show
          bolke Bolke de Bruin added a comment - Updated patch with logging to @info and kdiag extension.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          LTGM, apart from something minor about a test I could fix myself when applying (there's no need to catch an exception and call Assert.fail(); just have the test method declare that it throws the exception and let junit handle the failure).

          Let's see what Jenkins says

          Show
          stevel@apache.org Steve Loughran added a comment - LTGM, apart from something minor about a test I could fix myself when applying (there's no need to catch an exception and call Assert.fail(); just have the test method declare that it throws the exception and let junit handle the failure). Let's see what Jenkins says
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 22s Maven dependency ordering for branch
          +1 mvninstall 6m 35s trunk passed
          +1 compile 5m 47s trunk passed with JDK v1.8.0_77
          +1 compile 6m 34s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 1m 15s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 2m 0s trunk passed
          +1 javadoc 1m 3s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 16s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 0m 54s the patch passed
          +1 compile 5m 41s the patch passed with JDK v1.8.0_77
          +1 javac 5m 41s the patch passed
          +1 compile 6m 37s the patch passed with JDK v1.7.0_95
          +1 javac 6m 37s the patch passed
          -1 checkstyle 0m 25s hadoop-common-project: patch generated 4 new + 93 unchanged - 0 fixed = 97 total (was 93)
          +1 mvnsite 1m 13s the patch passed
          +1 mvneclipse 0m 24s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 21s the patch passed
          +1 javadoc 1m 4s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 15s the patch passed with JDK v1.7.0_95
          +1 unit 3m 38s hadoop-auth in the patch passed with JDK v1.8.0_77.
          -1 unit 6m 48s hadoop-common in the patch failed with JDK v1.8.0_77.
          +1 unit 4m 1s hadoop-auth in the patch passed with JDK v1.7.0_95.
          -1 unit 7m 7s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          69m 9s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.security.TestUserGroupInformation
            hadoop.security.TestKDiag
            hadoop.security.ssl.TestReloadingX509TrustManager
          JDK v1.7.0_95 Failed junit tests hadoop.security.TestUserGroupInformation
            hadoop.security.TestKDiag



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799510/0005-HADOOP-12751-leave-user-validation-to-os.patch
          JIRA Issue HADOOP-12751
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e260f6214e15 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 90d1af1
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/testReport/
          modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 22s Maven dependency ordering for branch +1 mvninstall 6m 35s trunk passed +1 compile 5m 47s trunk passed with JDK v1.8.0_77 +1 compile 6m 34s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 27s trunk passed +1 mvnsite 1m 15s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 2m 0s trunk passed +1 javadoc 1m 3s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 16s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 54s the patch passed +1 compile 5m 41s the patch passed with JDK v1.8.0_77 +1 javac 5m 41s the patch passed +1 compile 6m 37s the patch passed with JDK v1.7.0_95 +1 javac 6m 37s the patch passed -1 checkstyle 0m 25s hadoop-common-project: patch generated 4 new + 93 unchanged - 0 fixed = 97 total (was 93) +1 mvnsite 1m 13s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 21s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 15s the patch passed with JDK v1.7.0_95 +1 unit 3m 38s hadoop-auth in the patch passed with JDK v1.8.0_77. -1 unit 6m 48s hadoop-common in the patch failed with JDK v1.8.0_77. +1 unit 4m 1s hadoop-auth in the patch passed with JDK v1.7.0_95. -1 unit 7m 7s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 69m 9s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.security.TestUserGroupInformation   hadoop.security.TestKDiag   hadoop.security.ssl.TestReloadingX509TrustManager JDK v1.7.0_95 Failed junit tests hadoop.security.TestUserGroupInformation   hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799510/0005-HADOOP-12751-leave-user-validation-to-os.patch JIRA Issue HADOOP-12751 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e260f6214e15 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 90d1af1 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9116/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          bolke Bolke de Bruin added a comment -

          Ok. Ill have a look at the errors (I had some trouble running tests for hadoop-common) and fix the codestyle issues.

          Show
          bolke Bolke de Bruin added a comment - Ok. Ill have a look at the errors (I had some trouble running tests for hadoop-common) and fix the codestyle issues.
          Hide
          bolke Bolke de Bruin added a comment -
          • Fixed code-style issues, except "nonSimplePattern" to keep it equivalent to the one in KerberosName.
          • Fixed test cases for new behavior
          Show
          bolke Bolke de Bruin added a comment - Fixed code-style issues, except "nonSimplePattern" to keep it equivalent to the one in KerberosName. Fixed test cases for new behavior
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 6m 54s trunk passed
          +1 compile 5m 58s trunk passed with JDK v1.8.0_77
          +1 compile 6m 49s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 1m 18s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 2m 1s trunk passed
          +1 javadoc 1m 4s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 20s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 0m 56s the patch passed
          +1 compile 5m 46s the patch passed with JDK v1.8.0_77
          +1 javac 5m 46s the patch passed
          +1 compile 6m 47s the patch passed with JDK v1.7.0_95
          +1 javac 6m 47s the patch passed
          -1 checkstyle 0m 26s hadoop-common-project: patch generated 1 new + 93 unchanged - 0 fixed = 94 total (was 93)
          +1 mvnsite 1m 17s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 28s the patch passed
          +1 javadoc 1m 4s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 19s the patch passed with JDK v1.7.0_95
          +1 unit 14m 9s hadoop-auth in the patch passed with JDK v1.8.0_77.
          -1 unit 6m 49s hadoop-common in the patch failed with JDK v1.8.0_77.
          +1 unit 13m 21s hadoop-auth in the patch passed with JDK v1.7.0_95.
          -1 unit 7m 15s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          90m 32s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.security.TestUserGroupInformation
            hadoop.security.TestKDiag
          JDK v1.7.0_95 Failed junit tests hadoop.security.TestUserGroupInformation
            hadoop.security.TestKDiag



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799526/0006-HADOOP-12751-leave-user-validation-to-os.patch
          JIRA Issue HADOOP-12751
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0a4449a68564 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 90d1af1
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/testReport/
          modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 54s trunk passed +1 compile 5m 58s trunk passed with JDK v1.8.0_77 +1 compile 6m 49s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 18s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 2m 1s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 20s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 56s the patch passed +1 compile 5m 46s the patch passed with JDK v1.8.0_77 +1 javac 5m 46s the patch passed +1 compile 6m 47s the patch passed with JDK v1.7.0_95 +1 javac 6m 47s the patch passed -1 checkstyle 0m 26s hadoop-common-project: patch generated 1 new + 93 unchanged - 0 fixed = 94 total (was 93) +1 mvnsite 1m 17s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 28s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 19s the patch passed with JDK v1.7.0_95 +1 unit 14m 9s hadoop-auth in the patch passed with JDK v1.8.0_77. -1 unit 6m 49s hadoop-common in the patch failed with JDK v1.8.0_77. +1 unit 13m 21s hadoop-auth in the patch passed with JDK v1.7.0_95. -1 unit 7m 15s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 90m 32s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.security.TestUserGroupInformation   hadoop.security.TestKDiag JDK v1.7.0_95 Failed junit tests hadoop.security.TestUserGroupInformation   hadoop.security.TestKDiag Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799526/0006-HADOOP-12751-leave-user-validation-to-os.patch JIRA Issue HADOOP-12751 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0a4449a68564 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 90d1af1 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9117/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          bolke Bolke de Bruin added a comment -

          Latest patch is not picked up yet by hadoop-qa

          (Sorry for that chatty QA, I have some versioning conflicts locally and have to rely on hadoop-qa)

          Show
          bolke Bolke de Bruin added a comment - Latest patch is not picked up yet by hadoop-qa (Sorry for that chatty QA, I have some versioning conflicts locally and have to rely on hadoop-qa)
          Hide
          bolke Bolke de Bruin added a comment -

          Another try to kickstart the builds

          Show
          bolke Bolke de Bruin added a comment - Another try to kickstart the builds
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 6m 50s trunk passed
          +1 compile 6m 10s trunk passed with JDK v1.8.0_77
          +1 compile 6m 47s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 1m 17s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 2m 1s trunk passed
          +1 javadoc 1m 6s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 20s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 0m 58s the patch passed
          +1 compile 6m 1s the patch passed with JDK v1.8.0_77
          +1 javac 6m 1s the patch passed
          +1 compile 6m 49s the patch passed with JDK v1.7.0_95
          +1 javac 6m 49s the patch passed
          -1 checkstyle 0m 26s hadoop-common-project: patch generated 1 new + 93 unchanged - 0 fixed = 94 total (was 93)
          +1 mvnsite 1m 17s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 27s the patch passed
          +1 javadoc 1m 7s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 21s the patch passed with JDK v1.7.0_95
          +1 unit 12m 57s hadoop-auth in the patch passed with JDK v1.8.0_77.
          -1 unit 6m 54s hadoop-common in the patch failed with JDK v1.8.0_77.
          +1 unit 13m 11s hadoop-auth in the patch passed with JDK v1.7.0_95.
          -1 unit 7m 11s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          89m 42s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.security.TestUserGroupInformation
          JDK v1.7.0_95 Failed junit tests hadoop.security.TestUserGroupInformation



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800036/0007-HADOOP-12751-leave-user-validation-to-os.patch
          JIRA Issue HADOOP-12751
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 59d87ac91d7f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a749ba0
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/testReport/
          modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 50s trunk passed +1 compile 6m 10s trunk passed with JDK v1.8.0_77 +1 compile 6m 47s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 17s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 2m 1s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 20s trunk passed with JDK v1.7.0_95 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 58s the patch passed +1 compile 6m 1s the patch passed with JDK v1.8.0_77 +1 javac 6m 1s the patch passed +1 compile 6m 49s the patch passed with JDK v1.7.0_95 +1 javac 6m 49s the patch passed -1 checkstyle 0m 26s hadoop-common-project: patch generated 1 new + 93 unchanged - 0 fixed = 94 total (was 93) +1 mvnsite 1m 17s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 27s the patch passed +1 javadoc 1m 7s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 21s the patch passed with JDK v1.7.0_95 +1 unit 12m 57s hadoop-auth in the patch passed with JDK v1.8.0_77. -1 unit 6m 54s hadoop-common in the patch failed with JDK v1.8.0_77. +1 unit 13m 11s hadoop-auth in the patch passed with JDK v1.7.0_95. -1 unit 7m 11s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 89m 42s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.security.TestUserGroupInformation JDK v1.7.0_95 Failed junit tests hadoop.security.TestUserGroupInformation Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800036/0007-HADOOP-12751-leave-user-validation-to-os.patch JIRA Issue HADOOP-12751 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 59d87ac91d7f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a749ba0 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9145/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          bolke Bolke de Bruin added a comment -

          Updated tests to support Malformed Kerberos name

          Show
          bolke Bolke de Bruin added a comment - Updated tests to support Malformed Kerberos name
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 9m 13s trunk passed
          +1 compile 11m 46s trunk passed with JDK v1.8.0_77
          +1 compile 9m 30s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 31s trunk passed
          +1 mvnsite 1m 39s trunk passed
          +1 mvneclipse 0m 32s trunk passed
          +1 findbugs 2m 31s trunk passed
          +1 javadoc 1m 26s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 30s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 7s the patch passed
          +1 compile 9m 28s the patch passed with JDK v1.8.0_77
          +1 javac 9m 28s the patch passed
          +1 compile 7m 55s the patch passed with JDK v1.7.0_95
          +1 javac 7m 55s the patch passed
          -1 checkstyle 0m 29s hadoop-common-project: patch generated 1 new + 93 unchanged - 0 fixed = 94 total (was 93)
          +1 mvnsite 1m 17s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 27s the patch passed
          +1 javadoc 1m 23s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 27s the patch passed with JDK v1.7.0_95
          +1 unit 14m 8s hadoop-auth in the patch passed with JDK v1.8.0_77.
          +1 unit 10m 44s hadoop-common in the patch passed with JDK v1.8.0_77.
          -1 unit 13m 44s hadoop-auth in the patch failed with JDK v1.7.0_95.
          +1 unit 11m 22s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          117m 8s



          Reason Tests
          JDK v1.7.0_95 Failed junit tests hadoop.security.authentication.util.TestZKSignerSecretProvider



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800096/0008-HADOOP-12751-leave-user-validation-to-os.patch
          JIRA Issue HADOOP-12751
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux fd63c2826578 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bbce1d5
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9147/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9147/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9147/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9147/testReport/
          modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9147/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 9m 13s trunk passed +1 compile 11m 46s trunk passed with JDK v1.8.0_77 +1 compile 9m 30s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 39s trunk passed +1 mvneclipse 0m 32s trunk passed +1 findbugs 2m 31s trunk passed +1 javadoc 1m 26s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 30s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 7s the patch passed +1 compile 9m 28s the patch passed with JDK v1.8.0_77 +1 javac 9m 28s the patch passed +1 compile 7m 55s the patch passed with JDK v1.7.0_95 +1 javac 7m 55s the patch passed -1 checkstyle 0m 29s hadoop-common-project: patch generated 1 new + 93 unchanged - 0 fixed = 94 total (was 93) +1 mvnsite 1m 17s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 27s the patch passed +1 javadoc 1m 23s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 27s the patch passed with JDK v1.7.0_95 +1 unit 14m 8s hadoop-auth in the patch passed with JDK v1.8.0_77. +1 unit 10m 44s hadoop-common in the patch passed with JDK v1.8.0_77. -1 unit 13m 44s hadoop-auth in the patch failed with JDK v1.7.0_95. +1 unit 11m 22s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 117m 8s Reason Tests JDK v1.7.0_95 Failed junit tests hadoop.security.authentication.util.TestZKSignerSecretProvider Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800096/0008-HADOOP-12751-leave-user-validation-to-os.patch JIRA Issue HADOOP-12751 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fd63c2826578 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bbce1d5 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9147/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9147/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9147/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9147/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9147/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          resubmitting the patch. Bolke: if you want isolation on local dev & test, create a linux (or even windows) VM. I have both, including a VM with Kerberos enabled, that being the first step to testing my code in a secure env

          Show
          stevel@apache.org Steve Loughran added a comment - resubmitting the patch. Bolke: if you want isolation on local dev & test, create a linux (or even windows) VM. I have both, including a VM with Kerberos enabled, that being the first step to testing my code in a secure env
          Hide
          bolke Bolke de Bruin added a comment -

          Thanks. Normally I do have vm for this, just not now and I (wrongly) thought the tests would be a bit easier on me.

          Code is production with us.

          Show
          bolke Bolke de Bruin added a comment - Thanks. Normally I do have vm for this, just not now and I (wrongly) thought the tests would be a bit easier on me. Code is production with us.
          Hide
          bolke Bolke de Bruin added a comment -

          How are we doing here?

          Show
          bolke Bolke de Bruin added a comment - How are we doing here?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          turns out that precommits need to be explicitly triggered if the patch hasn't been updated (Yetus is getting cleverer)... I've just kicked one off

          Show
          stevel@apache.org Steve Loughran added a comment - turns out that precommits need to be explicitly triggered if the patch hasn't been updated (Yetus is getting cleverer)... I've just kicked one off
          Hide
          bolke Bolke de Bruin added a comment -

          Re-attaching - not seeing any update

          Show
          bolke Bolke de Bruin added a comment - Re-attaching - not seeing any update
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 7m 35s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 0m 33s Maven dependency ordering for branch
          +1 mvninstall 7m 34s trunk passed
          +1 compile 6m 56s trunk passed with JDK v1.8.0_92
          +1 compile 7m 31s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 1m 25s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 2m 11s trunk passed
          +1 javadoc 1m 14s trunk passed with JDK v1.8.0_92
          +1 javadoc 1m 23s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 2s the patch passed
          +1 compile 7m 5s the patch passed with JDK v1.8.0_92
          +1 javac 7m 5s the patch passed
          +1 compile 7m 45s the patch passed with JDK v1.7.0_95
          +1 javac 7m 45s the patch passed
          -1 checkstyle 0m 26s hadoop-common-project: The patch generated 1 new + 93 unchanged - 0 fixed = 94 total (was 93)
          +1 mvnsite 1m 13s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 25s the patch passed
          +1 javadoc 1m 1s the patch passed with JDK v1.8.0_92
          +1 javadoc 1m 16s the patch passed with JDK v1.7.0_95
          +1 unit 3m 37s hadoop-auth in the patch passed with JDK v1.8.0_92.
          +1 unit 7m 4s hadoop-common in the patch passed with JDK v1.8.0_92.
          +1 unit 3m 58s hadoop-auth in the patch passed with JDK v1.7.0_95.
          +1 unit 7m 25s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          83m 59s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:7b1c37a
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801224/0008-HADOOP-12751-leave-user-validation-to-os.patch
          JIRA Issue HADOOP-12751
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 42c9a488e131 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6f26b66
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9218/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9218/testReport/
          modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9218/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 7m 35s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 0m 33s Maven dependency ordering for branch +1 mvninstall 7m 34s trunk passed +1 compile 6m 56s trunk passed with JDK v1.8.0_92 +1 compile 7m 31s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 25s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 2m 11s trunk passed +1 javadoc 1m 14s trunk passed with JDK v1.8.0_92 +1 javadoc 1m 23s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 2s the patch passed +1 compile 7m 5s the patch passed with JDK v1.8.0_92 +1 javac 7m 5s the patch passed +1 compile 7m 45s the patch passed with JDK v1.7.0_95 +1 javac 7m 45s the patch passed -1 checkstyle 0m 26s hadoop-common-project: The patch generated 1 new + 93 unchanged - 0 fixed = 94 total (was 93) +1 mvnsite 1m 13s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 25s the patch passed +1 javadoc 1m 1s the patch passed with JDK v1.8.0_92 +1 javadoc 1m 16s the patch passed with JDK v1.7.0_95 +1 unit 3m 37s hadoop-auth in the patch passed with JDK v1.8.0_92. +1 unit 7m 4s hadoop-common in the patch passed with JDK v1.8.0_92. +1 unit 3m 58s hadoop-auth in the patch passed with JDK v1.7.0_95. +1 unit 7m 25s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 83m 59s Subsystem Report/Notes Docker Image:yetus/hadoop:7b1c37a JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801224/0008-HADOOP-12751-leave-user-validation-to-os.patch JIRA Issue HADOOP-12751 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 42c9a488e131 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6f26b66 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9218/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9218/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9218/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          bolke Bolke de Bruin added a comment -

          Steve Loughran All good now? Code style issue is due to "nonSimplePattern" to keep it equivalent to the one in KerberosName.

          Show
          bolke Bolke de Bruin added a comment - Steve Loughran All good now? Code style issue is due to "nonSimplePattern" to keep it equivalent to the one in KerberosName.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          patch 009.

          • Slightly tweaks the logging to use SLF4J formatting better
          • Adds documentation for KDiag's --verifyshortname
          Show
          stevel@apache.org Steve Loughran added a comment - patch 009. Slightly tweaks the logging to use SLF4J formatting better Adds documentation for KDiag's --verifyshortname
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          0 mvndep 2m 7s Maven dependency ordering for branch
          +1 mvninstall 8m 51s trunk passed
          +1 compile 6m 2s trunk passed with JDK v1.8.0_92
          +1 compile 6m 45s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 31s trunk passed
          +1 mvnsite 1m 23s trunk passed
          +1 mvneclipse 0m 32s trunk passed
          +1 findbugs 2m 12s trunk passed
          +1 javadoc 1m 5s trunk passed with JDK v1.8.0_92
          +1 javadoc 1m 18s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 0m 56s the patch passed
          +1 compile 5m 48s the patch passed with JDK v1.8.0_92
          +1 javac 5m 48s the patch passed
          +1 compile 6m 48s the patch passed with JDK v1.7.0_95
          +1 javac 6m 48s the patch passed
          -1 checkstyle 0m 27s hadoop-common-project: The patch generated 2 new + 93 unchanged - 0 fixed = 95 total (was 93)
          +1 mvnsite 1m 15s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 26s the patch passed
          +1 javadoc 1m 3s the patch passed with JDK v1.8.0_92
          +1 javadoc 1m 18s the patch passed with JDK v1.7.0_95
          +1 unit 3m 39s hadoop-auth in the patch passed with JDK v1.8.0_92.
          +1 unit 7m 47s hadoop-common in the patch passed with JDK v1.8.0_92.
          +1 unit 3m 59s hadoop-auth in the patch passed with JDK v1.7.0_95.
          +1 unit 7m 42s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          76m 23s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801429/HADOOP-12751-009.patch
          JIRA Issue HADOOP-12751
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6f092405aa97 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4a85085
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9228/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9228/testReport/
          modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9228/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. 0 mvndep 2m 7s Maven dependency ordering for branch +1 mvninstall 8m 51s trunk passed +1 compile 6m 2s trunk passed with JDK v1.8.0_92 +1 compile 6m 45s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 23s trunk passed +1 mvneclipse 0m 32s trunk passed +1 findbugs 2m 12s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_92 +1 javadoc 1m 18s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 56s the patch passed +1 compile 5m 48s the patch passed with JDK v1.8.0_92 +1 javac 5m 48s the patch passed +1 compile 6m 48s the patch passed with JDK v1.7.0_95 +1 javac 6m 48s the patch passed -1 checkstyle 0m 27s hadoop-common-project: The patch generated 2 new + 93 unchanged - 0 fixed = 95 total (was 93) +1 mvnsite 1m 15s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 26s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_92 +1 javadoc 1m 18s the patch passed with JDK v1.7.0_95 +1 unit 3m 39s hadoop-auth in the patch passed with JDK v1.8.0_92. +1 unit 7m 47s hadoop-common in the patch passed with JDK v1.8.0_92. +1 unit 3m 59s hadoop-auth in the patch passed with JDK v1.7.0_95. +1 unit 7m 42s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 76m 23s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801429/HADOOP-12751-009.patch JIRA Issue HADOOP-12751 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6f092405aa97 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4a85085 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9228/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9228/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9228/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          bolke Bolke de Bruin added a comment -

          Hi Steve Loughran any update on this?

          Show
          bolke Bolke de Bruin added a comment - Hi Steve Loughran any update on this?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1 —committed to Hadoop 2.8.

          Thanks your work here Bolke!

          Show
          stevel@apache.org Steve Loughran added a comment - +1 —committed to Hadoop 2.8. Thanks your work here Bolke!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9741 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9741/)
          HADOOP-12751. While using kerberos Hadoop incorrectly assumes names with (stevel: rev 829a2e4d271f05afb209ddc834cd4a0e85492eda)

          • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java
          • hadoop-common-project/hadoop-common/src/site/markdown/SecureMode.md
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestKDiag.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
          • hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestKerberosAuthenticationHandler.java
          • hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/util/TestKerberosName.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/KDiag.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9741 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9741/ ) HADOOP-12751 . While using kerberos Hadoop incorrectly assumes names with (stevel: rev 829a2e4d271f05afb209ddc834cd4a0e85492eda) hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosName.java hadoop-common-project/hadoop-common/src/site/markdown/SecureMode.md hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestKDiag.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestKerberosAuthenticationHandler.java hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/util/TestKerberosName.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/KDiag.java

            People

            • Assignee:
              bolke Bolke de Bruin
              Reporter:
              bolke Bolke de Bruin
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development