Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12743

Fix git environment check during test-patch

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      I'm seeing this error when running test-patch in Apache Hadoop:

      ============================================================================
      ============================================================================
      Confirming git environment
      ============================================================================
      ============================================================================

      ERROR: /Users/rchiang/Dev_01/ah_01/patchprocess is not a git repo.

      ============================================================================
      ============================================================================

      From a follow up email:

      it’s a trivial bug in the yetus-wrapper. Missing a popd after extraction. Simple fix is to run the command twice. (since the short circuit kicks in after yetus is cached).

      1. HADOOP-12743.00.patch
        0.4 kB
        Allen Wittenauer

        Activity

        Hide
        aw Allen Wittenauer added a comment -

        -00:

        • popd prior to exec
        Show
        aw Allen Wittenauer added a comment - -00: popd prior to exec
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        0 shelldocs 0m 8s Shelldocs was not available.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 shellcheck 0m 8s There were no new shellcheck issues.
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 asflicense 0m 16s Patch does not generate ASF License warnings.
        0m 40s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784493/HADOOP-12743.00.patch
        JIRA Issue HADOOP-12743
        Optional Tests asflicense shellcheck shelldocs
        uname Linux 279e058ed72f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / cf8af7b
        shellcheck v0.4.3
        modules C: U:
        Max memory used 30MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8474/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. 0 shelldocs 0m 8s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 shellcheck 0m 8s There were no new shellcheck issues. +1 whitespace 0m 0s Patch has no whitespace issues. +1 asflicense 0m 16s Patch does not generate ASF License warnings. 0m 40s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784493/HADOOP-12743.00.patch JIRA Issue HADOOP-12743 Optional Tests asflicense shellcheck shelldocs uname Linux 279e058ed72f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cf8af7b shellcheck v0.4.3 modules C: U: Max memory used 30MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8474/console This message was automatically generated.
        Hide
        rchiang Ray Chiang added a comment -

        +1 (nonbinding)

        Ran on patched tree and error no longer occurs.

        Show
        rchiang Ray Chiang added a comment - +1 (nonbinding) Ran on patched tree and error no longer occurs.
        Hide
        owen.omalley Owen O'Malley added a comment -

        +1, looks good to me

        Show
        owen.omalley Owen O'Malley added a comment - +1, looks good to me
        Hide
        aw Allen Wittenauer added a comment -

        Thanks!

        Committed to trunk.

        Show
        aw Allen Wittenauer added a comment - Thanks! Committed to trunk.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9188 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9188/)
        HADOOP-12743. Fix git environment check during test-patch (aw) (aw: rev d323639686eab28f1510031e52e4390f82d78989)

        • dev-support/bin/yetus-wrapper
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9188 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9188/ ) HADOOP-12743 . Fix git environment check during test-patch (aw) (aw: rev d323639686eab28f1510031e52e4390f82d78989) dev-support/bin/yetus-wrapper
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Backport this to branch-2 and branch-2.8 because this is needed to backport HADOOP-12892.

        Show
        ajisakaa Akira Ajisaka added a comment - Backport this to branch-2 and branch-2.8 because this is needed to backport HADOOP-12892 .

          People

          • Assignee:
            aw Allen Wittenauer
            Reporter:
            rchiang Ray Chiang
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development