Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12736

TestTimedOutTestsListener#testThreadDumpAndDeadlocks sometimes times out

    Details

    • Type: Test
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.3, 2.6.4, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Saw this test failure today, the @Test(timeout=500) seems too aggressive to me.

      testThreadDumpAndDeadlocks(org.apache.hadoop.test.TestTimedOutTestsListener)  Time elapsed: 0.521 sec  <<< ERROR!
      java.lang.Exception: test timed out after 500 milliseconds
      	at jdk.internal.org.objectweb.asm.ByteVector.putShort(ByteVector.java:147)
      	at jdk.internal.org.objectweb.asm.ClassWriter.toByteArray(ClassWriter.java:942)
      	at java.lang.invoke.InvokerBytecodeGenerator.generateCustomizedCodeBytes(InvokerBytecodeGenerator.java:727)
      	at java.lang.invoke.InvokerBytecodeGenerator.generateCustomizedCode(InvokerBytecodeGenerator.java:618)
      	at java.lang.invoke.LambdaForm.compileToBytecode(LambdaForm.java:654)
      	at java.lang.invoke.LambdaForm.prepare(LambdaForm.java:635)
      	at java.lang.invoke.MethodHandle.<init>(MethodHandle.java:461)
      	at java.lang.invoke.BoundMethodHandle.<init>(BoundMethodHandle.java:56)
      	at java.lang.invoke.SimpleMethodHandle.<init>(SimpleMethodHandle.java:37)
      	at java.lang.invoke.SimpleMethodHandle.make(SimpleMethodHandle.java:41)
      	at java.lang.invoke.LambdaForm.createIdentityForms(LambdaForm.java:1778)
      	at java.lang.invoke.LambdaForm.<clinit>(LambdaForm.java:1833)
      	at java.lang.invoke.DirectMethodHandle.makePreparedLambdaForm(DirectMethodHandle.java:222)
      	at java.lang.invoke.DirectMethodHandle.preparedLambdaForm(DirectMethodHandle.java:187)
      	at java.lang.invoke.DirectMethodHandle.preparedLambdaForm(DirectMethodHandle.java:176)
      	at java.lang.invoke.DirectMethodHandle.make(DirectMethodHandle.java:83)
      	at java.lang.invoke.MethodHandles$Lookup.getDirectMethodCommon(MethodHandles.java:1656)
      	at java.lang.invoke.MethodHandles$Lookup.getDirectMethodNoSecurityManager(MethodHandles.java:1613)
      	at java.lang.invoke.MethodHandles$Lookup.getDirectMethodForConstant(MethodHandles.java:1798)
      	at java.lang.invoke.MethodHandles$Lookup.linkMethodHandleConstant(MethodHandles.java:1747)
      	at java.lang.invoke.MethodHandleNatives.linkMethodHandleConstant(MethodHandleNatives.java:477)
      	at java.lang.UNIXProcess$Platform.get(UNIXProcess.java:155)
      	at java.lang.UNIXProcess.<clinit>(UNIXProcess.java:168)
      	at java.lang.ProcessImpl.start(ProcessImpl.java:130)
      	at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
      	at org.apache.hadoop.util.Shell.runCommand(Shell.java:868)
      	at org.apache.hadoop.util.Shell.run(Shell.java:838)
      	at org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:1117)
      	at org.apache.hadoop.util.Shell.checkIsBashSupported(Shell.java:716)
      	at org.apache.hadoop.util.Shell.<clinit>(Shell.java:705)
      	at org.apache.hadoop.util.StringUtils.<clinit>(StringUtils.java:79)
      	at org.apache.hadoop.test.TimedOutTestsListener.buildThreadDump(TimedOutTestsListener.java:98)
      	at org.apache.hadoop.test.TimedOutTestsListener.buildThreadDiagnosticString(TimedOutTestsListener.java:73)
      	at org.apache.hadoop.test.TimedOutTestsListener.testFailure(TimedOutTestsListener.java:62)
      	at org.apache.hadoop.test.TestTimedOutTestsListener.testThreadDumpAndDeadlocks(TestTimedOutTestsListener.java:163)
      

        Activity

        Hide
        xiaochen Xiao Chen added a comment -

        Patch 1 increases the timeout. The timeout on tests is to make sure we don't hang the whole job in case any individual test is faulty. No need to make it super aggressive and raise false alarm.

        Show
        xiaochen Xiao Chen added a comment - Patch 1 increases the timeout. The timeout on tests is to make sure we don't hang the whole job in case any individual test is faulty. No need to make it super aggressive and raise false alarm.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 49s trunk passed
        +1 compile 8m 0s trunk passed with JDK v1.8.0_66
        +1 compile 8m 26s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 17s trunk passed
        +1 mvnsite 1m 13s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 2m 2s trunk passed
        +1 javadoc 0m 58s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 9s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 36s the patch passed
        +1 compile 6m 46s the patch passed with JDK v1.8.0_66
        +1 javac 6m 46s the patch passed
        +1 compile 7m 41s the patch passed with JDK v1.7.0_91
        +1 javac 7m 41s the patch passed
        +1 checkstyle 0m 16s the patch passed
        +1 mvnsite 1m 7s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 10s the patch passed
        +1 javadoc 0m 58s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 7s the patch passed with JDK v1.7.0_91
        -1 unit 7m 30s hadoop-common in the patch failed with JDK v1.8.0_66.
        +1 unit 8m 8s hadoop-common in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        70m 22s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784029/HADOOP-12736.01.patch
        JIRA Issue HADOOP-12736
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c0981bad4c5f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 99829eb
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8460/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8460/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8460/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8460/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 49s trunk passed +1 compile 8m 0s trunk passed with JDK v1.8.0_66 +1 compile 8m 26s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 17s trunk passed +1 mvnsite 1m 13s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 2s trunk passed +1 javadoc 0m 58s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 9s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 36s the patch passed +1 compile 6m 46s the patch passed with JDK v1.8.0_66 +1 javac 6m 46s the patch passed +1 compile 7m 41s the patch passed with JDK v1.7.0_91 +1 javac 7m 41s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 1m 7s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 10s the patch passed +1 javadoc 0m 58s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 7s the patch passed with JDK v1.7.0_91 -1 unit 7m 30s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 8m 8s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 70m 22s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784029/HADOOP-12736.01.patch JIRA Issue HADOOP-12736 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c0981bad4c5f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99829eb Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8460/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8460/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8460/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8460/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, committing this.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, committing this.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, branch-2.8, branch-2.7, and branch-2.6. Thanks Xiao Chen for the contribution!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, branch-2.8, branch-2.7, and branch-2.6. Thanks Xiao Chen for the contribution!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9177 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9177/)
        HADOOP-12736. TestTimedOutTestsListener#testThreadDumpAndDeadlocks (aajisaka: rev 643227927a7d7974655627d7e97aae42600692ae)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TestTimedOutTestsListener.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9177 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9177/ ) HADOOP-12736 . TestTimedOutTestsListener#testThreadDumpAndDeadlocks (aajisaka: rev 643227927a7d7974655627d7e97aae42600692ae) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TestTimedOutTestsListener.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks a lot Akira Ajisaka!

        Show
        xiaochen Xiao Chen added a comment - Thanks a lot Akira Ajisaka !
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

          People

          • Assignee:
            xiaochen Xiao Chen
            Reporter:
            xiaochen Xiao Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development