Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: performance
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are lots of places where useless boxing/unboxing occur.
      To avoid performance issue, let's remove them.

      1. HADOOP-12731.patch.0
        15 kB
        Kousuke Saruta

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9176 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9176/)
        HADOOP-12731. Remove useless boxing/unboxing code. Contributed by (aajisaka: rev 736eb17a796a1c1ad5f4db2c6a64f6752db7bec3)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedIdMapping.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/bloom/Key.java
        • hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestPseudoLocalFs.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestSshFenceByTcpPort.java
        • hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/DistributedCacheEmulator.java
        • hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/util/TestZKSignerSecretProvider.java
        • hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/DelayEchoApp.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/AbstractMapWritable.java
        • hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/CommonJobTest.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9176 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9176/ ) HADOOP-12731 . Remove useless boxing/unboxing code. Contributed by (aajisaka: rev 736eb17a796a1c1ad5f4db2c6a64f6752db7bec3) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedIdMapping.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/bloom/Key.java hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/TestPseudoLocalFs.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/SshFenceByTcpPort.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestSshFenceByTcpPort.java hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/DistributedCacheEmulator.java hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/util/TestZKSignerSecretProvider.java hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/DelayEchoApp.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/AbstractMapWritable.java hadoop-tools/hadoop-gridmix/src/test/java/org/apache/hadoop/mapred/gridmix/CommonJobTest.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.8. Thanks Kousuke Saruta for cleaning up the source code.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Kousuke Saruta for cleaning up the source code.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1.
        Hide
        sarutak Kousuke Saruta added a comment -

        I think the latest test failure is related to what HADOOP-12715 try to resolve.

        Show
        sarutak Kousuke Saruta added a comment - I think the latest test failure is related to what HADOOP-12715 try to resolve.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        0 patch 0m 7s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
        0 mvndep 0m 36s Maven dependency ordering for branch
        +1 mvninstall 7m 53s trunk passed
        +1 compile 6m 43s trunk passed with JDK v1.8.0_66
        +1 compile 7m 24s trunk passed with JDK v1.7.0_91
        +1 checkstyle 1m 1s trunk passed
        +1 mvnsite 2m 18s trunk passed
        +1 mvneclipse 0m 57s trunk passed
        +1 findbugs 3m 31s trunk passed
        +1 javadoc 1m 33s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 52s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 35s Maven dependency ordering for patch
        +1 mvninstall 2m 32s the patch passed
        +1 compile 6m 38s the patch passed with JDK v1.8.0_66
        +1 javac 6m 38s the patch passed
        +1 compile 7m 24s the patch passed with JDK v1.7.0_91
        +1 javac 7m 24s the patch passed
        +1 checkstyle 1m 2s root: patch generated 0 new + 98 unchanged - 1 fixed = 98 total (was 99)
        +1 mvnsite 2m 16s the patch passed
        +1 mvneclipse 0m 56s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 4m 24s the patch passed
        +1 javadoc 1m 35s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 54s the patch passed with JDK v1.7.0_91
        +1 unit 3m 38s hadoop-auth in the patch passed with JDK v1.8.0_66.
        -1 unit 16m 59s hadoop-common in the patch failed with JDK v1.8.0_66.
        +1 unit 6m 11s hadoop-streaming in the patch passed with JDK v1.8.0_66.
        +1 unit 14m 47s hadoop-gridmix in the patch passed with JDK v1.8.0_66.
        +1 unit 3m 58s hadoop-auth in the patch passed with JDK v1.7.0_91.
        -1 unit 7m 47s hadoop-common in the patch failed with JDK v1.7.0_91.
        +1 unit 6m 25s hadoop-streaming in the patch passed with JDK v1.7.0_91.
        +1 unit 15m 38s hadoop-gridmix in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        140m 43s



        Reason Tests
        JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
        JDK v1.7.0_91 Failed junit tests hadoop.crypto.key.TestValueQueue



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784002/HADOOP-12731.patch.0
        JIRA Issue HADOOP-12731
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 51875130f676 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 99829eb
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8457/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8457/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8457/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8457/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8457/testReport/
        modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-streaming U: .
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8457/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. 0 patch 0m 7s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 0m 36s Maven dependency ordering for branch +1 mvninstall 7m 53s trunk passed +1 compile 6m 43s trunk passed with JDK v1.8.0_66 +1 compile 7m 24s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 1s trunk passed +1 mvnsite 2m 18s trunk passed +1 mvneclipse 0m 57s trunk passed +1 findbugs 3m 31s trunk passed +1 javadoc 1m 33s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 52s trunk passed with JDK v1.7.0_91 0 mvndep 0m 35s Maven dependency ordering for patch +1 mvninstall 2m 32s the patch passed +1 compile 6m 38s the patch passed with JDK v1.8.0_66 +1 javac 6m 38s the patch passed +1 compile 7m 24s the patch passed with JDK v1.7.0_91 +1 javac 7m 24s the patch passed +1 checkstyle 1m 2s root: patch generated 0 new + 98 unchanged - 1 fixed = 98 total (was 99) +1 mvnsite 2m 16s the patch passed +1 mvneclipse 0m 56s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 24s the patch passed +1 javadoc 1m 35s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 54s the patch passed with JDK v1.7.0_91 +1 unit 3m 38s hadoop-auth in the patch passed with JDK v1.8.0_66. -1 unit 16m 59s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 6m 11s hadoop-streaming in the patch passed with JDK v1.8.0_66. +1 unit 14m 47s hadoop-gridmix in the patch passed with JDK v1.8.0_66. +1 unit 3m 58s hadoop-auth in the patch passed with JDK v1.7.0_91. -1 unit 7m 47s hadoop-common in the patch failed with JDK v1.7.0_91. +1 unit 6m 25s hadoop-streaming in the patch passed with JDK v1.7.0_91. +1 unit 15m 38s hadoop-gridmix in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 140m 43s Reason Tests JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_91 Failed junit tests hadoop.crypto.key.TestValueQueue Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784002/HADOOP-12731.patch.0 JIRA Issue HADOOP-12731 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 51875130f676 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99829eb Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8457/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8457/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8457/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8457/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8457/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-streaming U: . Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8457/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        0 patch 0m 7s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
        0 mvndep 0m 36s Maven dependency ordering for branch
        +1 mvninstall 7m 53s trunk passed
        +1 compile 6m 41s trunk passed with JDK v1.8.0_66
        +1 compile 7m 25s trunk passed with JDK v1.7.0_91
        +1 checkstyle 1m 3s trunk passed
        +1 mvnsite 2m 18s trunk passed
        +1 mvneclipse 0m 57s trunk passed
        +1 findbugs 3m 30s trunk passed
        +1 javadoc 1m 38s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 53s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 36s Maven dependency ordering for patch
        -1 mvninstall 0m 22s hadoop-common in the patch failed.
        -1 compile 0m 34s root in the patch failed with JDK v1.8.0_66.
        -1 javac 0m 34s root in the patch failed with JDK v1.8.0_66.
        -1 compile 0m 37s root in the patch failed with JDK v1.7.0_91.
        -1 javac 0m 37s root in the patch failed with JDK v1.7.0_91.
        -1 checkstyle 1m 1s root: patch generated 2 new + 98 unchanged - 1 fixed = 100 total (was 99)
        -1 mvnsite 0m 26s hadoop-common in the patch failed.
        +1 mvneclipse 0m 46s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        -1 findbugs 0m 23s hadoop-common in the patch failed.
        +1 javadoc 1m 25s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 46s the patch passed with JDK v1.7.0_91
        +1 unit 3m 35s hadoop-auth in the patch passed with JDK v1.8.0_66.
        -1 unit 0m 20s hadoop-common in the patch failed with JDK v1.8.0_66.
        +1 unit 6m 8s hadoop-streaming in the patch passed with JDK v1.8.0_66.
        +1 unit 14m 40s hadoop-gridmix in the patch passed with JDK v1.8.0_66.
        +1 unit 4m 2s hadoop-auth in the patch passed with JDK v1.7.0_91.
        -1 unit 0m 24s hadoop-common in the patch failed with JDK v1.7.0_91.
        +1 unit 6m 30s hadoop-streaming in the patch passed with JDK v1.7.0_91.
        +1 unit 15m 43s hadoop-gridmix in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        99m 6s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783996/HADOOP-12731.patch.0
        JIRA Issue HADOOP-12731
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 32c48f88ebd1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 99829eb
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/diff-checkstyle-root.txt
        mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/testReport/
        modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-streaming U: .
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. 0 patch 0m 7s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 0m 36s Maven dependency ordering for branch +1 mvninstall 7m 53s trunk passed +1 compile 6m 41s trunk passed with JDK v1.8.0_66 +1 compile 7m 25s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 3s trunk passed +1 mvnsite 2m 18s trunk passed +1 mvneclipse 0m 57s trunk passed +1 findbugs 3m 30s trunk passed +1 javadoc 1m 38s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 53s trunk passed with JDK v1.7.0_91 0 mvndep 0m 36s Maven dependency ordering for patch -1 mvninstall 0m 22s hadoop-common in the patch failed. -1 compile 0m 34s root in the patch failed with JDK v1.8.0_66. -1 javac 0m 34s root in the patch failed with JDK v1.8.0_66. -1 compile 0m 37s root in the patch failed with JDK v1.7.0_91. -1 javac 0m 37s root in the patch failed with JDK v1.7.0_91. -1 checkstyle 1m 1s root: patch generated 2 new + 98 unchanged - 1 fixed = 100 total (was 99) -1 mvnsite 0m 26s hadoop-common in the patch failed. +1 mvneclipse 0m 46s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 23s hadoop-common in the patch failed. +1 javadoc 1m 25s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 46s the patch passed with JDK v1.7.0_91 +1 unit 3m 35s hadoop-auth in the patch passed with JDK v1.8.0_66. -1 unit 0m 20s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 6m 8s hadoop-streaming in the patch passed with JDK v1.8.0_66. +1 unit 14m 40s hadoop-gridmix in the patch passed with JDK v1.8.0_66. +1 unit 4m 2s hadoop-auth in the patch passed with JDK v1.7.0_91. -1 unit 0m 24s hadoop-common in the patch failed with JDK v1.7.0_91. +1 unit 6m 30s hadoop-streaming in the patch passed with JDK v1.7.0_91. +1 unit 15m 43s hadoop-gridmix in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 99m 6s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783996/HADOOP-12731.patch.0 JIRA Issue HADOOP-12731 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 32c48f88ebd1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99829eb Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/diff-checkstyle-root.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-streaming U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8456/console This message was automatically generated.
        Hide
        sarutak Kousuke Saruta added a comment -

        I've fixed the compile error.

        Show
        sarutak Kousuke Saruta added a comment - I've fixed the compile error.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        0 patch 0m 8s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
        0 mvndep 1m 3s Maven dependency ordering for branch
        +1 mvninstall 8m 33s trunk passed
        +1 compile 8m 41s trunk passed with JDK v1.8.0_66
        +1 compile 8m 8s trunk passed with JDK v1.7.0_91
        +1 checkstyle 1m 9s trunk passed
        +1 mvnsite 3m 21s trunk passed
        +1 mvneclipse 1m 14s trunk passed
        +1 findbugs 6m 2s trunk passed
        +1 javadoc 3m 9s trunk passed with JDK v1.8.0_66
        +1 javadoc 3m 59s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 46s Maven dependency ordering for patch
        -1 mvninstall 0m 14s hadoop-auth in the patch failed.
        -1 mvninstall 0m 14s hadoop-common in the patch failed.
        -1 mvninstall 0m 28s hadoop-hdfs in the patch failed.
        -1 compile 0m 25s root in the patch failed with JDK v1.8.0_66.
        -1 javac 0m 25s root in the patch failed with JDK v1.8.0_66.
        -1 compile 0m 21s root in the patch failed with JDK v1.7.0_91.
        -1 javac 0m 21s root in the patch failed with JDK v1.7.0_91.
        -1 checkstyle 1m 5s root: patch generated 5 new + 457 unchanged - 3 fixed = 462 total (was 460)
        -1 mvnsite 0m 14s hadoop-auth in the patch failed.
        -1 mvnsite 0m 15s hadoop-common in the patch failed.
        -1 mvnsite 0m 28s hadoop-hdfs in the patch failed.
        +1 mvneclipse 0m 57s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        -1 findbugs 0m 11s hadoop-auth in the patch failed.
        -1 findbugs 0m 13s hadoop-common in the patch failed.
        -1 findbugs 0m 26s hadoop-hdfs in the patch failed.
        -1 javadoc 0m 12s hadoop-common in the patch failed with JDK v1.8.0_66.
        -1 javadoc 0m 12s hadoop-common in the patch failed with JDK v1.7.0_91.
        -1 unit 0m 11s hadoop-auth in the patch failed with JDK v1.8.0_66.
        -1 unit 0m 11s hadoop-common in the patch failed with JDK v1.8.0_66.
        -1 unit 0m 23s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        +1 unit 6m 7s hadoop-streaming in the patch passed with JDK v1.8.0_66.
        +1 unit 14m 45s hadoop-gridmix in the patch passed with JDK v1.8.0_66.
        -1 unit 0m 14s hadoop-auth in the patch failed with JDK v1.7.0_91.
        -1 unit 0m 14s hadoop-common in the patch failed with JDK v1.7.0_91.
        -1 unit 0m 28s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 unit 6m 28s hadoop-streaming in the patch passed with JDK v1.7.0_91.
        +1 unit 15m 26s hadoop-gridmix in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        105m 28s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783885/HADOOP-12731.patch.0
        JIRA Issue HADOOP-12731
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4653b67738d4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 99829eb
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-auth.txt
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/diff-checkstyle-root.txt
        mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-auth.txt
        mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
        mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-auth.txt
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
        javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/testReport/
        modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-streaming U: .
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. 0 patch 0m 8s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 1m 3s Maven dependency ordering for branch +1 mvninstall 8m 33s trunk passed +1 compile 8m 41s trunk passed with JDK v1.8.0_66 +1 compile 8m 8s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 9s trunk passed +1 mvnsite 3m 21s trunk passed +1 mvneclipse 1m 14s trunk passed +1 findbugs 6m 2s trunk passed +1 javadoc 3m 9s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 59s trunk passed with JDK v1.7.0_91 0 mvndep 0m 46s Maven dependency ordering for patch -1 mvninstall 0m 14s hadoop-auth in the patch failed. -1 mvninstall 0m 14s hadoop-common in the patch failed. -1 mvninstall 0m 28s hadoop-hdfs in the patch failed. -1 compile 0m 25s root in the patch failed with JDK v1.8.0_66. -1 javac 0m 25s root in the patch failed with JDK v1.8.0_66. -1 compile 0m 21s root in the patch failed with JDK v1.7.0_91. -1 javac 0m 21s root in the patch failed with JDK v1.7.0_91. -1 checkstyle 1m 5s root: patch generated 5 new + 457 unchanged - 3 fixed = 462 total (was 460) -1 mvnsite 0m 14s hadoop-auth in the patch failed. -1 mvnsite 0m 15s hadoop-common in the patch failed. -1 mvnsite 0m 28s hadoop-hdfs in the patch failed. +1 mvneclipse 0m 57s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 11s hadoop-auth in the patch failed. -1 findbugs 0m 13s hadoop-common in the patch failed. -1 findbugs 0m 26s hadoop-hdfs in the patch failed. -1 javadoc 0m 12s hadoop-common in the patch failed with JDK v1.8.0_66. -1 javadoc 0m 12s hadoop-common in the patch failed with JDK v1.7.0_91. -1 unit 0m 11s hadoop-auth in the patch failed with JDK v1.8.0_66. -1 unit 0m 11s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 0m 23s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 6m 7s hadoop-streaming in the patch passed with JDK v1.8.0_66. +1 unit 14m 45s hadoop-gridmix in the patch passed with JDK v1.8.0_66. -1 unit 0m 14s hadoop-auth in the patch failed with JDK v1.7.0_91. -1 unit 0m 14s hadoop-common in the patch failed with JDK v1.7.0_91. -1 unit 0m 28s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 unit 6m 28s hadoop-streaming in the patch passed with JDK v1.7.0_91. +1 unit 15m 26s hadoop-gridmix in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 105m 28s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783885/HADOOP-12731.patch.0 JIRA Issue HADOOP-12731 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4653b67738d4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99829eb Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-auth.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-compile-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/diff-checkstyle-root.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-auth.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-auth.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-streaming U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8454/console This message was automatically generated.
        Hide
        sarutak Kousuke Saruta added a comment -

        I've attached the initial patch.

        Show
        sarutak Kousuke Saruta added a comment - I've attached the initial patch.

          People

          • Assignee:
            sarutak Kousuke Saruta
            Reporter:
            sarutak Kousuke Saruta
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development