Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12716

KerberosAuthenticator#doSpnegoSequence use incorrect class to determine isKeyTab in JDK8

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Environment:

      Java 8

    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-11287 and HADOOP-10786 has fixed the issue in UserGroupInformation class for JDK8.

      However, the logic in KerberosAuthenticator#doSpnegoSequence is not updated. The KerberosKey.class below should be KeyTab.class for JDK8.

      if (subject == null
                || (subject.getPrivateCredentials(KerberosKey.class).isEmpty()
                    && subject.getPrivateCredentials(KerberosTicket.class).isEmpty())) {
      
      1. HADOOP-12716.000.patch
        5 kB
        Xiaoyu Yao
      2. HADOOP-12716.001.patch
        5 kB
        Xiaoyu Yao
      3. HADOOP-12716.002.patch
        5 kB
        Xiaoyu Yao

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 16s Maven dependency ordering for branch
        +1 mvninstall 7m 58s trunk passed
        +1 compile 6m 49s trunk passed with JDK v1.8.0_66
        +1 compile 7m 24s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 1m 27s trunk passed
        +1 mvneclipse 0m 27s trunk passed
        +1 findbugs 2m 20s trunk passed
        +1 javadoc 1m 8s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 21s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 52s the patch passed
        +1 compile 6m 44s the patch passed with JDK v1.8.0_66
        +1 javac 6m 44s the patch passed
        +1 compile 7m 31s the patch passed with JDK v1.7.0_91
        +1 javac 7m 31s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 1m 26s the patch passed
        +1 mvneclipse 0m 28s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 42s the patch passed
        +1 javadoc 1m 8s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 21s the patch passed with JDK v1.7.0_91
        -1 unit 3m 36s hadoop-auth in the patch failed with JDK v1.8.0_66.
        -1 unit 7m 30s hadoop-common in the patch failed with JDK v1.8.0_66.
        -1 unit 4m 1s hadoop-auth in the patch failed with JDK v1.7.0_91.
        -1 unit 7m 59s hadoop-common in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        78m 22s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.security.authentication.client.TestKerberosAuthenticator
          hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.security.token.delegation.web.TestWebDelegationToken
        JDK v1.7.0_91 Failed junit tests hadoop.security.authentication.client.TestKerberosAuthenticator
          hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.security.token.delegation.web.TestWebDelegationToken



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782697/HADOOP-12716.000.patch
        JIRA Issue HADOOP-12716
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bc7d44f8af75 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2a30386
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/testReport/
        modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 7m 58s trunk passed +1 compile 6m 49s trunk passed with JDK v1.8.0_66 +1 compile 7m 24s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 22s trunk passed +1 mvnsite 1m 27s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 2m 20s trunk passed +1 javadoc 1m 8s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 21s trunk passed with JDK v1.7.0_91 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 52s the patch passed +1 compile 6m 44s the patch passed with JDK v1.8.0_66 +1 javac 6m 44s the patch passed +1 compile 7m 31s the patch passed with JDK v1.7.0_91 +1 javac 7m 31s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 1m 26s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 42s the patch passed +1 javadoc 1m 8s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 21s the patch passed with JDK v1.7.0_91 -1 unit 3m 36s hadoop-auth in the patch failed with JDK v1.8.0_66. -1 unit 7m 30s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 4m 1s hadoop-auth in the patch failed with JDK v1.7.0_91. -1 unit 7m 59s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 78m 22s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.security.authentication.client.TestKerberosAuthenticator   hadoop.metrics2.impl.TestGangliaMetrics   hadoop.security.token.delegation.web.TestWebDelegationToken JDK v1.7.0_91 Failed junit tests hadoop.security.authentication.client.TestKerberosAuthenticator   hadoop.metrics2.impl.TestGangliaMetrics   hadoop.security.token.delegation.web.TestWebDelegationToken Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782697/HADOOP-12716.000.patch JIRA Issue HADOOP-12716 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bc7d44f8af75 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2a30386 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-auth-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8427/console This message was automatically generated.
        Hide
        xyao Xiaoyu Yao added a comment -

        Fix the unit test issue.

        Show
        xyao Xiaoyu Yao added a comment - Fix the unit test issue.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 17s Maven dependency ordering for branch
        +1 mvninstall 7m 51s trunk passed
        +1 compile 6m 39s trunk passed with JDK v1.8.0_66
        +1 compile 7m 18s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 1m 28s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 2m 20s trunk passed
        +1 javadoc 1m 7s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 20s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 54s the patch passed
        +1 compile 6m 34s the patch passed with JDK v1.8.0_66
        +1 javac 6m 34s the patch passed
        +1 compile 7m 20s the patch passed with JDK v1.7.0_91
        +1 javac 7m 20s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 1m 27s the patch passed
        +1 mvneclipse 0m 27s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 39s the patch passed
        +1 javadoc 1m 11s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 20s the patch passed with JDK v1.7.0_91
        +1 unit 3m 38s hadoop-auth in the patch passed with JDK v1.8.0_66.
        -1 unit 7m 30s hadoop-common in the patch failed with JDK v1.8.0_66.
        +1 unit 4m 1s hadoop-auth in the patch passed with JDK v1.7.0_91.
        -1 unit 7m 36s hadoop-common in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        77m 17s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager
        JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782728/HADOOP-12716.001.patch
        JIRA Issue HADOOP-12716
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1fdacc0bd669 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / da77f42
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8429/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8429/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8429/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8429/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8429/testReport/
        modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8429/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 7m 51s trunk passed +1 compile 6m 39s trunk passed with JDK v1.8.0_66 +1 compile 7m 18s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 28s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 2m 20s trunk passed +1 javadoc 1m 7s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 20s trunk passed with JDK v1.7.0_91 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 54s the patch passed +1 compile 6m 34s the patch passed with JDK v1.8.0_66 +1 javac 6m 34s the patch passed +1 compile 7m 20s the patch passed with JDK v1.7.0_91 +1 javac 7m 20s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 1m 27s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 39s the patch passed +1 javadoc 1m 11s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 20s the patch passed with JDK v1.7.0_91 +1 unit 3m 38s hadoop-auth in the patch passed with JDK v1.8.0_66. -1 unit 7m 30s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 4m 1s hadoop-auth in the patch passed with JDK v1.7.0_91. -1 unit 7m 36s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 77m 17s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782728/HADOOP-12716.001.patch JIRA Issue HADOOP-12716 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1fdacc0bd669 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / da77f42 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8429/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8429/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8429/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8429/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8429/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8429/console This message was automatically generated.
        Hide
        xyao Xiaoyu Yao added a comment -

        Can't repro the following unit test failures locally. No unit test is added as this is a simple fix with minor refactor.

        JDK v1.8.0_66 Failed junit tests	hadoop.security.ssl.TestReloadingX509TrustManager
        JDK v1.7.0_91 Failed junit tests	hadoop.metrics2.impl.TestGangliaMetrics
        
        Show
        xyao Xiaoyu Yao added a comment - Can't repro the following unit test failures locally. No unit test is added as this is a simple fix with minor refactor. JDK v1.8.0_66 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thanks Xiao Yu for the patch. There is a copy-paste issue, it should be 'Kerberos ticket'.

        253	   * @return true if Kerberos keytab exist
        254	   */
        255	  public static boolean hasKerbosTicket(Subject subject) {
        
        Show
        xiaobingo Xiaobing Zhou added a comment - Thanks Xiao Yu for the patch. There is a copy-paste issue, it should be 'Kerberos ticket'. 253 * @ return true if Kerberos keytab exist 254 */ 255 public static boolean hasKerbosTicket(Subject subject) {
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Xiaobing Zhou for the review. Patch 002 addressed the comments and a typo in patch 001.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Xiaobing Zhou for the review. Patch 002 addressed the comments and a typo in patch 001.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 9s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 8s Maven dependency ordering for branch
        +1 mvninstall 6m 49s trunk passed
        +1 compile 6m 54s trunk passed with JDK v1.8.0_72
        +1 compile 6m 50s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 1m 21s trunk passed
        +1 mvneclipse 0m 25s trunk passed
        +1 findbugs 1m 57s trunk passed
        +1 javadoc 1m 5s trunk passed with JDK v1.8.0_72
        +1 javadoc 1m 15s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 0m 55s the patch passed
        +1 compile 6m 7s the patch passed with JDK v1.8.0_72
        +1 javac 6m 7s the patch passed
        +1 compile 7m 8s the patch passed with JDK v1.7.0_95
        +1 javac 7m 8s the patch passed
        +1 checkstyle 0m 26s hadoop-common-project: patch generated 0 new + 143 unchanged - 2 fixed = 143 total (was 145)
        +1 mvnsite 1m 20s the patch passed
        +1 mvneclipse 0m 25s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 27s the patch passed
        +1 javadoc 1m 6s the patch passed with JDK v1.8.0_72
        +1 javadoc 1m 16s the patch passed with JDK v1.7.0_95
        +1 unit 3m 34s hadoop-auth in the patch passed with JDK v1.8.0_72.
        +1 unit 7m 7s hadoop-common in the patch passed with JDK v1.8.0_72.
        +1 unit 3m 58s hadoop-auth in the patch passed with JDK v1.7.0_95.
        +1 unit 7m 37s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 26s Patch does not generate ASF License warnings.
        72m 39s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788311/HADOOP-12716.002.patch
        JIRA Issue HADOOP-12716
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 82dd496373f1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 76fab26
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8650/testReport/
        modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8650/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 6m 49s trunk passed +1 compile 6m 54s trunk passed with JDK v1.8.0_72 +1 compile 6m 50s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 21s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 15s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 55s the patch passed +1 compile 6m 7s the patch passed with JDK v1.8.0_72 +1 javac 6m 7s the patch passed +1 compile 7m 8s the patch passed with JDK v1.7.0_95 +1 javac 7m 8s the patch passed +1 checkstyle 0m 26s hadoop-common-project: patch generated 0 new + 143 unchanged - 2 fixed = 143 total (was 145) +1 mvnsite 1m 20s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 27s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 16s the patch passed with JDK v1.7.0_95 +1 unit 3m 34s hadoop-auth in the patch passed with JDK v1.8.0_72. +1 unit 7m 7s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 3m 58s hadoop-auth in the patch passed with JDK v1.7.0_95. +1 unit 7m 37s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 72m 39s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788311/HADOOP-12716.002.patch JIRA Issue HADOOP-12716 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 82dd496373f1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 76fab26 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8650/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8650/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        002 LGTM +1

        Show
        xiaobingo Xiaobing Zhou added a comment - 002 LGTM +1
        Hide
        cnauroth Chris Nauroth added a comment -

        +1 for the patch. I have committed this to trunk, branch-2 and branch-2.8. Xiaoyu Yao, thank you for the patch. Xiaobing Zhou, thank you for helping with the code review.

        Show
        cnauroth Chris Nauroth added a comment - +1 for the patch. I have committed this to trunk, branch-2 and branch-2.8. Xiaoyu Yao , thank you for the patch. Xiaobing Zhou , thank you for helping with the code review.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9363 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9363/)
        HADOOP-12716. KerberosAuthenticator#doSpnegoSequence use incorrect class (cnauroth: rev d6b181c6faa56e43c9f05d2cc860a0aeb940fd90)

        • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9363 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9363/ ) HADOOP-12716 . KerberosAuthenticator#doSpnegoSequence use incorrect class (cnauroth: rev d6b181c6faa56e43c9f05d2cc860a0aeb940fd90) hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/KerberosUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/UserGroupInformation.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/client/KerberosAuthenticator.java

          People

          • Assignee:
            xyao Xiaoyu Yao
            Reporter:
            xyao Xiaoyu Yao
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development