Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Some of the checkstyle checks are not realistic (like the line length), leading to spurious -1 in precommit. Let's disable.

      1. HADOOP-12713.001.patch
        1 kB
        Andrew Wang
      2. HADOOP-12713.002.patch
        2 kB
        Andrew Wang

        Issue Links

          Activity

          Hide
          andrew.wang Andrew Wang added a comment -

          Turn off line length and the qualifier ordering check (which I think is pretty nitty).

          Note you need to run "mvn install" before these get picked up.

          Show
          andrew.wang Andrew Wang added a comment - Turn off line length and the qualifier ordering check (which I think is pretty nitty). Note you need to run "mvn install" before these get picked up.
          Hide
          andrew.wang Andrew Wang added a comment -

          Disable the TODO check too, nothing wrong with a TODO.

          Show
          andrew.wang Andrew Wang added a comment - Disable the TODO check too, nothing wrong with a TODO.
          Hide
          cmccabe Colin P. McCabe added a comment -

          +1 pending jenkins. Thanks, Annie Wang.

          Show
          cmccabe Colin P. McCabe added a comment - +1 pending jenkins. Thanks, Annie Wang .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 45s trunk passed
          +1 compile 0m 7s trunk passed with JDK v1.8.0_66
          +1 compile 0m 8s trunk passed with JDK v1.7.0_91
          +1 mvnsite 0m 11s trunk passed
          +1 mvneclipse 0m 10s trunk passed
          +1 javadoc 0m 10s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 10s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 7s the patch passed
          +1 compile 0m 5s the patch passed with JDK v1.8.0_66
          +1 javac 0m 5s the patch passed
          +1 compile 0m 5s the patch passed with JDK v1.7.0_91
          +1 javac 0m 5s the patch passed
          +1 mvnsite 0m 8s the patch passed
          +1 mvneclipse 0m 6s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 6s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 7s the patch passed with JDK v1.7.0_91
          +1 unit 0m 6s hadoop-build-tools in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 6s hadoop-build-tools in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          10m 54s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782379/HADOOP-12713.002.patch
          JIRA Issue HADOOP-12713
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux bb1537183018 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / cdf8895
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8412/testReport/
          modules C: hadoop-build-tools U: hadoop-build-tools
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8412/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 45s trunk passed +1 compile 0m 7s trunk passed with JDK v1.8.0_66 +1 compile 0m 8s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 11s trunk passed +1 mvneclipse 0m 10s trunk passed +1 javadoc 0m 10s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 10s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 7s the patch passed +1 compile 0m 5s the patch passed with JDK v1.8.0_66 +1 javac 0m 5s the patch passed +1 compile 0m 5s the patch passed with JDK v1.7.0_91 +1 javac 0m 5s the patch passed +1 mvnsite 0m 8s the patch passed +1 mvneclipse 0m 6s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 6s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 7s the patch passed with JDK v1.7.0_91 +1 unit 0m 6s hadoop-build-tools in the patch passed with JDK v1.8.0_66. +1 unit 0m 6s hadoop-build-tools in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 10m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782379/HADOOP-12713.002.patch JIRA Issue HADOOP-12713 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux bb1537183018 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cdf8895 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8412/testReport/ modules C: hadoop-build-tools U: hadoop-build-tools Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8412/console This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks for reviewing Colin, will commit shortly.

          Show
          andrew.wang Andrew Wang added a comment - Thanks for reviewing Colin, will commit shortly.
          Hide
          andrew.wang Andrew Wang added a comment -

          Pushed to trunk and branch-2

          Show
          andrew.wang Andrew Wang added a comment - Pushed to trunk and branch-2
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9123 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9123/)
          HADOOP-12713. Disable spurious checkstyle checks. (wang: rev 5d5a22a878d185dd996a921d681863c4bc44e6b8)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9123 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9123/ ) HADOOP-12713 . Disable spurious checkstyle checks. (wang: rev 5d5a22a878d185dd996a921d681863c4bc44e6b8) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml

            People

            • Assignee:
              andrew.wang Andrew Wang
              Reporter:
              andrew.wang Andrew Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development