Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12683

Add number of samples in last interval in snapshot of MutableStat

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: metrics
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Besides the total number of samples, it is also useful to know the number of samples in the last snapshot of MutableStat.

      1. HADOOP-12683.001.patch
        2 kB
        Vikram Srivastava
      2. HADOOP-12683.002.patch
        3 kB
        Vikram Srivastava

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9103 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9103/)
        HADOOP-12683. Add number of samples in last interval in snapshot of (kasha: rev fb64e6051a65b43e1db051915af84711a8120ea1)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMutableMetrics.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9103 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9103/ ) HADOOP-12683 . Add number of samples in last interval in snapshot of (kasha: rev fb64e6051a65b43e1db051915af84711a8120ea1) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableStat.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/lib/TestMutableMetrics.java
        Hide
        kasha Karthik Kambatla added a comment -

        Thanks for the contribution, Vikram Srivastava. Just committed this to trunk and branch-2.

        Show
        kasha Karthik Kambatla added a comment - Thanks for the contribution, Vikram Srivastava . Just committed this to trunk and branch-2.
        Hide
        kasha Karthik Kambatla added a comment -

        +1

        Show
        kasha Karthik Kambatla added a comment - +1
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 31s trunk passed
        +1 compile 8m 8s trunk passed with JDK v1.8.0_66
        +1 compile 8m 48s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 49s trunk passed
        +1 javadoc 0m 56s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 3s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 36s the patch passed
        +1 compile 7m 55s the patch passed with JDK v1.8.0_66
        +1 javac 7m 55s the patch passed
        +1 compile 8m 50s the patch passed with JDK v1.7.0_91
        +1 javac 8m 50s the patch passed
        +1 checkstyle 0m 15s the patch passed
        +1 mvnsite 1m 2s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 1s Patch has no whitespace issues.
        +1 findbugs 1m 59s the patch passed
        +1 javadoc 0m 52s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 5s the patch passed with JDK v1.7.0_91
        +1 unit 7m 33s hadoop-common in the patch passed with JDK v1.8.0_66.
        -1 unit 7m 40s hadoop-common in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        70m 31s



        Reason Tests
        JDK v1.7.0_91 Failed junit tests hadoop.ipc.TestIPC



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782111/HADOOP-12683.002.patch
        JIRA Issue HADOOP-12683
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7af57d0fe28a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c722b62
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8402/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8402/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8402/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8402/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 31s trunk passed +1 compile 8m 8s trunk passed with JDK v1.8.0_66 +1 compile 8m 48s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 15s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 49s trunk passed +1 javadoc 0m 56s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 36s the patch passed +1 compile 7m 55s the patch passed with JDK v1.8.0_66 +1 javac 7m 55s the patch passed +1 compile 8m 50s the patch passed with JDK v1.7.0_91 +1 javac 8m 50s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 1s Patch has no whitespace issues. +1 findbugs 1m 59s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 5s the patch passed with JDK v1.7.0_91 +1 unit 7m 33s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 7m 40s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 70m 31s Reason Tests JDK v1.7.0_91 Failed junit tests hadoop.ipc.TestIPC Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782111/HADOOP-12683.002.patch JIRA Issue HADOOP-12683 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7af57d0fe28a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c722b62 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8402/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8402/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8402/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8402/console This message was automatically generated.
        Hide
        vickyuec Vikram Srivastava added a comment -

        Updated existing unit test to check for interval sample count as well.

        Show
        vickyuec Vikram Srivastava added a comment - Updated existing unit test to check for interval sample count as well.
        Hide
        kasha Karthik Kambatla added a comment -

        The patch itself looks good to me.

        Show
        kasha Karthik Kambatla added a comment - The patch itself looks good to me.
        Hide
        kasha Karthik Kambatla added a comment -

        Thanks for filing and working on this, Vikram Srivastava. Any chance we could add a test to verify?

        Show
        kasha Karthik Kambatla added a comment - Thanks for filing and working on this, Vikram Srivastava . Any chance we could add a test to verify?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 17s trunk passed
        +1 compile 10m 9s trunk passed with JDK v1.8.0_66
        +1 compile 9m 54s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 17s trunk passed
        +1 mvnsite 1m 11s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 2m 3s trunk passed
        +1 javadoc 1m 1s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 16s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 44s the patch passed
        +1 compile 9m 52s the patch passed with JDK v1.8.0_66
        +1 javac 9m 52s the patch passed
        +1 compile 9m 52s the patch passed with JDK v1.7.0_91
        +1 javac 9m 52s the patch passed
        +1 checkstyle 0m 18s the patch passed
        +1 mvnsite 1m 8s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 13s the patch passed
        +1 javadoc 0m 59s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 9s the patch passed with JDK v1.7.0_91
        +1 unit 9m 12s hadoop-common in the patch passed with JDK v1.8.0_66.
        -1 unit 8m 2s hadoop-common in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        80m 48s



        Reason Tests
        JDK v1.7.0_91 Failed junit tests hadoop.fs.TestSymlinkLocalFSFileSystem



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779762/HADOOP-12683.001.patch
        JIRA Issue HADOOP-12683
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 82e80accc4c5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d0a22ba
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8322/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8322/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8322/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8322/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 17s trunk passed +1 compile 10m 9s trunk passed with JDK v1.8.0_66 +1 compile 9m 54s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 17s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 3s trunk passed +1 javadoc 1m 1s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 16s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 44s the patch passed +1 compile 9m 52s the patch passed with JDK v1.8.0_66 +1 javac 9m 52s the patch passed +1 compile 9m 52s the patch passed with JDK v1.7.0_91 +1 javac 9m 52s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 13s the patch passed +1 javadoc 0m 59s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 9s the patch passed with JDK v1.7.0_91 +1 unit 9m 12s hadoop-common in the patch passed with JDK v1.8.0_66. -1 unit 8m 2s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 80m 48s Reason Tests JDK v1.7.0_91 Failed junit tests hadoop.fs.TestSymlinkLocalFSFileSystem Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779762/HADOOP-12683.001.patch JIRA Issue HADOOP-12683 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 82e80accc4c5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d0a22ba Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8322/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8322/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8322/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8322/console This message was automatically generated.

          People

          • Assignee:
            vickyuec Vikram Srivastava
            Reporter:
            vickyuec Vikram Srivastava
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development