Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12658

Clear javadoc and check style issues around DomainSocket

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It was noticed Javadoc needs minor udpate in DomainSocket.
      There are some other check style issues around to clear up found when working on HDFS-8562.

      1. HADOOP-12658-v6.patch
        11 kB
        Kai Zheng
      2. HADOOP-12658-v5.patch
        11 kB
        Kai Zheng
      3. HADOOP-12658-v4.patch
        12 kB
        Kai Zheng
      4. HADOOP-12658-v3.patch
        12 kB
        Kai Zheng
      5. HADOOP-12658-v2.patch
        2 kB
        Kai Zheng
      6. HADOOP-12658-v1.patch
        2 kB
        Kai Zheng

        Activity

        Hide
        drankye Kai Zheng added a comment -

        Thanks Uma for the review and commit!

        Show
        drankye Kai Zheng added a comment - Thanks Uma for the review and commit!
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        Committed to trunk and branch-2. Thanks Kai for the patch.

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - Committed to trunk and branch-2. Thanks Kai for the patch.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9047 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9047/)
        HADOOP-12658. Clear javadoc and check style issues around DomainSocket. (umamahesh: rev 778146eaae5b1e17928a1f26fb1e46536a6ee510)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ShortCircuitRegistry.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/unix/DomainSocket.java
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9047 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9047/ ) HADOOP-12658 . Clear javadoc and check style issues around DomainSocket. (umamahesh: rev 778146eaae5b1e17928a1f26fb1e46536a6ee510) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/IOUtils.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ShortCircuitRegistry.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/unix/DomainSocket.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/shortcircuit/DfsClientShmManager.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        Latest patch looks good to me.
        +1 , failures seems to be unrelated to this changes.

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - Latest patch looks good to me. +1 , failures seems to be unrelated to this changes.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 59s trunk passed
        +1 compile 9m 12s trunk passed with JDK v1.8.0_66
        +1 compile 9m 39s trunk passed with JDK v1.7.0_91
        +1 checkstyle 1m 7s trunk passed
        +1 mvnsite 2m 45s trunk passed
        +1 mvneclipse 0m 43s trunk passed
        +1 findbugs 6m 5s trunk passed
        +1 javadoc 2m 32s trunk passed with JDK v1.8.0_66
        +1 javadoc 3m 31s trunk passed with JDK v1.7.0_91
        +1 mvninstall 3m 1s the patch passed
        +1 compile 8m 58s the patch passed with JDK v1.8.0_66
        +1 javac 8m 58s the patch passed
        +1 compile 9m 39s the patch passed with JDK v1.7.0_91
        +1 javac 9m 39s the patch passed
        +1 checkstyle 1m 8s the patch passed
        +1 mvnsite 2m 40s the patch passed
        +1 mvneclipse 0m 44s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 6m 23s the patch passed
        +1 javadoc 2m 34s the patch passed with JDK v1.8.0_66
        +1 javadoc 3m 27s the patch passed with JDK v1.7.0_91
        +1 unit 8m 28s hadoop-common in the patch passed with JDK v1.8.0_66.
        +1 unit 0m 56s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
        -1 unit 58m 32s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 8m 6s hadoop-common in the patch failed with JDK v1.7.0_91.
        +1 unit 1m 1s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
        -1 unit 56m 16s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 26s Patch does not generate ASF License warnings.
        217m 39s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.TestRecoverStripedBlocks
          hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
        JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.fs.TestLocalFsFCStatistics
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion
          hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure020
          hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779977/HADOOP-12658-v6.patch
        JIRA Issue HADOOP-12658
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5c8550203036 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ad997fa
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client U: .
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 59s trunk passed +1 compile 9m 12s trunk passed with JDK v1.8.0_66 +1 compile 9m 39s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 7s trunk passed +1 mvnsite 2m 45s trunk passed +1 mvneclipse 0m 43s trunk passed +1 findbugs 6m 5s trunk passed +1 javadoc 2m 32s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 31s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 1s the patch passed +1 compile 8m 58s the patch passed with JDK v1.8.0_66 +1 javac 8m 58s the patch passed +1 compile 9m 39s the patch passed with JDK v1.7.0_91 +1 javac 9m 39s the patch passed +1 checkstyle 1m 8s the patch passed +1 mvnsite 2m 40s the patch passed +1 mvneclipse 0m 44s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 23s the patch passed +1 javadoc 2m 34s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 27s the patch passed with JDK v1.7.0_91 +1 unit 8m 28s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 56s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 58m 32s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 8m 6s hadoop-common in the patch failed with JDK v1.7.0_91. +1 unit 1m 1s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. -1 unit 56m 16s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 217m 39s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.TestRecoverStripedBlocks   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.TestLocalFsFCStatistics   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure020   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779977/HADOOP-12658-v6.patch JIRA Issue HADOOP-12658 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5c8550203036 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ad997fa Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8326/console This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        Fixed the newly found checking style.

        Show
        drankye Kai Zheng added a comment - Fixed the newly found checking style.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 56s trunk passed
        +1 compile 8m 48s trunk passed with JDK v1.8.0_66
        +1 compile 9m 39s trunk passed with JDK v1.7.0_91
        +1 checkstyle 1m 5s trunk passed
        +1 mvnsite 2m 44s trunk passed
        +1 mvneclipse 0m 43s trunk passed
        +1 findbugs 6m 3s trunk passed
        +1 javadoc 2m 30s trunk passed with JDK v1.8.0_66
        +1 javadoc 3m 26s trunk passed with JDK v1.7.0_91
        +1 mvninstall 3m 0s the patch passed
        +1 compile 8m 39s the patch passed with JDK v1.8.0_66
        +1 javac 8m 39s the patch passed
        +1 compile 10m 0s the patch passed with JDK v1.7.0_91
        +1 javac 10m 0s the patch passed
        -1 checkstyle 1m 9s Patch generated 1 new checkstyle issues in root (total was 184, now 173).
        +1 mvnsite 2m 44s the patch passed
        +1 mvneclipse 0m 42s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 6m 27s the patch passed
        +1 javadoc 2m 33s the patch passed with JDK v1.8.0_66
        +1 javadoc 3m 28s the patch passed with JDK v1.7.0_91
        +1 unit 8m 39s hadoop-common in the patch passed with JDK v1.8.0_66.
        +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
        -1 unit 69m 22s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 8m 49s hadoop-common in the patch failed with JDK v1.7.0_91.
        +1 unit 1m 11s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
        -1 unit 55m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 26s Patch does not generate ASF License warnings.
        228m 32s



        Reason Tests
        JDK v Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.TestDFSClientRetries
          hadoop.hdfs.TestFsShellPermission
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
        JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.hdfs.tools.TestDFSZKFailoverController
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779923/HADOOP-12658-v5.patch
        JIRA Issue HADOOP-12658
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cce727bd695f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ad997fa
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client U: .
        Max memory used 75MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 56s trunk passed +1 compile 8m 48s trunk passed with JDK v1.8.0_66 +1 compile 9m 39s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 5s trunk passed +1 mvnsite 2m 44s trunk passed +1 mvneclipse 0m 43s trunk passed +1 findbugs 6m 3s trunk passed +1 javadoc 2m 30s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 26s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 0s the patch passed +1 compile 8m 39s the patch passed with JDK v1.8.0_66 +1 javac 8m 39s the patch passed +1 compile 10m 0s the patch passed with JDK v1.7.0_91 +1 javac 10m 0s the patch passed -1 checkstyle 1m 9s Patch generated 1 new checkstyle issues in root (total was 184, now 173). +1 mvnsite 2m 44s the patch passed +1 mvneclipse 0m 42s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 27s the patch passed +1 javadoc 2m 33s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 28s the patch passed with JDK v1.7.0_91 +1 unit 8m 39s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 69m 22s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 8m 49s hadoop-common in the patch failed with JDK v1.7.0_91. +1 unit 1m 11s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. -1 unit 55m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 228m 32s Reason Tests JDK v Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.TestFsShellPermission   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark JDK v1.7.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779923/HADOOP-12658-v5.patch JIRA Issue HADOOP-12658 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cce727bd695f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ad997fa Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client U: . Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8325/console This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        Updated the patch addressing review comments.

        Show
        drankye Kai Zheng added a comment - Updated the patch addressing review comments.
        Hide
        drankye Kai Zheng added a comment -

        Thanks Uma for the careful review! I'll update the patch to address them.

        Show
        drankye Kai Zheng added a comment - Thanks Uma for the careful review! I'll update the patch to address them.
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        Hi Kai,
        Thanks for the patch.

        +  private static native int connect0(String path) throws IOException;;
        

        Please remove unnecessary “;"

          * @param path         The path to connect to.
        +   * @throws IOException                  If there was an I/O error
        +   *                                      performing the connect
            * @return             The new DomainSocket.
        

        Please maintain consistent spacing for clean look.

         /**
           * Receive some FileDescriptor objects from the process on the other side of
          /**
           * Receive some FileDescriptor objects from the process on the other side of
        

        did not cleanup the code well. 2 lines missed to remove I think. Please check

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - Hi Kai, Thanks for the patch. + private static native int connect0( String path) throws IOException;; Please remove unnecessary “;" * @param path The path to connect to. + * @ throws IOException If there was an I/O error + * performing the connect * @ return The new DomainSocket. Please maintain consistent spacing for clean look. /** * Receive some FileDescriptor objects from the process on the other side of /** * Receive some FileDescriptor objects from the process on the other side of did not cleanup the code well. 2 lines missed to remove I think. Please check
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 40s trunk passed
        +1 compile 10m 35s trunk passed with JDK v1.8.0_66
        +1 compile 9m 59s trunk passed with JDK v1.7.0_91
        +1 checkstyle 1m 7s trunk passed
        +1 mvnsite 2m 49s trunk passed
        +1 mvneclipse 0m 42s trunk passed
        +1 findbugs 6m 16s trunk passed
        +1 javadoc 2m 45s trunk passed with JDK v1.8.0_66
        +1 javadoc 3m 50s trunk passed with JDK v1.7.0_91
        +1 mvninstall 3m 5s the patch passed
        +1 compile 9m 33s the patch passed with JDK v1.8.0_66
        +1 javac 9m 33s the patch passed
        +1 compile 10m 14s the patch passed with JDK v1.7.0_91
        +1 javac 10m 14s the patch passed
        +1 checkstyle 1m 12s the patch passed
        +1 mvnsite 2m 48s the patch passed
        +1 mvneclipse 0m 44s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 6m 47s the patch passed
        +1 javadoc 2m 31s the patch passed with JDK v1.8.0_66
        +1 javadoc 3m 34s the patch passed with JDK v1.7.0_91
        -1 unit 10m 28s hadoop-common in the patch failed with JDK v1.8.0_66.
        +1 unit 1m 1s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
        -1 unit 66m 1s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 9m 5s hadoop-common in the patch failed with JDK v1.7.0_91.
        +1 unit 1m 8s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
        -1 unit 60m 21s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 26s Patch does not generate ASF License warnings.
        237m 32s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.ha.TestZKFailoverController
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.TestFileAppend2
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
        JDK v1.7.0_91 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag
          hadoop.ha.TestZKFailoverController
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.TestDFSClientRetries
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779631/HADOOP-12658-v4.patch
        JIRA Issue HADOOP-12658
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 31dd2ab4b3c5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a0249da
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client U: .
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 40s trunk passed +1 compile 10m 35s trunk passed with JDK v1.8.0_66 +1 compile 9m 59s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 7s trunk passed +1 mvnsite 2m 49s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 6m 16s trunk passed +1 javadoc 2m 45s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 50s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 5s the patch passed +1 compile 9m 33s the patch passed with JDK v1.8.0_66 +1 javac 9m 33s the patch passed +1 compile 10m 14s the patch passed with JDK v1.7.0_91 +1 javac 10m 14s the patch passed +1 checkstyle 1m 12s the patch passed +1 mvnsite 2m 48s the patch passed +1 mvneclipse 0m 44s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 47s the patch passed +1 javadoc 2m 31s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 34s the patch passed with JDK v1.7.0_91 -1 unit 10m 28s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 1m 1s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 66m 1s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 9m 5s hadoop-common in the patch failed with JDK v1.7.0_91. +1 unit 1m 8s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. -1 unit 60m 21s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 237m 32s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.ha.TestZKFailoverController   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.TestFileAppend2   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark JDK v1.7.0_91 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag   hadoop.ha.TestZKFailoverController   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779631/HADOOP-12658-v4.patch JIRA Issue HADOOP-12658 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 31dd2ab4b3c5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a0249da Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8314/console This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        Updated the patch to address the reported checking style issues.

        Show
        drankye Kai Zheng added a comment - Updated the patch to address the reported checking style issues.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 35s trunk passed
        +1 compile 7m 57s trunk passed with JDK v1.8.0_66
        +1 compile 8m 52s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 57s trunk passed
        +1 mvnsite 2m 26s trunk passed
        +1 mvneclipse 0m 42s trunk passed
        +1 findbugs 5m 33s trunk passed
        +1 javadoc 2m 23s trunk passed with JDK v1.8.0_66
        +1 javadoc 3m 17s trunk passed with JDK v1.7.0_91
        +1 mvninstall 2m 59s the patch passed
        +1 compile 8m 26s the patch passed with JDK v1.8.0_66
        +1 javac 8m 26s the patch passed
        +1 compile 8m 41s the patch passed with JDK v1.7.0_91
        +1 javac 8m 41s the patch passed
        -1 checkstyle 0m 57s Patch generated 2 new checkstyle issues in root (total was 187, now 178).
        +1 mvnsite 2m 26s the patch passed
        +1 mvneclipse 0m 41s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 5m 57s the patch passed
        +1 javadoc 2m 18s the patch passed with JDK v1.8.0_66
        +1 javadoc 3m 12s the patch passed with JDK v1.7.0_91
        +1 unit 7m 5s hadoop-common in the patch passed with JDK v1.8.0_66.
        +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
        -1 unit 53m 18s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        +1 unit 7m 29s hadoop-common in the patch passed with JDK v1.7.0_91.
        +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
        -1 unit 51m 19s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 25s Patch generated 1 ASF License warnings.
        198m 10s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          hadoop.hdfs.server.datanode.TestDataNodeMetrics
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
          hadoop.hdfs.TestDFSUpgradeFromImage
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040
          hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779395/HADOOP-12658-v3.patch
        JIRA Issue HADOOP-12658
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 227e7f28aec9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a308e86
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client U: .
        Max memory used 75MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 35s trunk passed +1 compile 7m 57s trunk passed with JDK v1.8.0_66 +1 compile 8m 52s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 57s trunk passed +1 mvnsite 2m 26s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 5m 33s trunk passed +1 javadoc 2m 23s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 17s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 59s the patch passed +1 compile 8m 26s the patch passed with JDK v1.8.0_66 +1 javac 8m 26s the patch passed +1 compile 8m 41s the patch passed with JDK v1.7.0_91 +1 javac 8m 41s the patch passed -1 checkstyle 0m 57s Patch generated 2 new checkstyle issues in root (total was 187, now 178). +1 mvnsite 2m 26s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 57s the patch passed +1 javadoc 2m 18s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 12s the patch passed with JDK v1.7.0_91 +1 unit 7m 5s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 53m 18s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 7m 29s hadoop-common in the patch passed with JDK v1.7.0_91. +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. -1 unit 51m 19s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 25s Patch generated 1 ASF License warnings. 198m 10s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.TestDFSUpgradeFromImage JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779395/HADOOP-12658-v3.patch JIRA Issue HADOOP-12658 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 227e7f28aec9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a308e86 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-client U: . Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8311/console This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        About IOException, there was a comment here in HDFS-8562 I forgot to address:

        SocketTimeoutException is timeouts, other IOExceptions could be other things. Maybe have two lines about exceptions, one for IOE and another for timeout?

        SocketTimeoutException is also an IOException. Having the both in the throw list would not look clean. Not adding SocketTimeoutException explicitly doesn't prevent callers from handling it specially. If we'd like to add SocketTimeoutException in the accept() method throw list, we might need to do it as well for other methods. More suggestions are welcome.

        Show
        drankye Kai Zheng added a comment - About IOException, there was a comment here in HDFS-8562 I forgot to address: SocketTimeoutException is timeouts, other IOExceptions could be other things. Maybe have two lines about exceptions, one for IOE and another for timeout? SocketTimeoutException is also an IOException . Having the both in the throw list would not look clean. Not adding SocketTimeoutException explicitly doesn't prevent callers from handling it specially. If we'd like to add SocketTimeoutException in the accept() method throw list, we might need to do it as well for other methods. More suggestions are welcome.
        Hide
        drankye Kai Zheng added a comment -

        Hi Uma Maheswara Rao G, could you help review this? I thought this clear up would be better to be in. Thanks.

        Show
        drankye Kai Zheng added a comment - Hi Uma Maheswara Rao G , could you help review this? I thought this clear up would be better to be in. Thanks.
        Hide
        drankye Kai Zheng added a comment -

        I re-purposed this to handle more check style issues to be cleared up sooner found in HDFS-8562.

        Show
        drankye Kai Zheng added a comment - I re-purposed this to handle more check style issues to be cleared up sooner found in HDFS-8562 .
        Hide
        drankye Kai Zheng added a comment -

        Sorry, but I would probably handle this together in HDFS-8562. When that's in if possible, this will be marked as duplicate, otherwise will move on this.

        Show
        drankye Kai Zheng added a comment - Sorry, but I would probably handle this together in HDFS-8562 . When that's in if possible, this will be marked as duplicate, otherwise will move on this.
        Hide
        templedf Daniel Templeton added a comment -

        Looks good to me. I haven't validated that the changes are actually accurate, though.

        Show
        templedf Daniel Templeton added a comment - Looks good to me. I haven't validated that the changes are actually accurate, though.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 59s trunk passed
        +1 compile 9m 10s trunk passed with JDK v1.8.0_66
        +1 compile 10m 36s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 18s trunk passed
        +1 mvnsite 1m 13s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 2m 26s trunk passed
        +1 javadoc 1m 19s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 21s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 45s the patch passed
        +1 compile 8m 52s the patch passed with JDK v1.8.0_66
        +1 javac 8m 52s the patch passed
        +1 compile 9m 24s the patch passed with JDK v1.7.0_91
        +1 javac 9m 24s the patch passed
        -1 checkstyle 0m 17s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 38, now 38).
        +1 mvnsite 1m 7s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 6s the patch passed
        +1 javadoc 0m 56s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 6s the patch passed with JDK v1.7.0_91
        +1 unit 8m 9s hadoop-common in the patch passed with JDK v1.8.0_66.
        +1 unit 8m 17s hadoop-common in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        78m 27s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778759/HADOOP-12658-v2.patch
        JIRA Issue HADOOP-12658
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 778766c46084 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 52ad912
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8284/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8284/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8284/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 59s trunk passed +1 compile 9m 10s trunk passed with JDK v1.8.0_66 +1 compile 10m 36s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 18s trunk passed +1 mvnsite 1m 13s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 26s trunk passed +1 javadoc 1m 19s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 21s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 45s the patch passed +1 compile 8m 52s the patch passed with JDK v1.8.0_66 +1 javac 8m 52s the patch passed +1 compile 9m 24s the patch passed with JDK v1.7.0_91 +1 javac 9m 24s the patch passed -1 checkstyle 0m 17s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 38, now 38). +1 mvnsite 1m 7s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_91 +1 unit 8m 9s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 17s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 78m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778759/HADOOP-12658-v2.patch JIRA Issue HADOOP-12658 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 778766c46084 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 52ad912 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8284/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8284/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8284/console This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        Addressed Daniel's review comment. Thanks!

        Show
        drankye Kai Zheng added a comment - Addressed Daniel's review comment. Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 1s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 29m 5s trunk passed
        +1 compile 45m 41s trunk passed with JDK v1.8.0_66
        +1 compile 29m 41s trunk passed with JDK v1.7.0_91
        +1 checkstyle 1m 2s trunk passed
        +1 mvnsite 3m 40s trunk passed
        +1 mvneclipse 0m 49s trunk passed
        +1 findbugs 6m 31s trunk passed
        +1 javadoc 3m 34s trunk passed with JDK v1.8.0_66
        +1 javadoc 3m 2s trunk passed with JDK v1.7.0_91
        +1 mvninstall 4m 6s the patch passed
        -1 compile 12m 23s root in the patch failed with JDK v1.8.0_66.
        -1 javac 12m 23s root in the patch failed with JDK v1.8.0_66.
        +1 compile 29m 19s the patch passed with JDK v1.7.0_91
        +1 javac 29m 19s the patch passed
        -1 checkstyle 0m 53s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 39, now 39).
        +1 mvnsite 3m 43s the patch passed
        +1 mvneclipse 0m 42s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 6m 48s the patch passed
        +1 javadoc 2m 52s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 36s the patch passed with JDK v1.7.0_91
        -1 unit 23m 55s hadoop-common in the patch failed with JDK v1.8.0_66.
        -1 unit 20m 30s hadoop-common in the patch failed with JDK v1.7.0_91.
        +1 asflicense 1m 10s Patch does not generate ASF License warnings.
        235m 48s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.find.TestAnd
          hadoop.io.compress.TestCodecPool
          hadoop.fs.shell.find.TestPrint
          hadoop.fs.shell.find.TestPrint0
          hadoop.test.TestTimedOutTestsListener
          hadoop.fs.shell.find.TestIname
          hadoop.fs.shell.find.TestName
          hadoop.fs.shell.find.TestFind
          hadoop.ipc.TestRPCWaitForProxy
          hadoop.ipc.TestProtoBufRpc
        JDK v1.7.0_91 Failed junit tests hadoop.fs.TestLocalFsFCStatistics
          hadoop.fs.shell.find.TestAnd
          hadoop.io.compress.TestCodecPool
          hadoop.fs.shell.find.TestPrint
          hadoop.fs.shell.find.TestPrint0
          hadoop.test.TestTimedOutTestsListener
          hadoop.fs.shell.find.TestIname
          hadoop.fs.shell.find.TestName
          hadoop.fs.shell.find.TestFind
          hadoop.ipc.TestRPCWaitForProxy
          hadoop.ipc.TestProtoBufRpc



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778446/HADOOP-12658-v1.patch
        JIRA Issue HADOOP-12658
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 33901c9880ff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e63388f
        findbugs v3.0.0
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 75MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 29m 5s trunk passed +1 compile 45m 41s trunk passed with JDK v1.8.0_66 +1 compile 29m 41s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 2s trunk passed +1 mvnsite 3m 40s trunk passed +1 mvneclipse 0m 49s trunk passed +1 findbugs 6m 31s trunk passed +1 javadoc 3m 34s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 2s trunk passed with JDK v1.7.0_91 +1 mvninstall 4m 6s the patch passed -1 compile 12m 23s root in the patch failed with JDK v1.8.0_66. -1 javac 12m 23s root in the patch failed with JDK v1.8.0_66. +1 compile 29m 19s the patch passed with JDK v1.7.0_91 +1 javac 29m 19s the patch passed -1 checkstyle 0m 53s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 39, now 39). +1 mvnsite 3m 43s the patch passed +1 mvneclipse 0m 42s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 48s the patch passed +1 javadoc 2m 52s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 36s the patch passed with JDK v1.7.0_91 -1 unit 23m 55s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 20m 30s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 1m 10s Patch does not generate ASF License warnings. 235m 48s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.shell.find.TestAnd   hadoop.io.compress.TestCodecPool   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestPrint0   hadoop.test.TestTimedOutTestsListener   hadoop.fs.shell.find.TestIname   hadoop.fs.shell.find.TestName   hadoop.fs.shell.find.TestFind   hadoop.ipc.TestRPCWaitForProxy   hadoop.ipc.TestProtoBufRpc JDK v1.7.0_91 Failed junit tests hadoop.fs.TestLocalFsFCStatistics   hadoop.fs.shell.find.TestAnd   hadoop.io.compress.TestCodecPool   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestPrint0   hadoop.test.TestTimedOutTestsListener   hadoop.fs.shell.find.TestIname   hadoop.fs.shell.find.TestName   hadoop.fs.shell.find.TestFind   hadoop.ipc.TestRPCWaitForProxy   hadoop.ipc.TestProtoBufRpc Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778446/HADOOP-12658-v1.patch JIRA Issue HADOOP-12658 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 33901c9880ff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e63388f findbugs v3.0.0 compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/patch-compile-root-jdk1.8.0_66.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8279/console This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        If you're deleting line 468, you should also delete 467.

        Show
        templedf Daniel Templeton added a comment - If you're deleting line 468, you should also delete 467.
        Hide
        drankye Kai Zheng added a comment -

        Uploaded a patch to update the JAVA doc and comments.

        Show
        drankye Kai Zheng added a comment - Uploaded a patch to update the JAVA doc and comments.

          People

          • Assignee:
            drankye Kai Zheng
            Reporter:
            drankye Kai Zheng
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development