Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12608

Fix exception message in WASB when connecting with anonymous credential

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: tools
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Users of WASB have raised complaints over the error message returned back from WASB when they are trying to connect to Azure storage with anonymous credentials. Current implementation returns the correct message when we encounter a Storage exception, however for scenarios like querying to check if a container exists does not throw a StorageException but returns false when URI is directly specified (Anonymous access) the error message returned does not clearly state that credentials for storage account is not provided. This JIRA tracks the fix the error message to return what is returned when a storage exception is hit and also correct spelling mistakes in the error message.

      1. HADOOP-12608.005.patch
        5 kB
        Dushyanth
      2. HADOOP-12608.004.patch
        5 kB
        Dushyanth
      3. HADOOP-12608.003.patch
        9 kB
        Dushyanth
      4. HADOOP-12608.002.patch
        10 kB
        Dushyanth
      5. HADOOP-12608.001.patch
        2 kB
        Dushyanth

        Issue Links

          Activity

          Hide
          dchickabasapa Dushyanth added a comment -

          Adding patch for the first iteration.

          Show
          dchickabasapa Dushyanth added a comment - Adding patch for the first iteration.
          Hide
          stevel@apache.org Steve Loughran added a comment -
          1. should a more specific exception be raised, .e.g. PathAccessDeniedException?
          2. Is there an existing test for this outcome?
          3. patch requirements for anything against an object store primarily consist of confirming you've run all the existing tests + your patch: https://wiki.apache.org/hadoop/HowToContribute#Submitting_patches_against_object_stores_such_as_Amazon_S3.2C_OpenStack_Swift_and_Microsoft_Azure
          Show
          stevel@apache.org Steve Loughran added a comment - should a more specific exception be raised, .e.g. PathAccessDeniedException ? Is there an existing test for this outcome? patch requirements for anything against an object store primarily consist of confirming you've run all the existing tests + your patch: https://wiki.apache.org/hadoop/HowToContribute#Submitting_patches_against_object_stores_such_as_Amazon_S3.2C_OpenStack_Swift_and_Microsoft_Azure
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 7s trunk passed
          +1 compile 0m 15s trunk passed with JDK v1.8.0_66
          +1 compile 0m 16s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 8s trunk passed
          +1 mvnsite 0m 22s trunk passed
          +1 mvneclipse 0m 21s trunk passed
          +1 findbugs 0m 31s trunk passed
          +1 javadoc 0m 13s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 15s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 19s the patch passed
          +1 compile 0m 15s the patch passed with JDK v1.8.0_66
          +1 javac 0m 15s the patch passed
          +1 compile 0m 16s the patch passed with JDK v1.7.0_85
          +1 javac 0m 16s the patch passed
          +1 checkstyle 0m 8s the patch passed
          +1 mvnsite 0m 21s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 39s the patch passed
          +1 javadoc 0m 13s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 15s the patch passed with JDK v1.7.0_85
          +1 unit 1m 9s hadoop-azure in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 22s hadoop-azure in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          17m 6s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774931/HADOOP-12608.001.patch
          JIRA Issue HADOOP-12608
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e887a047d698 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1c05393
          findbugs v3.0.0
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8170/testReport/
          modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8170/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 7s trunk passed +1 compile 0m 15s trunk passed with JDK v1.8.0_66 +1 compile 0m 16s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 8s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 21s trunk passed +1 findbugs 0m 31s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 19s the patch passed +1 compile 0m 15s the patch passed with JDK v1.8.0_66 +1 javac 0m 15s the patch passed +1 compile 0m 16s the patch passed with JDK v1.7.0_85 +1 javac 0m 16s the patch passed +1 checkstyle 0m 8s the patch passed +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 39s the patch passed +1 javadoc 0m 13s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 15s the patch passed with JDK v1.7.0_85 +1 unit 1m 9s hadoop-azure in the patch passed with JDK v1.8.0_66. +1 unit 1m 22s hadoop-azure in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 17m 6s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774931/HADOOP-12608.001.patch JIRA Issue HADOOP-12608 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e887a047d698 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1c05393 findbugs v3.0.0 JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8170/testReport/ modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8170/console This message was automatically generated.
          Hide
          dchickabasapa Dushyanth added a comment -

          Steve Loughran Thanks Steve for the review.

          1) I would like to keep this way, because it gives an indication the error is with respect azure storage keys not being provided and it is azure specific.
          2) I have added a test that simulates and verifies the error message.
          3) I have tested as before with the live azure storage tests. I would start mentioning that going forward with new submissions.

          Show
          dchickabasapa Dushyanth added a comment - Steve Loughran Thanks Steve for the review. 1) I would like to keep this way, because it gives an indication the error is with respect azure storage keys not being provided and it is azure specific. 2) I have added a test that simulates and verifies the error message. 3) I have tested as before with the live azure storage tests. I would start mentioning that going forward with new submissions.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 12s HADOOP-12608 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777637/HADOOP-12608.002.patch
          JIRA Issue HADOOP-12608
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8240/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 12s HADOOP-12608 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777637/HADOOP-12608.002.patch JIRA Issue HADOOP-12608 Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8240/console This message was automatically generated.
          Hide
          dchickabasapa Dushyanth added a comment -

          Synced to the latest and created the patch.

          Show
          dchickabasapa Dushyanth added a comment - Synced to the latest and created the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 5s HADOOP-12608 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777796/HADOOP-12608.003.patch
          JIRA Issue HADOOP-12608
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8249/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 5s HADOOP-12608 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777796/HADOOP-12608.003.patch JIRA Issue HADOOP-12608 Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8249/console This message was automatically generated.
          Hide
          dchickabasapa Dushyanth added a comment -

          Fixing the issue with creating patch and attaching the patch.

          Show
          dchickabasapa Dushyanth added a comment - Fixing the issue with creating patch and attaching the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 40s trunk passed
          +1 compile 0m 15s trunk passed with JDK v1.8.0_66
          +1 compile 0m 16s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 8s trunk passed
          +1 mvnsite 0m 22s trunk passed
          +1 mvneclipse 0m 11s trunk passed
          +1 findbugs 0m 30s trunk passed
          +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 15s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 18s the patch passed
          +1 compile 0m 14s the patch passed with JDK v1.8.0_66
          +1 javac 0m 14s the patch passed
          +1 compile 0m 16s the patch passed with JDK v1.7.0_91
          +1 javac 0m 16s the patch passed
          +1 checkstyle 0m 8s the patch passed
          +1 mvnsite 0m 21s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          -1 whitespace 0m 0s The patch has 2 line(s) with tabs.
          +1 findbugs 0m 36s the patch passed
          +1 javadoc 0m 14s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 14s the patch passed with JDK v1.7.0_91
          +1 unit 1m 15s hadoop-azure in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 25s hadoop-azure in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          16m 29s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778087/HADOOP-12608.004.patch
          JIRA Issue HADOOP-12608
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d5f91f1e964b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0f708d4
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8258/artifact/patchprocess/whitespace-tabs.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8258/testReport/
          modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8258/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 40s trunk passed +1 compile 0m 15s trunk passed with JDK v1.8.0_66 +1 compile 0m 16s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 8s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 0m 30s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 18s the patch passed +1 compile 0m 14s the patch passed with JDK v1.8.0_66 +1 javac 0m 14s the patch passed +1 compile 0m 16s the patch passed with JDK v1.7.0_91 +1 javac 0m 16s the patch passed +1 checkstyle 0m 8s the patch passed +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) with tabs. +1 findbugs 0m 36s the patch passed +1 javadoc 0m 14s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 14s the patch passed with JDK v1.7.0_91 +1 unit 1m 15s hadoop-azure in the patch passed with JDK v1.8.0_66. +1 unit 1m 25s hadoop-azure in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 16m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778087/HADOOP-12608.004.patch JIRA Issue HADOOP-12608 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d5f91f1e964b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0f708d4 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8258/artifact/patchprocess/whitespace-tabs.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8258/testReport/ modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8258/console This message was automatically generated.
          Hide
          dchickabasapa Dushyanth added a comment -

          Fixed the white-space tab issue.

          Show
          dchickabasapa Dushyanth added a comment - Fixed the white-space tab issue.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 51s trunk passed
          +1 compile 0m 20s trunk passed with JDK v1.8.0_66
          +1 compile 0m 20s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 10s trunk passed
          +1 mvnsite 0m 26s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 0m 33s trunk passed
          +1 javadoc 0m 14s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 15s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 19s the patch passed
          +1 compile 0m 15s the patch passed with JDK v1.8.0_66
          +1 javac 0m 15s the patch passed
          +1 compile 0m 18s the patch passed with JDK v1.7.0_91
          +1 javac 0m 18s the patch passed
          +1 checkstyle 0m 10s the patch passed
          +1 mvnsite 0m 25s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 42s the patch passed
          +1 javadoc 0m 15s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 17s the patch passed with JDK v1.7.0_91
          +1 unit 1m 26s hadoop-azure in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 34s hadoop-azure in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          18m 58s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778137/HADOOP-12608.005.patch
          JIRA Issue HADOOP-12608
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 17a47a2eb635 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3c0adac
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8262/testReport/
          modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8262/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 51s trunk passed +1 compile 0m 20s trunk passed with JDK v1.8.0_66 +1 compile 0m 20s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 10s trunk passed +1 mvnsite 0m 26s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 33s trunk passed +1 javadoc 0m 14s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 19s the patch passed +1 compile 0m 15s the patch passed with JDK v1.8.0_66 +1 javac 0m 15s the patch passed +1 compile 0m 18s the patch passed with JDK v1.7.0_91 +1 javac 0m 18s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 42s the patch passed +1 javadoc 0m 15s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 17s the patch passed with JDK v1.7.0_91 +1 unit 1m 26s hadoop-azure in the patch passed with JDK v1.8.0_66. +1 unit 1m 34s hadoop-azure in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 18m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778137/HADOOP-12608.005.patch JIRA Issue HADOOP-12608 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 17a47a2eb635 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3c0adac findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8262/testReport/ modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8262/console This message was automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Dushyanth, please don't set fix-version. Committers set that to appropriate values at commit time. Unsetting it myself now, FYI.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Dushyanth , please don't set fix-version. Committers set that to appropriate values at commit time. Unsetting it myself now, FYI.
          Hide
          xyao Xiaoyu Yao added a comment -

          Dushyanth, thanks for working on this and the patch looks good to me overall. Can you add comments to this JIRA on tests that have been done to the latest patch (e.g., the new unit test added has passed with Azure) as suggested by Steve Loughran below. Thanks!

          "patch requirements for anything against an object store primarily consist of confirming you've run all the existing tests + your patch: https://wiki.apache.org/hadoop/HowToContribute#Submitting_patches_against_object_stores_such_as_Amazon_S3.2C_OpenStack_Swift_and_Microsoft_Azure"

          Show
          xyao Xiaoyu Yao added a comment - Dushyanth , thanks for working on this and the patch looks good to me overall. Can you add comments to this JIRA on tests that have been done to the latest patch (e.g., the new unit test added has passed with Azure) as suggested by Steve Loughran below. Thanks! "patch requirements for anything against an object store primarily consist of confirming you've run all the existing tests + your patch: https://wiki.apache.org/hadoop/HowToContribute#Submitting_patches_against_object_stores_such_as_Amazon_S3.2C_OpenStack_Swift_and_Microsoft_Azure "
          Hide
          dchickabasapa Dushyanth added a comment -

          Xiaoyu Yao Thanks for the review.

          Testing: The patch contains new tests to verify the changes made. Also changes have been tested against FileSystemContractLive tests for the both Block Blobs and Page Blobs.

          Show
          dchickabasapa Dushyanth added a comment - Xiaoyu Yao Thanks for the review. Testing: The patch contains new tests to verify the changes made. Also changes have been tested against FileSystemContractLive tests for the both Block Blobs and Page Blobs.
          Hide
          xyao Xiaoyu Yao added a comment -

          +1 for the v005 patch given the Jenkins results and manual test done by Dushyanth. I will commit it shortly.

          Show
          xyao Xiaoyu Yao added a comment - +1 for the v005 patch given the Jenkins results and manual test done by Dushyanth . I will commit it shortly.
          Hide
          xyao Xiaoyu Yao added a comment -

          Thanks Dushyanth for the contribution and all for the reviews. I've commit the patch to trunk, branch-2 and branch-2.8.

          Show
          xyao Xiaoyu Yao added a comment - Thanks Dushyanth for the contribution and all for the reviews. I've commit the patch to trunk, branch-2 and branch-2.8.
          Hide
          andrew.wang Andrew Wang added a comment -

          I believe this was mistakenly not pushed to trunk, I went ahead and cherry-picked the branch-2 patch over.

          Show
          andrew.wang Andrew Wang added a comment - I believe this was mistakenly not pushed to trunk, I went ahead and cherry-picked the branch-2 patch over.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10370 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10370/)
          HADOOP-12608. Fix exception message in WASB when connecting with (wang: rev 8b57be108f9de3b74c5d6465828241fd436bcb99)

          • (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java
          • (add) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestFileSystemOperationExceptionMessage.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10370 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10370/ ) HADOOP-12608 . Fix exception message in WASB when connecting with (wang: rev 8b57be108f9de3b74c5d6465828241fd436bcb99) (edit) hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/AzureNativeFileSystemStore.java (add) hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestFileSystemOperationExceptionMessage.java

            People

            • Assignee:
              dchickabasapa Dushyanth
              Reporter:
              dchickabasapa Dushyanth
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development