Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12600

FileContext and AbstractFileSystem should be annotated as a Stable interface.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: fs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The FileContext class currently is annotated as Evolving. However, at this point we really need to treat it as a Stable interface.

      1. HADOOP-12600.002.patch
        1 kB
        Chris Nauroth
      2. HADOOP-12600.001.patch
        0.7 kB
        Chris Nauroth

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2586 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2586/)
        HADOOP-12600. FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2586 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2586/ ) HADOOP-12600 . FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #649 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/649/)
        HADOOP-12600. FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #649 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/649/ ) HADOOP-12600 . FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2672 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2672/)
        HADOOP-12600. FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2672 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2672/ ) HADOOP-12600 . FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #730 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/730/)
        HADOOP-12600. FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #730 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/730/ ) HADOOP-12600 . FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #741 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/741/)
        HADOOP-12600. FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #741 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/741/ ) HADOOP-12600 . FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1461 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1461/)
        HADOOP-12600. FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1461 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1461/ ) HADOOP-12600 . FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8898 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8898/)
        HADOOP-12600. FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8898 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8898/ ) HADOOP-12600 . FileContext and AbstractFileSystem should be annotated as (cnauroth: rev b2c78536cb55c58e4d4a0ea16f648a34c7e2f88c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
        Hide
        cnauroth Chris Nauroth added a comment -

        I have committed this to trunk, branch-2 and branch-2.8. Thank you for the reviews, everyone.

        Show
        cnauroth Chris Nauroth added a comment - I have committed this to trunk, branch-2 and branch-2.8. Thank you for the reviews, everyone.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        +1

        Show
        stevel@apache.org Steve Loughran added a comment - +1
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 51s trunk passed
        +1 compile 9m 39s trunk passed with JDK v1.8.0_66
        +1 compile 9m 55s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 19s trunk passed
        +1 mvnsite 1m 10s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 2m 1s trunk passed
        +1 javadoc 1m 2s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 10s trunk passed with JDK v1.7.0_85
        +1 mvninstall 1m 42s the patch passed
        +1 compile 10m 28s the patch passed with JDK v1.8.0_66
        +1 javac 10m 28s the patch passed
        +1 compile 10m 21s the patch passed with JDK v1.7.0_85
        +1 javac 10m 21s the patch passed
        +1 checkstyle 0m 19s the patch passed
        +1 mvnsite 1m 15s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 22s the patch passed
        +1 javadoc 1m 6s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 13s the patch passed with JDK v1.7.0_85
        -1 unit 8m 58s hadoop-common in the patch failed with JDK v1.8.0_66.
        -1 unit 8m 51s hadoop-common in the patch failed with JDK v1.7.0_85.
        +1 asflicense 0m 27s Patch does not generate ASF License warnings.
        82m 53s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
        JDK v1.7.0_85 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
          hadoop.metrics2.impl.TestMetricsSystemImpl



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774441/HADOOP-12600.002.patch
        JIRA Issue HADOOP-12600
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b9dd8f71e4ef 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d57fd18
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8160/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8160/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8160/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8160/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8160/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8160/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 51s trunk passed +1 compile 9m 39s trunk passed with JDK v1.8.0_66 +1 compile 9m 55s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 19s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 1s trunk passed +1 javadoc 1m 2s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 10s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 42s the patch passed +1 compile 10m 28s the patch passed with JDK v1.8.0_66 +1 javac 10m 28s the patch passed +1 compile 10m 21s the patch passed with JDK v1.7.0_85 +1 javac 10m 21s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 1m 15s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 22s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 13s the patch passed with JDK v1.7.0_85 -1 unit 8m 58s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 8m 51s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 27s Patch does not generate ASF License warnings. 82m 53s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestDecayRpcScheduler JDK v1.7.0_85 Failed junit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.metrics2.impl.TestMetricsSystemImpl Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774441/HADOOP-12600.002.patch JIRA Issue HADOOP-12600 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b9dd8f71e4ef 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d57fd18 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8160/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8160/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8160/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8160/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8160/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8160/console This message was automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -

        I just noticed that AbstractFileSystem has the same problem, so here is patch v002.

        Show
        cnauroth Chris Nauroth added a comment - I just noticed that AbstractFileSystem has the same problem, so here is patch v002.
        Hide
        xyao Xiaoyu Yao added a comment -

        Patch LGTM. +1
        The findbugs issue has just been fixed by HDFS-9451.

        Show
        xyao Xiaoyu Yao added a comment - Patch LGTM. +1 The findbugs issue has just been fixed by HDFS-9451 .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 9m 43s trunk passed
        +1 compile 10m 45s trunk passed with JDK v1.8.0_66
        +1 compile 10m 46s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 19s trunk passed
        +1 mvnsite 1m 20s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        -1 findbugs 2m 13s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings.
        +1 javadoc 1m 7s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 17s trunk passed with JDK v1.7.0_85
        +1 mvninstall 1m 54s the patch passed
        +1 compile 9m 43s the patch passed with JDK v1.8.0_66
        +1 javac 9m 43s the patch passed
        +1 compile 9m 47s the patch passed with JDK v1.7.0_85
        +1 javac 9m 47s the patch passed
        +1 checkstyle 0m 17s the patch passed
        +1 mvnsite 1m 3s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 6s the patch passed
        +1 javadoc 0m 59s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 10s the patch passed with JDK v1.7.0_85
        -1 unit 7m 5s hadoop-common in the patch failed with JDK v1.8.0_66.
        -1 unit 6m 56s hadoop-common in the patch failed with JDK v1.7.0_85.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        80m 44s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.fs.permission.TestFsPermission
          hadoop.security.token.delegation.TestZKDelegationTokenSecretManager
          hadoop.ha.TestZKFailoverController
        JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774409/HADOOP-12600.001.patch
        JIRA Issue HADOOP-12600
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux abfd399a901a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 95d5227
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 43s trunk passed +1 compile 10m 45s trunk passed with JDK v1.8.0_66 +1 compile 10m 46s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 19s trunk passed +1 mvnsite 1m 20s trunk passed +1 mvneclipse 0m 17s trunk passed -1 findbugs 2m 13s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 7s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 17s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 54s the patch passed +1 compile 9m 43s the patch passed with JDK v1.8.0_66 +1 javac 9m 43s the patch passed +1 compile 9m 47s the patch passed with JDK v1.7.0_85 +1 javac 9m 47s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 0m 59s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 10s the patch passed with JDK v1.7.0_85 -1 unit 7m 5s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 6m 56s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 80m 44s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.fs.permission.TestFsPermission   hadoop.security.token.delegation.TestZKDelegationTokenSecretManager   hadoop.ha.TestZKFailoverController JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774409/HADOOP-12600.001.patch JIRA Issue HADOOP-12600 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux abfd399a901a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 95d5227 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8159/console This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        pre-emptive +1 if jenkins is happy

        Show
        stevel@apache.org Steve Loughran added a comment - pre-emptive +1 if jenkins is happy
        Hide
        cnauroth Chris Nauroth added a comment -

        I'm attaching a one-liner patch. No tests are necessary since this is metadata only.

        Show
        cnauroth Chris Nauroth added a comment - I'm attaching a one-liner patch. No tests are necessary since this is metadata only.
        Hide
        cnauroth Chris Nauroth added a comment -

        I'm tentatively making this a 2.8.0 blocker. It's easy to get done, and we should commit to stability for this interface.

        Show
        cnauroth Chris Nauroth added a comment - I'm tentatively making this a 2.8.0 blocker. It's easy to get done, and we should commit to stability for this interface.
        Hide
        cnauroth Chris Nauroth added a comment -

        Note the comment below. The class has been annotated Evolving for a long time now. I expect we simply forgot to graduate to Stable.

        @InterfaceAudience.Public
        @InterfaceStability.Evolving /*Evolving for a release,to be changed to Stable */
        public class FileContext {
        
        Show
        cnauroth Chris Nauroth added a comment - Note the comment below. The class has been annotated Evolving for a long time now. I expect we simply forgot to graduate to Stable . @InterfaceAudience.Public @InterfaceStability.Evolving /*Evolving for a release,to be changed to Stable */ public class FileContext {

          People

          • Assignee:
            cnauroth Chris Nauroth
            Reporter:
            cnauroth Chris Nauroth
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development