Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12587

Hadoop AuthToken refuses to work without a maxinactive attribute in issued token

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Environment:

      OSX heimdal kerberos client against Linux KDC -talking to a Hadoop 2.6.0 cluster

    • Target Version/s:

      Description

      If you don't have a max-inactive attribute in the auth token returned from the web site, AuthToken will raise an exception. This stops callers without this token being able to submit jobs to a secure Hadoop 2.6 YARN cluster with timeline server enabled.

      1. HADOOP-12587-001.patch
        18 kB
        Benoy Antony
      2. HADOOP-12587-002.patch
        20 kB
        Benoy Antony
      3. HADOOP-12587-003.patch
        20 kB
        Benoy Antony

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -

          The Hadoop 2.6 timeline service isn't setting the max-inactive attribute which HADOOP-12050 now requires. As a result, a 2.7.1+ client cannot submit work to a Hadoop 2.6 cluster (and presumably, a 2.7.0 cluster).

          Show
          stevel@apache.org Steve Loughran added a comment - The Hadoop 2.6 timeline service isn't setting the max-inactive attribute which HADOOP-12050 now requires. As a result, a 2.7.1+ client cannot submit work to a Hadoop 2.6 cluster (and presumably, a 2.7.0 cluster).
          Hide
          githubbot ASF GitHub Bot added a comment - - edited

          GitHub user steveloughran opened a pull request:

          apache/hadoop/pull/48

          HADOOP-12587 Hadoop auth token refused to work without a maxinactive attribute in issued token

          This initial patch is not a fix. This is the patch to diagnose why I cannot submit work to a secure cluster and so identify the change that actually broke things.

          I would propose that the max-inactive value is considered optional, defaulting to -1 as the code itself appears to do elsewhere.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/steveloughran/hadoop stevel/HADOOP-12587-max-inactive-auth-token

          Alternatively you can review and apply these changes as the patch at:

          apache/hadoop/pull/48.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #48


          commit 6a92ebda2c1bcf5b1eacfd7ee1d687b08699aa92
          Author: Steve Loughran <stevel@hortonworks.com>
          Date: 2015-11-19T15:01:21Z

          HADOOP-12587 Hadoop auth token refused to work without a maxinactive attribute in issued token


          Show
          githubbot ASF GitHub Bot added a comment - - edited GitHub user steveloughran opened a pull request: apache/hadoop/pull/48 HADOOP-12587 Hadoop auth token refused to work without a maxinactive attribute in issued token This initial patch is not a fix. This is the patch to diagnose why I cannot submit work to a secure cluster and so identify the change that actually broke things. I would propose that the max-inactive value is considered optional, defaulting to -1 as the code itself appears to do elsewhere. You can merge this pull request into a Git repository by running: $ git pull https://github.com/steveloughran/hadoop stevel/ HADOOP-12587 -max-inactive-auth-token Alternatively you can review and apply these changes as the patch at: apache/hadoop/pull/48.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #48 commit 6a92ebda2c1bcf5b1eacfd7ee1d687b08699aa92 Author: Steve Loughran <stevel@hortonworks.com> Date: 2015-11-19T15:01:21Z HADOOP-12587 Hadoop auth token refused to work without a maxinactive attribute in issued token
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Stack trace with the initial patch applied.

          java.io.IOException: org.apache.hadoop.security.authentication.client.AuthenticationException: Incomplete token string -present: p= stevel@COTHAM; t= kerberos-dt; u= stevel; e= 1447944593313;  Missing attributes: [ i ]
          	at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$5.run(TimelineClientImpl.java:453)
          	at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$TimelineClientConnectionRetry.retryOn(TimelineClientImpl.java:183)
          	at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl.operateDelegationToken(TimelineClientImpl.java:466)
          	at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl.getDelegationToken(TimelineClientImpl.java:363)
          	at org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.getTimelineDelegationToken(YarnClientImpl.java:354)
          	at org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.addTimelineDelegationToken(YarnClientImpl.java:335)
          	at org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.submitApplication(YarnClientImpl.java:255)
          	at org.apache.slider.core.launch.AppMasterLauncher.submitApplication(AppMasterLauncher.java:259)
          	at org.apache.slider.client.SliderClient.launchApplication(SliderClient.java:2164)
          	at org.apache.slider.client.SliderClient.startCluster(SliderClient.java:1773)
          	at org.apache.slider.client.SliderClient.actionCreate(SliderClient.java:703)
          	at org.apache.slider.client.SliderClient.exec(SliderClient.java:356)
          	at org.apache.slider.client.SliderClient.runService(SliderClient.java:318)
          	at org.apache.slider.core.main.ServiceLauncher.launchService(ServiceLauncher.java:188)
          	at org.apache.slider.core.main.ServiceLauncher.launchServiceRobustly(ServiceLauncher.java:475)
          	at org.apache.slider.core.main.ServiceLauncher.launchServiceAndExit(ServiceLauncher.java:403)
          	at org.apache.slider.core.main.ServiceLauncher.serviceMain(ServiceLauncher.java:630)
          	at org.apache.slider.Slider.main(Slider.java:49)
          Caused by: org.apache.hadoop.security.authentication.client.AuthenticationException: Incomplete token string -present: p= stevel@COTHAM; t= kerberos-dt; u= stevel; e= 1447944593313;  Missing attributes: [ i ]
          	at org.apache.hadoop.security.authentication.util.AuthToken.parse(AuthToken.java:223)
          	at org.apache.hadoop.security.authentication.client.KerberosAuthenticator.isTokenKerberos(KerberosAuthenticator.java:240)
          	at org.apache.hadoop.security.authentication.client.KerberosAuthenticator.authenticate(KerberosAuthenticator.java:198)
          	at org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticator.authenticate(DelegationTokenAuthenticator.java:128)
          	at org.apache.hadoop.security.authentication.client.AuthenticatedURL.openConnection(AuthenticatedURL.java:215)
          	at org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticator.doDelegationTokenOperation(DelegationTokenAuthenticator.java:285)
          	at org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticator.getDelegationToken(DelegationTokenAuthenticator.java:166)
          	at org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticatedURL.getDelegationToken(DelegationTokenAuthenticatedURL.java:371)
          	at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$2.run(TimelineClientImpl.java:359)
          	at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$2.run(TimelineClientImpl.java:351)
          	at java.security.AccessController.doPrivileged(Native Method)
          	at javax.security.auth.Subject.doAs(Subject.java:422)
          	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657)
          	at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$5.run(TimelineClientImpl.java:451)
          	... 17 more
          
          Show
          stevel@apache.org Steve Loughran added a comment - Stack trace with the initial patch applied. java.io.IOException: org.apache.hadoop.security.authentication.client.AuthenticationException: Incomplete token string -present: p= stevel@COTHAM; t= kerberos-dt; u= stevel; e= 1447944593313; Missing attributes: [ i ] at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$5.run(TimelineClientImpl.java:453) at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$TimelineClientConnectionRetry.retryOn(TimelineClientImpl.java:183) at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl.operateDelegationToken(TimelineClientImpl.java:466) at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl.getDelegationToken(TimelineClientImpl.java:363) at org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.getTimelineDelegationToken(YarnClientImpl.java:354) at org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.addTimelineDelegationToken(YarnClientImpl.java:335) at org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.submitApplication(YarnClientImpl.java:255) at org.apache.slider.core.launch.AppMasterLauncher.submitApplication(AppMasterLauncher.java:259) at org.apache.slider.client.SliderClient.launchApplication(SliderClient.java:2164) at org.apache.slider.client.SliderClient.startCluster(SliderClient.java:1773) at org.apache.slider.client.SliderClient.actionCreate(SliderClient.java:703) at org.apache.slider.client.SliderClient.exec(SliderClient.java:356) at org.apache.slider.client.SliderClient.runService(SliderClient.java:318) at org.apache.slider.core.main.ServiceLauncher.launchService(ServiceLauncher.java:188) at org.apache.slider.core.main.ServiceLauncher.launchServiceRobustly(ServiceLauncher.java:475) at org.apache.slider.core.main.ServiceLauncher.launchServiceAndExit(ServiceLauncher.java:403) at org.apache.slider.core.main.ServiceLauncher.serviceMain(ServiceLauncher.java:630) at org.apache.slider.Slider.main(Slider.java:49) Caused by: org.apache.hadoop.security.authentication.client.AuthenticationException: Incomplete token string -present: p= stevel@COTHAM; t= kerberos-dt; u= stevel; e= 1447944593313; Missing attributes: [ i ] at org.apache.hadoop.security.authentication.util.AuthToken.parse(AuthToken.java:223) at org.apache.hadoop.security.authentication.client.KerberosAuthenticator.isTokenKerberos(KerberosAuthenticator.java:240) at org.apache.hadoop.security.authentication.client.KerberosAuthenticator.authenticate(KerberosAuthenticator.java:198) at org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticator.authenticate(DelegationTokenAuthenticator.java:128) at org.apache.hadoop.security.authentication.client.AuthenticatedURL.openConnection(AuthenticatedURL.java:215) at org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticator.doDelegationTokenOperation(DelegationTokenAuthenticator.java:285) at org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticator.getDelegationToken(DelegationTokenAuthenticator.java:166) at org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticatedURL.getDelegationToken(DelegationTokenAuthenticatedURL.java:371) at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$2.run(TimelineClientImpl.java:359) at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$2.run(TimelineClientImpl.java:351) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657) at org.apache.hadoop.yarn.client.api.impl.TimelineClientImpl$5.run(TimelineClientImpl.java:451) ... 17 more
          Hide
          aw Allen Wittenauer added a comment -

          Manually kicked off Jenkins. Looks like the precommit-admin job requires an actual patch attached in order to fire off the precommit-hadoop-build job. (Yetus works as expected, detecting this was a github pr.)

          Show
          aw Allen Wittenauer added a comment - Manually kicked off Jenkins. Looks like the precommit-admin job requires an actual patch attached in order to fire off the precommit-hadoop-build job. (Yetus works as expected, detecting this was a github pr.)
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 32s branch-2 passed
          +1 compile 7m 57s branch-2 passed with JDK v1.8.0_66
          +1 compile 7m 59s branch-2 passed with JDK v1.7.0_85
          +1 checkstyle 0m 10s branch-2 passed
          +1 mvnsite 0m 24s branch-2 passed
          +1 mvneclipse 0m 14s branch-2 passed
          +1 findbugs 0m 32s branch-2 passed
          +1 javadoc 0m 14s branch-2 passed with JDK v1.8.0_66
          +1 javadoc 0m 17s branch-2 passed with JDK v1.7.0_85
          +1 mvninstall 0m 21s the patch passed
          +1 compile 9m 10s the patch passed with JDK v1.8.0_66
          +1 javac 9m 10s the patch passed
          +1 compile 7m 55s the patch passed with JDK v1.7.0_85
          +1 javac 7m 55s the patch passed
          +1 checkstyle 0m 10s the patch passed
          +1 mvnsite 0m 23s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 38s the patch passed
          +1 javadoc 0m 13s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 15s the patch passed with JDK v1.7.0_85
          +1 unit 5m 19s hadoop-auth in the patch passed with JDK v1.8.0_66.
          +1 unit 5m 40s hadoop-auth in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          57m 16s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-19
          JIRA Issue HADOOP-12587
          GITHUB PR https://github.com/apache/hadoop/pull/48
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b8f893e3de32 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision branch-2 / c74e42b
          findbugs v3.0.0
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8097/testReport/
          modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth
          Max memory used 77MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8097/console
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8097/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 32s branch-2 passed +1 compile 7m 57s branch-2 passed with JDK v1.8.0_66 +1 compile 7m 59s branch-2 passed with JDK v1.7.0_85 +1 checkstyle 0m 10s branch-2 passed +1 mvnsite 0m 24s branch-2 passed +1 mvneclipse 0m 14s branch-2 passed +1 findbugs 0m 32s branch-2 passed +1 javadoc 0m 14s branch-2 passed with JDK v1.8.0_66 +1 javadoc 0m 17s branch-2 passed with JDK v1.7.0_85 +1 mvninstall 0m 21s the patch passed +1 compile 9m 10s the patch passed with JDK v1.8.0_66 +1 javac 9m 10s the patch passed +1 compile 7m 55s the patch passed with JDK v1.7.0_85 +1 javac 7m 55s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 13s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 15s the patch passed with JDK v1.7.0_85 +1 unit 5m 19s hadoop-auth in the patch passed with JDK v1.8.0_66. +1 unit 5m 40s hadoop-auth in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 57m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-19 JIRA Issue HADOOP-12587 GITHUB PR https://github.com/apache/hadoop/pull/48 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b8f893e3de32 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision branch-2 / c74e42b findbugs v3.0.0 JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8097/testReport/ modules C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth Max memory used 77MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8097/console Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8097/console This message was automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Steve Loughran, HADOOP-12050 is only in 2.8 and above. So 2.7 shouldn't be affected, right?

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Steve Loughran , HADOOP-12050 is only in 2.8 and above. So 2.7 shouldn't be affected, right?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          OK -if that's the case then I must have got my reading of the logs wrong...changing to a 2.8.x issue. It's certainly on branch 2 right now.

          Show
          stevel@apache.org Steve Loughran added a comment - OK -if that's the case then I must have got my reading of the logs wrong...changing to a 2.8.x issue. It's certainly on branch 2 right now.
          Hide
          benoyantony Benoy Antony added a comment -

          Steve , If you are busy, I can take this up. Please let me know.

          Show
          benoyantony Benoy Antony added a comment - Steve , If you are busy, I can take this up. Please let me know.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I wasn't actually going to work on it at all, once I'd found the problem I was opening the bug and hoping it'd get fixed before I'd had revert the original bug prior to 2.8 shipping. So yes, I would be grateful. The current patch exists purely to diagnose the problem and track it down if it re-occurs.

          fix wise, something that splits up into "required" and "optional" attrs is enough, with a test

          Show
          stevel@apache.org Steve Loughran added a comment - I wasn't actually going to work on it at all, once I'd found the problem I was opening the bug and hoping it'd get fixed before I'd had revert the original bug prior to 2.8 shipping. So yes, I would be grateful. The current patch exists purely to diagnose the problem and track it down if it re-occurs. fix wise, something that splits up into "required" and "optional" attrs is enough, with a test
          Hide
          benoyantony Benoy Antony added a comment -

          Thanks Steve. I will work on the fix as you suggested. Assigning to me.

          Show
          benoyantony Benoy Antony added a comment - Thanks Steve. I will work on the fix as you suggested. Assigning to me.
          Hide
          benoyantony Benoy Antony added a comment - - edited

          Attaching the patch

          1. changed the name of the configuration from hadoop.http.authentication.token.MaxInactiveInterval to hadoop.http.authentication.token.max-inactive-interval.
          2. Set the default value to -1 so that the feature is disabled by default.
          3. If the token does not contain InactiveInterval, the token is still processed without throwing exception.
          4. added test cases to test token with valid activity interval, expired activity interval and missing activity interval. Each test case runs against a server where activity interval feature is enabled and disabled.
          5. Updated documentation to reflect changes.

          Show
          benoyantony Benoy Antony added a comment - - edited Attaching the patch 1. changed the name of the configuration from hadoop.http.authentication.token.MaxInactiveInterval to hadoop.http.authentication.token.max-inactive-interval. 2. Set the default value to -1 so that the feature is disabled by default. 3. If the token does not contain InactiveInterval, the token is still processed without throwing exception. 4. added test cases to test token with valid activity interval, expired activity interval and missing activity interval. Each test case runs against a server where activity interval feature is enabled and disabled. 5. Updated documentation to reflect changes.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          -1 docker 0m 1s Docker failed to build yetus/hadoop:5d9212c.



          Subsystem Report/Notes
          JIRA Issue HADOOP-12587
          GITHUB PR https://github.com/apache/hadoop/pull/48
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8261/console
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8261/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 docker 0m 1s Docker failed to build yetus/hadoop:5d9212c. Subsystem Report/Notes JIRA Issue HADOOP-12587 GITHUB PR https://github.com/apache/hadoop/pull/48 Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8261/console Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8261/console This message was automatically generated.
          Hide
          benoyantony Benoy Antony added a comment -

          Not sure, what happened here. I can apply the patch and build fine on my local machine.

          Show
          benoyantony Benoy Antony added a comment - Not sure, what happened here. I can apply the patch and build fine on my local machine.
          Hide
          aw Allen Wittenauer added a comment -

          Two things are going off kilter:

          a) Yetus doesn't look at JIRA attached patches once it detects a github PR. Just need to edit the git pr URL to not look like a URL anymore and Yetus will start using the attached patches.
          b) The Dockerfile in branch-2 is busted.

          Show
          aw Allen Wittenauer added a comment - Two things are going off kilter: a) Yetus doesn't look at JIRA attached patches once it detects a github PR. Just need to edit the git pr URL to not look like a URL anymore and Yetus will start using the attached patches. b) The Dockerfile in branch-2 is busted.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 48s trunk passed
          +1 compile 8m 6s trunk passed with JDK v1.8.0_66
          +1 compile 8m 44s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 1m 24s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 2m 14s trunk passed
          +1 javadoc 1m 6s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 16s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 1s the patch passed
          +1 compile 7m 41s the patch passed with JDK v1.8.0_66
          +1 javac 7m 41s the patch passed
          +1 compile 8m 39s the patch passed with JDK v1.7.0_91
          +1 javac 8m 39s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 1m 21s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 28s the patch passed
          +1 javadoc 1m 2s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 16s the patch passed with JDK v1.7.0_91
          +1 unit 3m 37s hadoop-auth in the patch passed with JDK v1.8.0_66.
          -1 unit 18m 56s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 3m 57s hadoop-auth in the patch passed with JDK v1.7.0_91.
          -1 unit 7m 7s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          91m 51s



          Reason Tests
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle
          JDK v1.7.0_91 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778328/HADOOP-12587-001.patch
          JIRA Issue HADOOP-12587
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d90a97ed74e2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4e7d32c
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8266/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8266/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8266/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8266/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8266/testReport/
          modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8266/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 48s trunk passed +1 compile 8m 6s trunk passed with JDK v1.8.0_66 +1 compile 8m 44s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 20s trunk passed +1 mvnsite 1m 24s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 2m 14s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 16s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 1s the patch passed +1 compile 7m 41s the patch passed with JDK v1.8.0_66 +1 javac 7m 41s the patch passed +1 compile 8m 39s the patch passed with JDK v1.7.0_91 +1 javac 8m 39s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 1m 21s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 28s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 16s the patch passed with JDK v1.7.0_91 +1 unit 3m 37s hadoop-auth in the patch passed with JDK v1.8.0_66. -1 unit 18m 56s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 3m 57s hadoop-auth in the patch passed with JDK v1.7.0_91. -1 unit 7m 7s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 91m 51s Reason Tests JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle JDK v1.7.0_91 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778328/HADOOP-12587-001.patch JIRA Issue HADOOP-12587 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d90a97ed74e2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4e7d32c findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8266/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8266/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8266/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8266/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8266/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8266/console This message was automatically generated.
          Hide
          benoyantony Benoy Antony added a comment -

          I don't think that test failures are related.

          Show
          benoyantony Benoy Antony added a comment - I don't think that test failures are related.
          Hide
          benoyantony Benoy Antony added a comment -

          Requesting a review before the patch gets outdated.

          Show
          benoyantony Benoy Antony added a comment - Requesting a review before the patch gets outdated.
          Hide
          benoyantony Benoy Antony added a comment -

          Steve Loughran, Do you have some time to review the patch ?

          Show
          benoyantony Benoy Antony added a comment - Steve Loughran , Do you have some time to review the patch ?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          looking at it. I'm trying to work out if I can test it, given my kerberos cluster is being extra fussy right now

          Show
          stevel@apache.org Steve Loughran added a comment - looking at it. I'm trying to work out if I can test it, given my kerberos cluster is being extra fussy right now
          Hide
          stevel@apache.org Steve Loughran added a comment -

          LGTM: +1

          Show
          stevel@apache.org Steve Loughran added a comment - LGTM: +1
          Hide
          benoyantony Benoy Antony added a comment -

          Thanks for the review Steve Loughran. I will commit this patch tomorrow if there are no further comments.

          Show
          benoyantony Benoy Antony added a comment - Thanks for the review Steve Loughran . I will commit this patch tomorrow if there are no further comments.
          Hide
          benoyantony Benoy Antony added a comment -

          Attaching a newer patch since the previous patch does not apply cleanly. Its a documentation change.

          Show
          benoyantony Benoy Antony added a comment - Attaching a newer patch since the previous patch does not apply cleanly. Its a documentation change.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 6s trunk passed
          +1 compile 10m 37s trunk passed with JDK v1.8.0_66
          +1 compile 10m 3s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 1m 37s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 2m 42s trunk passed
          +1 javadoc 1m 25s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 26s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 53s the patch passed
          +1 compile 11m 22s the patch passed with JDK v1.8.0_66
          +1 javac 11m 22s the patch passed
          +1 compile 10m 7s the patch passed with JDK v1.7.0_91
          +1 javac 10m 7s the patch passed
          -1 checkstyle 0m 24s Patch generated 1 new checkstyle issues in hadoop-common-project (total was 56, now 56).
          +1 mvnsite 1m 32s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 59s the patch passed
          +1 javadoc 1m 35s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 26s the patch passed with JDK v1.7.0_91
          +1 unit 3m 44s hadoop-auth in the patch passed with JDK v1.8.0_66.
          -1 unit 9m 11s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 4m 13s hadoop-auth in the patch passed with JDK v1.7.0_91.
          -1 unit 10m 7s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 29s Patch does not generate ASF License warnings.
          97m 58s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.ha.TestZKFailoverController
            hadoop.ipc.TestIPC
          JDK v1.7.0_91 Failed junit tests hadoop.fs.TestLocalFsFCStatistics
            hadoop.ha.TestZKFailoverController
            hadoop.security.ssl.TestReloadingX509TrustManager
            hadoop.test.TestTimedOutTestsListener



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781328/HADOOP-12587-002.patch
          JIRA Issue HADOOP-12587
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 847b8e94f30d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 109e528
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/testReport/
          modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 6s trunk passed +1 compile 10m 37s trunk passed with JDK v1.8.0_66 +1 compile 10m 3s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 25s trunk passed +1 mvnsite 1m 37s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 2m 42s trunk passed +1 javadoc 1m 25s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 26s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 53s the patch passed +1 compile 11m 22s the patch passed with JDK v1.8.0_66 +1 javac 11m 22s the patch passed +1 compile 10m 7s the patch passed with JDK v1.7.0_91 +1 javac 10m 7s the patch passed -1 checkstyle 0m 24s Patch generated 1 new checkstyle issues in hadoop-common-project (total was 56, now 56). +1 mvnsite 1m 32s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 59s the patch passed +1 javadoc 1m 35s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 26s the patch passed with JDK v1.7.0_91 +1 unit 3m 44s hadoop-auth in the patch passed with JDK v1.8.0_66. -1 unit 9m 11s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 4m 13s hadoop-auth in the patch passed with JDK v1.7.0_91. -1 unit 10m 7s hadoop-common in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 29s Patch does not generate ASF License warnings. 97m 58s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.ipc.TestIPC JDK v1.7.0_91 Failed junit tests hadoop.fs.TestLocalFsFCStatistics   hadoop.ha.TestZKFailoverController   hadoop.security.ssl.TestReloadingX509TrustManager   hadoop.test.TestTimedOutTestsListener Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781328/HADOOP-12587-002.patch JIRA Issue HADOOP-12587 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 847b8e94f30d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 109e528 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/artifact/patchprocess/diff-checkstyle-hadoop-common-project.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8369/console This message was automatically generated.
          Hide
          benoyantony Benoy Antony added a comment -

          Attaching the patch which fixes the checkstyle issue

          Show
          benoyantony Benoy Antony added a comment - Attaching the patch which fixes the checkstyle issue
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 39s trunk passed
          +1 compile 7m 45s trunk passed with JDK v1.8.0_66
          +1 compile 8m 35s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 1m 25s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 2m 14s trunk passed
          +1 javadoc 1m 4s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 17s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 53s the patch passed
          +1 compile 7m 51s the patch passed with JDK v1.8.0_66
          +1 javac 7m 51s the patch passed
          +1 compile 8m 44s the patch passed with JDK v1.7.0_91
          +1 javac 8m 44s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 1m 24s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 33s the patch passed
          +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 17s the patch passed with JDK v1.7.0_91
          +1 unit 3m 36s hadoop-auth in the patch passed with JDK v1.8.0_66.
          +1 unit 6m 40s hadoop-common in the patch passed with JDK v1.8.0_66.
          +1 unit 4m 1s hadoop-auth in the patch passed with JDK v1.7.0_91.
          +1 unit 6m 55s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          79m 26s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781368/HADOOP-12587-003.patch
          JIRA Issue HADOOP-12587
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e19b8263fa24 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 109e528
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8373/testReport/
          modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8373/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 39s trunk passed +1 compile 7m 45s trunk passed with JDK v1.8.0_66 +1 compile 8m 35s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 21s trunk passed +1 mvnsite 1m 25s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 2m 14s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 17s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 53s the patch passed +1 compile 7m 51s the patch passed with JDK v1.8.0_66 +1 javac 7m 51s the patch passed +1 compile 8m 44s the patch passed with JDK v1.7.0_91 +1 javac 8m 44s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 1m 24s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 33s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 17s the patch passed with JDK v1.7.0_91 +1 unit 3m 36s hadoop-auth in the patch passed with JDK v1.8.0_66. +1 unit 6m 40s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 4m 1s hadoop-auth in the patch passed with JDK v1.7.0_91. +1 unit 6m 55s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 79m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781368/HADOOP-12587-003.patch JIRA Issue HADOOP-12587 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e19b8263fa24 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 109e528 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8373/testReport/ modules C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common U: hadoop-common-project Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8373/console This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1

          Show
          stevel@apache.org Steve Loughran added a comment - +1
          Hide
          benoyantony Benoy Antony added a comment -

          Committed to trunk and branch-2.
          Thanks Steve Loughran for reporting the issue and reviewing the patches.

          Show
          benoyantony Benoy Antony added a comment - Committed to trunk and branch-2. Thanks Steve Loughran for reporting the issue and reviewing the patches.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9078 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9078/)
          HADOOP-12587. Hadoop AuthToken refuses to work without a maxinactive (benoy: rev dec8dfdfa66c37f8cc8c0900fd12f98c7529b99e)

          • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/AuthToken.java
          • hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md
          • hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/AuthenticationFilter.java
          • hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9078 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9078/ ) HADOOP-12587 . Hadoop AuthToken refuses to work without a maxinactive (benoy: rev dec8dfdfa66c37f8cc8c0900fd12f98c7529b99e) hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/AuthToken.java hadoop-common-project/hadoop-common/src/site/markdown/HttpAuthentication.md hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/server/AuthenticationFilter.java hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/server/TestAuthenticationFilter.java
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Benoy Antony, there is a branch-2.8 where you need to land this patch for it to be in 2.8.0.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Benoy Antony , there is a branch-2.8 where you need to land this patch for it to be in 2.8.0.
          Hide
          benoyantony Benoy Antony added a comment -

          Vinod Kumar Vavilapalli, I will merge the changes to branch-2.8. Is it okay to cherry-pick from trunk ? That will make the dates slightly off as this change is from Dec 22.

          Show
          benoyantony Benoy Antony added a comment - Vinod Kumar Vavilapalli , I will merge the changes to branch-2.8. Is it okay to cherry-pick from trunk ? That will make the dates slightly off as this change is from Dec 22.
          Hide
          benoyantony Benoy Antony added a comment -

          committed to branch-2.8.

          Show
          benoyantony Benoy Antony added a comment - committed to branch-2.8.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user steveloughran closed the pull request at:

          https://github.com/apache/hadoop/pull/48

          Show
          githubbot ASF GitHub Bot added a comment - Github user steveloughran closed the pull request at: https://github.com/apache/hadoop/pull/48
          Hide
          hzlu Huizhi Lu added a comment -

          Thank you for resolving this, Benoy!!

          Show
          hzlu Huizhi Lu added a comment - Thank you for resolving this, Benoy!!

            People

            • Assignee:
              benoyantony Benoy Antony
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development