Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12575

Add build instruction for docker toolbox instead of boot2docker

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Currently docker on MacOSX is mainly used by docker toolbox and docker-machine. These tools make boot2docker deprecated. (https://docs.docker.com/engine/installation/mac/)
      It might be better to append the instruction of docker toolbox and docker-machine when using start-build-env.sh.

      1. HADOOP-12575.01.patch
        0.7 kB
        Kai Sasaki
      2. HADOOP-12575.02.patch
        0.7 kB
        Kai Sasaki
      3. HADOOP-12575.03.patch
        0.8 kB
        Kai Sasaki

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #619 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/619/)
          HADOOP-12575. Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • BUILDING.txt
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #619 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/619/ ) HADOOP-12575 . Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690) hadoop-common-project/hadoop-common/CHANGES.txt BUILDING.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2556 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2556/)
          HADOOP-12575. Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • BUILDING.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2556 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2556/ ) HADOOP-12575 . Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690) hadoop-common-project/hadoop-common/CHANGES.txt BUILDING.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #695 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/695/)
          HADOOP-12575. Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690)

          • BUILDING.txt
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #695 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/695/ ) HADOOP-12575 . Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690) BUILDING.txt hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1421 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1421/)
          HADOOP-12575. Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690)

          • BUILDING.txt
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1421 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1421/ ) HADOOP-12575 . Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690) BUILDING.txt hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2624 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2624/)
          HADOOP-12575. Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690)

          • BUILDING.txt
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2624 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2624/ ) HADOOP-12575 . Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690) BUILDING.txt hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #682 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/682/)
          HADOOP-12575. Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690)

          • BUILDING.txt
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #682 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/682/ ) HADOOP-12575 . Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690) BUILDING.txt hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8825 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8825/)
          HADOOP-12575. Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • BUILDING.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8825 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8825/ ) HADOOP-12575 . Add build instruction for docker toolbox instead of (ozawa: rev 25e82b4eb92262d56e543621cd7db6c0bf218690) hadoop-common-project/hadoop-common/CHANGES.txt BUILDING.txt
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Committed this to trunk and branch-2. Thanks Kai Sasaki for your contribution.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Kai Sasaki for your contribution.
          Hide
          lewuathe Kai Sasaki added a comment -

          Tsuyoshi Ozawa Thank you so much for attentive review!

          Show
          lewuathe Kai Sasaki added a comment - Tsuyoshi Ozawa Thank you so much for attentive review!
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          +1, checking this in.

          Show
          ozawa Tsuyoshi Ozawa added a comment - +1, checking this in.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 asflicense 0m 38s Patch does not generate ASF License warnings.
          0m 53s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-19
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773205/HADOOP-12575.03.patch
          JIRA Issue HADOOP-12575
          Optional Tests asflicense
          uname Linux f5a31bae5997 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision trunk / 23a130a
          modules C: . U: .
          Max memory used 32MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8095/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s Patch has no whitespace issues. +1 asflicense 0m 38s Patch does not generate ASF License warnings. 0m 53s Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-19 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773205/HADOOP-12575.03.patch JIRA Issue HADOOP-12575 Optional Tests asflicense uname Linux f5a31bae5997 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / 23a130a modules C: . U: . Max memory used 32MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8095/console This message was automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Kai Sasaki thank you for quick updating! As Marco Zühlke linked, change from boot2docker to docker-machine looks to be better. Could you remove the section about boot2docker and update the first sentence to You can use docker toolbox as described in http://docs.docker.com/mac/step_one/.? Also I found the indentation goes wrong after applying the patch. Could you fix it?

          On Mac:
          ...
          Also you can use docker toolbox as described in http://docs.docker.com/mac/step_one/. # <-- This line should be indended
          First make sure Virtualbox and docker toolbox are installed.
          $ docker-machine create --driver virtualbox \
          ...

          Show
          ozawa Tsuyoshi Ozawa added a comment - Kai Sasaki thank you for quick updating! As Marco Zühlke linked, change from boot2docker to docker-machine looks to be better. Could you remove the section about boot2docker and update the first sentence to You can use docker toolbox as described in http://docs.docker.com/mac/step_one/ . ? Also I found the indentation goes wrong after applying the patch. Could you fix it? On Mac: ... Also you can use docker toolbox as described in http://docs.docker.com/mac/step_one/ . # <-- This line should be indended First make sure Virtualbox and docker toolbox are installed. $ docker-machine create --driver virtualbox \ ...
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 6s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 1s Patch has no whitespace issues.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          0m 31s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-19
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773197/HADOOP-12575.02.patch
          JIRA Issue HADOOP-12575
          Optional Tests asflicense
          uname Linux b8a5b6dc43ce 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision trunk / 23a130a
          modules C: . U: .
          Max memory used 31MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8090/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 1s Patch has no whitespace issues. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 0m 31s Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-19 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773197/HADOOP-12575.02.patch JIRA Issue HADOOP-12575 Optional Tests asflicense uname Linux b8a5b6dc43ce 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / 23a130a modules C: . U: . Max memory used 31MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8090/console This message was automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Kai Sasaki thank you for taking this issue. Followings are my review comments - could you update the patch?

          1. The configuration looks to be for a driver of softlayer. We can remove it.

          +                            --softlayer-memory "4096" \
          

          2. The docker machine name default can be conflicted. For a workaround, it's better to name {{hadoopdev}.
          3. Why 4094? Typo of 4096?

          +                            --virtualbox-memory "4094" default
          
          Show
          ozawa Tsuyoshi Ozawa added a comment - Kai Sasaki thank you for taking this issue. Followings are my review comments - could you update the patch? 1. The configuration looks to be for a driver of softlayer. We can remove it. + --softlayer-memory "4096" \ 2. The docker machine name default can be conflicted. For a workaround, it's better to name {{hadoopdev}. 3. Why 4094? Typo of 4096? + --virtualbox-memory "4094" default
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          0m 34s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-17
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772660/HADOOP-12575.01.patch
          JIRA Issue HADOOP-12575
          Optional Tests asflicense
          uname Linux 1a9335826bd2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-4659377/precommit/personality/hadoop.sh
          git revision trunk / 007c6ce
          modules C: . U: .
          Max memory used 31MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8079/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s Patch has no whitespace issues. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 0m 34s Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-17 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772660/HADOOP-12575.01.patch JIRA Issue HADOOP-12575 Optional Tests asflicense uname Linux 1a9335826bd2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-4659377/precommit/personality/hadoop.sh git revision trunk / 007c6ce modules C: . U: . Max memory used 31MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8079/console This message was automatically generated.

            People

            • Assignee:
              lewuathe Kai Sasaki
              Reporter:
              lewuathe Kai Sasaki
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development