Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Environment:

      Jenkins

      Description

      TestRPC.testClientBackOff is failing

      java.lang.AssertionError: RetriableException not received
      	at org.junit.Assert.fail(Assert.java:88)
      	at org.junit.Assert.assertTrue(Assert.java:41)
      	at org.apache.hadoop.ipc.TestRPC.testClientBackOff(TestRPC.java:1146)
      
      1. HADOOP-12573.01.patch
        3 kB
        Xiao Chen
      2. HADOOP-12573.02.patch
        3 kB
        Xiao Chen

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9077 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9077/)
        HADOOP-12573. TestRPC.testClientBackOff failing. (Xiao Chen via stevel) (stevel: rev 84bf5122e4e3166539ed4c678e564691f1365573)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9077 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9077/ ) HADOOP-12573 . TestRPC.testClientBackOff failing. (Xiao Chen via stevel) (stevel: rev 84bf5122e4e3166539ed4c678e564691f1365573) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        xiaochen Xiao Chen added a comment -

        Thank you Steve Loughran!

        Show
        xiaochen Xiao Chen added a comment - Thank you Steve Loughran !
        Hide
        stevel@apache.org Steve Loughran added a comment -

        +1 - patch applied to branch-2 and up. Thanks!

        Show
        stevel@apache.org Steve Loughran added a comment - +1 - patch applied to branch-2 and up. Thanks!
        Hide
        xiaochen Xiao Chen added a comment -

        The remaining javac/license warnings are not related to this patch. Please kindly review. Thanks!

        Show
        xiaochen Xiao Chen added a comment - The remaining javac/license warnings are not related to this patch. Please kindly review. Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 29s trunk passed
        +1 compile 7m 53s trunk passed with JDK v1.8.0_66
        +1 compile 8m 41s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 48s trunk passed
        +1 javadoc 0m 51s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 5s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 39s the patch passed
        +1 compile 7m 58s the patch passed with JDK v1.8.0_66
        -1 javac 13m 22s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 730, now 730).
        +1 javac 7m 58s the patch passed
        +1 compile 8m 35s the patch passed with JDK v1.7.0_91
        -1 javac 21m 58s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 724, now 724).
        +1 javac 8m 35s the patch passed
        +1 checkstyle 0m 14s the patch passed
        +1 mvnsite 1m 0s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 54s the patch passed
        +1 javadoc 0m 52s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 1s the patch passed with JDK v1.7.0_91
        +1 unit 6m 40s hadoop-common in the patch passed with JDK v1.8.0_66.
        +1 unit 7m 0s hadoop-common in the patch passed with JDK v1.7.0_91.
        -1 asflicense 0m 22s Patch generated 1 ASF License warnings.
        67m 53s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779292/HADOOP-12573.02.patch
        JIRA Issue HADOOP-12573
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6c759f7007ff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / bb5df27
        findbugs v3.0.0
        javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8301/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
        javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HADOOP-Build/8301/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8301/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8301/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 75MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8301/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 29s trunk passed +1 compile 7m 53s trunk passed with JDK v1.8.0_66 +1 compile 8m 41s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 15s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 48s trunk passed +1 javadoc 0m 51s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 39s the patch passed +1 compile 7m 58s the patch passed with JDK v1.8.0_66 -1 javac 13m 22s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 730, now 730). +1 javac 7m 58s the patch passed +1 compile 8m 35s the patch passed with JDK v1.7.0_91 -1 javac 21m 58s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 724, now 724). +1 javac 8m 35s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 54s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 1s the patch passed with JDK v1.7.0_91 +1 unit 6m 40s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 7m 0s hadoop-common in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 22s Patch generated 1 ASF License warnings. 67m 53s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779292/HADOOP-12573.02.patch JIRA Issue HADOOP-12573 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6c759f7007ff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bb5df27 findbugs v3.0.0 javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8301/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HADOOP-Build/8301/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8301/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/8301/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8301/console This message was automatically generated.
        Hide
        xiaochen Xiao Chen added a comment -

        Patch 2 fixes the javac issues.

        Show
        xiaochen Xiao Chen added a comment - Patch 2 fixes the javac issues.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 32s trunk passed
        +1 compile 9m 14s trunk passed with JDK v1.8.0_66
        +1 compile 9m 32s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 17s trunk passed
        +1 mvnsite 1m 8s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 57s trunk passed
        +1 javadoc 0m 58s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 9s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 43s the patch passed
        +1 compile 8m 49s the patch passed with JDK v1.8.0_66
        -1 javac 14m 37s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 2 new issues (was 730, now 730).
        +1 javac 8m 49s the patch passed
        +1 compile 9m 39s the patch passed with JDK v1.7.0_91
        -1 javac 24m 16s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 2 new issues (was 723, now 723).
        +1 javac 9m 39s the patch passed
        +1 checkstyle 0m 16s the patch passed
        +1 mvnsite 1m 6s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 13s the patch passed
        +1 javadoc 0m 59s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 9s the patch passed with JDK v1.7.0_91
        +1 unit 8m 27s hadoop-common in the patch passed with JDK v1.8.0_66.
        +1 unit 8m 30s hadoop-common in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        77m 34s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778881/HADOOP-12573.01.patch
        JIRA Issue HADOOP-12573
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 346917be7153 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2cb5aff
        findbugs v3.0.0
        javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8289/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
        javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HADOOP-Build/8289/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8289/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8289/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 32s trunk passed +1 compile 9m 14s trunk passed with JDK v1.8.0_66 +1 compile 9m 32s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 17s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 0m 58s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 9s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 43s the patch passed +1 compile 8m 49s the patch passed with JDK v1.8.0_66 -1 javac 14m 37s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 2 new issues (was 730, now 730). +1 javac 8m 49s the patch passed +1 compile 9m 39s the patch passed with JDK v1.7.0_91 -1 javac 24m 16s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 2 new issues (was 723, now 723). +1 javac 9m 39s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 1m 6s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 13s the patch passed +1 javadoc 0m 59s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 9s the patch passed with JDK v1.7.0_91 +1 unit 8m 27s hadoop-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 30s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 77m 34s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778881/HADOOP-12573.01.patch JIRA Issue HADOOP-12573 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 346917be7153 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2cb5aff findbugs v3.0.0 javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HADOOP-Build/8289/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HADOOP-Build/8289/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8289/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8289/console This message was automatically generated.
        Hide
        xiaochen Xiao Chen added a comment -

        Attached patch 1 to both log last non-retriable exception, and ensure the callQueue is filled before trying to make another call.

        Show
        xiaochen Xiao Chen added a comment - Attached patch 1 to both log last non-retriable exception, and ensure the callQueue is filled before trying to make another call.
        Hide
        xiaochen Xiao Chen added a comment -

        Hi Steve Loughran,
        Thanks reporting the issue and the suggestion. I happened to met the exactly same failure.
        Looking at the test, I suspect that this is similar to HADOOP-12605, as Masatake Iwasaki and I discussed in there - maybe the call was processed and no exception was thrown at all.
        But your suggestion of recording the last thrown exception would be helpful too, since the current log/stack trace really gives us no clue. I'll provide a patch shortly.

        Show
        xiaochen Xiao Chen added a comment - Hi Steve Loughran , Thanks reporting the issue and the suggestion. I happened to met the exactly same failure. Looking at the test, I suspect that this is similar to HADOOP-12605 , as Masatake Iwasaki and I discussed in there - maybe the call was processed and no exception was thrown at all. But your suggestion of recording the last thrown exception would be helpful too, since the current log/stack trace really gives us no clue. I'll provide a patch shortly.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        stdout

        Standard Output
        
        2015-11-14 06:45:51,626 INFO  ipc.Server (Server.java:run(962)) - Stopping IPC Server Responder
        2015-11-14 06:45:51,637 INFO  ipc.Server (Server.java:run(829)) - Stopping IPC Server listener on 42775
        2015-11-14 06:45:51,645 INFO  ipc.CallQueueManager (CallQueueManager.java:<init>(60)) - Using callQueue class java.util.concurrent.LinkedBlockingQueue
        2015-11-14 06:45:51,646 INFO  ipc.Server (Server.java:run(727)) - Starting Socket Reader #1 for port 50098
        2015-11-14 06:45:51,653 INFO  ipc.Server (Server.java:run(957)) - IPC Server Responder: starting
        2015-11-14 06:45:51,653 INFO  ipc.Server (Server.java:run(797)) - IPC Server listener on 50098: starting
        2015-11-14 06:45:51,664 INFO  ipc.Server (Server.java:doRead(901)) - Socket Reader #1 for port 50098: readAndProcess from client 67.195.81.151 threw exception [org.apache.hadoop.ipc.RetriableException: Server is too busy.]
        2015-11-14 06:45:51,665 INFO  ipc.Server (Server.java:run(2274)) - IPC Server handler 0 on 50098: skipped sleep(100000), rpc version=2, client version=1, methodsFingerPrint=-1263125924 from 67.195.81.151:53368 Call#4002 Retry#0
        2015-11-14 06:45:51,768 INFO  ipc.Server (WritableRpcEngine.java:log(445)) - Call: sleep(100), rpc version=2, client version=1, meth...
        2015-11-14 06:45:51,869 INFO  ipc.Server (WritableRpcEngine.java:log(445)) - Return: null
        2015-11-14 06:45:51,870 INFO  ipc.Server (Server.java:stop(2697)) - Stopping server on 50098
        2015-11-14 06:45:51,872 INFO  ipc.Server (Server.java:run(962)) - Stopping IPC Server Responder
        2015-11-14 06:45:51,873 INFO  ipc.Server (Server.java:run(829)) - Stopping IPC Server listener on 50098
        
        Show
        stevel@apache.org Steve Loughran added a comment - stdout Standard Output 2015-11-14 06:45:51,626 INFO ipc.Server (Server.java:run(962)) - Stopping IPC Server Responder 2015-11-14 06:45:51,637 INFO ipc.Server (Server.java:run(829)) - Stopping IPC Server listener on 42775 2015-11-14 06:45:51,645 INFO ipc.CallQueueManager (CallQueueManager.java:<init>(60)) - Using callQueue class java.util.concurrent.LinkedBlockingQueue 2015-11-14 06:45:51,646 INFO ipc.Server (Server.java:run(727)) - Starting Socket Reader #1 for port 50098 2015-11-14 06:45:51,653 INFO ipc.Server (Server.java:run(957)) - IPC Server Responder: starting 2015-11-14 06:45:51,653 INFO ipc.Server (Server.java:run(797)) - IPC Server listener on 50098: starting 2015-11-14 06:45:51,664 INFO ipc.Server (Server.java:doRead(901)) - Socket Reader #1 for port 50098: readAndProcess from client 67.195.81.151 threw exception [org.apache.hadoop.ipc.RetriableException: Server is too busy.] 2015-11-14 06:45:51,665 INFO ipc.Server (Server.java:run(2274)) - IPC Server handler 0 on 50098: skipped sleep(100000), rpc version=2, client version=1, methodsFingerPrint=-1263125924 from 67.195.81.151:53368 Call#4002 Retry#0 2015-11-14 06:45:51,768 INFO ipc.Server (WritableRpcEngine.java:log(445)) - Call: sleep(100), rpc version=2, client version=1, meth... 2015-11-14 06:45:51,869 INFO ipc.Server (WritableRpcEngine.java:log(445)) - Return: null 2015-11-14 06:45:51,870 INFO ipc.Server (Server.java:stop(2697)) - Stopping server on 50098 2015-11-14 06:45:51,872 INFO ipc.Server (Server.java:run(962)) - Stopping IPC Server Responder 2015-11-14 06:45:51,873 INFO ipc.Server (Server.java:run(829)) - Stopping IPC Server listener on 50098
        Hide
        stevel@apache.org Steve Loughran added a comment -

        While not fixing the test, a patch to record the last exception which was not a retriable one, and, then,if !succeeded, to rethrow any such exception on test failure, would go some way to working what is going wrong here

        Show
        stevel@apache.org Steve Loughran added a comment - While not fixing the test, a patch to record the last exception which was not a retriable one, and, then,if !succeeded, to rethrow any such exception on test failure, would go some way to working what is going wrong here

          People

          • Assignee:
            xiaochen Xiao Chen
            Reporter:
            stevel@apache.org Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development