Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12565

Replace DSA with RSA for SSH key type in SingleCluster.md

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
    • Component/s: documentation
    • Labels:
      None
    • Environment:

      Linux (Gentoo)

    • Hadoop Flags:
      Reviewed

      Description

      http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/SingleCluster.html

      suggests to create a DSA key to ssh to localhost. However DSA is going to be deprecated[1], and ssh to localhost with DSA actually does not work on all systems. I suggest to replace DSA with RSA, ECDSA, or ED25519.

      Ref.:
      [1] http://comments.gmane.org/gmane.linux.gentoo.devel/96896

        Activity

        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #660 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/660/)
        HADOOP-12565. Replace DSA with RSA for SSH key type in SingleCluster.md. (aajisaka: rev 3857fed2c8fc601b46e8331f73a3104f4f33e498)

        • hadoop-common-project/hadoop-common/src/site/markdown/SingleCluster.md.vm
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #660 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/660/ ) HADOOP-12565 . Replace DSA with RSA for SSH key type in SingleCluster.md. (aajisaka: rev 3857fed2c8fc601b46e8331f73a3104f4f33e498) hadoop-common-project/hadoop-common/src/site/markdown/SingleCluster.md.vm hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8912 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8912/)
        HADOOP-12565. Replace DSA with RSA for SSH key type in SingleCluster.md. (aajisaka: rev 3857fed2c8fc601b46e8331f73a3104f4f33e498)

        • hadoop-common-project/hadoop-common/src/site/markdown/SingleCluster.md.vm
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8912 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8912/ ) HADOOP-12565 . Replace DSA with RSA for SSH key type in SingleCluster.md. (aajisaka: rev 3857fed2c8fc601b46e8331f73a3104f4f33e498) hadoop-common-project/hadoop-common/src/site/markdown/SingleCluster.md.vm hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, branch-2.8, and branch-2.7. Thanks Alexander Veit for reporting this and thanks Mingliang Liu for the contribution.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, branch-2.8, and branch-2.7. Thanks Alexander Veit for reporting this and thanks Mingliang Liu for the contribution.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Mingliang Liu for taking this issue. +1, I'm okay with the patch.

        Is it OK by not suggesting the type of key to create? I think the default one will work just fine.

        Now the default key type is RSA, so the document is valid if not suggesting the type. However, when the default is changed from RSA, we need to edit the document to change the name of the public & private key as well. Therefore I'm thinking we should suggest the type.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Mingliang Liu for taking this issue. +1, I'm okay with the patch. Is it OK by not suggesting the type of key to create? I think the default one will work just fine. Now the default key type is RSA, so the document is valid if not suggesting the type. However, when the default is changed from RSA, we need to edit the document to change the name of the public & private key as well. Therefore I'm thinking we should suggest the type.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 mvnsite 1m 6s trunk passed
        +1 mvnsite 0m 57s the patch passed
        -1 whitespace 0m 0s The patch has 83 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        2m 45s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773988/HADOOP-12565.000.patch
        JIRA Issue HADOOP-12565
        Optional Tests asflicense mvnsite
        uname Linux 09bc5936bbfc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 411e2b2
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8147/artifact/patchprocess/whitespace-eol.txt
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Max memory used 31MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8147/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvnsite 1m 6s trunk passed +1 mvnsite 0m 57s the patch passed -1 whitespace 0m 0s The patch has 83 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 2m 45s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773988/HADOOP-12565.000.patch JIRA Issue HADOOP-12565 Optional Tests asflicense mvnsite uname Linux 09bc5936bbfc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 411e2b2 whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/8147/artifact/patchprocess/whitespace-eol.txt modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 31MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8147/console This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        Is it OK by not suggesting the type of key to create? I think the default one will work just fine.

        Show
        liuml07 Mingliang Liu added a comment - Is it OK by not suggesting the type of key to create? I think the default one will work just fine.

          People

          • Assignee:
            liuml07 Mingliang Liu
            Reporter:
            veita Alexander Veit
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development