Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12552

Fix undeclared/unused dependency to httpclient

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Hide
      Dependency on commons-httpclient::commons-httpclient was removed from hadoop-common. Downstream projects using commons-httpclient transitively provided by hadoop-common need to add explicit dependency to their pom. Since commons-httpclient is EOL, it is recommended to migrate to org.apache.httpcomponents:httpclient which is the successor.
      Show
      Dependency on commons-httpclient::commons-httpclient was removed from hadoop-common. Downstream projects using commons-httpclient transitively provided by hadoop-common need to add explicit dependency to their pom. Since commons-httpclient is EOL, it is recommended to migrate to org.apache.httpcomponents:httpclient which is the successor.

      Description

      hadoop-common has undeclared dependency on org.apache.httpcomponents:httpclient and unused dependency on commons-httpclient:commons-httpclient. Vise versa in hadoop-azure and hadoop-openstack.

      1. HADOOP-12552.001.patch
        2 kB
        Masatake Iwasaki
      2. HADOOP-12552.002.patch
        1 kB
        Masatake Iwasaki

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 7s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          -1 mvninstall 1m 48s root in trunk failed.
          +1 compile 4m 56s trunk passed with JDK v1.8.0_60
          +1 compile 4m 15s trunk passed with JDK v1.7.0_79
          +1 mvneclipse 0m 37s trunk passed
          +1 javadoc 1m 21s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 30s trunk passed with JDK v1.7.0_79
          +1 mvninstall 2m 5s the patch passed
          +1 compile 4m 15s the patch passed with JDK v1.8.0_60
          +1 javac 4m 15s the patch passed
          +1 compile 4m 10s the patch passed with JDK v1.7.0_79
          +1 javac 4m 10s the patch passed
          +1 mvneclipse 0m 37s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 javadoc 1m 20s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 30s the patch passed with JDK v1.7.0_79
          -1 unit 6m 58s hadoop-common in the patch failed with JDK v1.8.0_60.
          +1 unit 1m 3s hadoop-azure in the patch passed with JDK v1.8.0_60.
          +1 unit 0m 12s hadoop-openstack in the patch passed with JDK v1.8.0_60.
          +1 unit 8m 27s hadoop-common in the patch passed with JDK v1.7.0_79.
          +1 unit 1m 17s hadoop-azure in the patch passed with JDK v1.7.0_79.
          +1 unit 0m 12s hadoop-openstack in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          47m 57s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-06
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770961/HADOOP-12552.001.patch
          JIRA Issue HADOOP-12552
          Optional Tests asflicense javac javadoc mvninstall unit xml compile
          uname Linux 3546e1c85455 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
          git revision trunk / 66c0967
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8038/artifact/patchprocess/branch-mvninstall-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8038/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8038/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8038/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure hadoop-tools/hadoop-openstack U: .
          Max memory used 205MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8038/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 7s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 mvninstall 1m 48s root in trunk failed. +1 compile 4m 56s trunk passed with JDK v1.8.0_60 +1 compile 4m 15s trunk passed with JDK v1.7.0_79 +1 mvneclipse 0m 37s trunk passed +1 javadoc 1m 21s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 30s trunk passed with JDK v1.7.0_79 +1 mvninstall 2m 5s the patch passed +1 compile 4m 15s the patch passed with JDK v1.8.0_60 +1 javac 4m 15s the patch passed +1 compile 4m 10s the patch passed with JDK v1.7.0_79 +1 javac 4m 10s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 javadoc 1m 20s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 30s the patch passed with JDK v1.7.0_79 -1 unit 6m 58s hadoop-common in the patch failed with JDK v1.8.0_60. +1 unit 1m 3s hadoop-azure in the patch passed with JDK v1.8.0_60. +1 unit 0m 12s hadoop-openstack in the patch passed with JDK v1.8.0_60. +1 unit 8m 27s hadoop-common in the patch passed with JDK v1.7.0_79. +1 unit 1m 17s hadoop-azure in the patch passed with JDK v1.7.0_79. +1 unit 0m 12s hadoop-openstack in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 47m 57s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-06 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770961/HADOOP-12552.001.patch JIRA Issue HADOOP-12552 Optional Tests asflicense javac javadoc mvninstall unit xml compile uname Linux 3546e1c85455 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh git revision trunk / 66c0967 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8038/artifact/patchprocess/branch-mvninstall-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8038/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8038/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8038/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-azure hadoop-tools/hadoop-openstack U: . Max memory used 205MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8038/console This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1

          There is a risk that something downstream depended on the POM dependencies. Can you tag this as a potentially incompatible ("may affect downstream projects depending on the POM") change?

          Show
          stevel@apache.org Steve Loughran added a comment - +1 There is a risk that something downstream depended on the POM dependencies. Can you tag this as a potentially incompatible ("may affect downstream projects depending on the POM") change?
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Sure. The downstream projects implicitly using commons-httpclient provided as transient dependency of hadoop-common need to update the POM. The fix is not urgent and not worth to bother downstream projects. I think it's ok to make this trunk-only.

          Compatibility guide currently does not state a policy for dependencies, for reference.

          Show
          iwasakims Masatake Iwasaki added a comment - Sure. The downstream projects implicitly using commons-httpclient provided as transient dependency of hadoop-common need to update the POM. The fix is not urgent and not worth to bother downstream projects. I think it's ok to make this trunk-only. Compatibility guide currently does not state a policy for dependencies , for reference.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          given that azure ships, I do think it should go in ... it just needs to be something to be aware of.

          or: you split it up so the azure side patch goes in, but the hadoop-common one is postponed to trunk

          Show
          stevel@apache.org Steve Loughran added a comment - given that azure ships, I do think it should go in ... it just needs to be something to be aware of. or: you split it up so the azure side patch goes in, but the hadoop-common one is postponed to trunk
          Hide
          iwasakims Masatake Iwasaki added a comment -

          HADOOP-12625 added dependency on commons-httpclient. HADOOP-12710 will fix this.

          Show
          iwasakims Masatake Iwasaki added a comment - HADOOP-12625 added dependency on commons-httpclient. HADOOP-12710 will fix this.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 2s trunk passed
          +1 compile 6m 28s trunk passed with JDK v1.8.0_72
          +1 compile 7m 12s trunk passed with JDK v1.7.0_95
          +1 mvnsite 1m 44s trunk passed
          +1 mvneclipse 0m 38s trunk passed
          +1 javadoc 1m 21s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 37s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          -1 mvninstall 0m 34s hadoop-common in the patch failed.
          -1 compile 0m 49s root in the patch failed with JDK v1.8.0_72.
          -1 javac 0m 49s root in the patch failed with JDK v1.8.0_72.
          -1 compile 0m 55s root in the patch failed with JDK v1.7.0_95.
          -1 javac 0m 55s root in the patch failed with JDK v1.7.0_95.
          -1 mvnsite 0m 36s hadoop-common in the patch failed.
          +1 mvneclipse 0m 31s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 1m 17s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 31s the patch passed with JDK v1.7.0_95
          -1 unit 0m 36s hadoop-common in the patch failed with JDK v1.8.0_72.
          +1 unit 0m 10s hadoop-openstack in the patch passed with JDK v1.8.0_72.
          +1 unit 1m 8s hadoop-azure in the patch passed with JDK v1.8.0_72.
          -1 unit 0m 41s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 unit 0m 11s hadoop-openstack in the patch passed with JDK v1.7.0_95.
          +1 unit 1m 22s hadoop-azure in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          39m 24s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770961/HADOOP-12552.001.patch
          JIRA Issue HADOOP-12552
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux d4abce0080b1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 453e7e0
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt
          compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt
          mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 2s trunk passed +1 compile 6m 28s trunk passed with JDK v1.8.0_72 +1 compile 7m 12s trunk passed with JDK v1.7.0_95 +1 mvnsite 1m 44s trunk passed +1 mvneclipse 0m 38s trunk passed +1 javadoc 1m 21s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 37s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch -1 mvninstall 0m 34s hadoop-common in the patch failed. -1 compile 0m 49s root in the patch failed with JDK v1.8.0_72. -1 javac 0m 49s root in the patch failed with JDK v1.8.0_72. -1 compile 0m 55s root in the patch failed with JDK v1.7.0_95. -1 javac 0m 55s root in the patch failed with JDK v1.7.0_95. -1 mvnsite 0m 36s hadoop-common in the patch failed. +1 mvneclipse 0m 31s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 1m 17s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 31s the patch passed with JDK v1.7.0_95 -1 unit 0m 36s hadoop-common in the patch failed with JDK v1.8.0_72. +1 unit 0m 10s hadoop-openstack in the patch passed with JDK v1.8.0_72. +1 unit 1m 8s hadoop-azure in the patch passed with JDK v1.8.0_72. -1 unit 0m 41s hadoop-common in the patch failed with JDK v1.7.0_95. +1 unit 0m 11s hadoop-openstack in the patch passed with JDK v1.7.0_95. +1 unit 1m 22s hadoop-azure in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 39m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770961/HADOOP-12552.001.patch JIRA Issue HADOOP-12552 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux d4abce0080b1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 453e7e0 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-compile-root-jdk1.8.0_72.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-compile-root-jdk1.7.0_95.txt mvnsite https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-mvnsite-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-openstack hadoop-tools/hadoop-azure U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8644/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I think it would be better to commit this to branch-2 too now, in order to avoid classes of commons-httpclient to be used further. We need to fix HADOOP-12711 at first for this.

          Show
          iwasakims Masatake Iwasaki added a comment - I think it would be better to commit this to branch-2 too now, in order to avoid classes of commons-httpclient to be used further. We need to fix HADOOP-12711 at first for this.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Masatake Iwasaki thanks for the work. This patch also depends on HADOOP-11613 (Remove httpclient dependency from hadoop-azure) and HADOOP-11614 (Remove httpclient dependency from hadoop-openstack) Could you also review that two JIRAs as well? Thanks again.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Masatake Iwasaki thanks for the work. This patch also depends on HADOOP-11613 (Remove httpclient dependency from hadoop-azure) and HADOOP-11614 (Remove httpclient dependency from hadoop-openstack) Could you also review that two JIRAs as well? Thanks again.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I updated the patch. Since HADOOP-11613 came in, we don't need to fix hadoop-azure/pom.xml.

          HADOOP-11614 seems to need more time. I would like to fix the dependency of hadoop-common first. We can update hadoop-openstack/pom.xml later in HADOOP-11614.

          Show
          iwasakims Masatake Iwasaki added a comment - I updated the patch. Since HADOOP-11613 came in, we don't need to fix hadoop-azure/pom.xml. HADOOP-11614 seems to need more time. I would like to fix the dependency of hadoop-common first. We can update hadoop-openstack/pom.xml later in HADOOP-11614 .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 30s trunk passed
          +1 compile 6m 47s trunk passed with JDK v1.8.0_72
          +1 compile 6m 57s trunk passed with JDK v1.7.0_95
          +1 mvnsite 1m 20s trunk passed
          +1 mvneclipse 0m 23s trunk passed
          +1 javadoc 1m 15s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 18s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 0m 51s the patch passed
          +1 compile 5m 45s the patch passed with JDK v1.8.0_72
          +1 javac 5m 45s the patch passed
          +1 compile 6m 32s the patch passed with JDK v1.7.0_95
          +1 javac 6m 32s the patch passed
          +1 mvnsite 1m 17s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 1m 3s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 17s the patch passed with JDK v1.7.0_95
          +1 unit 6m 37s hadoop-common in the patch passed with JDK v1.8.0_72.
          +1 unit 0m 11s hadoop-openstack in the patch passed with JDK v1.8.0_72.
          +1 unit 6m 54s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 0m 14s hadoop-openstack in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          57m 32s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790080/HADOOP-12552.002.patch
          JIRA Issue HADOOP-12552
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux e423e5e34460 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d7fdec1
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8727/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-openstack U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8727/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 30s trunk passed +1 compile 6m 47s trunk passed with JDK v1.8.0_72 +1 compile 6m 57s trunk passed with JDK v1.7.0_95 +1 mvnsite 1m 20s trunk passed +1 mvneclipse 0m 23s trunk passed +1 javadoc 1m 15s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 18s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 0m 51s the patch passed +1 compile 5m 45s the patch passed with JDK v1.8.0_72 +1 javac 5m 45s the patch passed +1 compile 6m 32s the patch passed with JDK v1.7.0_95 +1 javac 6m 32s the patch passed +1 mvnsite 1m 17s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 1m 3s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 17s the patch passed with JDK v1.7.0_95 +1 unit 6m 37s hadoop-common in the patch passed with JDK v1.8.0_72. +1 unit 0m 11s hadoop-openstack in the patch passed with JDK v1.8.0_72. +1 unit 6m 54s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 0m 14s hadoop-openstack in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 57m 32s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790080/HADOOP-12552.002.patch JIRA Issue HADOOP-12552 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux e423e5e34460 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d7fdec1 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8727/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-openstack U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8727/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, would you add a release note because this is an incompatible change?

          Show
          ajisakaa Akira Ajisaka added a comment - +1, would you add a release note because this is an incompatible change?
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks. Committed this to branch-2.8 and above.

          Show
          iwasakims Masatake Iwasaki added a comment - Thanks. Committed this to branch-2.8 and above.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9390 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9390/)
          HADOOP-12552. Fix undeclared/unused dependency to httpclient (iwasakims) (iwasakims: rev 809ebc0b146135d86433e9c7bfa17e294b7928f2)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-openstack/pom.xml
          • hadoop-common-project/hadoop-common/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9390 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9390/ ) HADOOP-12552 . Fix undeclared/unused dependency to httpclient (iwasakims) (iwasakims: rev 809ebc0b146135d86433e9c7bfa17e294b7928f2) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-openstack/pom.xml hadoop-common-project/hadoop-common/pom.xml

            People

            • Assignee:
              iwasakims Masatake Iwasaki
              Reporter:
              iwasakims Masatake Iwasaki
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development