Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12545

Hadoop javadoc has broken links for AccessControlList, ImpersonationProvider, DefaultImpersonationProvider, and DistCp

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      1) open hadoop-2.7.1\share\doc\hadoop\api\index.html
      2) Click on "All Classes"
      3) Click on "AccessControlList", The page shows "This page can’t be displayed"
      Same error for DistCp, ImpersonationProvider and DefaultImpersonationProvider also.

      Javadoc generated from Trunk has the same problem

      1. HADOOP-12545.branch-2.7.patch
        3 kB
        Akira Ajisaka
      2. HADOOP-12545-01.patch
        2 kB
        Mohammad Arshad
      3. HADOOP-12545-02.patch
        1 kB
        Mohammad Arshad
      4. HADOOP-12545-03.patch
        2 kB
        Mohammad Arshad

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2541 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2541/)
          HADOOP-12545. Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java
          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2541 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2541/ ) HADOOP-12545 . Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #665 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/665/)
          HADOOP-12545. Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java
          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #665 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/665/ ) HADOOP-12545 . Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2606 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2606/)
          HADOOP-12545. Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2606 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2606/ ) HADOOP-12545 . Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1401 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1401/)
          HADOOP-12545. Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1401 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1401/ ) HADOOP-12545 . Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #604 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/604/)
          HADOOP-12545. Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de)

          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #604 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/604/ ) HADOOP-12545 . Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #677 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/677/)
          HADOOP-12545. Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java
          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #677 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/677/ ) HADOOP-12545 . Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8802 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8802/)
          HADOOP-12545. Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8802 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8802/ ) HADOOP-12545 . Hadoop javadoc has broken links for AccessControlList, (aajisaka: rev f94d89270464ea8e0d19e26e425835cd6a5dc5de) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/authorize/package-info.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Attaching the patch used for branch-2.7.

          Show
          ajisakaa Akira Ajisaka added a comment - Attaching the patch used for branch-2.7.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk, branch-2, and branch-2.7. Thanks Mohammad Arshad for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.7. Thanks Mohammad Arshad for the contribution.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1

          Show
          ajisakaa Akira Ajisaka added a comment - +1
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 10s trunk passed
          +1 compile 4m 26s trunk passed with JDK v1.8.0_60
          +1 compile 4m 13s trunk passed with JDK v1.7.0_79
          +1 checkstyle 1m 0s trunk passed
          +1 mvnsite 1m 13s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 2m 7s trunk passed
          +1 javadoc 1m 5s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 17s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 50s the patch passed
          +1 compile 4m 22s the patch passed with JDK v1.8.0_60
          +1 javac 4m 22s the patch passed
          +1 compile 4m 11s the patch passed with JDK v1.7.0_79
          +1 javac 4m 11s the patch passed
          +1 checkstyle 0m 57s the patch passed
          +1 mvnsite 1m 14s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 21s the patch passed
          +1 javadoc 1m 5s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 17s the patch passed with JDK v1.7.0_79
          -1 unit 6m 17s hadoop-common in the patch failed with JDK v1.8.0_60.
          +1 unit 6m 57s hadoop-distcp in the patch passed with JDK v1.8.0_60.
          -1 unit 6m 36s hadoop-common in the patch failed with JDK v1.7.0_79.
          +1 unit 6m 13s hadoop-distcp in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          64m 28s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.ha.TestZKFailoverController
          JDK v1.7.0_79 Failed junit tests hadoop.security.token.delegation.TestZKDelegationTokenSecretManager



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772022/HADOOP-12545-03.patch
          JIRA Issue HADOOP-12545
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux dd6da9dee582 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh
          git revision trunk / 0ca8df7
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8066/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8066/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8066/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8066/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8066/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-distcp U: .
          Max memory used 227MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8066/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 10s trunk passed +1 compile 4m 26s trunk passed with JDK v1.8.0_60 +1 compile 4m 13s trunk passed with JDK v1.7.0_79 +1 checkstyle 1m 0s trunk passed +1 mvnsite 1m 13s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 2m 7s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 17s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 50s the patch passed +1 compile 4m 22s the patch passed with JDK v1.8.0_60 +1 javac 4m 22s the patch passed +1 compile 4m 11s the patch passed with JDK v1.7.0_79 +1 javac 4m 11s the patch passed +1 checkstyle 0m 57s the patch passed +1 mvnsite 1m 14s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 21s the patch passed +1 javadoc 1m 5s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 17s the patch passed with JDK v1.7.0_79 -1 unit 6m 17s hadoop-common in the patch failed with JDK v1.8.0_60. +1 unit 6m 57s hadoop-distcp in the patch passed with JDK v1.8.0_60. -1 unit 6m 36s hadoop-common in the patch failed with JDK v1.7.0_79. +1 unit 6m 13s hadoop-distcp in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 64m 28s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.ha.TestZKFailoverController JDK v1.7.0_79 Failed junit tests hadoop.security.token.delegation.TestZKDelegationTokenSecretManager Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772022/HADOOP-12545-03.patch JIRA Issue HADOOP-12545 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dd6da9dee582 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh git revision trunk / 0ca8df7 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8066/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8066/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8066/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8066/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8066/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-distcp U: . Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8066/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Mohammad Arshad for updating the patch. With the patch, mvn site fails on JDK8.

          [ERROR] /Users/aajisaka/git/hadoop/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java:26: error: package org.apache.hadoop.tools has already been annotated
          [ERROR] @InterfaceAudience.Public
          [ERROR] ^
          

          Would you remove @Private from hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java to fix the error?

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Mohammad Arshad for updating the patch. With the patch, mvn site fails on JDK8. [ERROR] /Users/aajisaka/git/hadoop/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java:26: error: package org.apache.hadoop.tools has already been annotated [ERROR] @InterfaceAudience.Public [ERROR] ^ Would you remove @Private from hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java to fix the error?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 52s trunk passed
          +1 compile 5m 34s trunk passed with JDK v1.8.0_60
          +1 compile 5m 8s trunk passed with JDK v1.7.0_79
          +1 checkstyle 1m 11s trunk passed
          +1 mvneclipse 0m 47s trunk passed
          +1 findbugs 2m 45s trunk passed
          +1 javadoc 1m 37s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 41s trunk passed with JDK v1.7.0_79
          -1 mvninstall 1m 30s hadoop-common in the patch failed.
          +1 compile 5m 32s the patch passed with JDK v1.8.0_60
          +1 javac 5m 32s the patch passed
          +1 compile 5m 9s the patch passed with JDK v1.7.0_79
          +1 javac 5m 9s the patch passed
          +1 checkstyle 1m 10s the patch passed
          +1 mvneclipse 0m 33s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 2s the patch passed
          +1 javadoc 1m 34s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 40s the patch passed with JDK v1.7.0_79
          -1 unit 8m 49s hadoop-common in the patch failed with JDK v1.8.0_60.
          +1 unit 8m 10s hadoop-distcp in the patch passed with JDK v1.8.0_60.
          -1 unit 8m 36s hadoop-common in the patch failed with JDK v1.7.0_79.
          +1 unit 7m 45s hadoop-distcp in the patch passed with JDK v1.7.0_79.
          +1 asflicense 0m 29s Patch does not generate ASF License warnings.
          78m 46s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.fs.shell.find.TestPrint
          JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestIPC



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-09
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771305/HADOOP-12545-02.patch
          JIRA Issue HADOOP-12545
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux f67c5b7d45b8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
          git revision trunk / 668e897
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-distcp U: .
          Max memory used 227MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 52s trunk passed +1 compile 5m 34s trunk passed with JDK v1.8.0_60 +1 compile 5m 8s trunk passed with JDK v1.7.0_79 +1 checkstyle 1m 11s trunk passed +1 mvneclipse 0m 47s trunk passed +1 findbugs 2m 45s trunk passed +1 javadoc 1m 37s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 41s trunk passed with JDK v1.7.0_79 -1 mvninstall 1m 30s hadoop-common in the patch failed. +1 compile 5m 32s the patch passed with JDK v1.8.0_60 +1 javac 5m 32s the patch passed +1 compile 5m 9s the patch passed with JDK v1.7.0_79 +1 javac 5m 9s the patch passed +1 checkstyle 1m 10s the patch passed +1 mvneclipse 0m 33s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 2s the patch passed +1 javadoc 1m 34s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 40s the patch passed with JDK v1.7.0_79 -1 unit 8m 49s hadoop-common in the patch failed with JDK v1.8.0_60. +1 unit 8m 10s hadoop-distcp in the patch passed with JDK v1.8.0_60. -1 unit 8m 36s hadoop-common in the patch failed with JDK v1.7.0_79. +1 unit 7m 45s hadoop-distcp in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 29s Patch does not generate ASF License warnings. 78m 46s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.shell.find.TestPrint JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestIPC Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-09 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771305/HADOOP-12545-02.patch JIRA Issue HADOOP-12545 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux f67c5b7d45b8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh git revision trunk / 668e897 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-distcp U: . Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8053/console This message was automatically generated.
          Hide
          arshad.mohammad Mohammad Arshad added a comment -

          Thanks Akira Ajisaka for your review comment. Added @Public to hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java. Submitted HADOOP-12545-02.patch

          Show
          arshad.mohammad Mohammad Arshad added a comment - Thanks Akira Ajisaka for your review comment. Added @Public to hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java . Submitted HADOOP-12545 -02.patch
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Cancelling my +1. Would you remove @Public from hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java and add @Public to hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java? Since DistCp is in hadoop-distcp package, it's better to add the annotation there.

          Show
          ajisakaa Akira Ajisaka added a comment - Cancelling my +1. Would you remove @Public from hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tools/package-info.java and add @Public to hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/package-info.java? Since DistCp is in hadoop-distcp package, it's better to add the annotation there.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1. Thanks Mohammad Arshad.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1. Thanks Mohammad Arshad .
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Moving out all non-critical / non-blocker issues that didn't make it out of 2.7.2 into 2.7.3. Please revert back if you disagree.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Moving out all non-critical / non-blocker issues that didn't make it out of 2.7.2 into 2.7.3. Please revert back if you disagree.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Mohammad Arshad, FYI, you should use target-version for your intention. Fix-version is set at commit time. I'm fixing this for now.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Mohammad Arshad , FYI, you should use target-version for your intention. Fix-version is set at commit time. I'm fixing this for now.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 5s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 9s trunk passed
          +1 compile 4m 35s trunk passed with JDK v1.8.0_60
          +1 compile 4m 25s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 16s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 47s trunk passed
          +1 javadoc 0m 58s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 6s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 27s the patch passed
          +1 compile 4m 38s the patch passed with JDK v1.8.0_60
          +1 javac 4m 38s the patch passed
          +1 compile 4m 38s the patch passed with JDK v1.7.0_79
          +1 javac 4m 38s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 11s the patch passed
          +1 javadoc 1m 9s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 12s the patch passed with JDK v1.7.0_79
          -1 unit 8m 33s hadoop-common in the patch failed with JDK v1.8.0_60.
          -1 unit 8m 48s hadoop-common in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          51m 25s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag
            hadoop.ha.TestZKFailoverController
            hadoop.crypto.key.TestValueQueue
          JDK v1.7.0_79 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-03
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770331/HADOOP-12545-01.patch
          JIRA Issue HADOOP-12545
          Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
          uname Linux 53648da7a59b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-1a9afee/precommit/personality/hadoop.sh
          git revision trunk / 957f031
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8012/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8012/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8012/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8012/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8012/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 227MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8012/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 5s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 9s trunk passed +1 compile 4m 35s trunk passed with JDK v1.8.0_60 +1 compile 4m 25s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 16s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 47s trunk passed +1 javadoc 0m 58s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 27s the patch passed +1 compile 4m 38s the patch passed with JDK v1.8.0_60 +1 javac 4m 38s the patch passed +1 compile 4m 38s the patch passed with JDK v1.7.0_79 +1 javac 4m 38s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 11s the patch passed +1 javadoc 1m 9s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 12s the patch passed with JDK v1.7.0_79 -1 unit 8m 33s hadoop-common in the patch failed with JDK v1.8.0_60. -1 unit 8m 48s hadoop-common in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 51m 25s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag   hadoop.ha.TestZKFailoverController   hadoop.crypto.key.TestValueQueue JDK v1.7.0_79 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-03 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12770331/HADOOP-12545-01.patch JIRA Issue HADOOP-12545 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 53648da7a59b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-1a9afee/precommit/personality/hadoop.sh git revision trunk / 957f031 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8012/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8012/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8012/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8012/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8012/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8012/console This message was automatically generated.
          Hide
          arshad.mohammad Mohammad Arshad added a comment -

          Changed package annotation to @InterfaceAudience.Public

          Show
          arshad.mohammad Mohammad Arshad added a comment - Changed package annotation to @InterfaceAudience.Public
          Hide
          arshad.mohammad Mohammad Arshad added a comment -
          1. For AccessControlList,ImpersonationProvider and DefaultImpersonationProvider::
            Package of these classes is annotated as
            @InterfaceAudience.LimitedPrivate({"HBase", "HDFS", "MapReduce"}) 

            but these classes are annotated as

            @InterfaceAudience.Public 

            These two contradicting annotations causing the broken link problem
            To fix the problem we have to either mark the package as Public or mark classed as LimitedPrivate.
            Any suggestion which one is more appropriate?

          2. For DistCp:
            DistCp has the same problem as above.
            Package of DistCp class is annotated as @InterfaceAudience.Private but DistCp is annotated as @InterfaceAudience.Public
            To fix the problem we have to either mark the package as Public or mark DistCp as Private.
            Any suggestion which one is more appropriate?
          Show
          arshad.mohammad Mohammad Arshad added a comment - For AccessControlList,ImpersonationProvider and DefaultImpersonationProvider:: Package of these classes is annotated as @InterfaceAudience.LimitedPrivate({ "HBase" , "HDFS" , "MapReduce" }) but these classes are annotated as @InterfaceAudience.Public These two contradicting annotations causing the broken link problem To fix the problem we have to either mark the package as Public or mark classed as LimitedPrivate. Any suggestion which one is more appropriate? For DistCp: DistCp has the same problem as above. Package of DistCp class is annotated as @InterfaceAudience.Private but DistCp is annotated as @InterfaceAudience.Public To fix the problem we have to either mark the package as Public or mark DistCp as Private. Any suggestion which one is more appropriate?

            People

            • Assignee:
              arshad.mohammad Mohammad Arshad
              Reporter:
              arshad.mohammad Mohammad Arshad
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development