Details

    • Hadoop Flags:
      Reviewed

      Description

      Documentation for writeVLong in WritableUtils states that "For
      -112 <= i <= 127, only one byte is used"

      Documentation for writeVInt states that "For -120 <= i <= 127, only one byte is used"

      writeVInt calls internally writeVLong, so the ranges are the same for both functions.
      After examining the code, I see that the documentation that is at writeVLong is correct.
      Documentation for writeVInt is therefore incorrect and should be fixed.

      1. MAPREDUCE-6496-00.patch
        2 kB
        Jagadesh Kiran N
      2. MAPREDUCE-6496-01.patch
        2 kB
        Jagadesh Kiran N

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #468 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/468/)
        HADOOP-12465. Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #468 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/468/ ) HADOOP-12465 . Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2406 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2406/)
        HADOOP-12465. Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2406 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2406/ ) HADOOP-12465 . Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1232 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1232/)
        HADOOP-12465. Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1232 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1232/ ) HADOOP-12465 . Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #495 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/495/)
        HADOOP-12465. Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #495 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/495/ ) HADOOP-12465 . Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2438 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2438/)
        HADOOP-12465. Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2438 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2438/ ) HADOOP-12465 . Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #503 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/503/)
        HADOOP-12465. Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #503 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/503/ ) HADOOP-12465 . Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 32s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 59s There were no new javac warning messages.
        +1 javadoc 10m 24s There were no new javadoc warning messages.
        -1 release audit 0m 20s The applied patch generated 1 release audit warnings.
        +1 checkstyle 1m 8s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 29s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 8m 28s Tests passed in hadoop-common.
            49m 49s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12765034/MAPREDUCE-6496-01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 99e5204
        Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7778/artifact/patchprocess/patchReleaseAuditProblems.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7778/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7778/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7778/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 32s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 59s There were no new javac warning messages. +1 javadoc 10m 24s There were no new javadoc warning messages. -1 release audit 0m 20s The applied patch generated 1 release audit warnings. +1 checkstyle 1m 8s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 8m 28s Tests passed in hadoop-common.     49m 49s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765034/MAPREDUCE-6496-01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 99e5204 Release Audit https://builds.apache.org/job/PreCommit-HADOOP-Build/7778/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7778/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7778/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7778/console This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8588 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8588/)
        HADOOP-12465. Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8588 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8588/ ) HADOOP-12465 . Incorrect javadoc in WritableUtils.java. Contributed by (aajisaka: rev 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.7. Thanks Martin Petricek for reporting this and thanks Jagadesh Kiran N for creating patches.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.7. Thanks Martin Petricek for reporting this and thanks Jagadesh Kiran N for creating patches.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Moved to common project since the change is in hadoop-common-project module.

        Show
        ajisakaa Akira Ajisaka added a comment - Moved to common project since the change is in hadoop-common-project module.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, committing this.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, committing this.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        The Failures are not related to patch Akira Ajisaka Please review

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - The Failures are not related to patch Akira Ajisaka Please review
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 20m 13s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 9m 38s There were no new javac warning messages.
        +1 javadoc 12m 28s There were no new javadoc warning messages.
        -1 release audit 0m 20s The applied patch generated 1 release audit warnings.
        +1 checkstyle 1m 18s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 51s mvn install still works.
        +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
        +1 findbugs 2m 10s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 8m 51s Tests passed in hadoop-common.
            57m 33s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12765034/MAPREDUCE-6496-01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f1c19b9
        Release Audit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6056/artifact/patchprocess/patchReleaseAuditProblems.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6056/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6056/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6056/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 13s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 9m 38s There were no new javac warning messages. +1 javadoc 12m 28s There were no new javadoc warning messages. -1 release audit 0m 20s The applied patch generated 1 release audit warnings. +1 checkstyle 1m 18s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 51s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. +1 findbugs 2m 10s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 8m 51s Tests passed in hadoop-common.     57m 33s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765034/MAPREDUCE-6496-01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f1c19b9 Release Audit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6056/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6056/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6056/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6056/console This message was automatically generated.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Thanks Akira Ajisaka & Martin Petricek for your reviews, I have executed the test cases for different combinations for vint and all values seems fall between -113 and -116, or between -121 and -124.Changed the Same Please review

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Thanks Akira Ajisaka & Martin Petricek for your reviews, I have executed the test cases for different combinations for vint and all values seems fall between -113 and -116, or between -121 and -124.Changed the Same Please review
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Mostly looks good to me.

        +   * If the first byte value v is between -113 and -120, the following integer
        +   * is positive, with number of bytes that follow are -(v+112).
        +   * If the first byte value v is between -121 and -128, the following integer
        +   * is negative, with number of bytes that follow are -(v+120). Bytes are
        

        If v is int, I'm thinking v is between -113 and -116, or between -121 and -124.

        Show
        ajisakaa Akira Ajisaka added a comment - Mostly looks good to me. + * If the first byte value v is between -113 and -120, the following integer + * is positive, with number of bytes that follow are -(v+112). + * If the first byte value v is between -121 and -128, the following integer + * is negative, with number of bytes that follow are -(v+120). Bytes are If v is int, I'm thinking v is between -113 and -116, or between -121 and -124.
        Hide
        mpl Martin Petricek added a comment -

        Patch looks good.

        Show
        mpl Martin Petricek added a comment - Patch looks good.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        No changes done in Java Doc ,no tests are included.

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - No changes done in Java Doc ,no tests are included.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 17m 31s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 55s There were no new javac warning messages.
        +1 javadoc 10m 10s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 11s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 29s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 6m 54s Tests passed in hadoop-common.
            48m 7s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12764294/MAPREDUCE-6496-00.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 80d33b5
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6035/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
        hadoop-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6035/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6035/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6035/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 31s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 55s There were no new javac warning messages. +1 javadoc 10m 10s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 11s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 6m 54s Tests passed in hadoop-common.     48m 7s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764294/MAPREDUCE-6496-00.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 80d33b5 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6035/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6035/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6035/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6035/console This message was automatically generated.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Attached the patch, Martin Petricek Please review

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Attached the patch, Martin Petricek Please review

          People

          • Assignee:
            jagadesh.kiran Jagadesh Kiran N
            Reporter:
            mpl Martin Petricek
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development